GNU bug report logs - #45409
[PATCH 0/3] Move some (guix scripts substitute) code to two new modules

Previous Next

Full log

View this message in rfc822 format

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 45409 <at> debbugs.gnu.org
Subject: [bug#45409] [PATCH v3 3/3] guix: Split (guix substitutes) from (guix scripts substitute).
Date: Sat, 13 Feb 2021 13:56:31 +0000

[Message part 1 (text/plain, inline)]

Christopher Baines <mail <at> cbaines.net> writes:

> I've rebased on master, tweaked the commit messages, and send a set of
> v4 patches and while they don't create the (guix substitutes) module, I
> think they unpick the bits I'd like to move out from the code doing the
> connection caching.

I did some more testing today, and while it turns out the tests passed
when run with network access, one test failed when building the guix
package.

I've now rebased, and added an addition patch to address this, and sent
a v5 series. My testing locally seems to suggest this works, so I'd like
to merge it soon so I can push on with moving code out of the script
module.

One other thing, while trying to debug the test failure, I was hitting
the rather topical substituter "Backtrace:" issue [1][2], and of course,
this is more an issue with error handling than anything else. I hacked
something in to send backtraces to (current-error-port), which is
specifically handled in the substituter script, and I think that would
be a good thing to do properly?

1: https://issues.guix.gnu.org/45828
2: https://issues.guix.gnu.org/46362

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.