From unknown Fri Jun 20 07:10:03 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#45403 <45403@debbugs.gnu.org> To: bug#45403 <45403@debbugs.gnu.org> Subject: Status: [PATCH] gnu: zfs: Split into packages specific for each of our major supported kernel versions. Reply-To: bug#45403 <45403@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:10:03 +0000 retitle 45403 [PATCH] gnu: zfs: Split into packages specific for each of ou= r major supported kernel versions. reassign 45403 guix-patches submitter 45403 raid5atemyhomework severity 45403 normal tag 45403 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 24 06:00:15 2020 Received: (at submit) by debbugs.gnu.org; 24 Dec 2020 11:00:16 +0000 Received: from localhost ([127.0.0.1]:54819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksOLv-0000EY-JK for submit@debbugs.gnu.org; Thu, 24 Dec 2020 06:00:15 -0500 Received: from lists.gnu.org ([209.51.188.17]:40982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksOLq-0000EM-TN for submit@debbugs.gnu.org; Thu, 24 Dec 2020 06:00:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56216) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ksOLp-0005Ez-7k for guix-patches@gnu.org; Thu, 24 Dec 2020 06:00:10 -0500 Received: from mail-40130.protonmail.ch ([185.70.40.130]:21481) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ksOLk-0005sn-84 for guix-patches@gnu.org; Thu, 24 Dec 2020 06:00:08 -0500 Date: Thu, 24 Dec 2020 10:59:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1608807600; bh=NpvB8nWrO3dSKXlkH3XrW2CTxkoi7X+JxvS5EtmbRe4=; h=Date:To:From:Reply-To:Subject:From; b=j6yjV2oh77xK+rQadGZlVlFLcU2auR5L8xWyXEIPKDiWo/sruJHCnSCf3+Akz9WUT 1M1i/ZbRT6Cyxm88h2MFFbEpjOFUac8G3YJYRamTmsm7ep8ygb277qvr7k/TqpVkkR ebtWrW3xYoa5+E5oVzdFwoPizh63L5KQ58yI/r8c= To: "guix-patches@gnu.org" From: raid5atemyhomework Subject: [PATCH] gnu: zfs: Split into packages specific for each of our major supported kernel versions. Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Received-SPF: pass client-ip=185.70.40.130; envelope-from=raid5atemyhomework@protonmail.com; helo=mail-40130.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: raid5atemyhomework Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Fixes: https://issues.guix.gnu.org/45401 Untested --- no idea how to repoint my guix to a temporary commit on my loc= al file repo, would appreciate any guidance. >From 242ee858b057f1c3ca4a80c9c449f710c5b1ff96 Mon Sep 17 00:00:00 2001 From: raid5atemyhomework Date: Thu, 24 Dec 2020 10:54:17 +0000 Subject: [PATCH] gnu: zfs: Split into packages specific for each of our maj= or supported kernel versions. --- gnu/packages/file-systems.scm | 31 ++++++++++++++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/gnu/packages/file-systems.scm b/gnu/packages/file-systems.scm index af587f73fe..d3cdeda4fb 100644 --- a/gnu/packages/file-systems.scm +++ b/gnu/packages/file-systems.scm @@ -843,7 +843,7 @@ APFS.") (home-page "https://github.com/sgan81/apfs-fuse") (license license:gpl2+)))) -(define-public zfs +(define zfs-base (package (name "zfs") (version "0.8.5") @@ -954,6 +954,35 @@ originally developed for Solaris and is now maintained= by the OpenZFS community.") (license license:cddl1.0))) +(define-public zfs + (package + (inherit zfs-base) + (description + (string-append (package-description zfs-base) + " + +This package is deprecated, use linux-VERSION-zfs packages instead.")))) + +(define (make-linux-zfs linux-libre) + (package + (inherit zfs-base) + (arguments + `(#:linux ,linux-libre) + ,@(package-arguments zfs-base)) + (description + (string-append (package-description zfs-base) + " + +This package will be compiled to work with the linux-libre " + (package-version linux-libre) + " kernel.")))) + +(define-public linux-5.9-zfs (make-linux-zfs linux-libre-5.9)) +(define-public linux-5.4-zfs (make-linux-zfs linux-libre-5.4)) +(define-public linux-4.19-zfs (make-linux-zfs linux-libre-4.19)) +(define-public linux-4.14-zfs (make-linux-zfs linux-libre-4.14)) +(define-public linux-4.4-zfs (make-linux-zfs linux-libre-4.4)) + (define-public mergerfs (package (name "mergerfs") -- 2.29.2 From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 24 15:41:46 2020 Received: (at submit) by debbugs.gnu.org; 24 Dec 2020 20:41:46 +0000 Received: from localhost ([127.0.0.1]:56077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksXQf-0008NV-Rg for submit@debbugs.gnu.org; Thu, 24 Dec 2020 15:41:46 -0500 Received: from lists.gnu.org ([209.51.188.17]:57436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksXQd-0008NM-7S for submit@debbugs.gnu.org; Thu, 24 Dec 2020 15:41:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ksXQZ-0000vj-Bs for guix-patches@gnu.org; Thu, 24 Dec 2020 15:41:43 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:35587) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ksXQV-00089j-KW for guix-patches@gnu.org; Thu, 24 Dec 2020 15:41:38 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 32D015C004A; Thu, 24 Dec 2020 15:41:35 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 24 Dec 2020 15:41:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=35g3CXc158qinWaoqSEhX3mo aj+31p0AV+89COoC+xI=; b=gm36+MN2OpBtsMXbL25Da4ZpmK260PurSOo5oy/4 j6CVJMVijLZLBcC5/yaKkuzwaVYC2P5jvw9gRC/3KdMbKRVQ8MutIuaxOEFI7JQ8 8i43hL0+yHDbYcfEXU8ga3kqvM2KnGUWRXKkc157UMLmZMtiQJtR0eAE8NJDwJ+a gf8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=35g3CX c158qinWaoqSEhX3moaj+31p0AV+89COoC+xI=; b=fkz9C8T6i+ehNLzre02s3F +tE2jQru3hQtvWqegW22UBVv5qMuL6Gg/IroRuUiBcaeaTtVMdnPMhbwRvcAc/5b AezKeHTDM/Ca2Oekqt8dVEZ8fSHuLTjx+FB2Wk+73g4KUSDtZpztvAjbOcLotPs/ wYD24jvp0IVSTp0tamfkEKmLsFHi+VYN3idBa0UjSn//xEYfcKROWGyKtyPRzahK EbnckcsMwDd3Dn1Fl0h0A7ghlxumz2qhH1XwvRaFAeuzxPbSIdEk60XCUIBVpGVO xAYIowdCxfQcJ3e7TsYr/AJM4WsFZptW7ZhVBtAIu30pMS9JIGADmBNSh5GQwABA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvddtledgudegudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepvddvudegffefiedttdfhfedvuefhgfekieekgeekveetgefhfeetgfeguedu ffeinecuffhomhgrihhnpehgnhhurdhorhhgnecukfhppeejfedrudeguddruddvjedrud egieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehl vghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id C73451080063; Thu, 24 Dec 2020 15:41:34 -0500 (EST) Date: Thu, 24 Dec 2020 15:41:33 -0500 From: Leo Famulari To: raid5atemyhomework via Guix-patches via Subject: Re: [bug#45403] [PATCH] gnu: zfs: Split into packages specific for each of our major supported kernel versions. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=66.111.4.28; envelope-from=leo@famulari.name; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: 45403@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) On Thu, Dec 24, 2020 at 10:59:56AM +0000, raid5atemyhomework via Guix-patches via wrote: > Fixes: https://issues.guix.gnu.org/45401 > > Untested --- no idea how to repoint my guix to a temporary commit on my local file repo, would appreciate any guidance. There are primarily two ways to use Guix with a local Git repo. First, you can follow the instructions in the manual section Contributing, specifically the sections Building from Git and Running Guix Before It Is Installed. Or, you can use something like `guix pull --url=/path/to/my/repo --commit=mycommit`. Beyond that, does this patch create linux-libre packages with ZFS support compiled in? From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 24 20:12:29 2020 Received: (at 45403) by debbugs.gnu.org; 25 Dec 2020 01:12:29 +0000 Received: from localhost ([127.0.0.1]:56337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksbee-0006Sw-UU for submit@debbugs.gnu.org; Thu, 24 Dec 2020 20:12:29 -0500 Received: from mail-40137.protonmail.ch ([185.70.40.137]:39960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksbec-0006Sg-0P for 45403@debbugs.gnu.org; Thu, 24 Dec 2020 20:12:27 -0500 Date: Fri, 25 Dec 2020 01:12:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1608858739; bh=u9gwkZnS6JZzIwKXGM4/M1fQk5uw+qVlX4WUROqZIaM=; h=Date:To:From:Reply-To:Subject:From; b=avSVNDvomakQPOC6qNV1T9d/c7nclPcYQXWQ9NqfyU1ZQlAKkajxaiGt1HztHMgTl xnxWwjdoBwpisvnI+aNYWMWF6oXizVtyX0fYMhPNT/0DZhaYBmbV4UNmS2nL5asQFg wT/TQYd7ZTnUkH9FioeICnDGBQEoVztos6jV3lPo= To: "45403@debbugs.gnu.org" <45403@debbugs.gnu.org> From: raid5atemyhomework Subject: Re: [PATCH] gnu: zfs: Split into packages specific for each of our major supported kernel versions. Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45403 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: raid5atemyhomework Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > There are primarily two ways to use Guix with a local Git repo. > > First, you can follow the instructions in the manual section Contributing= , specifically the sections Building from Git and RunningGuix Before It Is = Installed. > > Or, you can use something like `guix pull --url=3D/path/to/my/repo --comm= it=3Dmycommit`. Thank you very much, will check. > Beyond that, does this patch create linux-libre packages with ZFS support= compiled in? No, this patch continues to use the existing technique of downloading ZFS a= s source and compiling it as a kernel module you have to load in, as per li= censing incompatibility. What it changes is that it compiles kernel modules for all guix-provided ke= rnel versions that ZFS currently is rated to support, rather than compile a= kernel module for whatever `(default-linux)` is, which is always the lates= t and greatest kernel (currently 5.10) which ZFS is currently not rated for= . As Guix goes through the trouble of maintaining a `linux-libre-4.4` package= I assume at least one user somewhere is using Linux 4.4, and did not want = to prevent that user from using ZFS if they decide to do so someday. I admit the naming scheme `linux-5.9-zfs` does make it seem like the packag= e contains an entire Linux kernel. The alternative is to call it `zfs-for-linux-5.9` but that makes the entire= package name with version `zfs-for-linux-5.9-0.8.5` which I think is worse= , because the version numbers are right next to each other. What naming scheme would you suggest? * `linux-5.9-zfs` --- makes it look like it contains a whole Linux kernel. * `zfs-for-linux-5.9` --- versions are right next to each other: `zfs-for-l= inux-5.9-0.8.5`, this is bad since some versioning conventions include a `-= ` in the version naming, so at a glance this makes for a very confusing ver= sion. * `kernelmodule-5.9-zfs` --- makes it clear that it is not an entire kernel= , but this package *also* includes userspace utilities not just the kernel = module. * `zfs-for-linux-5.9-version` --- kind of a weird and absurdly lengthy name= but maybe palatable? I imagine a similar problem would occur for other kernel modules --- the in= ternal kernel interfaces are *not* stable at all, so complex external kerne= l modules like ZFS need to know what kernel version it's being compiled for= and include a bunch of `#ifdef`s to compensate. So we need some decent convention for "how do we name kernel modules so tha= t they are targeted for each kernel version". From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 24 23:10:00 2020 Received: (at submit) by debbugs.gnu.org; 25 Dec 2020 04:10:00 +0000 Received: from localhost ([127.0.0.1]:56427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kseQR-0002DZ-MN for submit@debbugs.gnu.org; Thu, 24 Dec 2020 23:09:59 -0500 Received: from lists.gnu.org ([209.51.188.17]:49630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kseQO-0002DQ-H2 for submit@debbugs.gnu.org; Thu, 24 Dec 2020 23:09:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kseQN-0007xi-Q8 for guix-patches@gnu.org; Thu, 24 Dec 2020 23:09:56 -0500 Received: from tobias.gr ([2a02:c205:2020:6054::1]:34002) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kseQH-0007He-DD for guix-patches@gnu.org; Thu, 24 Dec 2020 23:09:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=/2UOoYukUUIcZOVSU/WGPT4YLYmG6QvXWhR/OLQfUCk=; h=date:in-reply-to: references:subject:cc:to:from; b=pxn0tcW1hphj1bGvf+StfLP3Ucm5/enPoX1n0 BVYT/WaPQgjqr3i5KvdCFcbVGBvvu/TliMBO+49jR6vYbLTtgqXxET3kzKKVt6M3H2ha2t lRlVSn9mOEcnzvgeCalLuikmh25zmVhh9gJVOn88zo2zc4IputqftEASOTBN37BB2vknMO DjojGL6P4ynXRgejmd6TAqIRs0845PMwK3MOf50d6cP7aesqzY6e2gN0z53ucoyKsm8CPW +c/6UTo6akxUVBOE4XLDSCWjCWpWHtXCLgb/d5PjrVwwFIU+ApQkWuc0Fh5wOkp6edNGxa ZoB1WWeb2qUJ2Ens6mse8QrdQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id f45fccc9 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Fri, 25 Dec 2020 04:10:09 +0000 (UTC) BIMI-Selector: v=BIMI1; s=default; From: Tobias Geerinckx-Rice To: raid5atemyhomework , raid5atemyhomework via Guix-patches Subject: Re: [bug#45403] [PATCH] gnu: zfs: Split into packages specific for each of our major supported kernel versions. References: In-reply-to: Date: Fri, 25 Dec 2020 05:09:44 +0100 Message-ID: <87tusaa5mf.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: "45403@debbugs.gnu.org" <45403@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hullo RAIDperson! Thanks for working to improve Guix's currently broken ZFS package! raid5atemyhomework via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A > What it changes is that it compiles kernel modules for all=20 > guix-provided kernel versions that ZFS currently is rated to=20 > support, However, I oppose this (and not because =E2=80=98rated=E2=80=99 sets off my= =20 corpo-speak alarms :-). It makes your system.scm tedious to=20 maintain, especially if we'd do this for all modules (and why=20 not?). Worse, there's no such thing as =E2=80=98a 5.10=E2=80=99 Linux module that = loads=20 on =E2=80=98a 5.10=E2=80=99 Linux kernel. We still need an easy generic me= thod to=20 build modules against their chosen kernel and configuration. As your patch illustrates, that already exists: > (define (make-linux-zfs linux-libre) > (package > (inherit zfs-base) > (arguments > `(#:linux ,linux-libre) > ,@(package-arguments zfs-base)) It just belongs in your system.scm, not in Guix itself. Kind regards, T G-R P.S.nitpick: unfortunately this breaks localisation and can't be=20 done: > + (string-append (package-description zfs-base) > + " > + > +This package is deprecated, use linux-VERSION-zfs packages=20 > instead.")))) Descriptions need to be simple self-contained strings, even if it=20 means duplicating entire paragraphs. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCX+VmCA0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW150G4BAO4HZvoshtDSsDWogXhVuVycBUzD9VQtk6ueOOLr oFl6AP9Md2WvxjqXvMfauMLocsJrl5e+fNTCSvm/TR9JzfLHBg== =w6WA -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 04 08:58:29 2021 Received: (at submit) by debbugs.gnu.org; 4 Jan 2021 13:58:29 +0000 Received: from localhost ([127.0.0.1]:58133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwQNR-0006gc-1V for submit@debbugs.gnu.org; Mon, 04 Jan 2021 08:58:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:37730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwQNP-0006gV-L9 for submit@debbugs.gnu.org; Mon, 04 Jan 2021 08:58:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwQNP-0002f1-C8 for guix-patches@gnu.org; Mon, 04 Jan 2021 08:58:27 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:55500) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwQNN-0006DI-9z for guix-patches@gnu.org; Mon, 04 Jan 2021 08:58:27 -0500 Received: from localhost (80-110-127-104.cgn.dynamic.surfer.at [80.110.127.104]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 7C9CD33656AE; Mon, 4 Jan 2021 14:58:20 +0100 (CET) Date: Mon, 4 Jan 2021 14:58:18 +0100 From: Danny Milosavljevic To: Tobias Geerinckx-Rice via Guix-patches via Subject: Re: [bug#45403] [PATCH] gnu: zfs: Split into packages specific for each of our major supported kernel versions. Message-ID: <20210104145818.0fcd9a0d@scratchpost.org> In-Reply-To: <87tusaa5mf.fsf@nckx> References: <87tusaa5mf.fsf@nckx> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/Q/RvIEApKgH6KQhOlJJcvR="; protocol="application/pgp-signature"; micalg=pgp-sha512 Received-SPF: none client-ip=85.13.145.193; envelope-from=dannym@scratchpost.org; helo=dd26836.kasserver.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: raid5atemyhomework@protonmail.com, Tobias Geerinckx-Rice , 45403@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --Sig_/Q/RvIEApKgH6KQhOlJJcvR= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Fri, 25 Dec 2020 05:09:44 +0100 Tobias Geerinckx-Rice via Guix-patches via wrote: > Worse, there's no such thing as =E2=80=98a 5.10=E2=80=99 Linux module tha= t loads=20 > on =E2=80=98a 5.10=E2=80=99 Linux kernel. We still need an easy generic = method to=20 > build modules against their chosen kernel and configuration. >=20 > As your patch illustrates, that already exists: >=20 > > (define (make-linux-zfs linux-libre) > > (package > > (inherit zfs-base) > > (arguments > > `(#:linux ,linux-libre) > > ,@(package-arguments zfs-base)) =20 >=20 > It just belongs in your system.scm, not in Guix itself. Why is this needed? KERNEL-LOADABLE-MODULES are already automatically adapted in this way. See this in gnu/system.scm : (define* (operating-system-directory-base-entries os) "Return the basic entries of the 'system' directory of OS for use as the value of the SYSTEM-SERVICE-TYPE service." (let* ((locale (operating-system-locale-directory os)) (kernel (operating-system-kernel os)) (hurd (operating-system-hurd os)) (modules (operating-system-kernel-loadable-modules os)) (kernel (if hurd kernel (profile (content (packages->manifest (cons kernel (map (lambda (module) (if (package? module) (package-for-kernel kerne= l <----- modul= e) module)) modules)))) (hooks (list linux-module-database))))) (initrd (and (not hurd) (operating-system-initrd-file os))) (params (operating-system-boot-parameters-file os))) `(("kernel" ,kernel) ,@(if hurd `(("hurd" ,hurd)) '()) ("parameters" ,params) ,@(if initrd `(("initrd" ,initrd)) '()) ("locale" ,locale)))) ;used by libc --Sig_/Q/RvIEApKgH6KQhOlJJcvR= Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl/zHvoACgkQ5xo1VCww uqVN4ggAnf6F7tLDIa3EU200sDCYpVLCX0e+69/Yrio9UiNVtm7wqbjwK9XUelPH +M6FedO9jC29rHv4F1eV0sl9u5sxnuALLW7gO8L6hTRM8DXLpcsfHUB0cJFP8d3h 1LXKJJasu7CaRCC3byYy9vD93o3eBJyz0M39Jalqwwi4KEGz5N53d+wzEx9OKnf6 8nAHbopXePUtt30qW/D2YfirnijjdRuMsaHoYJVSCphT+A1ny3ikuvmOmSDtZttq SImM11fjmljEmbKebyjKflBk97cktS3vKFpjqz2uu0j8u93ACpMYezAeL1r83J2Z UbE8wlCF3xUdKiNiNp/kF78lCw8ZeA== =N9Ts -----END PGP SIGNATURE----- --Sig_/Q/RvIEApKgH6KQhOlJJcvR=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 04 10:49:11 2021 Received: (at submit) by debbugs.gnu.org; 4 Jan 2021 15:49:11 +0000 Received: from localhost ([127.0.0.1]:60003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwS6Y-0001WT-WF for submit@debbugs.gnu.org; Mon, 04 Jan 2021 10:49:11 -0500 Received: from lists.gnu.org ([209.51.188.17]:47186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwS6X-0001WF-8k for submit@debbugs.gnu.org; Mon, 04 Jan 2021 10:49:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwS6X-0008Jt-0N for guix-patches@gnu.org; Mon, 04 Jan 2021 10:49:09 -0500 Received: from mail-40135.protonmail.ch ([185.70.40.135]:23723) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwS6U-0001ds-Fa for guix-patches@gnu.org; Mon, 04 Jan 2021 10:49:08 -0500 Date: Mon, 04 Jan 2021 15:49:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1609775343; bh=B4cgb6tHzmKqVjborxtizkeHWchKMk98//7NMPpiE3w=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=TIZp6LiBhKMxBJfrvr9a6L++aiY+vZkPhBU+CzkdVQDRmECjSUCOIKlvr2+CJb0qG GtNdWjXKNF1k2it+YVoT0kqWvqLYRxuj/QxxlYjxcCHv47bzz4GYAZkuljK2InivLE cPVY5qFEVmxmWiGEdSlk1TYd2zjRL1NmGE4ogBAU= To: Danny Milosavljevic From: raid5atemyhomework Subject: Re: [bug#45403] [PATCH] gnu: zfs: Split into packages specific for each of our major supported kernel versions. Message-ID: In-Reply-To: <20210104145818.0fcd9a0d@scratchpost.org> References: <87tusaa5mf.fsf@nckx> <20210104145818.0fcd9a0d@scratchpost.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Received-SPF: pass client-ip=185.70.40.135; envelope-from=raid5atemyhomework@protonmail.com; helo=mail-40135.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Tobias Geerinckx-Rice , "45403@debbugs.gnu.org" <45403@debbugs.gnu.org>, Tobias Geerinckx-Rice via Guix-patches via X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: raid5atemyhomework Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This doesn't work, for two reasons: * The kernel-module is in the output "module" of the `zfs` package. The co= de specifically checks for `(package? module)`, but we have to specify it a= s `(list system-zfs "module")`. * ZFS is primarily managed via userspace tools, that's what ZFS users know = how to use, and we should support that so that Guix users can ask non-Guix = ZFS users for help with their ZFS problems. The userspace tools are includ= ed in the package. If the base `zfs` package cannot compile because it's i= ncompatible with the default kernel, then the userspace tools are nonexiste= nt and there is no way to manage ZFS. * So, for example we can't just remove the "module" output and have the `= .ko` installed in the default "out" output, our core problem is we need to = compile a ZFS module ***and*** userspace tools. * We can try to split the compilation to separate the ZFS module from the= userspace tool, but that risks brittleness and subtle incompatibilities be= tween a ZFS module compiled for your local kernel (which cannot be the late= st and greatest kernel since the kernel does not maintain interface compati= bility with kernel modules and the ZFS module is always having to catch up)= , and ZFS userspace tool compiled for the default latest-and-greatest kerne= l (even if we somehow manage to compile ***just*** the userspace tools with= the latest kernel, there may be implicit assumptions about kernel constant= s and so on passed from the userspace tools to the kernel module, which may= cause problems and birttleness). So it's just safer to always override the `zfs` `#:linux` with the system k= ernel, and install it in `(packages ...)` and in `(kernel-loadable-modules = ...)`. * We get compileability as long as older kernel is used. * We ensure that the userspace tool is built for the same kernel module for= a compatible kernel, at all generations of the `guix system`. Thanks raid5atemyhomework > Why is this needed? KERNEL-LOADABLE-MODULES are already automatically > adapted in this way. > > See this in gnu/system.scm : > > (define* (operating-system-directory-base-entries os) > "Return the basic entries of the 'system' directory of OS for use as the > value of the SYSTEM-SERVICE-TYPE service." > (let* ((locale (operating-system-locale-directory os)) > (kernel (operating-system-kernel os)) > (hurd (operating-system-hurd os)) > (modules (operating-system-kernel-loadable-modules os)) > (kernel (if hurd > kernel > (profile > (content (packages->manifest > > (cons kernel > (map (lambda (module) > (if (package? module) > (package-for-kernel ker= nel <----- > mod= ule) > module)) > modules)))) > (hooks (list linux-module-database))))) > (initrd (and (not hurd) (operating-system-initrd-file os))) > (params (operating-system-boot-parameters-file os))) > `(("kernel" ,kernel) > ,@(if hurd `(("hurd" ,hurd)) '()) > ("parameters" ,params) > ,@(if initrd `(("initrd" ,initrd)) '()) > ("locale" ,locale)))) ;used by libc From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 04 11:07:28 2021 Received: (at submit) by debbugs.gnu.org; 4 Jan 2021 16:07:28 +0000 Received: from localhost ([127.0.0.1]:60018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwSOF-00020S-QI for submit@debbugs.gnu.org; Mon, 04 Jan 2021 11:07:28 -0500 Received: from lists.gnu.org ([209.51.188.17]:59878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwSOD-00020K-Qw for submit@debbugs.gnu.org; Mon, 04 Jan 2021 11:07:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwSOB-0006q2-M4 for guix-patches@gnu.org; Mon, 04 Jan 2021 11:07:23 -0500 Received: from mail-40130.protonmail.ch ([185.70.40.130]:13875) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwSO6-0008OB-Qj for guix-patches@gnu.org; Mon, 04 Jan 2021 11:07:23 -0500 Date: Mon, 04 Jan 2021 16:07:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1609776433; bh=pshoaocx7EiF6T8OAoy2mmlBLjXcF3oJ8X6+OQUEhwM=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=sQfiZX5ZbToKy+f4HtMyFGaUReJFEJHnK614YhFEV4UVxK5VbnBUi/3q3n5KH9Bgc vX4eL+pZiPX8hRZF4RAnYIVnOWS3YrrMNRohaCUI21xoH3I9iYvBC6GOyJi7Iy5f4U gv1x5runJUsp5T3RjYNs1Mz7OntfDDZ5KHskOpY8= To: Danny Milosavljevic From: raid5atemyhomework Subject: Re: [bug#45403] [PATCH] gnu: zfs: Split into packages specific for each of our major supported kernel versions. Message-ID: In-Reply-To: References: <87tusaa5mf.fsf@nckx> <20210104145818.0fcd9a0d@scratchpost.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Received-SPF: pass client-ip=185.70.40.130; envelope-from=raid5atemyhomework@protonmail.com; helo=mail-40130.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Tobias Geerinckx-Rice , "45403@debbugs.gnu.org" <45403@debbugs.gnu.org>, Tobias Geerinckx-Rice via Guix-patches via X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: raid5atemyhomework Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Here's another alternative: * Remove the separate "module" output and put the `.ko` file in the "out" o= utput. * Create a separate `zfs-guix-tools` which provides `zpool`, `zfs`, `zed`, = `arc_summary`, `arcstat`, `dbufstat`, `raidz_test`, `zgenhostid`, `zvol_wai= t`, `fsck.zfs`, `mount.zfs`, `zdb`, `zhack`, `zinject`, `zstreamdump`, `zte= st`. * What the provided binaries do is: * It looks at `/run/booted-system/kernel/manifest` and looks for a `"zf= s"` package. * It `exec`s into the corresponding file in the `/gnu/store` for that p= ackage. This way, we can have a separate package for ZFS userspace tools, which jus= t calls the corresponding tools in the actual ZFS that gets installed. It's somewhat magical, though. Thanks raid5atemyhomework > This doesn't work, for two reasons: > > - The kernel-module is in the output "module" of the `zfs` package. The= code specifically checks for `(package? module)`, but we have to specify i= t as `(list system-zfs "module")`. > - ZFS is primarily managed via userspace tools, that's what ZFS users k= now how to use, and we should support that so that Guix users can ask non-G= uix ZFS users for help with their ZFS problems. The userspace tools are inc= luded in the package. If the base `zfs` package cannot compile because it's= incompatible with the default kernel, then the userspace tools are nonexis= tent and there is no way to manage ZFS. > - So, for example we can't just remove the "module" output and have= the `.ko` installed in the default "out" output, our core problem is we ne= ed to compile a ZFS module and userspace tools. > - We can try to split the compilation to separate the ZFS module fr= om the userspace tool, but that risks brittleness and subtle incompatibilit= ies between a ZFS module compiled for your local kernel (which cannot be th= e latest and greatest kernel since the kernel does not maintain interface c= ompatibility with kernel modules and the ZFS module is always having to cat= ch up), and ZFS userspace tool compiled for the default latest-and-greatest= kernel (even if we somehow manage to compile just the userspace tools with= the latest kernel, there may be implicit assumptions about kernel constant= s and so on passed from the userspace tools to the kernel module, which may= cause problems and birttleness). > > So it's just safer to always override the `zfs` `#:linux` with th= e system kernel, and install it in `(packages ...)` and in `(kernel-loadabl= e-modules ...)`. > > - We get compileability as long as older kernel is used. > - We ensure that the userspace tool is built for the same kernel module= for a compatible kernel, at all generations of the `guix system`. > > Thanks > raid5atemyhomework > > > > Why is this needed? KERNEL-LOADABLE-MODULES are already automatically > > adapted in this way. > > See this in gnu/system.scm : > > (define* (operating-system-directory-base-entries os) > > "Return the basic entries of the 'system' directory of OS for use as th= e > > value of the SYSTEM-SERVICE-TYPE service." > > (let* ((locale (operating-system-locale-directory os)) > > (kernel (operating-system-kernel os)) > > (hurd (operating-system-hurd os)) > > (modules (operating-system-kernel-loadable-modules os)) > > (kernel (if hurd > > kernel > > (profile > > (content (packages->manifest > > > > (cons kernel > > (map (lambda (module) > > (if (package? module) > > (package-for-kernel k= ernel <----- > > m= odule) > > module)) > > modules)))) > > (hooks (list linux-module-database))))) > > (initrd (and (not hurd) (operating-system-initrd-file os))) > > (params (operating-system-boot-parameters-file os))) > > `(("kernel" ,kernel) > > ,@(if hurd `(("hurd" ,hurd)) '()) > > ("parameters" ,params) > > ,@(if initrd `(("initrd" ,initrd)) '()) > > ("locale" ,locale)))) ;used by libc > > From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 04 11:32:30 2021 Received: (at submit) by debbugs.gnu.org; 4 Jan 2021 16:32:30 +0000 Received: from localhost ([127.0.0.1]:60051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwSmT-0002eF-No for submit@debbugs.gnu.org; Mon, 04 Jan 2021 11:32:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:52318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwSmS-0002e6-M0 for submit@debbugs.gnu.org; Mon, 04 Jan 2021 11:32:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwSmS-0001Im-6j for guix-patches@gnu.org; Mon, 04 Jan 2021 11:32:28 -0500 Received: from mail4.protonmail.ch ([185.70.40.27]:40587) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwSmN-0003lM-Ld for guix-patches@gnu.org; Mon, 04 Jan 2021 11:32:27 -0500 Date: Mon, 04 Jan 2021 16:32:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1609777941; bh=xzxxAnyky9Dp1doIdZ8+0tdAtCnzPF74TB8Ah9vdQik=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=VGz4Enh/ui6B4UOyGANl0a+Xxh6h8mjuT8xQQIJEgyrNHmRshwDTELRV0u29dvvGe Smff1rGN6eKUWq6mtUejhZviR2yYaoP8W1wGhcvj30gyVGB9Zdv29q+DDCnzmv3sNr Zu6OwjXYoxXDfpr/d5H7c9ihXwwBRVHo1qsrvbSc= To: Danny Milosavljevic From: raid5atemyhomework Subject: Re: [bug#45403] [PATCH] gnu: zfs: Split into packages specific for each of our major supported kernel versions. Message-ID: In-Reply-To: References: <87tusaa5mf.fsf@nckx> <20210104145818.0fcd9a0d@scratchpost.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Received-SPF: pass client-ip=185.70.40.27; envelope-from=raid5atemyhomework@protonmail.com; helo=mail4.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Tobias Geerinckx-Rice , "45403@debbugs.gnu.org" <45403@debbugs.gnu.org>, Tobias Geerinckx-Rice via Guix-patches via X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: raid5atemyhomework Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > Here's another alternative: > > - Remove the separate "module" output and put the `.ko` file in the "ou= t" output. > - Create a separate `zfs-guix-tools` which provides `zpool`, `zfs`, `ze= d`, `arc_summary`, `arcstat`, `dbufstat`, `raidz_test`, `zgenhostid`, `zvol= _wait`, `fsck.zfs`, `mount.zfs`, `zdb`, `zhack`, `zinject`, `zstreamdump`, = `ztest`. > - What the provided binaries do is: > - It looks at `/run/booted-system/kernel/manifest` and looks fo= r a `"zfs"` package. > - It `exec`s into the corresponding file in the `/gnu/store` fo= r that package. > > This way, we can have a separate package for ZFS userspace to= ols, which just calls the corresponding tools in the actual ZFS that gets i= nstalled. > It's somewhat magical, though. > Unfortunately, this confounds `bash-completion`. We want the bash-completi= on from the actual compiled ZFS, not the shim `zfs-guix-tools`. We could t= ry digging for it too in the `kernel/manifest`, but that just adds more com= plexity and maintenance headaches. It's also an extra layer of complexity and maintenance burden to create thi= s shim wrapper that digs through your kernel manifest to look for the userl= and tools you need to manage ZFS in the same package that contains the actu= al ZFS kernel module. I think it's better to just expose a `make-zfs-packa= ge` that overrides the `#:linux` and creates a new package that you can ins= tall in `(packages ...)` **and** in `(kernel-loadable-modules ...)`. See https://issues.guix.gnu.org/45643 for my current latest patchset. Thanks raid5atemyhomework From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 08 10:51:13 2021 Received: (at 45403-done) by debbugs.gnu.org; 8 Jan 2021 15:51:13 +0000 Received: from localhost ([127.0.0.1]:50375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxu2j-0002hh-I1 for submit@debbugs.gnu.org; Fri, 08 Jan 2021 10:51:13 -0500 Received: from mail4.protonmail.ch ([185.70.40.27]:63946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxu2h-0002hO-9a for 45403-done@debbugs.gnu.org; Fri, 08 Jan 2021 10:51:12 -0500 Date: Fri, 08 Jan 2021 15:50:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1610121064; bh=Em+OOH+DaErRioTUsNuV6IKd/eMAQbOyLr/v32KmvWw=; h=Date:To:From:Reply-To:Subject:From; b=UGVVtqjFv6SlmajnEBs4cZbHRDEOBR2ci6wzIXg0tS0YhYxMnnA90jf14LJ0+8U1D eWJrsXWq4sXqfo3hBoirMucVf/Pt3TXldMq6In8Lh4sQE0FUxE9qqCa2fAcxb1LcFH RC/dsddm46jwHFqtsw5tAiay2XMiLQEYXJOT1AAI= To: "45403-done@debbugs.gnu.org" <45403-done@debbugs.gnu.org> From: raid5atemyhomework Subject: Re: [PATCH] gnu: zfs: Split into packages specific for each of our major supported kernel versions. Message-ID: <2r7IOZWhDUrtijdxF7PIYyQGG9cAEdOl7txgyZi6hBKGAtU1fMY6Y2oQkjmAMA_C1TtKQHTH62WLaGtSzsABkQTumQQtm0t-GxJ0Jx9xgfo=@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45403-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: raid5atemyhomework Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Close in favor of 45692 From unknown Fri Jun 20 07:10:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 06 Feb 2021 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator