From unknown Mon Aug 18 09:07:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45393: 27.1; Make remove-hook (interactive Resent-From: Thibault Polge Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Dec 2020 13:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45393 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 45393@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160872977231956 (code B ref -1); Wed, 23 Dec 2020 13:23:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Dec 2020 13:22:52 +0000 Received: from localhost ([127.0.0.1]:52323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ks46O-0008JM-Bu for submit@debbugs.gnu.org; Wed, 23 Dec 2020 08:22:52 -0500 Received: from lists.gnu.org ([209.51.188.17]:55664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ks46L-0008JD-6T for submit@debbugs.gnu.org; Wed, 23 Dec 2020 08:22:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ks46L-0003Q7-0k for bug-gnu-emacs@gnu.org; Wed, 23 Dec 2020 08:22:49 -0500 Received: from 8.mo2.mail-out.ovh.net ([188.165.52.147]:58699) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ks46I-0006xv-Ha for bug-gnu-emacs@gnu.org; Wed, 23 Dec 2020 08:22:48 -0500 Received: from player692.ha.ovh.net (unknown [10.108.42.168]) by mo2.mail-out.ovh.net (Postfix) with ESMTP id 9B4101F405D for ; Wed, 23 Dec 2020 14:22:34 +0100 (CET) Received: from thb.lt (lfbn-idf3-1-503-177.w83-114.abo.wanadoo.fr [83.114.90.177]) (Authenticated sender: thibault@thb.lt) by player692.ha.ovh.net (Postfix) with ESMTPSA id 543D919520935 for ; Wed, 23 Dec 2020 13:22:33 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-106R006dd5ed6c1-da79-4226-9b8b-9769a0a7ed6c, 273662A954AFE31D1DDA89026AB79E951850FC0F) smtp.auth=thibault@thb.lt X-OVh-ClientIp: 83.114.90.177 From: Thibault Polge Date: Wed, 23 Dec 2020 14:22:27 +0100 Message-ID: <87r1ngbqss.fsf@thb.lt> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Ovh-Tracer-Id: 4943263544981047563 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedujedrvddtjedgheduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvffufffkgggtsehmtderredttddtnecuhfhrohhmpefvhhhisggruhhlthcurfholhhgvgcuoehthhhisggruhhlthesthhhsgdrlhhtqeenucggtffrrghtthgvrhhnpeekheekveejuddtheffueehteeiffdttdejheehtdehvdeuheffiedtvdejkeefveenucffohhmrghinhepghhnuhdrohhrghenucfkpheptddrtddrtddrtddpkeefrdduudegrdeltddrudejjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehplhgrhigvrheiledvrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepthhhihgsrghulhhtsehthhgsrdhlthdprhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhg Received-SPF: pass client-ip=188.165.52.147; envelope-from=thibault@thb.lt; helo=8.mo2.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain This is a follow-up to a previous discussion on emacs-devel[1]. The attached patch makes `remove-hook` interactive. A common use case for remove-hook is to fix your own mistakes when programming Emacs: renaming a hook function for something more expressive, moving a function to a different hook or from global to local, and so on. For these cases, it seems more natural to use the function interactively than to have to write throwaway lisp one-liners. A limitation of this approach is that since completion requires a text representation of the function to remove, if two hooks have the same representation under `princ` it will be impossible to distinguish between them. In this case, which is probably *extremely* rare (and only concerns anonymous functions), only the first one will be removed. The copyright assignment paperwork was completed on Dec, 11. [1] See: https://lists.gnu.org/archive/html/emacs-devel/2020-11/msg00860.html --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Make-remove-hook-interactive.patch >From 8175c3f1e92a53a6b9bb9e78cfb7d2cb481bf583 Mon Sep 17 00:00:00 2001 From: Thibault Polge Date: Wed, 23 Dec 2020 14:19:15 +0100 Subject: [PATCH] Make `remove-hook` interactive * lisp/subr.el: modify remove-hook to make it interactive. --- lisp/subr.el | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/lisp/subr.el b/lisp/subr.el index 1fb0f9ab7e..2c8bc6a191 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -1742,7 +1742,30 @@ FUNCTION isn't the value of HOOK, or, if FUNCTION doesn't appear in the list of hooks to run in HOOK, then nothing is done. See `add-hook'. The optional third argument, LOCAL, if non-nil, says to modify -the hook's buffer-local value rather than its default value." +the hook's buffer-local value rather than its default value. + +Interactively, prompt for the various arguments (skipping local +unless HOOK has both local and global functions). If multiple +functions have the same representation under `princ', the first +one will be removed." + (interactive + (let* ((hook (intern (completing-read "Hook variable: " obarray #'boundp t))) + (local + (and + (local-variable-p hook) + (symbol-value hook) + (or (not (default-value hook)) ; No need to prompt if there's nothing global + (y-or-n-p (format "%s has a buffer-local binding, use that? " hook))))) + (fn-alist (mapcar + (lambda (x) (cons (with-output-to-string (prin1 x)) x)) + (if local (symbol-value hook) (default-value hook)))) + (function (alist-get (completing-read + (format "%s hook to remove:" + (if local "Buffer-local" "Global")) + fn-alist + nil t) + fn-alist nil nil 'string=))) + (list hook function local))) (or (boundp hook) (set hook nil)) (or (default-boundp hook) (set-default hook nil)) ;; Do nothing if LOCAL is t but this hook has no local binding. -- 2.29.2 --=-=-= Content-Type: text/plain Best regards, Thibault --=-=-=-- From unknown Mon Aug 18 09:07:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45393: 27.1; Make remove-hook (interactive Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Dec 2020 16:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45393 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Thibault Polge , 45393@debbugs.gnu.org Received: via spool by 45393-submit@debbugs.gnu.org id=B45393.16087425385538 (code B ref 45393); Wed, 23 Dec 2020 16:56:02 +0000 Received: (at 45393) by debbugs.gnu.org; 23 Dec 2020 16:55:38 +0000 Received: from localhost ([127.0.0.1]:53975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ks7QH-0001RG-Ow for submit@debbugs.gnu.org; Wed, 23 Dec 2020 11:55:37 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:54040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ks7QD-0001R0-AT for 45393@debbugs.gnu.org; Wed, 23 Dec 2020 11:55:36 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BNGo8gZ050308; Wed, 23 Dec 2020 16:55:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type; s=corp-2020-01-29; bh=dP7IQ8vTnnUyHHfi4hCAHPxd2yPzereMG6SKTWxg9QA=; b=VlXJp0djBxP6WQa25VkqYTj82YCUOZgZytL27E5hbBj/kVquwZT142zNH/Q8MM0SHGBk viLWKENaVNj8s7nrcha4Mk1iR/tHrSWj/q/yhU2p1hphdRFYVnajRFjHJeO9744wbh4D +ncEVGyaiZLdEyZB8ii/L6vWKpFj8z8JXfmzcBZRnIIwoOxFaSSByYC5Dhc/XNt9A3UX tz7Tv9p45Fqj1XjnipduptjvYbZKKihC4My8lbWbSvm3T/Q2DcK57OcQ6mcoxF5uwIRK CerPO9865x7dG0Se6aIJyEOzJkMy8CW8ye0PDyRSuOvZcoPxo9e7rTGE5jX289RzjI78 sg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2130.oracle.com with ESMTP id 35k0d18p7s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 23 Dec 2020 16:55:27 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BNGpfHv073686; Wed, 23 Dec 2020 16:55:26 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 35k0ea282h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Dec 2020 16:55:26 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0BNGtOgi031423; Wed, 23 Dec 2020 16:55:24 GMT MIME-Version: 1.0 Message-ID: Date: Wed, 23 Dec 2020 08:55:22 -0800 (PST) From: Drew Adams References: <87r1ngbqss.fsf@thb.lt> In-Reply-To: <87r1ngbqss.fsf@thb.lt> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5095.0 (x86)] Content-Type: multipart/mixed; boundary="__1608742523912131432abhmp0010.oracle.com" X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9844 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 mlxscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012230124 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9844 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 suspectscore=0 adultscore=0 bulkscore=0 priorityscore=1501 mlxscore=0 clxscore=1011 phishscore=0 mlxlogscore=999 spamscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012230124 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --__1608742523912131432abhmp0010.oracle.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable 1. I think this is a fine idea. For one thing, it'll help with the gotcha of someone misguidedly using a lambda form as a hook function (which requires using the same form for removal). Instead of having to type the lambda form exactly for `remove-hook', it can be retrieved from the history. 2. Please add a space char at the end of the "Function:" prompt. 3. The doc string should maybe start with a description of the interactive use. I think that's typical. And that description should describe each arg (instead of the interactive description just referring to the Lisp description). On the other hand, 90% of the uses will not be interactive, so maybe that general rule shouldn't be followed here? 4. I suggest doing the same for `add-hook', and letting `remove-hook' use the last hook added interactively as default when reading the hook. Attached is some quick-and-dirty code that does that, to show what I mean. If the idea is accepted then we can work out a patch. When `add-hook' is used interactively (only), the hook var and function are recorded in vars `last-add-hook-var' and `hook-history'. --__1608742523912131432abhmp0010.oracle.com Content-Type: application/octet-stream; name="throw-add-remove-hook.el" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="throw-add-remove-hook.el" KGRlZnZhciBsYXN0LWFkZC1ob29rLXZhciBuaWwNCiAgIkxhc3QgaG9vayB2YXJpYWJsZSB1c2Vk IHdpdGggYGFkZC1ob29rJyBpbnRlcmFjdGl2ZWx5LiIpDQooZGVmdmFyIGhvb2staGlzdG9yeSAo KQ0KICAiSGlzdG9yeSBvZiBob29rIHZhcmlhYmxlcyB1c2VkIGFzIG1pbmlidWZmZXIgaW5wdXQu IikNCg0KKGRlZnVuIGFkZC1ob29rIChob29rIGZ1bmN0aW9uICZvcHRpb25hbCBhcHBlbmQgbG9j YWwgbXNncCkNCiAgIkFkZCB0byB0aGUgdmFsdWUgb2YgSE9PSyB0aGUgZnVuY3Rpb24gRlVOQ1RJ T04uDQpGVU5DVElPTiBpcyBub3QgYWRkZWQgaWYgYWxyZWFkeSBwcmVzZW50Lg0KRlVOQ1RJT04g aXMgYWRkZWQgKGlmIG5lY2Vzc2FyeSkgYXQgdGhlIGJlZ2lubmluZyBvZiB0aGUgaG9vayBsaXN0 DQp1bmxlc3MgdGhlIG9wdGlvbmFsIGFyZ3VtZW50IEFQUEVORCBpcyBub24tbmlsLCBpbiB3aGlj aCBjYXNlDQpGVU5DVElPTiBpcyBhZGRlZCBhdCB0aGUgZW5kLg0KDQpUaGUgb3B0aW9uYWwgZm91 cnRoIGFyZ3VtZW50LCBMT0NBTCwgaWYgbm9uLW5pbCwgc2F5cyB0byBtb2RpZnkNCnRoZSBob29r J3MgYnVmZmVyLWxvY2FsIHZhbHVlIHJhdGhlciB0aGFuIGl0cyBnbG9iYWwgdmFsdWUuDQpUaGlz IG1ha2VzIHRoZSBob29rIGJ1ZmZlci1sb2NhbCwgYW5kIGl0IG1ha2VzIHQgYSBtZW1iZXIgb2Yg dGhlDQpidWZmZXItbG9jYWwgdmFsdWUuICBUaGF0IGFjdHMgYXMgYSBmbGFnIHRvIHJ1biB0aGUg aG9vaw0KZnVuY3Rpb25zIG9mIHRoZSBnbG9iYWwgdmFsdWUgYXMgd2VsbCBhcyBpbiB0aGUgbG9j YWwgdmFsdWUuDQoNCkhPT0sgc2hvdWxkIGJlIGEgc3ltYm9sLCBhbmQgRlVOQ1RJT04gbWF5IGJl IGFueSB2YWxpZCBmdW5jdGlvbi4gIElmDQpIT09LIGlzIHZvaWQsIGl0IGlzIGZpcnN0IHNldCB0 byBuaWwuICBJZiBIT09LJ3MgdmFsdWUgaXMgYSBzaW5nbGUNCmZ1bmN0aW9uLCBpdCBpcyBjaGFu Z2VkIHRvIGEgbGlzdCBvZiBmdW5jdGlvbnMuDQoNCkludGVyYWN0aXZlbHksIHByb21wdCBmb3Ig dGhlIHZhcmlvdXMgYXJndW1lbnRzIChza2lwcGluZyBsb2NhbA0KdW5sZXNzIEhPT0sgaGFzIGJv dGggbG9jYWwgYW5kIGdsb2JhbCBmdW5jdGlvbnMpLiAgV2l0aCBhIHByZWZpeA0KYXJndW1lbnQs IGFwcGVuZCwgZWxzZSBwcmVwZW5kLiINCiAgKGludGVyYWN0aXZlDQogICAobGV0KiAoKGhvb2sg KGludGVybg0KCQkgKGNvbXBsZXRpbmctcmVhZCAiSG9vayB2YXJpYWJsZTogIg0KCQkJCSAgb2Jh cnJheSAjJ2JvdW5kcCB0IG5pbA0KCQkJCSAgJ2hvb2staGlzdG9yeSBsYXN0LWFkZC1ob29rLXZh cikpKQ0KICAgICAgICAgIChsb2NhbA0KICAgICAgICAgICAoYW5kDQogICAgICAgICAgICAobG9j YWwtdmFyaWFibGUtcCBob29rKQ0KICAgICAgICAgICAgKHN5bWJvbC12YWx1ZSBob29rKQ0KICAg ICAgICAgICAgKG9yIChub3QgKGRlZmF1bHQtdmFsdWUgaG9vaykpIDsgTm8gbmVlZCB0byBwcm9t cHQgaWYgdGhlcmUncyBub3RoaW5nIGdsb2JhbA0KICAgICAgICAgICAgICAgICh5LW9yLW4tcCAo Zm9ybWF0ICIlcyBoYXMgYSBidWZmZXItbG9jYWwgYmluZGluZywgdXNlIHRoYXQ/ICIgaG9vaykp KSkpDQoJICAoZnVuY3Rpb24gKHJlYWQtZnJvbS1taW5pYnVmZmVyICJGdW5jdGlvbjogIiBuaWwg bmlsICdSRUFEKSkpDQogICAgIChsaXN0IGhvb2sgZnVuY3Rpb24gY3VycmVudC1wcmVmaXgtYXJn IGxvY2FsIHQpKSkNCiAgKG9yIChib3VuZHAgaG9vaykgKHNldCBob29rIG5pbCkpDQogIChvciAo ZGVmYXVsdC1ib3VuZHAgaG9vaykgKHNldC1kZWZhdWx0IGhvb2sgbmlsKSkNCiAgKGlmIGxvY2Fs ICh1bmxlc3MgKGxvY2FsLXZhcmlhYmxlLWlmLXNldC1wIGhvb2spDQoJICAgICAgKHNldCAobWFr ZS1sb2NhbC12YXJpYWJsZSBob29rKSAobGlzdCB0KSkpDQogICAgOzsgRGV0ZWN0IHRoZSBjYXNl IHdoZXJlIG1ha2UtbG9jYWwtdmFyaWFibGUgd2FzIHVzZWQgb24gYSBob29rDQogICAgOzsgYW5k IGRvIHdoYXQgd2UgdXNlZCB0byBkby4NCiAgICAodW5sZXNzIChhbmQgKGNvbnNwIChzeW1ib2wt dmFsdWUgaG9vaykpIChtZW1xIHQgKHN5bWJvbC12YWx1ZSBob29rKSkpDQogICAgICAoc2V0cSBs b2NhbCB0KSkpDQogIChsZXQgKChob29rLXZhbHVlIChpZiBsb2NhbCAoc3ltYm9sLXZhbHVlIGhv b2spIChkZWZhdWx0LXZhbHVlIGhvb2spKSkpDQogICAgOzsgSWYgdGhlIGhvb2sgdmFsdWUgaXMg YSBzaW5nbGUgZnVuY3Rpb24sIHR1cm4gaXQgaW50byBhIGxpc3QuDQogICAgKHdoZW4gKG9yIChu b3QgKGxpc3RwIGhvb2stdmFsdWUpKSAoZnVuY3Rpb25wIGhvb2stdmFsdWUpKQ0KICAgICAgKHNl dHEgaG9vay12YWx1ZSAobGlzdCBob29rLXZhbHVlKSkpDQogICAgOzsgRG8gdGhlIGFjdHVhbCBh ZGRpdGlvbiBpZiBuZWNlc3NhcnkNCiAgICAodW5sZXNzIChtZW1iZXIgZnVuY3Rpb24gaG9vay12 YWx1ZSkNCiAgICAgICh3aGVuIChzdHJpbmdwIGZ1bmN0aW9uKQ0KCShzZXRxIGZ1bmN0aW9uIChw dXJlY29weSBmdW5jdGlvbikpKQ0KICAgICAgKHNldHEgaG9vay12YWx1ZQ0KCSAgICAoaWYgYXBw ZW5kDQoJCShhcHBlbmQgaG9vay12YWx1ZSAobGlzdCBmdW5jdGlvbikpDQoJICAgICAgKGNvbnMg ZnVuY3Rpb24gaG9vay12YWx1ZSkpKSkNCiAgICA7OyBTZXQgdGhlIGFjdHVhbCB2YXJpYWJsZQ0K ICAgIChpZiBsb2NhbA0KCShwcm9nbg0KCSAgOzsgSWYgSE9PSyBpc24ndCBhIHBlcm1hbmVudCBs b2NhbCwNCgkgIDs7IGJ1dCBGVU5DVElPTiB3YW50cyB0byBzdXJ2aXZlIGEgY2hhbmdlIG9mIG1v ZGVzLA0KCSAgOzsgbWFyayBIT09LIGFzIHBhcnRpYWxseSBwZXJtYW5lbnQuDQoJICAoYW5kIChz eW1ib2xwIGZ1bmN0aW9uKQ0KCSAgICAgICAoZ2V0IGZ1bmN0aW9uICdwZXJtYW5lbnQtbG9jYWwt aG9vaykNCgkgICAgICAgKG5vdCAoZ2V0IGhvb2sgJ3Blcm1hbmVudC1sb2NhbCkpDQoJICAgICAg IChwdXQgaG9vayAncGVybWFuZW50LWxvY2FsICdwZXJtYW5lbnQtbG9jYWwtaG9vaykpDQoJICAo c2V0IGhvb2sgaG9vay12YWx1ZSkpDQogICAgICAoc2V0LWRlZmF1bHQgaG9vayBob29rLXZhbHVl KSkpDQogICh3aGVuIG1zZ3AgKHNldHEgbGFzdC1hZGQtaG9vay12YXIgIGhvb2spKSkNCg0KDQoo ZGVmdW4gcmVtb3ZlLWhvb2sgKGhvb2sgZnVuY3Rpb24gJm9wdGlvbmFsIGxvY2FsKQ0KICAiUmVt b3ZlIGZyb20gdGhlIHZhbHVlIG9mIEhPT0sgdGhlIGZ1bmN0aW9uIEZVTkNUSU9OLg0KSE9PSyBz aG91bGQgYmUgYSBzeW1ib2wsIGFuZCBGVU5DVElPTiBtYXkgYmUgYW55IHZhbGlkIGZ1bmN0aW9u LiAgSWYNCkZVTkNUSU9OIGlzbid0IHRoZSB2YWx1ZSBvZiBIT09LLCBvciwgaWYgRlVOQ1RJT04g ZG9lc24ndCBhcHBlYXIgaW4gdGhlDQpsaXN0IG9mIGhvb2tzIHRvIHJ1biBpbiBIT09LLCB0aGVu IG5vdGhpbmcgaXMgZG9uZS4gIFNlZSBgYWRkLWhvb2snLg0KDQpUaGUgb3B0aW9uYWwgdGhpcmQg YXJndW1lbnQsIExPQ0FMLCBpZiBub24tbmlsLCBzYXlzIHRvIG1vZGlmeQ0KdGhlIGhvb2sncyBi dWZmZXItbG9jYWwgdmFsdWUgcmF0aGVyIHRoYW4gaXRzIGRlZmF1bHQgdmFsdWUuDQoNCkludGVy YWN0aXZlbHksIHByb21wdCBmb3IgdGhlIHZhcmlvdXMgYXJndW1lbnRzIChza2lwcGluZyBsb2Nh bA0KdW5sZXNzIEhPT0sgaGFzIGJvdGggbG9jYWwgYW5kIGdsb2JhbCBmdW5jdGlvbnMpLiAgSWYg bXVsdGlwbGUNCmZ1bmN0aW9ucyBoYXZlIHRoZSBzYW1lIHJlcHJlc2VudGF0aW9uIHVuZGVyIGBw cmluYycsIHJlbW92ZSB0aGUNCmZpcnN0IG9uZS4iDQogIChpbnRlcmFjdGl2ZQ0KICAgKGxldCog KChob29rIChpbnRlcm4NCgkJIChjb21wbGV0aW5nLXJlYWQgIkhvb2sgdmFyaWFibGU6ICINCgkJ CQkgIG9iYXJyYXkgIydib3VuZHAgdCBuaWwgJ2hvb2staGlzdG9yeQ0KCQkJCSAgKGFuZCBsYXN0 LWFkZC1ob29rLXZhcg0KCQkJCSAgICAgICAoc3ltYm9sLW5hbWUgbGFzdC1hZGQtaG9vay12YXIp KSkpKQ0KICAgICAgICAgIChsb2NhbA0KICAgICAgICAgICAoYW5kDQogICAgICAgICAgICAobG9j YWwtdmFyaWFibGUtcCBob29rKQ0KICAgICAgICAgICAgKHN5bWJvbC12YWx1ZSBob29rKQ0KICAg ICAgICAgICAgKG9yIChub3QgKGRlZmF1bHQtdmFsdWUgaG9vaykpIDsgTm8gbmVlZCB0byBwcm9t cHQgaWYgdGhlcmUncyBub3RoaW5nIGdsb2JhbA0KICAgICAgICAgICAgICAgICh5LW9yLW4tcCAo Zm9ybWF0ICIlcyBoYXMgYSBidWZmZXItbG9jYWwgYmluZGluZywgdXNlIHRoYXQ/ICIgaG9vaykp KSkpDQogICAgICAgICAgKGZuLWFsaXN0IChtYXBjYXINCiAgICAgICAgICAgICAgICAgICAgIChs YW1iZGEgKHgpIChjb25zICh3aXRoLW91dHB1dC10by1zdHJpbmcgKHByaW4xIHgpKSB4KSkNCiAg ICAgICAgICAgICAgICAgICAgIChpZiBsb2NhbCAoc3ltYm9sLXZhbHVlIGhvb2spIChkZWZhdWx0 LXZhbHVlIGhvb2spKSkpDQogICAgICAgICAgKGZ1bmN0aW9uIChhbGlzdC1nZXQgKGNvbXBsZXRp bmctcmVhZA0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZm9ybWF0ICIlcyBob29r IHRvIHJlbW92ZTogIg0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChp ZiBsb2NhbCAiQnVmZmVyLWxvY2FsIiAiR2xvYmFsIikpDQogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGZuLWFsaXN0DQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5pbCB0 KQ0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZuLWFsaXN0IG5pbCBuaWwgJ3N0cmlu Zz0pKSkNCiAgICAgKGxpc3QgaG9vayBmdW5jdGlvbiBsb2NhbCkpKQ0KICAob3IgKGJvdW5kcCBo b29rKSAoc2V0IGhvb2sgbmlsKSkNCiAgKG9yIChkZWZhdWx0LWJvdW5kcCBob29rKSAoc2V0LWRl ZmF1bHQgaG9vayBuaWwpKQ0KICA7OyBEbyBub3RoaW5nIGlmIExPQ0FMIGlzIHQgYnV0IHRoaXMg aG9vayBoYXMgbm8gbG9jYWwgYmluZGluZy4NCiAgKHVubGVzcyAoYW5kIGxvY2FsIChub3QgKGxv Y2FsLXZhcmlhYmxlLXAgaG9vaykpKQ0KICAgIDs7IERldGVjdCB0aGUgY2FzZSB3aGVyZSBtYWtl LWxvY2FsLXZhcmlhYmxlIHdhcyB1c2VkIG9uIGEgaG9vaw0KICAgIDs7IGFuZCBkbyB3aGF0IHdl IHVzZWQgdG8gZG8uDQogICAgKHdoZW4gKGFuZCAobG9jYWwtdmFyaWFibGUtcCBob29rKQ0KCSAg ICAgICAobm90IChhbmQgKGNvbnNwIChzeW1ib2wtdmFsdWUgaG9vaykpDQoJCQkgKG1lbXEgdCAo c3ltYm9sLXZhbHVlIGhvb2spKSkpKQ0KICAgICAgKHNldHEgbG9jYWwgdCkpDQogICAgKGxldCAo KGhvb2stdmFsdWUgKGlmIGxvY2FsIChzeW1ib2wtdmFsdWUgaG9vaykgKGRlZmF1bHQtdmFsdWUg aG9vaykpKSkNCiAgICAgIDs7IFJlbW92ZSB0aGUgZnVuY3Rpb24sIGZvciBib3RoIHRoZSBsaXN0 IGFuZCB0aGUgbm9uLWxpc3QgY2FzZXMuDQogICAgICAoaWYgKG9yIChub3QgKGxpc3RwIGhvb2st dmFsdWUpKSAoZXEgKGNhciBob29rLXZhbHVlKSAnbGFtYmRhKSkNCgkgIChpZiAoZXF1YWwgaG9v ay12YWx1ZSBmdW5jdGlvbikgKHNldHEgaG9vay12YWx1ZSBuaWwpKQ0KCShzZXRxIGhvb2stdmFs dWUgKGRlbGV0ZSBmdW5jdGlvbiAoY29weS1zZXF1ZW5jZSBob29rLXZhbHVlKSkpKQ0KICAgICAg OzsgSWYgdGhlIGZ1bmN0aW9uIGlzIG9uIHRoZSBnbG9iYWwgaG9vaywgd2UgbmVlZCB0byBzaGFk b3cgaXQgbG9jYWxseQ0KICAgICAgOzsod2hlbiAoYW5kIGxvY2FsIChtZW1iZXIgZnVuY3Rpb24g KGRlZmF1bHQtdmFsdWUgaG9vaykpDQogICAgICA7OwkgICAgICAgKG5vdCAobWVtYmVyIChjb25z ICdub3QgZnVuY3Rpb24pIGhvb2stdmFsdWUpKSkNCiAgICAgIDs7ICAocHVzaCAoY29ucyAnbm90 IGZ1bmN0aW9uKSBob29rLXZhbHVlKSkNCiAgICAgIDs7IFNldCB0aGUgYWN0dWFsIHZhcmlhYmxl DQogICAgICAoaWYgKG5vdCBsb2NhbCkNCgkgIChzZXQtZGVmYXVsdCBob29rIGhvb2stdmFsdWUp DQoJKGlmIChlcXVhbCBob29rLXZhbHVlICcodCkpDQoJICAgIChraWxsLWxvY2FsLXZhcmlhYmxl IGhvb2spDQoJICAoc2V0IGhvb2sgaG9vay12YWx1ZSkpKSkpKQ0K --__1608742523912131432abhmp0010.oracle.com-- From unknown Mon Aug 18 09:07:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45393: 27.1; Make remove-hook (interactive Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Dec 2020 05:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45393 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Thibault Polge Cc: 45393@debbugs.gnu.org Received: via spool by 45393-submit@debbugs.gnu.org id=B45393.160887514319553 (code B ref 45393); Fri, 25 Dec 2020 05:46:01 +0000 Received: (at 45393) by debbugs.gnu.org; 25 Dec 2020 05:45:43 +0000 Received: from localhost ([127.0.0.1]:56519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksfv4-000552-L4 for submit@debbugs.gnu.org; Fri, 25 Dec 2020 00:45:42 -0500 Received: from quimby.gnus.org ([95.216.78.240]:35548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksfv3-0004z7-1j for 45393@debbugs.gnu.org; Fri, 25 Dec 2020 00:45:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EFALRtNvK2IO5BYQxq7EMBcY8YbAsNY4S12OsEdiWOs=; b=QSNGNZKVDDzi6MoylbPtS3z6eU HI41oTx9kXH8aNm8MRhnwV133iYigGm3y+oiZ8j6KQ/Em8D5/qwYm+GuqWMh++EWmNrJB+umH2U15 IMWntZPHU3O7wVdlIobqZ41+DrCt4XFprPnQ9IDdLzJoDYjlB/ZuYlIzLvvXjzIC62SQ=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ksfuu-00073o-Us; Fri, 25 Dec 2020 06:45:35 +0100 From: Lars Ingebrigtsen References: <87r1ngbqss.fsf@thb.lt> X-Now-Playing: Kate & Anna McGarrigle's _Kate & Anna McGarrigle_: "Heart Like a Wheel" Date: Fri, 25 Dec 2020 06:45:31 +0100 In-Reply-To: <87r1ngbqss.fsf@thb.lt> (Thibault Polge's message of "Wed, 23 Dec 2020 14:22:27 +0100") Message-ID: <87eejeiglg.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Thibault Polge writes: > The attached patch makes `remove-hook` interactive. Looks good; applied to Emacs 28 (after some minor white-space changes to make the lines shorter than 80 characters). Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thibault Polge writes: > The attached patch makes `remove-hook` interactive. Looks good; applied to Emacs 28 (after some minor white-space changes to make the lines shorter than 80 characters). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 25 00:45:49 2020 Received: (at control) by debbugs.gnu.org; 25 Dec 2020 05:45:49 +0000 Received: from localhost ([127.0.0.1]:56522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksfvA-0005BR-VV for submit@debbugs.gnu.org; Fri, 25 Dec 2020 00:45:49 -0500 Received: from quimby.gnus.org ([95.216.78.240]:35562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksfv8-000544-Rc for control@debbugs.gnu.org; Fri, 25 Dec 2020 00:45:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Q7okdqvV/rygIMIrlce3StiAqsg/QQWFn8Yp3rd4jg0=; b=jKqlQ6gMipMVsC8bov75PZEZwR ct41CqZ4rr9I3Ih+vVLZo0x65m5nSTMv3tul8/bkwMfroHyNlJOPjJ5eUNRRnwGvYfGiGXYo0eMrH ld8ckfFf4Wa3CuLJ2DmAbLChwWqu+UUD8bOrdY4hC9Bju1Pi0S5yVnGpkCwqTLijBHXc=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ksfv1-00073x-DG for control@debbugs.gnu.org; Fri, 25 Dec 2020 06:45:41 +0100 Date: Fri, 25 Dec 2020 06:45:38 +0100 Message-Id: <87czyyigl9.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #45393 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 45393 fixed close 45393 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 45393 fixed close 45393 28.1 quit From unknown Mon Aug 18 09:07:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45393: 27.1; Make remove-hook (interactive Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jan 2021 18:09:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45393 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen Cc: Thibault Polge , 45393@debbugs.gnu.org Received: via spool by 45393-submit@debbugs.gnu.org id=B45393.160978372820054 (code B ref 45393); Mon, 04 Jan 2021 18:09:03 +0000 Received: (at 45393) by debbugs.gnu.org; 4 Jan 2021 18:08:48 +0000 Received: from localhost ([127.0.0.1]:60235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwUHg-0005DN-7t for submit@debbugs.gnu.org; Mon, 04 Jan 2021 13:08:48 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:54973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwUHe-0005Cy-Lj for 45393@debbugs.gnu.org; Mon, 04 Jan 2021 13:08:47 -0500 Received: from mail.gandi.net (m91-129-98-64.cust.tele2.ee [91.129.98.64]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 0F525100006; Mon, 4 Jan 2021 18:08:38 +0000 (UTC) From: Juri Linkov References: <87r1ngbqss.fsf@thb.lt> <87eejeiglg.fsf@gnus.org> Date: Mon, 04 Jan 2021 19:39:58 +0200 In-Reply-To: <87eejeiglg.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 25 Dec 2020 06:45:31 +0100") Message-ID: <8735zgob2p.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain >> The attached patch makes `remove-hook` interactive. > > Looks good; applied to Emacs 28 (after some minor white-space changes to > make the lines shorter than 80 characters). It's difficult to use this feature without a default value. Here's the patch that adds it: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=remove-hook-default.patch diff --git a/lisp/subr.el b/lisp/subr.el index 1acc3c3250..ad0c812ed3 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -1749,7 +1749,11 @@ remove-hook functions have the same representation under `princ', the first one will be removed." (interactive - (let* ((hook (intern (completing-read "Hook variable: " obarray #'boundp t))) + (let* ((default (and (symbolp (variable-at-point)) + (symbol-name (variable-at-point)))) + (hook (intern (completing-read + (format-prompt "Hook variable" default) + obarray #'boundp t nil nil default))) (local (and (local-variable-p hook) --=-=-=-- From unknown Mon Aug 18 09:07:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45393: 27.1; Make remove-hook (interactive Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Jan 2021 08:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45393 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Juri Linkov Cc: Thibault Polge , 45393@debbugs.gnu.org Received: via spool by 45393-submit@debbugs.gnu.org id=B45393.160983573419777 (code B ref 45393); Tue, 05 Jan 2021 08:36:02 +0000 Received: (at 45393) by debbugs.gnu.org; 5 Jan 2021 08:35:34 +0000 Received: from localhost ([127.0.0.1]:40723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwhoT-00058v-TB for submit@debbugs.gnu.org; Tue, 05 Jan 2021 03:35:34 -0500 Received: from quimby.gnus.org ([95.216.78.240]:41000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwhoR-00058g-OE for 45393@debbugs.gnu.org; Tue, 05 Jan 2021 03:35:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iX9T2fFrJglzBg1hpsLcAbXMhCoKCoaT/MgfcWcrhgM=; b=aSuMfUCGl31Zbw77eeVeNhONfv cHUbUeHlkqnkdMMccUl0Q44diosYMRx3Fc4bIuw/cGEqsNfGimCs0pkvaPaMR0FI4fagz99Rgd1I7 sa4tNGRRxlDAaSTd/h19E2KTc3dSZzEP0iVhB9Vw7o7p1yqC2D6VSI0sYUqSwYZTwgjc=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwhoG-0006cE-Q3; Tue, 05 Jan 2021 09:35:25 +0100 From: Lars Ingebrigtsen References: <87r1ngbqss.fsf@thb.lt> <87eejeiglg.fsf@gnus.org> <8735zgob2p.fsf@mail.linkov.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEW9sqcbFhRXTEX/ //+05+axAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+UBBQgjC6eLBkIAAAGlSURBVCjPLZLBbtswEETH AgSYOtcBmnMtpPkKw+jFPblBhhB5og0osPgVilAXqM+l0OjkBlBg8Su7TLy86HGXy5mlcKNI67Nz lIDakEOM7f0YJ6wtdQy+7Umi6gWGgYa6RllK8d9b09DUUCeBSzz7VLYy7zB8f0hnUlmMY2YFFl4+ J/d60gOBW4Gi2/++vAWsi9FfCkxPr8cG9BOrrPta/TtukNmJBxSx7SSzKkd7yOY9kO9gToGHeQtg DgRb0wNFC7WS1oG2i+cz5hs8irlQE2fkCqNh0+sqwQYz0rzFrTQonlEtyP6+EsAMQQX2qorSYETd iKtyC0URyhTTFjM9Bixo9Mvo5jMRjDtJBOO+JMG4C0I7d5NpgZ9Lgcb1GQW+iRyaVcg4EpuaVoBd ggdqQ17h01LGzLUsgV9XWCXY5XKGii4I/DjSBmnrEwzyFkEyh0VDlPkHuATypiZoxW2CfbLwOKuT Y/xZJMi5FY3I85QKrALTf9Cbd7esFNxLujSFO0EveQ0HlA21mNUI+wz4bOMk+zG4El6G6EcxS3sB mzSRZIP+P7+vysAdudVEAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTAxLTA1VDA4OjM1OjExKzAw OjAw+RoqfgAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wMS0wNVQwODozNToxMSswMDowMIhHksIA AAAASUVORK5CYII= X-Now-Playing: Big Audio Dynamite's _This Is Big Audio Dynamite_: "Medicine Show" Date: Tue, 05 Jan 2021 09:35:19 +0100 In-Reply-To: <8735zgob2p.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 04 Jan 2021 19:39:58 +0200") Message-ID: <87lfd73ho8.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > It's difficult to use this feature without a default value. > Here's the patch that adds it: Sure; looks good to me. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > It's difficult to use this feature without a default value. > Here's the patch that adds it: Sure; looks good to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no