GNU bug report logs - #45391
[PATCH] gnu: bitcoin-unlimited: Fix time specific test failure.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45391 in the body.
You can then email your comments to 45391 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: bitcoin-unlimited: Fix time specific test failure.
Date: Wed, 23 Dec 2020 10:45:10 +0000

* gnu/packages/finance.scm (bitcoin-unlimited)[arguments]: Patch test to fix
time specific failure.
---
 gnu/packages/finance.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index c7a606f3b2..3f1ecb40f1 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -1469,6 +1469,12 @@ entity management.")
        (modify-phases %standard-phases
          (add-after 'unpack 'fix-tests
            (lambda _
+             ;; Fix data specific test failure
+             ;; https://reviews.bitcoinabc.org/
+             ;;   rABC67bbd3d0aaee2952ff1cb5da51d1fd0b50c2b63a
+             (substitute* "src/test/rpc_tests.cpp"
+               (("1607731200") "9907731200"))
+
              ;; Disable utilprocess_tests because it never ends.
              ;; It looks like it tries to start /bin/sleep and waits until it
              ;; is in the list of running processes, but /bin/sleep doesn't
-- 
2.29.2

Message #8 received at 45391 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 45391 <at> debbugs.gnu.org
Subject: Re: [bug#45391] [PATCH] gnu: bitcoin-unlimited: Fix time specific
 test failure.
Date: Wed, 30 Dec 2020 11:51:41 +0100

Hey Chris,

> +             ;; Fix data specific test failure
> +             ;; https://reviews.bitcoinabc.org/
> +             ;;   rABC67bbd3d0aaee2952ff1cb5da51d1fd0b50c2b63a
> +             (substitute* "src/test/rpc_tests.cpp"
> +               (("1607731200") "9907731200"))

I think you should keep the URL on one single line, otherwise looks
fine!

Thanks,

Mathieu

Message #13 received at 45391-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 45391-done <at> debbugs.gnu.org
Subject: Re: [bug#45391] [PATCH] gnu: bitcoin-unlimited: Fix time specific
 test failure.
Date: Thu, 31 Dec 2020 20:08:03 +0000

[Message part 1 (text/plain, inline)]

Mathieu Othacehe <othacehe <at> gnu.org> writes:

> Hey Chris,
>
>> +             ;; Fix data specific test failure
>> +             ;; https://reviews.bitcoinabc.org/
>> +             ;;   rABC67bbd3d0aaee2952ff1cb5da51d1fd0b50c2b63a
>> +             (substitute* "src/test/rpc_tests.cpp"
>> +               (("1607731200") "9907731200"))
>
> I think you should keep the URL on one single line, otherwise looks
> fine!

Thanks, I've pushed as 94803ec345a1f83ce6fdc446452cb887a7a302a7.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.