GNU bug report logs -
#45379
28.0.50; Degraded Performance of describe-buffer-bindings
Previous Next
Reported by: styang <at> fastmail.com
Date: Wed, 23 Dec 2020 06:03:01 UTC
Severity: normal
Tags: confirmed, fixed, patch
Merged with 47494,
47565,
48812
Found in version 28.0.50
Fixed in version 28.1
Done: Stefan Kangas <stefan <at> marxist.se>
Bug is archived. No further changes may be made.
Full log
Message #30 received at 45379 <at> debbugs.gnu.org (full text, mbox):
In article <83v9a4wve3.fsf <at> gnu.org>, Eli Zaretskii <eliz <at> gnu.org> writes:
> > From: Stefan Kangas <stefan <at> marxist.se>
> > Date: Fri, 5 Mar 2021 20:44:33 -0800
> > Cc: Juri Linkov <juri <at> linkov.net>, martin rudalics <rudalics <at> gmx.at>, Eli Zaretskii <eliz <at> gnu.org>,
> > 45379 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>,
> > Stephen Berman <stephen.berman <at> gmx.net>
> >
> > It turns out that we were doing unnecessary looping due to the above
> > mentioned commit.
Could you show me what is "the above mentioned commit"?
> > While working on this, I also found that we can get
> > rid of an unnecessary call to char_table_ref_and_range, which should
> > make this function run even faster.
Is the patch for the above improvement the one included in the file
0001-Fix-describe-buffer-bindings-performance-regression.patch?
> > I'm also copying in Kenichi Handa, who was the last to touch this code.
> > Handa-san, please let us know if you have any comments on this patch.
> > Thanks in advance.
> AFAICT, you didn't CC Kenichi; I have now added him to the discussion.
It was more than 10 years ago that I last read keymap.c, and since then,
the code has been changed a lot. It will take some time to understand
the latest code.
---
K. Handa
handa <at> gnu.org
This bug report was last modified 3 years and 242 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.