GNU bug report logs - #45379
28.0.50; Degraded Performance of describe-buffer-bindings

Previous Next

Full log

Message #24 received at control <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Sheng Yang <styang <at> fastmail.com>
Cc: Stephen Berman <stephen.berman <at> gmx.net>, Juri Linkov <juri <at> linkov.net>,
 martin rudalics <rudalics <at> gmx.at>, Stefan Monnier <monnier <at> iro.umontreal.ca>,
 Eli Zaretskii <eliz <at> gnu.org>, 45379 <at> debbugs.gnu.org
Subject: Re: bug#45379: 28.0.50;
 Degraded Performance of describe-buffer-bindings
Date: Fri, 5 Mar 2021 20:44:33 -0800

[Message part 1 (text/plain, inline)]

tags 45379 + patch
thanks

Stefan Kangas <stefan <at> marxist.se> writes:

> "Sheng Yang" <styang <at> fastmail.com> writes:
>
>> Hi Juri,
>>
>> I recently came across a regression of performance in Emacs for
>> describe bindings, which I have reported as bug#45379. After
>> bisection, the offending seems to be a commit a649034336 you pushed in
>> November 2020, to fix bug#5423. [...]
>>
>> a649034336 * bad Don't show key ranges if shadowed by different commands
>
> BTW, the offending commit is not Juri's.  It is mine:
>
>     Author: Stefan Kangas <stefan <at> marxist.se>
>     Date:   Fri Nov 13 15:28:29 2020 +0100
>
>         Don't show key ranges if shadowed by different commands

Please try the attached patch and see that it fixes this performance
regression.

It turns out that we were doing unnecessary looping due to the above
mentioned commit.  While working on this, I also found that we can get
rid of an unnecessary call to char_table_ref_and_range, which should
make this function run even faster.

I'm also copying in Kenichi Handa, who was the last to touch this code.
Handa-san, please let us know if you have any comments on this patch.
Thanks in advance.

[0001-Fix-describe-buffer-bindings-performance-regression.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.