Subject: bug#45374: closed (Re: [bug#45374] [PATCH] gnu: udisks: Add dosfstools to PATH with wrapper.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 03 Jun 2024 01:37:02 +0000

Your bug report

#45374: [PATCH] gnu: udisks: Add dosfstools to PATH with wrapper.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
45374: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=45374
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#45374] [PATCH] gnu: udisks: Add dosfstools to PATH with wrapper.
From: Maxim Cournoyer <[email-masked]>
To: dftxbs3e <[email-masked]>
Cc: [email-masked]
Date: Sun, 02 Jun 2024 21:35:04 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

dftxbs3e <[email-masked]> writes:

> Looks like there has already been some discussion about this: 
> https://issues.guix.gnu.org/41247
>
> So what do we do?
>
> Patch libblockdev to use full paths or give it to udisksd's
> environment?

I think patching libblockdev is the better solution.  I'm applying
Sarah's patches which added dosfstools as an input and did the patching,
so we should be covered.

Closing.

-- 
Thanks,
Maxim

Subject: [PATCH] gnu: udisks: Add dosfstools to PATH with wrapper.
From: John Doe <[email-masked]>
To: [email-masked]
Cc: John Doe <[email-masked]>
Date: Tue, 22 Dec 2020 23:21:27 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/freedesktop.scm (udisks):
[inputs]: Add dosfstools.
[arguments]: Modify 'wrap-udisksd phase to add dosfstools in PATH with
wrapper.
---
 gnu/packages/freedesktop.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 3c4ad57a15..1104a07955 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -1112,6 +1112,7 @@ Analysis and Reporting Technology) functionality.")
     (inputs
      `(("acl" ,acl)
        ("cryptsetup" ,cryptsetup)
+       ("dosfstools" ,dosfstools)
        ("libatasmart" ,libatasmart)
        ("libblockdev" ,libblockdev)
        ("libgudev" ,libgudev)
@@ -1163,6 +1164,7 @@ Analysis and Reporting Technology) functionality.")
              (let ((out   (assoc-ref outputs "out"))
                    (utils (assoc-ref inputs "util-linux"))
                    (cryptsetup (assoc-ref inputs "cryptsetup"))
+                   (dosfstools (assoc-ref inputs "dosfstools"))
                    (parted (assoc-ref inputs "parted")))
                (wrap-program (string-append out "/libexec/udisks2/udisksd")
                  `("PATH" ":" prefix
@@ -1170,6 +1172,8 @@ Analysis and Reporting Technology) functionality.")
                     ;; cryptsetup is required for setting encrypted
                     ;; partitions, e.g. in gnome-disks
                     ,(string-append cryptsetup "/sbin")
+                    ;; Required to format FAT file systems in gnome-disks
+                    ,(string-append dosfstools "/sbin")
                     "/run/current-system/profile/bin"
                     "/run/current-system/profile/sbin")))
                #t))))))
-- 
2.29.2