From unknown Sun Jun 22 11:41:42 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#45374] [PATCH] gnu: udisks: Add dosfstools to PATH with wrapper. Resent-From: John Doe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 22 Dec 2020 22:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45374 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 45374@debbugs.gnu.org Cc: John Doe X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160867571524131 (code B ref -1); Tue, 22 Dec 2020 22:22:02 +0000 Received: (at submit) by debbugs.gnu.org; 22 Dec 2020 22:21:55 +0000 Received: from localhost ([127.0.0.1]:51095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krq2U-0006H9-Mg for submit@debbugs.gnu.org; Tue, 22 Dec 2020 17:21:54 -0500 Received: from lists.gnu.org ([209.51.188.17]:35434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krq2P-0006Gx-W8 for submit@debbugs.gnu.org; Tue, 22 Dec 2020 17:21:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krq2O-0006Ro-KI for guix-patches@gnu.org; Tue, 22 Dec 2020 17:21:49 -0500 Received: from smtp2-g21.free.fr ([212.27.42.2]:8184) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krq2L-0004v0-Sp for guix-patches@gnu.org; Tue, 22 Dec 2020 17:21:47 -0500 Received: from localhost.localdomain (unknown [IPv6:2a01:e0a:2a2:1350:cd10:777c:7b57:3bb6]) (Authenticated sender: dftxbs3e) by smtp2-g21.free.fr (Postfix) with ESMTPSA id AA3F42003C8; Tue, 22 Dec 2020 23:21:38 +0100 (CET) From: John Doe Date: Tue, 22 Dec 2020 23:21:27 +0100 Message-Id: <20201222222127.2659-1-dftxbs3e@free.fr> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=212.27.42.2; envelope-from=dftxbs3e@free.fr; helo=smtp2-g21.free.fr X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, SPOOFED_FREEMAIL=1.526 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) * gnu/packages/freedesktop.scm (udisks): [inputs]: Add dosfstools. [arguments]: Modify 'wrap-udisksd phase to add dosfstools in PATH with wrapper. --- gnu/packages/freedesktop.scm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm index 3c4ad57a15..1104a07955 100644 --- a/gnu/packages/freedesktop.scm +++ b/gnu/packages/freedesktop.scm @@ -1112,6 +1112,7 @@ Analysis and Reporting Technology) functionality.") (inputs `(("acl" ,acl) ("cryptsetup" ,cryptsetup) + ("dosfstools" ,dosfstools) ("libatasmart" ,libatasmart) ("libblockdev" ,libblockdev) ("libgudev" ,libgudev) @@ -1163,6 +1164,7 @@ Analysis and Reporting Technology) functionality.") (let ((out (assoc-ref outputs "out")) (utils (assoc-ref inputs "util-linux")) (cryptsetup (assoc-ref inputs "cryptsetup")) + (dosfstools (assoc-ref inputs "dosfstools")) (parted (assoc-ref inputs "parted"))) (wrap-program (string-append out "/libexec/udisks2/udisksd") `("PATH" ":" prefix @@ -1170,6 +1172,8 @@ Analysis and Reporting Technology) functionality.") ;; cryptsetup is required for setting encrypted ;; partitions, e.g. in gnome-disks ,(string-append cryptsetup "/sbin") + ;; Required to format FAT file systems in gnome-disks + ,(string-append dosfstools "/sbin") "/run/current-system/profile/bin" "/run/current-system/profile/sbin"))) #t)))))) -- 2.29.2 From unknown Sun Jun 22 11:41:42 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#45374] [PATCH] gnu: udisks: Add dosfstools to PATH with wrapper. Resent-From: dftxbs3e Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 22 Dec 2020 22:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45374 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 45374@debbugs.gnu.org Received: via spool by 45374-submit@debbugs.gnu.org id=B45374.160867707826776 (code B ref 45374); Tue, 22 Dec 2020 22:45:01 +0000 Received: (at 45374) by debbugs.gnu.org; 22 Dec 2020 22:44:38 +0000 Received: from localhost ([127.0.0.1]:51144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krqOT-0006xn-Pz for submit@debbugs.gnu.org; Tue, 22 Dec 2020 17:44:37 -0500 Received: from smtp2-g21.free.fr ([212.27.42.2]:5882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krqOR-0006xf-Rv for 45374@debbugs.gnu.org; Tue, 22 Dec 2020 17:44:36 -0500 Received: from [IPv6:2a01:e0a:2a2:1350:cd10:777c:7b57:3bb6] (unknown [IPv6:2a01:e0a:2a2:1350:cd10:777c:7b57:3bb6]) (Authenticated sender: dftxbs3e) by smtp2-g21.free.fr (Postfix) with ESMTPSA id 7E951200371 for <45374@debbugs.gnu.org>; Tue, 22 Dec 2020 23:44:33 +0100 (CET) Message-ID: From: dftxbs3e Date: Tue, 22 Dec 2020 23:44:29 +0100 In-Reply-To: References: <20201222222127.2659-1-dftxbs3e@free.fr> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-e21sUzq0M/uGEu7hKl5F" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-Spam-Score: 0.6 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) --=-e21sUzq0M/uGEu7hKl5F Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Looks like there has already been some discussion about this:=20 https://issues.guix.gnu.org/41247 So what do we do? Patch libblockdev to use full paths or give it to udisksd's environment? --=-e21sUzq0M/uGEu7hKl5F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQozTys6hLca3Ekt8u3HhLxn6GoewUCX+J2zQAKCRC3HhLxn6Go e2uZAP9dSOoNdS9P9gy52hIYBsvYxGKeaHzHC9mw+0TpjwxQ5wEAzmLnComUE1vj wD0z34HjAVxN0VCOq9gG2utCPoKO1w4= =LdpI -----END PGP SIGNATURE----- --=-e21sUzq0M/uGEu7hKl5F-- From unknown Sun Jun 22 11:41:42 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: John Doe Subject: bug#45374: closed (Re: [bug#45374] [PATCH] gnu: udisks: Add dosfstools to PATH with wrapper.) Message-ID: References: <87frtukdvb.fsf@gmail.com> <20201222222127.2659-1-dftxbs3e@free.fr> X-Gnu-PR-Message: they-closed 45374 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 45374@debbugs.gnu.org Date: Mon, 03 Jun 2024 01:37:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1717378622-31944-1" This is a multi-part message in MIME format... ------------=_1717378622-31944-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #45374: [PATCH] gnu: udisks: Add dosfstools to PATH with wrapper. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 45374@debbugs.gnu.org. --=20 45374: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D45374 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1717378622-31944-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 45374-done) by debbugs.gnu.org; 3 Jun 2024 01:36:28 +0000 Received: from localhost ([127.0.0.1]:57848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDwcd-0008Hp-St for submit@debbugs.gnu.org; Sun, 02 Jun 2024 21:36:28 -0400 Received: from mail-qk1-f169.google.com ([209.85.222.169]:46514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDwcc-0008HV-8E for 45374-done@debbugs.gnu.org; Sun, 02 Jun 2024 21:36:26 -0400 Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-794c3946468so290442685a.1 for <45374-done@debbugs.gnu.org>; Sun, 02 Jun 2024 18:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717378507; x=1717983307; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ae17jHhNOxs4wYi1HXGNqsyW6+szH78PqylOfRtdX3Q=; b=TLDFSLnCuT+NZC2rABdHKnKzmzgTZTp/e4iTHH57w4nIOFV0+XLOAfe8/xEuEWAl/S P5hk9wBt5VsTGm2D1Ok6Yx9PGVf8wGrJMV8Mj//4dK+04ls2n2N/ZBlexqfTHh39CCd0 7vkWElbo+xR8ej+vcdg+sEYEDWggFhg2ukr7LCPMmC+FskxvlHZJ5uq25D5oNUWr2tMV N+XBTjCHzPtrOa3KmAI8FGPalNFm2IRJkrbLi6yItDznL7praZrzXtUEscQkCTv2iSgY M070P3lozh79I7HmXvQ6AXNoIfoNIaoyPEjLpGqT4oWXacujvdUb6hL/kE9stFI/IDiE QrIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717378507; x=1717983307; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ae17jHhNOxs4wYi1HXGNqsyW6+szH78PqylOfRtdX3Q=; b=RT8o6VVSupByRXdNdqkUYnMb/euLnxlt/SASeiC/PrwZH7dKBRVG+56Z65a00mMsxh I22ZX5bc9tWIrnDc4v2Aml2byijSmT7fJGBMMVVxb72IkuKZLL7BmMC1NGhsxWoQblkD 86A65Rl0LTYlbwFed8twC97XGufDoARt+UmF1NAh3EBouzHzgLlkgsx6362OC+I/q3xI UAelxVyXrcVZk+3dOCCuqAFP/ESQdd7T14q/KI5dn6T6sFgK4/1qLCyQt7zV6aRVg6IG 1Vyrg2m/LjdjEX4EuXtC4JLlnXqa0V38gmM3GJw+8y3W+02azxRy+0K8JkSoKJG2yg4F Fu6w== X-Gm-Message-State: AOJu0YwoLzVq4KtXOkqPHHA3cAzeju5a9kWpIDTjQApmo4dNZ/LhTPTE ANVKmQGrHpSkWRjOmZdADYHdnC+0k7Z6w5gsNQZyZB56r2VZOD7TyS0Pww== X-Google-Smtp-Source: AGHT+IHaiSRwBA9ao2DGQKoZX5St4omqhfqcPK4LIsQbOfW+8wpji8QDqDNrAru7XD+MaBPveoGVmg== X-Received: by 2002:a05:620a:578a:b0:794:b350:a4b4 with SMTP id af79cd13be357-794f5c99841mr886020085a.46.1717378506608; Sun, 02 Jun 2024 18:35:06 -0700 (PDT) Received: from hurd (dsl-10-130-93.b2b2c.ca. [72.10.130.93]) by smtp.gmail.com with ESMTPSA id af79cd13be357-794f2f121aesm241854385a.39.2024.06.02.18.35.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jun 2024 18:35:05 -0700 (PDT) From: Maxim Cournoyer To: dftxbs3e Subject: Re: [bug#45374] [PATCH] gnu: udisks: Add dosfstools to PATH with wrapper. In-Reply-To: (dftxbs3e@free.fr's message of "Tue, 22 Dec 2020 23:44:29 +0100") References: <20201222222127.2659-1-dftxbs3e@free.fr> Date: Sun, 02 Jun 2024 21:35:04 -0400 Message-ID: <87frtukdvb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45374-done Cc: 45374-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, dftxbs3e writes: > Looks like there has already been some discussion about this: > https://issues.guix.gnu.org/41247 > > So what do we do? > > Patch libblockdev to use full paths or give it to udisksd's > environment? I think patching libblockdev is the better solution. I'm applying Sarah's patches which added dosfstools as an input and did the patching, so we should be covered. Closing. -- Thanks, Maxim ------------=_1717378622-31944-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 22 Dec 2020 22:21:55 +0000 Received: from localhost ([127.0.0.1]:51095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krq2U-0006H9-Mg for submit@debbugs.gnu.org; Tue, 22 Dec 2020 17:21:54 -0500 Received: from lists.gnu.org ([209.51.188.17]:35434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krq2P-0006Gx-W8 for submit@debbugs.gnu.org; Tue, 22 Dec 2020 17:21:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krq2O-0006Ro-KI for guix-patches@gnu.org; Tue, 22 Dec 2020 17:21:49 -0500 Received: from smtp2-g21.free.fr ([212.27.42.2]:8184) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krq2L-0004v0-Sp for guix-patches@gnu.org; Tue, 22 Dec 2020 17:21:47 -0500 Received: from localhost.localdomain (unknown [IPv6:2a01:e0a:2a2:1350:cd10:777c:7b57:3bb6]) (Authenticated sender: dftxbs3e) by smtp2-g21.free.fr (Postfix) with ESMTPSA id AA3F42003C8; Tue, 22 Dec 2020 23:21:38 +0100 (CET) From: John Doe To: guix-patches@gnu.org Subject: [PATCH] gnu: udisks: Add dosfstools to PATH with wrapper. Date: Tue, 22 Dec 2020 23:21:27 +0100 Message-Id: <20201222222127.2659-1-dftxbs3e@free.fr> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=212.27.42.2; envelope-from=dftxbs3e@free.fr; helo=smtp2-g21.free.fr X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, SPOOFED_FREEMAIL=1.526 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: submit Cc: John Doe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) * gnu/packages/freedesktop.scm (udisks): [inputs]: Add dosfstools. [arguments]: Modify 'wrap-udisksd phase to add dosfstools in PATH with wrapper. --- gnu/packages/freedesktop.scm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm index 3c4ad57a15..1104a07955 100644 --- a/gnu/packages/freedesktop.scm +++ b/gnu/packages/freedesktop.scm @@ -1112,6 +1112,7 @@ Analysis and Reporting Technology) functionality.") (inputs `(("acl" ,acl) ("cryptsetup" ,cryptsetup) + ("dosfstools" ,dosfstools) ("libatasmart" ,libatasmart) ("libblockdev" ,libblockdev) ("libgudev" ,libgudev) @@ -1163,6 +1164,7 @@ Analysis and Reporting Technology) functionality.") (let ((out (assoc-ref outputs "out")) (utils (assoc-ref inputs "util-linux")) (cryptsetup (assoc-ref inputs "cryptsetup")) + (dosfstools (assoc-ref inputs "dosfstools")) (parted (assoc-ref inputs "parted"))) (wrap-program (string-append out "/libexec/udisks2/udisksd") `("PATH" ":" prefix @@ -1170,6 +1172,8 @@ Analysis and Reporting Technology) functionality.") ;; cryptsetup is required for setting encrypted ;; partitions, e.g. in gnome-disks ,(string-append cryptsetup "/sbin") + ;; Required to format FAT file systems in gnome-disks + ,(string-append dosfstools "/sbin") "/run/current-system/profile/bin" "/run/current-system/profile/sbin"))) #t)))))) -- 2.29.2 ------------=_1717378622-31944-1--