GNU bug report logs - #45372
[PATCH 0/1] Fix 29485: package broken since ever

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45372 in the body.
You can then email your comments to 45372 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: zimoun <zimon.toutoune <at> gmail.com>
Subject: [PATCH 0/1] Fix 29485: package broken since ever
Date: Tue, 22 Dec 2020 17:58:28 +0100

Dear,

This patch is to close bug#29485, reported since more than 3 years.

   <http://issues.guix.gnu.org/issue/29485>


Quoting:

On Tue, 28 Nov 2017 at 15:41, ng0 <ng0 <at> n0.is> wrote:

  However this is not really a problem unless you are on GuixSD.
  As we do not package the DB of MaxDB (yet) you'll need for this, it's
  not a problem. I'm filing this bug to remind myself to fix Geo::IP once
  I have revisited the discussion we had about the DB a while back.


On Thu, 03 Dec 2020 at 01:34, zimoun <zimon.toutoune <at> gmail.com> wrote:

  It is a problem and the package is broken.  I am assuming this package
  is not used so I am proposing to simply remove it.  Otherwise, the
  database should be also packaged, else it appears to me meaningless.


On Thu, 03 Dec 2020 at 01:08, Leo Famulari <leo <at> famulari.name> wrote:

  Removal sounds good to me.

If the package is working for someone, we will know. :-)

All the best,
simon


zimoun (1):
  gnu: perl-geo-ip: Remove.

 gnu/packages/networking.scm | 24 ------------------------
 1 file changed, 24 deletions(-)


base-commit: aa6d4371d5f8413fe471ae820475b47adb869b28
-- 
2.29.2

Message #8 received at 45372 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: 45372 <at> debbugs.gnu.org
Cc: zimoun <zimon.toutoune <at> gmail.com>, leo <at> famulari.name
Subject: [PATCH 1/1] gnu: perl-geo-ip: Remove.
Date: Tue, 22 Dec 2020 18:01:58 +0100

Fixes <https://bugs.gnu.org/29485>.

* gnu/packages/networking.scm (perl-geo-ip): Remove variable.
---
 gnu/packages/networking.scm | 24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index d3f47da163..ff1de3a0cb 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2066,30 +2066,6 @@ It is intended primarily for use in testing.")
   (description "Net::CIDR::Lite merges IPv4 or IPv6 CIDR addresses.")
   (license license:gpl1+)))
 
-;; TODO: Use the geolite-mirror-simple.pl script from the example
-;; directory to stay current with the databases. How?
-(define-public perl-geo-ip
- (package
-  (name "perl-geo-ip")
-  (version "1.51")
-  (source
-    (origin
-      (method url-fetch)
-      (uri (string-append
-             "mirror://cpan/authors/id/M/MA/MAXMIND/Geo-IP-"
-             version
-             ".tar.gz"))
-      (sha256
-        (base32
-          "1fka8fr7fw6sh3xa9glhs1zjg3s2gfkhi7n7da1l2m2wblqj0c0n"))))
-  (build-system perl-build-system)
-  (home-page "https://metacpan.org/release/Geo-IP")
-  (synopsis
-    "Look up location and network information by IP Address in Perl")
-  (description "The Perl module @code{Geo::IP}.  It looks up location and
-network information by IP Address.")
-  (license license:perl-license)))
-
 (define-public perl-io-socket-inet6
  (package
   (name "perl-io-socket-inet6")
-- 
2.29.2

Message #13 received at 45372-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 45372-done <at> debbugs.gnu.org, 29485-done <at> debbugs.gnu.org, ng0 <ng0 <at> n0.is>
Subject: Re: bug#29485: perl-geo-ip is broken since ever!
Date: Tue, 22 Dec 2020 14:24:44 -0500

On Tue, Dec 22, 2020 at 06:00:38PM +0100, zimoun wrote:
> Hi,
> 
> On Thu, 03 Dec 2020 at 01:08, Leo Famulari <leo <at> famulari.name> wrote:
> > On Thu, Dec 03, 2020 at 01:34:23AM +0100, zimoun wrote:
> >> It is a problem and the package is broken.  I am assuming this package
> >> is not used so I am proposing to simply remove it.  Otherwise, the
> >> database should be also packaged, else it appears to me meaningless.
> >
> > Removal sounds good to me.
> 
> See 45372.  Once merged, let close this one.

Done with commit 06de9ca75f4bb508cdba3082d8ae80f014dbc38b

Message #16 received at 45372-done <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 45372-done <at> debbugs.gnu.org, 29485-done <at> debbugs.gnu.org, ng0 <ng0 <at> n0.is>
Subject: Re: bug#29485: perl-geo-ip is broken since ever!
Date: Tue, 22 Dec 2020 21:07:20 +0100

On Tue, 22 Dec 2020 at 14:24, Leo Famulari <leo <at> famulari.name> wrote:
> On Tue, Dec 22, 2020 at 06:00:38PM +0100, zimoun wrote:
>> Hi,
>> 
>> On Thu, 03 Dec 2020 at 01:08, Leo Famulari <leo <at> famulari.name> wrote:
>> > On Thu, Dec 03, 2020 at 01:34:23AM +0100, zimoun wrote:
>> >> It is a problem and the package is broken.  I am assuming this package
>> >> is not used so I am proposing to simply remove it.  Otherwise, the
>> >> database should be also packaged, else it appears to me meaningless.
>> >
>> > Removal sounds good to me.
>> 
>> See 45372.  Once merged, let close this one.
>
> Done with commit 06de9ca75f4bb508cdba3082d8ae80f014dbc38b

Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.