GNU bug report logs - #45362
[PATCH 0/1] rtl8812au-aircrack-ng won't build on Linux 5.10

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45362 in the body.
You can then email your comments to 45362 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: David Dashyan <mail <at> davie.li>
To: guix-patches <at> gnu.org
Cc: David Dashyan <mail <at> davie.li>
Subject: [PATCH 0/1] rtl8812au-aircrack-ng won't build on Linux 5.10
Date: Tue, 22 Dec 2020 13:46:50 +0300

Hello!  I'm using and recently it stopped building succesfully.
Probably due to kernel update I'm not too sure.

Fix for this was just merged today:
https://github.com/aircrack-ng/rtl8812au/pull/791

I haven't tested it on kernell versions defined in linux.scm.  Do I need to do
it before submitting patch for linux module?

David Dashyan (1):
  rtl8812au-aircrack-ng-linux-module: Update to 62cb003

 gnu/packages/linux.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)


base-commit: 2e7c2dc8fa64442eb5b67670c5533090bebdd7fd
-- 
2.29.2

Message #8 received at 45362 <at> debbugs.gnu.org (full text, mbox):

From: David Dashyan <mail <at> davie.li>
To: 45362 <at> debbugs.gnu.org
Cc: David Dashyan <mail <at> davie.li>
Subject: [PATCH 1/1] rtl8812au-aircrack-ng-linux-module: Update to 62cb003
Date: Tue, 22 Dec 2020 13:51:29 +0300

---
 gnu/packages/linux.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 01dba7e92d..d7e91f7c4f 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -51,6 +51,7 @@
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2020 Greg Hogan <code <at> greghogan.com>
 ;;; Copyright © 2020 Zhu Zihao <all_but_last <at> 163.com>
+;;; Copyright © 2020 David Dashyan <mail <at> davie.li>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1119,8 +1120,8 @@ and should be used with caution, especially on untested models.")
     (license license:gpl3+)))           ; see README.md (no licence headers)
 
 (define-public rtl8812au-aircrack-ng-linux-module
-  (let ((commit "e9fbf5c051453941bbc029810b893a6c010714e6")
-        (revision "2"))
+  (let ((commit "62cb003043e4daeeba0b8805137fa604af450ed2")
+        (revision "3"))
     (package
       (name "rtl8812au-aircrack-ng-linux-module")
       (version (git-version "5.6.4.2" revision commit))
@@ -1132,7 +1133,7 @@ and should be used with caution, especially on untested models.")
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32 "0y71q7ajwz1w38gdmxd4p05hhkqndq504nndy6vfa16fxz6pqxhn"))
+          (base32 "1kragxkjprjy7nl9h2rd0mwcry1ygw07zb1p2qkj7cmz0r2035yz"))
          (modules '((guix build utils)))
          (snippet
           '(begin
-- 
2.29.2

Message #11 received at 45362 <at> debbugs.gnu.org (full text, mbox):

From: David Dashyan <mail <at> davie.li>
To: David Dashyan <mail <at> davie.li>
Cc: 45362 <at> debbugs.gnu.org
Subject: Re: [PATCH 0/1] rtl8812au-aircrack-ng won't build on Linux 5.10
Date: Tue, 22 Dec 2020 14:00:11 +0300

Oops attached wrong pr link..
https://github.com/aircrack-ng/rtl8812au/pull/773

> Hello!  I'm using and recently it stopped building succesfully.
* I'm using rtl8812au-aircrack-ng and recently...

-- 
David aka zzappie

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: David Dashyan <mail <at> davie.li>
Cc: 45362-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#45362] [PATCH 0/1] rtl8812au-aircrack-ng won't build on
 Linux 5.10
Date: Tue, 22 Dec 2020 13:35:10 +0100

[Message part 1 (text/plain, inline)]

David,

David Dashyan 写道：
> Probably due to kernel update I'm not too sure.

Hah, yes :-)  Same damn upstream change that kept me busy all 
morning.

> Fix for this was just merged today:
> https://github.com/aircrack-ng/rtl8812au/pull/791

At a glance that looks like it should keep working fine on older 
kernels.

> I haven't tested it on kernell versions defined in linux.scm. 
> Do I need to do
> it before submitting patch for linux module?

I would, at least the latest ‘longterm’ release, currently 5.4. 
In this case it built fine.

The project obviously intend to keep backwards compatibility so 
any regressions are theirs to fix & ours to update or patch to.

Pushed with our conventional commit message, please take a 
look[0].

Thanks!

T G-R

[0]: 
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=8c66ac72fb0ad01227f196d61a0a7675b6f48d61

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 45362-done <at> debbugs.gnu.org (full text, mbox):

From: David Dashyan <mail <at> davie.li>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 45362-done <at> debbugs.gnu.org, David Dashyan <mail <at> davie.li>
Subject: Re: [bug#45362] [PATCH 0/1] rtl8812au-aircrack-ng won't build on
 Linux 5.10
Date: Tue, 22 Dec 2020 20:50:58 +0300

[Message part 1 (text/plain, inline)]

Hello Tobias!

> I would, at least the latest ‘longterm’ release, currently 5.4. In
> this case it built fine.
How do you test it btw?  With guix vm?

> Pushed with our conventional commit message, please take a look[0].
Cool!  Thanks for pointing out

-- 
David aka zzappie

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 45362-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: David Dashyan <mail <at> davie.li>
Cc: 45362-done <at> debbugs.gnu.org
Subject: Re: [bug#45362] [PATCH 0/1] rtl8812au-aircrack-ng won't build on
 Linux 5.10
Date: Tue, 22 Dec 2020 21:36:24 +0100

[Message part 1 (text/plain, inline)]

David,

David Dashyan 写道：
>> I would, at least the latest ‘longterm’ release, currently 
>> 5.4. In
>> this case it built fine.
> How do you test it btw?  With guix vm?

In this case I did, mainly because I was using 5.4 VMs for other 
things and it was the least effort.  Otherwise I'd have settled 
for build testing by simply adding ‘#:linux linux-libre-5.4’ in my 
git checkout and ./pre-inst-env guix building it.

I don't have the hardware nearby to really test it anyway.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.