GNU bug report logs - #45355
26.1; shr-tag-base doesn't handle <base href=""> properly

Previous Next

Package: emacs;

Reported by: Łukasz Stelmach <steelman <at> post.pl>

Date: Mon, 21 Dec 2020 20:37:02 UTC

Severity: normal

Tags: fixed

Found in version 26.1

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Łukasz Stelmach <steelman <at> post.pl>
Cc: 45355 <at> debbugs.gnu.org
Subject: bug#45355: 26.1; shr-tag-base doesn't handle <base href=""> properly
Date: Tue, 22 Dec 2020 07:47:54 +0100

Łukasz Stelmach <steelman <at> post.pl> writes:

> For what it's worth, W3C HTML Validator claims that a document with an
> empty string in the href attribute of a base tag
>
>     <base href="">
>
> is valid. I found such document recently in my INBOX and Gnus was unable
> to display it correctly because the second string-match in
> shr-parse-base breaks when local is nil. My solution is not to call
> shr-parse-base not only when href is not present but also when href is
> an empty string.
>
> The patch has been crated on the current master branch.

Looks good to me; I've now applied it to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
This bug report was last modified 4 years and 148 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.