From unknown Fri Sep 19 06:16:32 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#45345 <45345@debbugs.gnu.org> To: bug#45345 <45345@debbugs.gnu.org> Subject: Status: [elpa-archive] "make build/" should not pull unconditionally Reply-To: bug#45345 <45345@debbugs.gnu.org> Date: Fri, 19 Sep 2025 13:16:32 +0000 retitle 45345 [elpa-archive] "make build/" should not pull uncondi= tionally reassign 45345 emacs submitter 45345 Jonas Bernoulli severity 45345 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 20 15:31:38 2020 Received: (at submit) by debbugs.gnu.org; 20 Dec 2020 20:31:38 +0000 Received: from localhost ([127.0.0.1]:45685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kr5Mg-00048o-1l for submit@debbugs.gnu.org; Sun, 20 Dec 2020 15:31:38 -0500 Received: from lists.gnu.org ([209.51.188.17]:36848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kr5Me-00048g-Df for submit@debbugs.gnu.org; Sun, 20 Dec 2020 15:31:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kr5Me-0005h1-7H for bug-gnu-emacs@gnu.org; Sun, 20 Dec 2020 15:31:36 -0500 Received: from mail.hostpark.net ([212.243.197.30]:52318) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kr5Mc-0006OL-95 for bug-gnu-emacs@gnu.org; Sun, 20 Dec 2020 15:31:35 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id D9C0D165C4 for ; Sun, 20 Dec 2020 21:31:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :subject:subject:from:from:received:received; s=sel2011a; t= 1608496289; bh=DuKx2Kxvce9zbWawCLGP0SFaYHOY8tufy4Vpb/o0KTU=; b=A gHS1ZgpDBNf9c6m3kZhHr+IXLrFVNHpyNETLhHzAmDSh8n5h3Trq/QnDLJWvp5h4 ou0Dx9ULxL0aimz5nCuh5iPvEZcDHxRBtdAi9XyHtRA3aR8eAO9U6Y+7Aq6LLIDd 6+1q2wm6hk/yfAuMLJ6bMVfAXYg0DfJMTZFu1jkDaQ= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id 8jFSzmRFakcN for ; Sun, 20 Dec 2020 21:31:29 +0100 (CET) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id AF974165BD for ; Sun, 20 Dec 2020 21:31:29 +0100 (CET) From: Jonas Bernoulli To: bug-gnu-emacs@gnu.org Subject: [elpa-archive] "make build/" should not pull unconditionally X-Debbugs-Cc: Stefan Monnier Date: Sun, 20 Dec 2020 21:31:29 +0100 Message-ID: <875z4wi5i6.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: none client-ip=212.243.197.30; envelope-from=jonas@bernoul.li; helo=mail.hostpark.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > - Another advantage is that the new code makes it much easier to build > your own tarballs, for example to test them before pushing to code. > You can just do `make build/[PKGNAME]` and the resulting package will > be built in `archive/[PKGNAME]-[VERSION].tar. That almost worked. "make build/" (or `elpaa--make-one-package') calls `elpaa--external-package-sync', which pulls. That of course is not desirable when one wants to test some other revision of the package than what would end up being pulled. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 20 18:31:11 2020 Received: (at 45345) by debbugs.gnu.org; 20 Dec 2020 23:31:11 +0000 Received: from localhost ([127.0.0.1]:45788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kr8AR-0008If-5g for submit@debbugs.gnu.org; Sun, 20 Dec 2020 18:31:11 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:56968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kr8AQ-0008IS-14 for 45345@debbugs.gnu.org; Sun, 20 Dec 2020 18:31:10 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5D8EF100229; Sun, 20 Dec 2020 18:31:04 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 018161000D1; Sun, 20 Dec 2020 18:31:02 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1608507063; bh=rzUbbZS4w6CWbzjgiwKZkY4yaqTNQzPsCXxF9pfnr2I=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=O28RBu2Yvs4jDvuYXGXq1mWgKo75a/rhwOA11H9+1GUqG4c42ajcyATk7WaSht2N+ Fl+j5p3BRErp6mhs8yhtD9kpkFciKDYg6DN85yXsGIyiizMi5looRowWyOy3DZUyzR M1xnEWmFbSgDbPxQeZ9SRazPS6szaiMaanOtISLSSyS05iqUu0CT3oawslWcO6TqBt +m/HThHShaKIF2mJls/+Ub+qZtK/cG5dCp3tczUt4096s1h59Kvryz3t8kTbwK2HqH KinSAxKcRZacxoB41Sx5EhIoH5cVHlRfRz9E9wFytBSgpOJwoQoWryTjNPNnjw00qi MTYawwdzoBz9A== Received: from alfajor (69-165-136-52.dsl.teksavvy.com [69.165.136.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C49EF1202E2; Sun, 20 Dec 2020 18:31:02 -0500 (EST) From: Stefan Monnier To: Jonas Bernoulli Subject: Re: bug#45345: [elpa-archive] "make build/" should not pull unconditionally Message-ID: References: <875z4wi5i6.fsf@bernoul.li> Date: Sun, 20 Dec 2020 18:31:01 -0500 In-Reply-To: <875z4wi5i6.fsf@bernoul.li> (Jonas Bernoulli's message of "Sun, 20 Dec 2020 21:31:29 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.087 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45345 Cc: 45345@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> - Another advantage is that the new code makes it much easier to build >> your own tarballs, for example to test them before pushing to code. >> You can just do `make build/[PKGNAME]` and the resulting package will >> be built in `archive/[PKGNAME]-[VERSION].tar. > That almost worked. "make build/" (or `elpaa--make-one-package') > calls `elpaa--external-package-sync', which pulls. That of course is not > desirable when one wants to test some other revision of the package than > what would end up being pulled. Could you give some detail about the situation in which doing `git pull` was a problem for you? I mean, obviously I could just move that call to `elpaa--external-package-sync` elsewhere, but `elpaa--make-one-package' is supposed to make packages from *commits* (it normally makes two packages, one from the head of the branch and another from the last commit that changed `Version:` line) so it "inherently" moves between different commits. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 21 05:47:06 2020 Received: (at 45345) by debbugs.gnu.org; 21 Dec 2020 10:47:06 +0000 Received: from localhost ([127.0.0.1]:46402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krIiY-0001A6-0M for submit@debbugs.gnu.org; Mon, 21 Dec 2020 05:47:06 -0500 Received: from mail.hostpark.net ([212.243.197.30]:50662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krIiW-00019s-9c for 45345@debbugs.gnu.org; Mon, 21 Dec 2020 05:47:05 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id DDEC0165CD; Mon, 21 Dec 2020 11:47:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from:received :received; s=sel2011a; t=1608547622; bh=KBXqcWqKur6euIpIYBhbxcse WRpa6HeMJ4KU1inmuVw=; b=ze447qvb4yOlbixYM+6de7uax/vl5Hn0+r6urutX IsdhYIv+bnd9DtdWmjXRhAQ4sb5sr99cobfjTIoYJCEYVwpbrFcDH7hTjUQT9FD7 K379SxSCh2xXA1xN2CN46KObfttAE/M5XfniD0OMCAfraX5IJ4mZNcFphNEWwh7g vLg= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id s5Ou6qqFxCKP; Mon, 21 Dec 2020 11:47:02 +0100 (CET) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id AB16A165C7; Mon, 21 Dec 2020 11:47:02 +0100 (CET) From: Jonas Bernoulli To: Stefan Monnier Subject: Re: bug#45345: [elpa-archive] "make build/" should not pull unconditionally In-Reply-To: References: <875z4wi5i6.fsf@bernoul.li> Date: Mon, 21 Dec 2020 11:47:02 +0100 Message-ID: <87ft3zbfmh.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45345 Cc: 45345@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier writes: >>> - Another advantage is that the new code makes it much easier to build >>> your own tarballs, for example to test them before pushing to code. >>> You can just do `make build/[PKGNAME]` and the resulting package will >>> be built in `archive/[PKGNAME]-[VERSION].tar. >> That almost worked. "make build/" (or `elpaa--make-one-package') >> calls `elpaa--external-package-sync', which pulls. That of course is not >> desirable when one wants to test some other revision of the package than >> what would end up being pulled. > > Could you give some detail about the situation in which doing `git pull` > was a problem for you? I was making some experimental changes. In this case the changes where to transient's internal tools responsible for updating version numbers in the manual. These tools are broken when used in a worktree of the elpa repository because they relay in git tags, which do not exist here. I did not want to push any of these very temporary experiments to the public transient repository, just so elpa-archive could pull them from there. IMO its irrelevant what experiments I was running. There will always be things people will want to try out before making them public. > I mean, obviously I could just move that call to > `elpaa--external-package-sync` elsewhere, but `elpaa--make-one-package' > is supposed to make packages from *commits* (it normally makes two > packages, one from the head of the branch and another from the last > commit that changed `Version:` line) so it "inherently" moves between > different commits. I dealt with that by creating a temporary dummy commit. I also bumped the Package-Version to some temporary fantasy number in that same commit. None of that I want to push to some public location just so I can test locally. Jonas From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 21 09:33:34 2020 Received: (at 45345) by debbugs.gnu.org; 21 Dec 2020 14:33:34 +0000 Received: from localhost ([127.0.0.1]:46619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krMFh-0001Nl-Sn for submit@debbugs.gnu.org; Mon, 21 Dec 2020 09:33:34 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:3161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krMFc-0001Mx-Cd for 45345@debbugs.gnu.org; Mon, 21 Dec 2020 09:33:32 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D1120100246; Mon, 21 Dec 2020 09:33:22 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 602BE100068; Mon, 21 Dec 2020 09:33:21 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1608561201; bh=1YmkkkxllJ45Pqfl/SXay82AzcYa39fm/jg3qR7BO2U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Vz4jNC2i0KXT6O3UnI1lPTQThsjEgCaE/lh1TQhuHeZo8ehvz5Xxm9jstFY6FPybL xq5bDsjNQAXc10QrgN24HGbJtm3LBsSxvzh7fIRo+E7/ioiQp8rprU9DEoxoX4Y43v VpD6qtnwFVRQGxOnXgnleR+q6DbtA63x1BjixjumlB+pUlghfnKiH4qin0cx+Z65Sb W+OS2SXQ0LxiSqlLCAo0woRct7mb8eogWKt3R1axed3AXjQPff8fK/s85MarU1MhqY xhYeI8NyCiTSVgGqur4PPapfghyQFy2oYZ5FTHjFVnvlc97hpWQss8yVvnh2Xl2ieO yajM9BCEBrBmQ== Received: from alfajor (69-165-136-52.dsl.teksavvy.com [69.165.136.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 32525120312; Mon, 21 Dec 2020 09:33:21 -0500 (EST) From: Stefan Monnier To: Jonas Bernoulli Subject: Re: bug#45345: [elpa-archive] "make build/" should not pull unconditionally Message-ID: References: <875z4wi5i6.fsf@bernoul.li> <87ft3zbfmh.fsf@bernoul.li> Date: Mon, 21 Dec 2020 09:33:20 -0500 In-Reply-To: <87ft3zbfmh.fsf@bernoul.li> (Jonas Bernoulli's message of "Mon, 21 Dec 2020 11:47:02 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.087 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45345 Cc: 45345@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I was making some experimental changes. In this case the changes where > to transient's internal tools responsible for updating version numbers > in the manual. These tools are broken when used in a worktree of the > elpa repository because they relay in git tags, which do not exist here. > > I did not want to push any of these very temporary experiments to the > public transient repository, just so elpa-archive could pull them from > there. There's definitely no need to affect remote repositories. Assuming you're using the "normal" setup where `packages/transient` is a worktree, `elpaa--external-package-sync` won't actually fetch anything from the remote server and will just do `git merge` which will presumably do nothing at all unless you've `git fetched` something into `origin/externals/transient` since the last sync or you manually moved the `externals/transient` branch back to some earlier commit. So, I think your diagnostic pointing at `elpaa--external-package-sync` was a red herring and the problem is rather that: >> `elpaa--make-one-package' >> is supposed to make packages from *commits* whereas you wanted to make a tarball from whatever was currently in `packages/transient`, including uncommitted changes. Is that right? IOW the function that got in the way of your goal wasn't `elpaa--external-package-sync` but `elpaa--clean`. I think the solution will be to make a new kind of make target which just builds one tarball and skips `elpaa--clean` (and will also skip `elpaa--external-package-sync` while we're at it). Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 21 12:26:26 2020 Received: (at 45345) by debbugs.gnu.org; 21 Dec 2020 17:26:26 +0000 Received: from localhost ([127.0.0.1]:48186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krOx0-0007x5-IG for submit@debbugs.gnu.org; Mon, 21 Dec 2020 12:26:26 -0500 Received: from mail.hostpark.net ([212.243.197.30]:47796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krOww-0007wv-VE for 45345@debbugs.gnu.org; Mon, 21 Dec 2020 12:26:24 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 4C3D6160DD; Mon, 21 Dec 2020 18:26:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from:received :received; s=sel2011a; t=1608571581; bh=hmI46aHKMRdarcSkzGRJhPRz OQ071Bhb7tdgY2ruyyY=; b=mvSDmvBqxtbzdPuvBDLQGoeB8wxR2dJ0d+vlrE4r 3ajMyOOAhYjH3DDZKdZb7VibVRtzhj+59q89OCCMUqDLT1EAIZSap4jjKYcWxqC7 +SDBQ0ekQC1U9v9422iWN6+3ES2+kHdCLGLhpSsEGpeiPkUQtlWW1h18g5y1yTbi 9YA= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id XzNbKj9hWCYB; Mon, 21 Dec 2020 18:26:21 +0100 (CET) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 0F9E9160AE; Mon, 21 Dec 2020 18:26:21 +0100 (CET) From: Jonas Bernoulli To: Stefan Monnier Subject: Re: bug#45345: [elpa-archive] "make build/" should not pull unconditionally In-Reply-To: References: <875z4wi5i6.fsf@bernoul.li> <87ft3zbfmh.fsf@bernoul.li> Date: Mon, 21 Dec 2020 18:26:18 +0100 Message-ID: <87mty7vznp.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45345 Cc: 45345@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier writes: > `elpaa--external-package-sync` won't actually fetch anything > from the remote server and will just do `git merge` which will > presumably do nothing at all unless you've `git fetched` something into > `origin/externals/transient` since the last sync or you manually moved > the `externals/transient` branch back to some earlier commit. Now that you mention it, yes I did move back to some earlier commit. I just tried with some new local-only commits and without rewinding first and that indeed worked just fine. I don't expect to rewind history going forward so this likely won't cause me any issues anymore. (I had to rewind because I had not yet discarded the special "for-gnu-elpa" branch that moved the library to the top-level. In this case I did have to "rewrite history", but I don't plan to do that again.) > So, I think your diagnostic pointing at `elpaa--external-package-sync` > was a red herring and the problem is rather that: > >>> `elpaa--make-one-package' >>> is supposed to make packages from *commits* > > whereas you wanted to make a tarball from whatever was currently in > `packages/transient`, including uncommitted changes. Is that right? No, I did in fact create a commit named "[WIP]". > IOW the function that got in the way of your goal wasn't > `elpaa--external-package-sync` but `elpaa--clean`. Had I not created a commit, then yes, that would have been a problem, but apparently I anticipated this complication. ;) > I think the solution will be to make a new kind of make target which > just builds one tarball and skips `elpaa--clean` (and will also skip > `elpaa--external-package-sync` while we're at it). Something like "make archive/" and "make archive-devel/"? That might be useful. Jonas From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 21 22:27:28 2020 Received: (at 45345) by debbugs.gnu.org; 22 Dec 2020 03:27:28 +0000 Received: from localhost ([127.0.0.1]:48681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krYKe-0005gn-6H for submit@debbugs.gnu.org; Mon, 21 Dec 2020 22:27:28 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krYKb-0005gX-C5 for 45345@debbugs.gnu.org; Mon, 21 Dec 2020 22:27:27 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CF956100246; Mon, 21 Dec 2020 22:27:19 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5870A100225; Mon, 21 Dec 2020 22:27:18 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1608607638; bh=MmWz09Z5Z3oFK0fDOfvVmHEO8SY3mUm0UogBWC388PI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=RPLu5vSFW3F1Gh6tl+c8Dq+wZEtdMPHKZ4x/EIijSrIVcvfgSK1W83AGJ3icv1Ix3 78iVADS52Q1R975/nAkyqw7xKzp47ncReeunRxKq2Q2Ww14YwgWUTeI0if1Da4Rwmv cJmDzKdHpkVhD+p/SdWhhrLoVb+d5jPjkm02d7iGntn8xLnhcU+cdaB+I2V14nKCjo Ek4Pubz6Bd404Osq7il0iNuUBg9WTFhxGP/369WxZ+Wx6NfoG5ICSKKUDgazJgaRpc Z21hjLUJFiTpt1ZSk5lAjvqmgZW5fcRoWLxrpuYrq/GIHJUdR0HhQrAL+7HcUlDS/G DP7KIXsGY/swA== Received: from alfajor (69-165-136-52.dsl.teksavvy.com [69.165.136.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 13BA5120205; Mon, 21 Dec 2020 22:27:18 -0500 (EST) From: Stefan Monnier To: Jonas Bernoulli Subject: Re: bug#45345: [elpa-archive] "make build/" should not pull unconditionally Message-ID: References: <875z4wi5i6.fsf@bernoul.li> <87ft3zbfmh.fsf@bernoul.li> <87mty7vznp.fsf@bernoul.li> Date: Mon, 21 Dec 2020 22:27:17 -0500 In-Reply-To: <87mty7vznp.fsf@bernoul.li> (Jonas Bernoulli's message of "Mon, 21 Dec 2020 18:26:18 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.089 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45345 Cc: 45345@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Something like "make archive/" > and "make archive-devel/"? > That might be useful. I pushed a patch such that you can now do make [PKGNAME].tar and it will just (re)build that one tarball with whichever revision is currently in `packages/[PKGNAME]`. Stefan