From unknown Tue Jun 24 05:08:05 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#4534 <4534@debbugs.gnu.org> To: bug#4534 <4534@debbugs.gnu.org> Subject: Status: assertion failure at window.c:grow_mini_window Reply-To: bug#4534 <4534@debbugs.gnu.org> Date: Tue, 24 Jun 2025 12:08:05 +0000 retitle 4534 assertion failure at window.c:grow_mini_window reassign 4534 emacs submitter 4534 Juanma Barranquero severity 4534 normal thanks From lekktu@gmail.com Tue Sep 22 20:03:15 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 23 Sep 2009 03:03:15 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.2 required=4.0 tests=AWL,FOURLA,FVGT_m_MULTI_ODD, IMPRONONCABLE_2 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-fx0-f207.google.com (mail-fx0-f207.google.com [209.85.220.207]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8N33C9h029478 for ; Tue, 22 Sep 2009 20:03:14 -0700 Received: by fxm3 with SMTP id 3so263971fxm.44 for ; Tue, 22 Sep 2009 20:03:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=oJ0ievXbca7oRXdSR3FqdOWQc5WTUifH1vM3+n84NVU=; b=JfII6YdeBAQJvlI8M1LllPPBVy6ouaNFXORtAdJrktkOX5Z/H4ShkESL59bDOXxyIu CAhjCkWMsdm64rNxzhdiT+4sxqG/AjQsN9WRdLtfizXPvwV6NyE+noNl65281f9FEAUp eEJjp3U3KW5cUnPL9ZbzjCJyaHLO3PhCpMQEA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=BvBi0UVGCFf23duccuRmIZRj2L9ybK8f+pIFn4kAzpqeB9coUsf9aO9EOAokm33GxE FvCVcHYxLe5+JEQKcBeyUSy7jb5F3CzhaMXxTV3TqrQKjxBm7BkAZg4IJ93ZqQIz1Vzg XnGplvYt92U6tQDSFNAGSv50yrUJunm7Ho1Mc= MIME-Version: 1.0 Received: by 10.239.139.104 with SMTP id s40mr142159hbs.76.1253674987185; Tue, 22 Sep 2009 20:03:07 -0700 (PDT) From: Juanma Barranquero Date: Wed, 23 Sep 2009 05:02:47 +0200 Message-ID: Subject: assertion failure at window.c:grow_mini_window To: Emacs Bug Tracker Content-Type: multipart/mixed; boundary=001485f1ec84466674047435f47f --001485f1ec84466674047435f47f Content-Type: text/plain; charset=UTF-8 GNU Emacs 23.1.50.1 (i386-mingw-nt5.1.2600) of 2009-09-22 on LEKTU Compiled with gcc (4.3.3-tdm-1-dw2 mingw32) 4.3.3-dw2 I put the attached files into directory C:\temp, including the file test.el: (setq resize-mini-windows t) (setq ido-enable-flex-matching t) (setq ido-max-prospects 14) (ido-mode 1) Then, emacs -Q -l c:/temp/test.el C-x C-f c:/temp/testfile 3 7 Emacs aborts. (Note: As the failure depends on the number of lines in the minibuffer, tweaking `ido-max-prospects' and/or adding more files to the directory may be necessary to reproduce the bug.) The xassert (delta >= 0) at the start of window.c:grow_mini_window fails, because delta == -1. In resize_mini_window, the call to xdisp.c:grow_mini_window has height == 5 and WINDOW_TOTAL_LINES (w) == 6. Juanma Breakpoint 1, w32_abort () at w32fns.c:7344 7344 button = MessageBox (NULL, (gdb) bt #0 w32_abort () at w32fns.c:7344 #1 0x011b929c in grow_mini_window (w=0x2f9ec00, delta=-1) at window.c:4637 #2 0x0106d122 in resize_mini_window (w=0x2f9ec00, exact_p=0) at xdisp.c:8809 #3 0x01075952 in redisplay_internal (preserve_echo_area=0) at xdisp.c:11536 #4 0x01073682 in redisplay () at xdisp.c:11031 #5 0x0100c78b in read_char (commandflag=1, nmaps=3, maps=0x82e1e0, prev_event=48273409, used_mouse_menu=0x82e3c4, end_time=0x0) at keyboard.c:2707 #6 0x0101eb23 in read_key_sequence (keybuf=0x82e60c, bufsize=30, prompt=48273409, dont_downcase_last=0, can_return_switch_frame=1, fix_current_buffer=1) at keyboard.c:9464 #7 0x01007a9a in command_loop_1 () at keyboard.c:1640 #8 0x01039cb2 in internal_condition_case (bfun=0x1007276 , handlers=48337089, hfun=0x10069ec ) at eval.c:1513 #9 0x01006e85 in command_loop_2 () at keyboard.c:1357 #10 0x0103970b in internal_catch (tag=48447137, func=0x1006e65 , arg=48273409) at eval.c:1249 #11 0x01006dee in command_loop () at keyboard.c:1322 #12 0x01006143 in recursive_edit_1 () at keyboard.c:951 #13 0x0118feae in read_minibuf (map=52443485, initial=48273409, prompt=49230995, backup_n=0, expflag=0, histvar=54300225, histpos=0, defalt=48273409, allow_props=0, inherit_input_method=0) at minibuf.c:739 #14 0x01193225 in Fcompleting_read (prompt=49230995, collection=48635549, predicate=48273409, require_match=48273409, initial_input=48273409, hist=54300225, def=48273409, inherit_input_method=48273409) at minibuf.c:1823 #15 0x0103df96 in Ffuncall (nargs=7, args=0x82eab0) at eval.c:3076 #16 0x011df195 in Fbyte_code (bytestr=51766515, vector=49979972, maxdepth=56) at bytecode.c:678 #17 0x0103beb5 in Feval (form=48635773) at eval.c:2382 #18 0x0103970b in internal_catch (tag=49728209, func=0x103b477 , arg=48635773) at eval.c:1249 #19 0x011dfdba in Fbyte_code (bytestr=54186131, vector=52804612, maxdepth=176) at bytecode.c:853 #20 0x0103e7a9 in funcall_lambda (fun=50993028, nargs=6, arg_vector=0x82f1d4) at eval.c:3232 #21 0x0103e005 in Ffuncall (nargs=7, args=0x82f1d0) at eval.c:3091 #22 0x011df195 in Fbyte_code (bytestr=51674739, vector=50023940, maxdepth=64) at bytecode.c:678 #23 0x0103e7a9 in funcall_lambda (fun=50992164, nargs=1, arg_vector=0x82f4f4) at eval.c:3232 #24 0x0103e005 in Ffuncall (nargs=2, args=0x82f4f0) at eval.c:3091 #25 0x011df195 in Fbyte_code (bytestr=49722835, vector=54198164, maxdepth=16) at bytecode.c:678 #26 0x0103e7a9 in funcall_lambda (fun=50348772, nargs=0, arg_vector=0x82f834) at eval.c:3232 #27 0x0103e005 in Ffuncall (nargs=1, args=0x82f830) at eval.c:3091 #28 0x0103d017 in apply1 (fn=49253217, arg=48273409) at eval.c:2786 #29 0x011e2be5 in Fcall_interactively (function=49253217, record_flag=48273409, keys=48306948) at callint.c:395 #30 0x0103dbdc in Ffuncall (nargs=4, args=0x82faf8) at eval.c:3051 #31 0x0103d119 in call3 (fn=48471425, arg1=49253217, arg2=48273409, arg3=48273409) at eval.c:2871 #32 0x01023a41 in Fcommand_execute (cmd=49253217, record_flag=48273409, keys=48273409, special=48273409) at keyboard.c:10453 #33 0x0100a993 in command_loop_1 () at keyboard.c:1901 #34 0x01039cb2 in internal_condition_case (bfun=0x1007276 , handlers=48337089, hfun=0x10069ec ) at eval.c:1513 #35 0x01006e85 in command_loop_2 () at keyboard.c:1357 #36 0x0103970b in internal_catch (tag=48333209, func=0x1006e65 , arg=48273409) at eval.c:1249 #37 0x01006e3c in command_loop () at keyboard.c:1336 #38 0x01006143 in recursive_edit_1 () at keyboard.c:951 #39 0x01006618 in Frecursive_edit () at keyboard.c:1013 #40 0x01002a8d in main (argc=4, argv=0xa92840) at emacs.c:1827 Lisp Backtrace: "completing-read" (0x82eab4) "byte-code" (0x82ed40) "ido-read-internal" (0x82f1d4) "ido-file-internal" (0x82f4f4) "ido-find-file" (0x82f834) "call-interactively" (0x82fafc) (gdb) --001485f1ec84466674047435f47f Content-Type: application/zip; name="bugdata.zip" Content-Disposition: attachment; filename="bugdata.zip" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fzxhhwc40 UEsDBBQAAgAIAKQjNzsCUnnjVAAAAGwAAAAHAHwAdGVzdC5lbFNEZwC8AAAAAAgAG/a1GGNkYGkR YWBgMGCAAB8gZmQFM1lFgcSKRJbElIa0ffY74iTfMeOWY2RiYGBiKGBgAckKSDD8Z5RnAImB1CoA CQUQW0AEIs4IERcCq1WBiOGxE2TeSgYhFPMUgWwAVVQNAAfzh7lKk4y5SqJluUpdijsOgCAMQHcT 78CIQwcSL4RQtQkUpCQQT68yOr6PFqyXKih0I0RigkbsUxNVl3nSo5JPgGy3gLAH7BBtdSfx8Vui 7ZBLkoyuijLrF4dPHpV56QFQSwMECgAAAAAAKSE3OwAAAAAAAAAAAAAAAB4AfAB0ZXN0ZmlsZS1Y WDEteHh4eHh4eHh4eC0wMS5kYXRTRGcAvAAAAAAIABv2tRhjZGBpEWFgYDBggAAfIGZkBTNZRYHE ikSWxJSGtH32O+Ik3zHjlmNkYmBgYihgYAHJCkgw/GeUZwCJgdQqAAkFEFtABCLOCBEXAqtVgYjh sRNk3koGIRTzFIFsAFVUDQAHToO5Sk6DuUq5brlKUEsDBAoAAAAAAJcbNzsAAAAAAAAAAAAAAAAe AHwAdGVzdGZpbGUtWFgxLXh4eHh4eHh4eHgtMDIuZGF0U0RnALwAAAAACAAb9rUYY2RgaRFhYGAw YIAAHyBmZAUzWUWBxIpElsSUhrR99jviJN8x45ZjZGJgYGIoYGAByQpIMPxnlGcAiYHUKgAJBRBb QAQizggRFwKrVYGI4bETZN5KBiEU8xSBbABVVA0AB855uUrOeblKuW65SlBLAwQKAAAAAAAsGDc7 AAAAAAAAAAAAAAAAEwB8AHRlc3RmaWxlLVhYMi0wMS5kYXRTRGcAvAAAAAAIABv2tRhjZGBpEWFg YDBggAAfIGZkBTNZRYHEikSWxJSGtH32O+Ik3zHjlmNkYmBgYihgYAHJCkgw/GeUZwCJgdQqAAkF EFtABCLOCBEXAqtVgYjhsRNk3koGIRTzFIFsAFVUDQAHY3O5SvF0uUq5brlKUEsDBAoAAAAAAKka NzsAAAAAAAAAAAAAAAATAHwAdGVzdGZpbGUtWFgyLTAyLmRhdFNEZwC8AAAAAAgAG/a1GGNkYGkR YWBgMGCAAB8gZmQFM1lFgcSKRJbElIa0ffY74iTfMeOWY2RiYGBiKGBgAckKSDD8Z5RnAImB1CoA CQUQW0AEIs4IERcCq1WBiOGxE2TeSgYhFPMUgWwAVVQNAAcOeLlKDni5Sg54uUpQSwMECgAAAAAA LBg3OwAAAAAAAAAAAAAAAB4AfAB0ZXN0ZmlsZS1YWDMtWFhYWFhYWFhYWFgtMC5kYXRTRGcAvAAA AAAIABv2tRhjZGBpEWFgYDBggAAfIGZkBTNZRYHEikSWxJSGtH32O+Ik3zHjlmNkYmBgYihgYAHJ Ckgw/GeUZwCJgdQqAAkFEFtABCLOCBEXAqtVgYjhsRNk3koGIRTzFIFsAFVUDQAHY3O5SoJ0uUq5 brlKUEsDBAoAAAAAAEMhNzsAAAAAAAAAAAAAAAAeAHwAdGVzdGZpbGUtWFgzLVhYWFhYWFhYWFhY LTEuZGF0U0RnALwAAAAACAAb9rUYY2RgaRFhYGAwYIAAHyBmZAUzWUWBxIpElsSUhrR99jviJN8x 45ZjZGJgYGIoYGAByQpIMPxnlGcAiYHUKgAJBRBbQAQizggRFwKrVYGI4bETZN5KBiEU8xSBbABV VA0AB32DuUp9g7lKuW65SlBLAwQKAAAAAAAsGDc7AAAAAAAAAAAAAAAAHwB8AHRlc3RmaWxlLVhY My1YWFhYWFhYWFhYWC0xMC5kYXRTRGcAvAAAAAAIABv2tRhjZGBpEWFgYDBggAAfIGZkBTNZRYHE ikSWxJSGtH32O+Ik3zHjlmNkYmBgYihgYAHJCkgw/GeUZwCJgdQqAAkFEFtABCLOCBEXAqtVgYjh sRNk3koGIRTzFIFsAFVUDQAHY3O5SoJ0uUq5brlKUEsDBAoAAAAAACwYNzsAAAAAAAAAAAAAAAAf AHwAdGVzdGZpbGUtWFgzLVhYWFhYWFhYWFhYLTExLmRhdFNEZwC8AAAAAAgAG/a1GGNkYGkRYWBg MGCAAB8gZmQFM1lFgcSKRJbElIa0ffY74iTfMeOWY2RiYGBiKGBgAckKSDD8Z5RnAImB1CoACQUQ W0AEIs4IERcCq1WBiOGxE2TeSgYhFPMUgWwAVVQNAAdjc7lKgnS5SrluuUpQSwMECgAAAAAAWiI3 OwAAAAAAAAAAAAAAAB8AfAB0ZXN0ZmlsZS1YWDMtWFhYWFhYWFhYWFgtMTIuZGF0U0RnALwAAAAA CAAb9rUYY2RgaRFhYGAwYIAAHyBmZAUzWUWBxIpElsSUhrR99jviJN8x45ZjZGJgYGIoYGAByQpI MPxnlGcAiYHUKgAJBRBbQAQizggRFwKrVYGI4bETZN5KBiEU8xSBbABVVA0AB4yFuUqMhblKjIW5 SlBLAwQKAAAAAAAsGDc7AAAAAAAAAAAAAAAAHgB8AHRlc3RmaWxlLVhYMy1YWFhYWFhYWFhYWC0y LmRhdFNEZwC8AAAAAAgAG/a1GGNkYGkRYWBgMGCAAB8gZmQFM1lFgcSKRJbElIa0ffY74iTfMeOW Y2RiYGBiKGBgAckKSDD8Z5RnAImB1CoACQUQW0AEIs4IERcCq1WBiOGxE2TeSgYhFPMUgWwAVVQN AAdjc7lKgnS5SrluuUpQSwMECgAAAAAALBg3OwAAAAAAAAAAAAAAAB4AfAB0ZXN0ZmlsZS1YWDMt WFhYWFhYWFhYWFgtMy5kYXRTRGcAvAAAAAAIABv2tRhjZGBpEWFgYDBggAAfIGZkBTNZRYHEikSW xJSGtH32O+Ik3zHjlmNkYmBgYihgYAHJCkgw/GeUZwCJgdQqAAkFEFtABCLOCBEXAqtVgYjhsRNk 3koGIRTzFIFsAFVUDQAHY3O5SoJ0uUq5brlKUEsDBAoAAAAAACwYNzsAAAAAAAAAAAAAAAAeAHwA dGVzdGZpbGUtWFgzLVhYWFhYWFhYWFhYLTQuZGF0U0RnALwAAAAACAAb9rUYY2RgaRFhYGAwYIAA HyBmZAUzWUWBxIpElsSUhrR99jviJN8x45ZjZGJgYGIoYGAByQpIMPxnlGcAiYHUKgAJBRBbQAQi zggRFwKrVYGI4bETZN5KBiEU8xSBbABVVA0AB2NzuUqCdLlKuW65SlBLAwQKAAAAAAAsGDc7AAAA AAAAAAAAAAAAHgB8AHRlc3RmaWxlLVhYMy1YWFhYWFhYWFhYWC01LmRhdFNEZwC8AAAAAAgAG/a1 GGNkYGkRYWBgMGCAAB8gZmQFM1lFgcSKRJbElIa0ffY74iTfMeOWY2RiYGBiKGBgAckKSDD8Z5Rn AImB1CoACQUQW0AEIs4IERcCq1WBiOGxE2TeSgYhFPMUgWwAVVQNAAdjc7lKgnS5SrluuUpQSwME CgAAAAAALBg3OwAAAAAAAAAAAAAAAB4AfAB0ZXN0ZmlsZS1YWDMtWFhYWFhYWFhYWFgtNi5kYXRT RGcAvAAAAAAIABv2tRhjZGBpEWFgYDBggAAfIGZkBTNZRYHEikSWxJSGtH32O+Ik3zHjlmNkYmBg YihgYAHJCkgw/GeUZwCJgdQqAAkFEFtABCLOCBEXAqtVgYjhsRNk3koGIRTzFIFsAFVUDQAHY3O5 SoJ0uUq5brlKUEsDBAoAAAAAACwYNzsAAAAAAAAAAAAAAAAeAHwAdGVzdGZpbGUtWFgzLVhYWFhY WFhYWFhYLTcuZGF0U0RnALwAAAAACAAb9rUYY2RgaRFhYGAwYIAAHyBmZAUzWUWBxIpElsSUhrR9 9jviJN8x45ZjZGJgYGIoYGAByQpIMPxnlGcAiYHUKgAJBRBbQAQizggRFwKrVYGI4bETZN5KBiEU 8xSBbABVVA0AB2NzuUqCdLlKuW65SlBLAwQKAAAAAAAsGDc7AAAAAAAAAAAAAAAAHgB8AHRlc3Rm aWxlLVhYMy1YWFhYWFhYWFhYWC04LmRhdFNEZwC8AAAAAAgAG/a1GGNkYGkRYWBgMGCAAB8gZmQF M1lFgcSKRJbElIa0ffY74iTfMeOWY2RiYGBiKGBgAckKSDD8Z5RnAImB1CoACQUQW0AEIs4IERcC q1WBiOGxE2TeSgYhFPMUgWwAVVQNAAdjc7lKgnS5SrluuUpQSwMECgAAAAAALBg3OwAAAAAAAAAA AAAAAB4AfAB0ZXN0ZmlsZS1YWDMtWFhYWFhYWFhYWFgtOS5kYXRTRGcAvAAAAAAIABv2tRhjZGBp EWFgYDBggAAfIGZkBTNZRYHEikSWxJSGtH32O+Ik3zHjlmNkYmBgYihgYAHJCkgw/GeUZwCJgdQq AAkFEFtABCLOCBEXAqtVgYjhsRNk3koGIRTzFIFsAFVUDQAHY3O5SoJ0uUq5brlKUEsDBAoAAAAA ACwYNzsAAAAAAAAAAAAAAAATAHwAdGVzdGZpbGVfMzg3N18xLmRhdFNEZwC8AAAAAAgAG/a1GGNk YGkRYWBgMGCAAB8gZmQFM1lFgcSKRJbElIa0ffY74iTfMeOWY2RiYGBiKGBgAckKSDD8Z5RnAImB 1CoACQUQW0AEIs4IERcCq1WBiOGxE2TeSgYhFPMUgWwAVVQNAAdjc7lK2nO5SrpuuUpQSwMECgAA AAAALBg3OwAAAAAAAAAAAAAAABQAfAB0ZXN0ZmlsZV8zODc3XzEwLmRhdFNEZwC8AAAAAAgAG/a1 GGNkYGkRYWBgMGCAAB8gZmQFM1lFgcSKRJbElIa0ffY74iTfMeOWY2RiYGBiKGBgAckKSDD8Z5Rn AImB1CoACQUQW0AEIs4IERcCq1WBiOGxE2TeSgYhFPMUgWwAVVQNAAdjc7lK2nO5SrpuuUpQSwME CgAAAAAALBg3OwAAAAAAAAAAAAAAABQAfAB0ZXN0ZmlsZV8zODc3XzExLmRhdFNEZwC8AAAAAAgA G/a1GGNkYGkRYWBgMGCAAB8gZmQFM1lFgcSKRJbElIa0ffY74iTfMeOWY2RiYGBiKGBgAckKSDD8 Z5RnAImB1CoACQUQW0AEIs4IERcCq1WBiOGxE2TeSgYhFPMUgWwAVVQNAAdjc7lK2nO5SrpuuUpQ SwMECgAAAAAALBg3OwAAAAAAAAAAAAAAABQAfAB0ZXN0ZmlsZV8zODc3XzEyLmRhdFNEZwC8AAAA AAgAG/a1GGNkYGkRYWBgMGCAAB8gZmQFM1lFgcSKRJbElIa0ffY74iTfMeOWY2RiYGBiKGBgAckK SDD8Z5RnAImB1CoACQUQW0AEIs4IERcCq1WBiOGxE2TeSgYhFPMUgWwAVVQNAAdjc7lK2nO5Srpu uUpQSwMECgAAAAAALBg3OwAAAAAAAAAAAAAAABQAfAB0ZXN0ZmlsZV8zODc3XzEzLmRhdFNEZwC8 AAAAAAgAG/a1GGNkYGkRYWBgMGCAAB8gZmQFM1lFgcSKRJbElIa0ffY74iTfMeOWY2RiYGBiKGBg AckKSDD8Z5RnAImB1CoACQUQW0AEIs4IERcCq1WBiOGxE2TeSgYhFPMUgWwAVVQNAAdjc7lK2nO5 SrpuuUpQSwMECgAAAAAALBg3OwAAAAAAAAAAAAAAABQAfAB0ZXN0ZmlsZV8zODc3XzE0LmRhdFNE ZwC8AAAAAAgAG/a1GGNkYGkRYWBgMGCAAB8gZmQFM1lFgcSKRJbElIa0ffY74iTfMeOWY2RiYGBi KGBgAckKSDD8Z5RnAImB1CoACQUQW0AEIs4IERcCq1WBiOGxE2TeSgYhFPMUgWwAVVQNAAdjc7lK 2nO5SrpuuUpQSwMECgAAAAAALBg3OwAAAAAAAAAAAAAAABQAfAB0ZXN0ZmlsZV8zODc3XzE1LmRh dFNEZwC8AAAAAAgAG/a1GGNkYGkRYWBgMGCAAB8gZmQFM1lFgcSKRJbElIa0ffY74iTfMeOWY2Ri YGBiKGBgAckKSDD8Z5RnAImB1CoACQUQW0AEIs4IERcCq1WBiOGxE2TeSgYhFPMUgWwAVVQNAAdj c7lK2nO5SrpuuUpQSwMECgAAAAAALBg3OwAAAAAAAAAAAAAAABQAfAB0ZXN0ZmlsZV8zODc3XzE2 LmRhdFNEZwC8AAAAAAgAG/a1GGNkYGkRYWBgMGCAAB8gZmQFM1lFgcSKRJbElIa0ffY74iTfMeOW Y2RiYGBiKGBgAckKSDD8Z5RnAImB1CoACQUQW0AEIs4IERcCq1WBiOGxE2TeSgYhFPMUgWwAVVQN AAdjc7lK2nO5SrpuuUpQSwMECgAAAAAALBg3OwAAAAAAAAAAAAAAABQAfAB0ZXN0ZmlsZV8zODc3 XzE3LmRhdFNEZwC8AAAAAAgAG/a1GGNkYGkRYWBgMGCAAB8gZmQFM1lFgcSKRJbElIa0ffY74iTf MeOWY2RiYGBiKGBgAckKSDD8Z5RnAImB1CoACQUQW0AEIs4IERcCq1WBiOGxE2TeSgYhFPMUgWwA VVQNAAdjc7lK2nO5SrpuuUpQSwMECgAAAAAALBg3OwAAAAAAAAAAAAAAABQAfAB0ZXN0ZmlsZV8z ODc3XzE4LmRhdFNEZwC8AAAAAAgAG/a1GGNkYGkRYWBgMGCAAB8gZmQFM1lFgcSKRJbElIa0ffY7 4iTfMeOWY2RiYGBiKGBgAckKSDD8Z5RnAImB1CoACQUQW0AEIs4IERcCq1WBiOGxE2TeSgYhFPMU gWwAVVQNAAdjc7lK2nO5SrpuuUpQSwMECgAAAAAALBg3OwAAAAAAAAAAAAAAABQAfAB0ZXN0Zmls ZV8zODc3XzE5LmRhdFNEZwC8AAAAAAgAG/a1GGNkYGkRYWBgMGCAAB8gZmQFM1lFgcSKRJbElIa0 ffY74iTfMeOWY2RiYGBiKGBgAckKSDD8Z5RnAImB1CoACQUQW0AEIs4IERcCq1WBiOGxE2TeSgYh FPMUgWwAVVQNAAdjc7lK2nO5SrpuuUpQSwMECgAAAAAALBg3OwAAAAAAAAAAAAAAABMAfAB0ZXN0 ZmlsZV8zODc3XzIuZGF0U0RnALwAAAAACAAb9rUYY2RgaRFhYGAwYIAAHyBmZAUzWUWBxIpElsSU hrR99jviJN8x45ZjZGJgYGIoYGAByQpIMPxnlGcAiYHUKgAJBRBbQAQizggRFwKrVYGI4bETZN5K BiEU8xSBbABVVA0AB2NzuUrac7lKum65SlBLAwQKAAAAAAAsGDc7AAAAAAAAAAAAAAAAFAB8AHRl c3RmaWxlXzM4NzdfMjAuZGF0U0RnALwAAAAACAAb9rUYY2RgaRFhYGAwYIAAHyBmZAUzWUWBxIpE lsSUhrR99jviJN8x45ZjZGJgYGIoYGAByQpIMPxnlGcAiYHUKgAJBRBbQAQizggRFwKrVYGI4bET ZN5KBiEU8xSBbABVVA0AB2NzuUrac7lKum65SlBLAwQKAAAAAAAsGDc7AAAAAAAAAAAAAAAAEwB8 AHRlc3RmaWxlXzM4NzdfMy5kYXRTRGcAvAAAAAAIABv2tRhjZGBpEWFgYDBggAAfIGZkBTNZRYHE ikSWxJSGtH32O+Ik3zHjlmNkYmBgYihgYAHJCkgw/GeUZwCJgdQqAAkFEFtABCLOCBEXAqtVgYjh sRNk3koGIRTzFIFsAFVUDQAHY3O5StpzuUq6brlKUEsDBAoAAAAAACwYNzsAAAAAAAAAAAAAAAAT AHwAdGVzdGZpbGVfMzg3N180LmRhdFNEZwC8AAAAAAgAG/a1GGNkYGkRYWBgMGCAAB8gZmQFM1lF gcSKRJbElIa0ffY74iTfMeOWY2RiYGBiKGBgAckKSDD8Z5RnAImB1CoACQUQW0AEIs4IERcCq1WB iOGxE2TeSgYhFPMUgWwAVVQNAAdjc7lK2nO5SrpuuUpQSwMECgAAAAAALBg3OwAAAAAAAAAAAAAA ABMAfAB0ZXN0ZmlsZV8zODc3XzUuZGF0U0RnALwAAAAACAAb9rUYY2RgaRFhYGAwYIAAHyBmZAUz WUWBxIpElsSUhrR99jviJN8x45ZjZGJgYGIoYGAByQpIMPxnlGcAiYHUKgAJBRBbQAQizggRFwKr VYGI4bETZN5KBiEU8xSBbABVVA0AB2NzuUrac7lKum65SlBLAwQKAAAAAAAsGDc7AAAAAAAAAAAA AAAAEwB8AHRlc3RmaWxlXzM4NzdfNi5kYXRTRGcAvAAAAAAIABv2tRhjZGBpEWFgYDBggAAfIGZk BTNZRYHEikSWxJSGtH32O+Ik3zHjlmNkYmBgYihgYAHJCkgw/GeUZwCJgdQqAAkFEFtABCLOCBEX AqtVgYjhsRNk3koGIRTzFIFsAFVUDQAHY3O5StpzuUq6brlKUEsDBAoAAAAAACwYNzsAAAAAAAAA AAAAAAATAHwAdGVzdGZpbGVfMzg3N183LmRhdFNEZwC8AAAAAAgAG/a1GGNkYGkRYWBgMGCAAB8g ZmQFM1lFgcSKRJbElIa0ffY74iTfMeOWY2RiYGBiKGBgAckKSDD8Z5RnAImB1CoACQUQW0AEIs4I ERcCq1WBiOGxE2TeSgYhFPMUgWwAVVQNAAdjc7lK2nO5SrpuuUpQSwMECgAAAAAALBg3OwAAAAAA AAAAAAAAABMAfAB0ZXN0ZmlsZV8zODc3XzguZGF0U0RnALwAAAAACAAb9rUYY2RgaRFhYGAwYIAA HyBmZAUzWUWBxIpElsSUhrR99jviJN8x45ZjZGJgYGIoYGAByQpIMPxnlGcAiYHUKgAJBRBbQAQi zggRFwKrVYGI4bETZN5KBiEU8xSBbABVVA0AB2NzuUrac7lKum65SlBLAwQKAAAAAAAsGDc7AAAA AAAAAAAAAAAAEwB8AHRlc3RmaWxlXzM4NzdfOS5kYXRTRGcAvAAAAAAIABv2tRhjZGBpEWFgYDBg gAAfIGZkBTNZRYHEikSWxJSGtH32O+Ik3zHjlmNkYmBgYihgYAHJCkgw/GeUZwCJgdQqAAkFEFtA BCLOCBEXAqtVgYjhsRNk3koGIRTzFIFsAFVUDQAHY3O5StpzuUq6brlKUEsBAhcLFAACAAgApCM3 OwJSeeNUAAAAbAAAAAcAEQAAAAAAAQAgALaBAAAAAHRlc3QuZWxTRAQAvAAAAFVUBQAH84e5SlBL AQIXCwoAAAAAACkhNzsAAAAAAAAAAAAAAAAeABEAAAAAAAAAIAC2gfUAAAB0ZXN0ZmlsZS1YWDEt eHh4eHh4eHh4eC0wMS5kYXRTRAQAvAAAAFVUBQAHToO5SlBLAQIXCwoAAAAAAJcbNzsAAAAAAAAA AAAAAAAeABEAAAAAAAAAIAC2ga0BAAB0ZXN0ZmlsZS1YWDEteHh4eHh4eHh4eC0wMi5kYXRTRAQA vAAAAFVUBQAHznm5SlBLAQIXCwoAAAAAACwYNzsAAAAAAAAAAAAAAAATABEAAAAAAAAAIAC2gWUC AAB0ZXN0ZmlsZS1YWDItMDEuZGF0U0QEALwAAABVVAUAB2NzuUpQSwECFwsKAAAAAACpGjc7AAAA AAAAAAAAAAAAEwARAAAAAAAAACAAtoESAwAAdGVzdGZpbGUtWFgyLTAyLmRhdFNEBAC8AAAAVVQF AAcOeLlKUEsBAhcLCgAAAAAALBg3OwAAAAAAAAAAAAAAAB4AEQAAAAAAAAAgALaBvwMAAHRlc3Rm aWxlLVhYMy1YWFhYWFhYWFhYWC0wLmRhdFNEBAC8AAAAVVQFAAdjc7lKUEsBAhcLCgAAAAAAQyE3 OwAAAAAAAAAAAAAAAB4AEQAAAAAAAAAgALaBdwQAAHRlc3RmaWxlLVhYMy1YWFhYWFhYWFhYWC0x LmRhdFNEBAC8AAAAVVQFAAd9g7lKUEsBAhcLCgAAAAAALBg3OwAAAAAAAAAAAAAAAB8AEQAAAAAA AAAgALaBLwUAAHRlc3RmaWxlLVhYMy1YWFhYWFhYWFhYWC0xMC5kYXRTRAQAvAAAAFVUBQAHY3O5 SlBLAQIXCwoAAAAAACwYNzsAAAAAAAAAAAAAAAAfABEAAAAAAAAAIAC2gegFAAB0ZXN0ZmlsZS1Y WDMtWFhYWFhYWFhYWFgtMTEuZGF0U0QEALwAAABVVAUAB2NzuUpQSwECFwsKAAAAAABaIjc7AAAA AAAAAAAAAAAAHwARAAAAAAAAACAAtoGhBgAAdGVzdGZpbGUtWFgzLVhYWFhYWFhYWFhYLTEyLmRh dFNEBAC8AAAAVVQFAAeMhblKUEsBAhcLCgAAAAAALBg3OwAAAAAAAAAAAAAAAB4AEQAAAAAAAAAg ALaBWgcAAHRlc3RmaWxlLVhYMy1YWFhYWFhYWFhYWC0yLmRhdFNEBAC8AAAAVVQFAAdjc7lKUEsB AhcLCgAAAAAALBg3OwAAAAAAAAAAAAAAAB4AEQAAAAAAAAAgALaBEggAAHRlc3RmaWxlLVhYMy1Y WFhYWFhYWFhYWC0zLmRhdFNEBAC8AAAAVVQFAAdjc7lKUEsBAhcLCgAAAAAALBg3OwAAAAAAAAAA AAAAAB4AEQAAAAAAAAAgALaByggAAHRlc3RmaWxlLVhYMy1YWFhYWFhYWFhYWC00LmRhdFNEBAC8 AAAAVVQFAAdjc7lKUEsBAhcLCgAAAAAALBg3OwAAAAAAAAAAAAAAAB4AEQAAAAAAAAAgALaBggkA AHRlc3RmaWxlLVhYMy1YWFhYWFhYWFhYWC01LmRhdFNEBAC8AAAAVVQFAAdjc7lKUEsBAhcLCgAA AAAALBg3OwAAAAAAAAAAAAAAAB4AEQAAAAAAAAAgALaBOgoAAHRlc3RmaWxlLVhYMy1YWFhYWFhY WFhYWC02LmRhdFNEBAC8AAAAVVQFAAdjc7lKUEsBAhcLCgAAAAAALBg3OwAAAAAAAAAAAAAAAB4A EQAAAAAAAAAgALaB8goAAHRlc3RmaWxlLVhYMy1YWFhYWFhYWFhYWC03LmRhdFNEBAC8AAAAVVQF AAdjc7lKUEsBAhcLCgAAAAAALBg3OwAAAAAAAAAAAAAAAB4AEQAAAAAAAAAgALaBqgsAAHRlc3Rm aWxlLVhYMy1YWFhYWFhYWFhYWC04LmRhdFNEBAC8AAAAVVQFAAdjc7lKUEsBAhcLCgAAAAAALBg3 OwAAAAAAAAAAAAAAAB4AEQAAAAAAAAAgALaBYgwAAHRlc3RmaWxlLVhYMy1YWFhYWFhYWFhYWC05 LmRhdFNEBAC8AAAAVVQFAAdjc7lKUEsBAhcLCgAAAAAALBg3OwAAAAAAAAAAAAAAABMAEQAAAAAA AAAgALaBGg0AAHRlc3RmaWxlXzM4NzdfMS5kYXRTRAQAvAAAAFVUBQAHY3O5SlBLAQIXCwoAAAAA ACwYNzsAAAAAAAAAAAAAAAAUABEAAAAAAAAAIAC2gccNAAB0ZXN0ZmlsZV8zODc3XzEwLmRhdFNE BAC8AAAAVVQFAAdjc7lKUEsBAhcLCgAAAAAALBg3OwAAAAAAAAAAAAAAABQAEQAAAAAAAAAgALaB dQ4AAHRlc3RmaWxlXzM4NzdfMTEuZGF0U0QEALwAAABVVAUAB2NzuUpQSwECFwsKAAAAAAAsGDc7 AAAAAAAAAAAAAAAAFAARAAAAAAAAACAAtoEjDwAAdGVzdGZpbGVfMzg3N18xMi5kYXRTRAQAvAAA AFVUBQAHY3O5SlBLAQIXCwoAAAAAACwYNzsAAAAAAAAAAAAAAAAUABEAAAAAAAAAIAC2gdEPAAB0 ZXN0ZmlsZV8zODc3XzEzLmRhdFNEBAC8AAAAVVQFAAdjc7lKUEsBAhcLCgAAAAAALBg3OwAAAAAA AAAAAAAAABQAEQAAAAAAAAAgALaBfxAAAHRlc3RmaWxlXzM4NzdfMTQuZGF0U0QEALwAAABVVAUA B2NzuUpQSwECFwsKAAAAAAAsGDc7AAAAAAAAAAAAAAAAFAARAAAAAAAAACAAtoEtEQAAdGVzdGZp bGVfMzg3N18xNS5kYXRTRAQAvAAAAFVUBQAHY3O5SlBLAQIXCwoAAAAAACwYNzsAAAAAAAAAAAAA AAAUABEAAAAAAAAAIAC2gdsRAAB0ZXN0ZmlsZV8zODc3XzE2LmRhdFNEBAC8AAAAVVQFAAdjc7lK UEsBAhcLCgAAAAAALBg3OwAAAAAAAAAAAAAAABQAEQAAAAAAAAAgALaBiRIAAHRlc3RmaWxlXzM4 NzdfMTcuZGF0U0QEALwAAABVVAUAB2NzuUpQSwECFwsKAAAAAAAsGDc7AAAAAAAAAAAAAAAAFAAR AAAAAAAAACAAtoE3EwAAdGVzdGZpbGVfMzg3N18xOC5kYXRTRAQAvAAAAFVUBQAHY3O5SlBLAQIX CwoAAAAAACwYNzsAAAAAAAAAAAAAAAAUABEAAAAAAAAAIAC2geUTAAB0ZXN0ZmlsZV8zODc3XzE5 LmRhdFNEBAC8AAAAVVQFAAdjc7lKUEsBAhcLCgAAAAAALBg3OwAAAAAAAAAAAAAAABMAEQAAAAAA AAAgALaBkxQAAHRlc3RmaWxlXzM4NzdfMi5kYXRTRAQAvAAAAFVUBQAHY3O5SlBLAQIXCwoAAAAA ACwYNzsAAAAAAAAAAAAAAAAUABEAAAAAAAAAIAC2gUAVAAB0ZXN0ZmlsZV8zODc3XzIwLmRhdFNE BAC8AAAAVVQFAAdjc7lKUEsBAhcLCgAAAAAALBg3OwAAAAAAAAAAAAAAABMAEQAAAAAAAAAgALaB 7hUAAHRlc3RmaWxlXzM4NzdfMy5kYXRTRAQAvAAAAFVUBQAHY3O5SlBLAQIXCwoAAAAAACwYNzsA AAAAAAAAAAAAAAATABEAAAAAAAAAIAC2gZsWAAB0ZXN0ZmlsZV8zODc3XzQuZGF0U0QEALwAAABV VAUAB2NzuUpQSwECFwsKAAAAAAAsGDc7AAAAAAAAAAAAAAAAEwARAAAAAAAAACAAtoFIFwAAdGVz dGZpbGVfMzg3N181LmRhdFNEBAC8AAAAVVQFAAdjc7lKUEsBAhcLCgAAAAAALBg3OwAAAAAAAAAA AAAAABMAEQAAAAAAAAAgALaB9RcAAHRlc3RmaWxlXzM4NzdfNi5kYXRTRAQAvAAAAFVUBQAHY3O5 SlBLAQIXCwoAAAAAACwYNzsAAAAAAAAAAAAAAAATABEAAAAAAAAAIAC2gaIYAAB0ZXN0ZmlsZV8z ODc3XzcuZGF0U0QEALwAAABVVAUAB2NzuUpQSwECFwsKAAAAAAAsGDc7AAAAAAAAAAAAAAAAEwAR AAAAAAAAACAAtoFPGQAAdGVzdGZpbGVfMzg3N184LmRhdFNEBAC8AAAAVVQFAAdjc7lKUEsBAhcL CgAAAAAALBg3OwAAAAAAAAAAAAAAABMAEQAAAAAAAAAgALaB/BkAAHRlc3RmaWxlXzM4NzdfOS5k YXRTRAQAvAAAAFVUBQAHY3O5SlBLBQYAAAAAJgAmANMMAACpGgAAAAA= --001485f1ec84466674047435f47f-- From rudalics@gmx.at Wed Sep 23 00:28:27 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 23 Sep 2009 07:28:27 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.8 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER, IMPRONONCABLE_2 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with SMTP id n8N7SONG010470 for <4534@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 00:28:26 -0700 Received: (qmail invoked by alias); 23 Sep 2009 07:28:18 -0000 Received: from 62-47-54-210.adsl.highway.telekom.at (EHLO [62.47.54.210]) [62.47.54.210] by mail.gmx.net (mp063) with SMTP; 23 Sep 2009 09:28:18 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+Csi0dmRKCjtgSITnK3sNMuCZ8iZnxwnxhcDz/LK oU7PGp5LkYTHOn Message-ID: <4AB9CE11.9040300@gmx.at> Date: Wed, 23 Sep 2009 09:28:17 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Juanma Barranquero , 4534@debbugs.gnu.org Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.53 > I put the attached files into directory C:\temp, including the file test.el: > > (setq resize-mini-windows t) > (setq ido-enable-flex-matching t) > (setq ido-max-prospects 14) > (ido-mode 1) > > Then, > > emacs -Q -l c:/temp/test.el > C-x C-f c:/temp/testfile 3 7 > > Emacs aborts. (Note: As the failure depends on the number of lines in > the minibuffer, tweaking `ido-max-prospects' and/or adding more files > to the directory may be necessary to reproduce the bug.) > > The xassert (delta >= 0) at the start of window.c:grow_mini_window > fails, because delta == -1. In resize_mini_window, the call to > xdisp.c:grow_mini_window has height == 5 and WINDOW_TOTAL_LINES (w) == > 6. > > Juanma > > > > Breakpoint 1, w32_abort () at w32fns.c:7344 > 7344 button = MessageBox (NULL, > (gdb) bt > #0 w32_abort () at w32fns.c:7344 > #1 0x011b929c in grow_mini_window (w=0x2f9ec00, delta=-1) at window.c:4637 > #2 0x0106d122 in resize_mini_window (w=0x2f9ec00, exact_p=0) at xdisp.c:8809 ... The following part in `resize_mini_window' doesn't strike me as very elegant in this respect: if (height) { freeze_window_starts (f, 1); grow_mini_window (w, height - WINDOW_TOTAL_LINES (w)); } Does it cause the bug? Just comment it out to check. martin From lekktu@gmail.com Wed Sep 23 02:50:57 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 23 Sep 2009 09:50:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.3 required=4.0 tests=AWL,CT_IMAGE,HAS_BUG_NUMBER, MOSTLY_PNG_IMAGE,ONE_PNG autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-bw0-f223.google.com (mail-bw0-f223.google.com [209.85.218.223]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8N9otGB031371 for <4534@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 02:50:57 -0700 Received: by bwz23 with SMTP id 23so447176bwz.1 for <4534@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 02:50:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=FtsadhXMAobtioW5yaFzTBrS5e4QZxKXTsqRMjX3PpM=; b=m18cxp8wCu/heD2MCiOoVdkTRUMPNlWGSa94qVqtUC6/Y5kbKwmGnVpypmonUwutsr ct54IJqboAi8os1MV1uifDcmP9lWf7t1by/dEUqZRlu8ZMn7JYwCMQWHrsyPXBb5TuVz ekFae+PrYk4zeGXhPfBfaFQ6PH4pdANiis4/w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=UsiXkdVoQDqvrToixM4GVsHhaj5Qo+1P6DROyyYe9+Q2lc/heIoaNdZuLd2zMBoR4/ dkfDmDG/4zwl5YVD80Eg3OvIVjEgLZkMqZz5+QfHSMFE4L8GBvMUp9+IJtRjaYQSWWwe 9I8Y4Lqz1yneMq02SsGsbKtwsyxA5OSP8zsRQ= MIME-Version: 1.0 Received: by 10.239.168.153 with SMTP id k25mr153442hbe.68.1253699449085; Wed, 23 Sep 2009 02:50:49 -0700 (PDT) In-Reply-To: <4AB9CE11.9040300@gmx.at> References: <4AB9CE11.9040300@gmx.at> From: Juanma Barranquero Date: Wed, 23 Sep 2009 11:50:29 +0200 Message-ID: Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window To: martin rudalics Cc: 4534@debbugs.gnu.org Content-Type: multipart/mixed; boundary=001636498e6d5160a104743ba61c --001636498e6d5160a104743ba61c Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, Sep 23, 2009 at 09:28, martin rudalics wrote: > The following part in `resize_mini_window' doesn't strike me as very > elegant in this respect: > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (height) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{ > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0freeze_wind= ow_starts (f, 1); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0grow_mini_w= indow (w, height - WINDOW_TOTAL_LINES (w)); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} > > Does it cause the bug? =C2=A0Just comment it out to check. Well, yes, commenting that code out avoids the failure (which happens in that call to grow_mini_window). But the point is, the miniwindow is not shrunk as it should. See attached image. Juanma --001636498e6d5160a104743ba61c Content-Type: image/png; name="bug-4534.png" Content-Disposition: attachment; filename="bug-4534.png" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fzxw70b30 iVBORw0KGgoAAAANSUhEUgAAAq4AAAB3CAIAAABNM1WfAAAAAXNSR0IArs4c6QAAAARnQU1BAACx jwv8YQUAAAAgY0hSTQAAeiYAAICEAAD6AAAAgOgAAHUwAADqYAAAOpgAABdwnLpRPAAAJu5JREFU eF7tXc9vHEd2HmMXiBPAQLJGfMhmnVuAAMkphwAEvEBO2RwWARbRH7CXOfiso+3DGgv44ANh6JQg kIwVsAtjLYlWOLIk25H1y5RoUpRIypQoWqvVSgIcmxuRkihyhlKqu/rHqx+vu6qmOd0z8w3a8rCn uurVV69effWqut4Lr7y+vvG/f/zmv/6yZfu89NJL1vu4CQSAABAAAkAACOwdApubm+6Z97qbf/GD v7r1h+1bd7df+N4LL7RekM8+bz3vPv+e/PL8WXT93d98/2//+k+Pfv7Vz975YevJt63b56J/BRV4 cd/aBvN5jg8QAAJAAAgAASAwcAS4cdl6f/27e+eWHjjKeOT8PZG+9ZOHrddutV59v/XyuyNNBVYn J+ycqt1xBCwsWV3lhkmLp4BAvQjU1V/qKrdetFH68CDgSwW+e7j5wZk7B6ZuvPPrlbcPL755aOmt g9feOLgoLvFdXr84fP3AsbVvN7bsVOB/8AECQAAIAAEgAATGBgGLV0DU/R4+QAAIAAEgAASAwBgg IAZ9UIExaGdUEQgAASAABIAAg0CFVODo/n/cfxRAAwEgAASAABAAAkOFQCAVEMO++Ox77zKt7OX3 9ml3kl9lavHRqAJ3v1IEhVRqudEN5WMKnQgWzmzyMvYfrZwi0cwdoTJAyJ6LqmpvNcesy5LxRZc9 Wfi70YqmPvaV/71MOS2Km/y4p7iFSa91wbwSQtb39oUrtE2arAkqwUGIWkk+uqSF7SgSV1BubPjC 2gtPAYGGIBBCBRLjfnS/0XXto16WULNF3P1qoeGGoshEFJjGkp+LZIyNT4pN/Ee1JliW7SWgV+LB 4N9nKRnvzHSOI6L9FGTR8Xv3eP3vp6gqnlX7H210OWzvhR6yEwBbhapmI66gWdvR9WGSjpO/crof IBseAQL9IBBCBZLybN3Lbhdq8goo8wFj0mgbHdMnxDiu/EymoGUzlzgpTUSpiJFPcmP/fjk3l39m XyLbnT2im/Ei+RWXjQ5DNiDw3gVbfVNH0FHpVFFwUKfoqaTF+PejtfRZqxUmjp9EmgTZ91IHldsU tGgIqWp4qQqIe/cU/1ehE8DAR9LXfYmzj7RxKW6WLk8bPpsuG26cTKELvAtmO8ZELBI1de050RuW 0sXuQbNP5+WKgmQVePmTX+EYqE6TkdPgEaiYCsSTVaZzciNPgL/bFaeiIdwYSomrPB2h460Pyry+ dJIfPVqwTKIMk/EfaY5p8Zlc8Y19++UijMEwDK9AnCKHntSm2IVgxSHLiNY3rpoUSKkl/UOtvgeF cm1SI52pcEoLiJ9TG61MjClD48seKiqg+wQ41srgkypCqjnZGF+Mm0EFFDGkPmQAF3gFTErBtSPV PgsRsbVmQTuaOdA7EgwH+WM9U9ZLgzUaDwKBGhAooALGbFIb45nuZe3S1q0CGfVWuUNZuT4oFdAM bQjUh3BlRKYC2mbjRCSWCujPUcsb5a//Hd8g1oUVUBZuTFoMzwDD0Di50jrlv1OyoTxFW0wtZQ9p HpFPKVMUqetTgqK2acRIaFGsYaICGrnhRGfxiR5INCkGkFIBiqiWgd7fze5L7IYHFeDbMZIsE8jN N+NFBRJ6btvfVCC/viVJ3WxCtkpx9g33ZaMCh7pwaIe+TMh2L3OepoxV2pCUjRZOnj4fHpCt6lrX 1feQCljnB0FUgGDiQgVYCAv4ix8VoFsguE2gOX9JR6cS+uTXqFpqXduKqIC+qlGqclTH9YzdBqG+ 6ub1sEYF4iHakkEIFSjCzUIFeFibQAVKqIypXk5eAXV1xqvhkBgINACByhcIEl5n2VGY9Kh08pFU PvtTu7/n2OjDE53zJnNsws5Mxz4vYExrMwCyITy+bV8gYL0C6gMKqFb58wmYKURSdAmlKFgQoU/S 0hXf6F6O+lbITeKp7h/M9Uru4sgycdnCNkxUwFibU9qF0GEGnyKvQAFuVi8gRwbyog09seVDFZ7Y h/68AqVUQMFHVS9efhXsPbdeKAAIVIxACBXQPTjm5MM2I+Fm/3vpFbCClTutExegMmrLe/veS/aX yd/oI6UzScUFor6JZuST3UgLzP+fbFzMwM6kNB1ozE8Gc9Drq/ji9K2O6fuWCnmR2CS7ylK+owo0 uBVTtSE1B0r+umj2g7Dj+/fnL5KWCGpxdCdEq1z/K+6krtkZPupoqpp9coAswKV1En1Z/ppuWBUo MbhxjlzTx0uaJn+IuPhzGdWFRGsDU3uRS82v0rPtyMqvvmzMrV4aK2HYNuiqp0jXRARCqIBLPeyL BC5PIk3mL9mbt7/GFuC9eNuwWWDuTa8bfdz6bsW9Ab5vsZABEHBGYK+ogLMASGhDQJkPOfkhgGMx AuT1sFE+DabyYXtMcOur+3DbMvrKFA8DgYEiACowULhRGBAAAkAACACBpiHAUoGxCcyIigIBIAAE gAAQGHcELC8TbjCf5/gAgSFEoMV8hrAqEBkIAIExRYAbl63317+7t7u7446USA8q4A4XUg4lAqAC Q9lsEBoIAAGCgC8VEI/eX+8t3O5dXtk+f23rzMLWp/Nbp+cefzz75MTlx9MzW8e/eHz0wqNb97dF ytu/vwMqAHUbcQRABUa8gVE9IDAGCARQAcED7nzz7Ob9Z0t3eld/t7uw1ptf3b18Y3dmpXvheu/s Yu+T+Z2TlzYFeFe+WgMVGLQSrU4uT0xuDbrU58/rKnfwNdVKBBWovQkgABAAAn0iEEAFhD9A8ICV u72rX+9KEnBppXdhuXdhMeIBny30PpnbOfXlIyHYp7M3/ajA5MRcq6Ve7fWshp32nP8gt94WGU48 cIFJ5J+V3u7kT5jlimFPpvSXx0WQftKI+n5NZO8nK69nayi3085HYbW9WhOTq1T61ckJmVS7X1DD 7BHxTJYszSYpV+aWCxH/nT0on4r+pMJ5gUoSF+RDcSBlRbc5HPoQKQcmrlZW+MREgrHMO7svK8+1 lQmHb/5cucN+v0BplAb3U+vk0XKNDNBb8Yh7/wrtBx7P7al94OSw2g2lAxDsrfZEJObuF1ReVtYf //i52MRJKkAnNgXkQKz9i0fOL21Jf8Dcak+QAHHNLHcFAzg9vysv4RX45MvIKzB1dtmPCsQokJFs 9cEEoQIeWqAkXW+7UAFRlksyxTrXM/8uHMB0kRQ8QxEsfc50CUxOlJub0mxjfWDyiQ2PSw5ZGndT JUfRbCzPOhgVJsst6zwiGbU+8vHoThVIsPn4F+D/hA5zbO9krchX5Q/lPi3RwlCMVvTNf1TTM+pN 4VRwduoObs3vlkop0L1/FfVrpzrkiWqxD5yMnN2gvEqkyeyB1Z5o4LigmuTfaftTgdhEMVRAWDaO DUgq8NnC02hRYC1eFLjeFddPf/5LwQBOzfVOznXFv+KSVOA3p5dSKnCo9fK7rVdeX39x31rxGwRy 6NKGFvssXAze0Yx/Ofo3ulQOkXoX2p1yKkD9AVFWKSconv1bXOKdr3Ovhk4sYv+E85Q9F2niweTE MpnlFuSjTs0lPuTKhySLnNJ9shwLuTzZkc9G5caumuXJyaxqVBjZKbRyNVKrzVTToVMdyPNnxHRO /pQT7OSRTH59WkSG7YLZv6VT0YwYYsF1xawb81TAmL2RBiAeDdp/1Ton6bl8DIBSpLWZtWa5bFZe BUJxqVjtXlRCJLd4TjE/3P08ExcqINveJ/9RTV82MLoygbR9E7pqU6y8HQv0tkgel0GruF8rzqMh sQ8cIhQN8T3r+qX2RMvQY07lTgWI5Wh3FCpAR2dp2bg3CIScYp+g8AfM3UxcAoIHyEvwgBMxGxCX pAKHP14MoALJ6GX63i1DbzTaJSMT+VWMTNlw5bxAwHsFuFVw474yIkY0QmEDHlQg4gGpOySmI05U wCqnzSvAyRlJGKlsRBSiErMMYzaQMq0Ic2UNginXnAtTQpwYe6n3tHtQZl00e+C9AlxnM+6z8sRC 5dbT0ttJ5/b2Cmjmm4yN6YCWGkwyygZ4BbhH9Pu8PIUDUcQCItam84aC+xIqRydJQP6+8gxF+pLR 1wFPTcOsTUBVL9V+x4ZKBXSlAnF62wg3XPaBaxer3SDsyjrloGSBZszdtxbuSgUof48FU70C2kpB ARUQLwuIRYHLK7viyniA/NKZT9jAqdlor8Ch6RAqYPEKpAOG4ZCnKwidrxP2kH1JHnPz/PdPBehU 23RUlPF78nu5G8OWmX213kIFWDnTclNUKRWgZkHcJ39y5RqGxJhsECtGf1MeDHAAulKBInlygPV5 b8pdMinz8W11kq60ySzM8dicy+eLfCwM/EIDyxHYR7QneHlYr0NK39ptcyNEhL7tfoJonGfCHyrN nyt3iO8X4pPSxVJmVTTIqyVQWserFWvI+qUCw2kfChgB9bMQr0DbYM/RXMjKu7yYQOzpL3fo6cnS OZW5V6DUKyBeGszWBSQD+HwxWiPI2EBHOAZmI69AOBWw4mv3CmSbCZpABSrY2SCqHkIFONeFnQrY 5SygAsqiAKUCfLk2KuAyz4jH3kwB9pYKuMiTrqVRnaRS+XoFtEm4RdUzmzgQr0C5PBYRo4ci8NL/ k5mh9T7JQh+amL7ul7+vPMOSvnAC4dZyLBWgrCxbkUkLrIcKuPTHxtkHngykdkwZo20DNmflPFYH 4mlH5VSgeK/Af888Ee8LZGO/+H52ufcpYQPTczvT8cuEB6evBSwQsBvgXamAunQdOdtd9gP27xWI vF6xg93+8VsgIOsjqd8+ydaaD7uBP99nEDkDEmwZOYu8AhRDQi8Kyk3VkhgVbje9svVYcRMKSC35 pLNS+7ZBV69AvFPX2l70vsUmqly9mAqQsTK1yXIqpm58kJVUPBBqwZZ8OLdDmTW3LhBY5SmY8WRb BIj3OfZD0OaS39WxyIUJlOcp3S1mWaN1v5AIqDs286TKCG/4DojyUT1I/MT5nJLVN14mT6/AENsH DgPObigGwxywq/EJcFRATiyonVMsrOxHokYBbxBMffFEvDQojhAQbED8e255V1CBU0u9j65EvgHx 79TszvGZxyFUgLxMaK6O0x1w8ZCWbYsTc9zU6Z2tEeTb5dpfl75PqL/EmEya5aBrlBtRDev9eEJv SS81x4MKiNRUJHW4suRT9E5/vhxAOZYpZ3pH0CYJbHtd7poUkAo+0W4n70/SVygLy802xmlaSJ3o yU/qPkO1urnbML/P7Es0PYzyEe6++ZNtY6Kxtqf13GIqoJTO7cyiVjGHR6P4pBbJL0a97Plnd00c mJ+KJhd5Jsm2Ptqe8Xf1frz5hGySLFvb9s1fxcviZNbkGZb05RNkZuJuUIGEjaUbaidlY2itNJn0 qbxYU9+KmYmy46ckqdLzhtE+FJHkRMMUu0H1Um/Z/pmArvWWojmjKrpjW24XsC4QFHsFPjz3RLw6 KNjAucWIBIjr8+WuoAInFnvHr/aOznePXN6Zmgn1CpTrEFLoCNBtknuCjvoKQ1bEnpe7J5WpOlNt 7M6WX6suB/kBgUYj4OUVaHRNxlK4gCOGfnv2sXhdULCBz691P7vaE5dYHRA8oHO1K1wCR7/sfnhp e+oCqMCo6FPun3BZZxmVWrvXw5gVJzfcc0BKIDACCIAKDHUjBlCBD85snpjdPjnfjY4Smt85Pb99 8kpXbBX8aK57bHZb8IAjM1vHLmwIWEK2DQ41mhB+DBEAFRjDRkeVgcCIIRBABVbvPj1x8eHHlzZE oAF5ie9ic4C4Ppp5NHVx89j5jRt3nwigjpy57r1tcMTwRXVGHgFQgZFvYlQQCCQIZOt/ercv39vR F4Z7X64vFTi35HScf8QDzt8jQYqdTxvsCy88DASAABAAAkAACHgi4EsFvnu4+cGZOwembrzz65W3 Dy++eWjprYPX3ji4KC7xXV6/OHz9wLG1bze2QAU8WwPJgQAQAAJAAAgMHAFfKrD58NtH4tpcf/zo j08e/9/W1ub200fb21vd7tNud1tcu7s7z5515QUqMPD2RIFAAAgAASAABDwR8KUCYqR3LwFUwB0r pAQCQAAIAAEgUA8CvlRASHl/vbdwW8Qg2D5/bevMQnSJAEWn5x6LS4QnOP7F46MXHt26vy1SPnhw l902SHddSCEqB6BpL7dwx0woZ8zFKGR7RJwOkiwELt9uoh6VYzu5h42TXWH87Fwev302yXFolSuJ RLt/nCsUDHoiwJQg+LcL9MSIFjnS9iQzTZ6qAj3R9STgtEHBA+588+zm/WdLd3pXf7crrihm8equ uETYYnH0kHjDULxWILrzxau37FRA233pQgX8TmNOB1R3/QjI32r9A87M50aR/oeo7FBJbcAjp4pG CpENynsePztmPbK+yumXTgNpEkyzOG1AO3rhHJA/9KRAwyPlM45iTfTT8Ux1PXfoiR1vLz23ZtE0 e0ImUczRi0XGAnqioBNw2mASjmilK4ISXby+K67o7OHF6PzBU1d7IjhhFo7IHoOAi3eUjA8pTchH ceM9Csf5pKvqF+RPJ2iInx1rjsdYaJhy5QZ33ibVT9I0WVxt6Ilm3yx6zuttKemiudEm4npTBZFU uCHfnQpAT9LJT3q8sCVC3cjqSVr38nEBesLriblAwI3UIqVY+xc5yXBEMjihiEEQXfHxw1EkAnH2 8JVeSTiizCWQ0RDiFeh00nA+WqgYjxEotXauVIAd4ZSJa6RFKRugOVOmXDRSxs9YDTEnp3GflafQ vqfDAncm9gDjZ+tUgAEkrQ5dOdEcetCTvM1HT0+SurlSAeiJYgDGx56QartM8aEnRXqiDcfaMK0R BUkFxIaASytir8DuzEr34vKuuEQwAhGnWFynFnon5non57qnZh+JlEVeAfteAXWCTlleDVTAEtrE Fq5GDW4XsEDg2nWL5Cmd7OlR77KarE4OLn62HxXQRgLKpaAnpMF1/Rl+PfGjAtATtfePjz1J6h1b g3KXAPSkUE+sCwRimLZuJ6yGCoismb0Cyv45zX9cDxUo168ksmwG8t5SARd5WFaQE+e64mfrbo3i 6rBdF3pSOAv034Whqkz9elIRFYCejL6exDTAbUsY7Ik/FSiOTNivV4DbqajsJDOIHhu3np8Pey4Q IH42WVmxDtIuq/u0OWyRuTMXhDFgyclseVxt6Imm8qaea4trpS6jRsZZ7zf+OvRk5PVEW5zVGS3s iUDEeWE64A2CCqgA9wYB8ftOtNuC7pGRIXd7uk6NvagAiamO+NkTfTIB3UVN9gTk7yXqZZhUQA10 n8bVluqd7S6FnpDeZF3A0giWlRiQFmtAnPUC/Ul1ojz+OvQkNZ/mitFI6Im6SmhoOeyJ/nJ4Opra 9WEQbxD8+FbrR++3Xn639crr6y/uW+N8DqVzF98EflTAN3ekHxUEoCej0pJ7Ww/oyd7iOyq5D6me BBwx5P0yIajAqCj5aNZjSLvuaDZGg2sFPWlw4zRItCHVk1GmAg3SDogCBIAAEAACQKCpCIAKNLVl HOUyFszSlWPXHRWO5ejJ6io3UNyxf6yu9qqr3LFv8EAA6mqvusoNhGkEHwMVGMFGRZWAABAAAkAA CLgjACrgjhVSAgEgAASAABAYQQRABUawUVElIAAEgAAQAALuCIAKuGOFlEAACAABIAAERhCB2qiA NQZBtnfE7STJovbIt6GoMW+sJxXlJ9bEYmWlc/cLCpb5m/Jz8pTplBaGpyy5z+9Ne+mFnnyhHfOk 4TnCehI3YIyE375P6Ikef13gOLJ6omyy81IU6Mk46YkcDtxO5ws4bdA7MqF5rgB32qCUvP8hih5I SXOLelDacejBtzRwAE3P3ecG3CR/S3DeiB2E1s4l6JZP7OBUei+cA2JAWFEKiNFQgHaflLFpeiJr GinpZADe0BO7pnjpuTWLxumJqJIXAVBqBT0ZGz1J2LCTrgScNtgvFeCiIGftY+m6dMJYEtlWb2aN CpCIfCJosCWq9x7GX3cnOoT1tzuk6yrnw6bClxzAyToKXE1kQf58u5CjgSeS6Mx8PtxBs8WzupHU kySEjqOth56kfUpaFWuPHkE9cVQPalLzl4xhT8ZJT5yHS3OBgBupRUoZmbAaKpBFP8y+8FRAD2iX zbDZUY66Rbgz1a0YcX3Mq+/Z46yn411529CIappDr9PpJJXWQs4ETBNcqUAyVTWpJdsuNGctZEiA V4CT07g/9HqSe62c9A16ohiA8dETGoTDYSUJejKueiJGIhmjheXJOTKZV0BzDxQEKa6MCmTLBLIw lgqY0RN81lFpPxCrJsQrkAXJy+GohAmIUgoc14o8jDtSeTy2cElCdWJNB+caqEBRu3Dr/vxCBq2m CouriR9+PdFqULL8gfjr46onmr+/xBxCT8ZVT+RwkZgR3sBKeKwLBNlEXSME0ivgHZmw370CymSv 0BFg/7Ex8dcT8crW6hBXO7jrOi2KcSrUJD1x8QpAT6An0v1Z7GiEnoyrnkRUQIkKWzS5CNgrUAEV EKVa3yCQTWbOAoc9/joXDz6urpwKalvm8z+Jg51wopjvqV6BtJmjB5yGRM8FAkv+XLtEfoxsG4bK 5PKfNDn79wrIDXfpAooLZ+TaRRmITR9PNb4jacMtu1WSPlAexFlBFnri6j0afj2JLXyiOfmiUjbT gD1JRxGrERgfPRHVVzbKW9bKcysT8AZBBVSAeYPA9PCORFztfLxPlmxUBTWpAH39Qwzr7YgrxK1I 1geSNSCVMkhcXUdDLyrAvJGiNVlStPoSJhdaPr+vvbRZHFdbRUersl0enhaQ9NyeEgPP/pmArujM +64qUYCe+MVfH209Idty09VDlgrAnsj5ATe+jPC4o9TaZoiLqAC3OpBtG6yAClh3IrhM45CmQgT8 qECFBSOroUIAejJUzVWbsNCT2qCvouB+jhhaf/RMu05d7XXmu5257snZTSHdwelrrZ88bJl7BUAF qmi7fvNA1+0XwfF4HnoyHu3cby2hJ/0iWOvz/VCBmevdd4891S5QgVrbE4UDASAABIAAEPBEoB8q UKtXQH2tjmw+cF0p9wQqTV5XuYHijv1jdbVXXeWOfYMHAlBXe9VVbiBMY/9YXe219+X2QwXgFRj7 jgEAgAAQAAJAYPgR6IcK1OoVGH7oUQMgAASAABAAAk1AIIAK0NMGzb0Cx6/0pud2pi9h22ATmhcy AAEgAASAABAoQ6AfKmDxCiz2LFTgtVutVw+1Xn639crr6y/uW+OKLBMVvwMBIAAEgAAQAALVI9AP FbDuFXClAgWnDca11MLwVFnzpr30wp3Xb0YryPaO9BmcV6CZb0NhzrehJ+toRwBlpXP3C1pLVlaT PyCftAjoyXjFX887i9/+YOgJ9MRlEBlfPQk4bdA7HJHpFWBOG9Saquxs7Th5DWF4XDTKSBMQkY8r p38qQw6pVY55poeY0lNtqfC0dO5+geQRwzAO3PXNR80femLHe/T0hNNPtx4JPRkXPZGsR9bWnFCV acuY6skgYhBoVICLghy1EHllot1BXO2xiatNeqcTt4OexIgVe4ksVIA6oMqDZSs2k+ZGj17mCAfX jk7tm1pxzXvkUq4udDrtgD0xvXESq9HWk/JwTRh3YlNgLhBwI3X4wcNWKpCdb5x9UQmc5qjpdNIw M1rIGQ/LkhoJr9mSLX8lDExkjlOrSnOmM+8i70X8jJWocnIa91l5CvlvOixwZ+9bpaLGmObO3bdK 4BeGx8yCEn3oic2U2038COgJFzOC0bOcS0NPxklPiFcgpsvFi0mwJ1H3ybwCmnvAuocgMEgxRwWy ZQJZmO43pmOkesCCGpHPb83QzoL5MdNCBczoFbmqcev+/EJG/1SgSJ4yZ5jmQOu0MzRXJ9tm2LxK mEBBRD4nRoH462qrulLGEdCTMv1UgIGejK2eqHuhSqaL0JNYT6wLBFxEomqogBahOPcKIK52cNf1 pkO0pHwhRmkB29y9Aq+vKJn3Cjj5eKAn46onpfrpRgWU5WONfTppoBv+Vhpun1q49F8y091bL6Pi PCqfSxgpGmRPYtnK1v5hT3gqwL1WIKnAicuPxbsDMytd8e/F67viOre8e3axJy57OCLry4S2NwgU HSQOdnLfcPdE7nUZuTt6wKVLsY4yputa8tcWKbIHc2GkPEQcVs7+vQLDH389AdDuE5CTWdqy0BNF VV29AsOvJ4qC6IQSehJrBeyJascNYgM9setJwBsEFVAB9g0Cxb/ejsaAeMWarA9MtNti7YeMDPkj Tjwg7SySPjh87PlrztakaPWlOFt4aHVU016iS2tlenJlVtx986dSKLg1V3aBQ+JmzdfJq5+xNdr2 6nYEJh+z6yL++tjGXy/QT+iJWIVULWvSXcfPnhSZMeiJXU8C3iCogArUG6TYa9ugA1lAktFEAHoy mu1ada2gJ1UjOpr5NVxPAo4YAhUYTU1FrTQEGt510V4NQQB60pCGaLgYDdeTACpQwRFD9XoFGq4x EA8IAAEgAASAwCARABUYJNoDLEt9/ZIsIZZuI+hPyLrK7U/q8X26rvaqq9zxben+al5Xe9VVbn9o DePToALD2GqQGQgAASAABIBAZQiAClQGJTICAkAACAABIDCMCIAKDGOrQWYgAASAABAAApUhEEAF Pp59cmmld3llV5wydHF5V1znFnc/X+yK69RC78Rc7+Rc99TsIyHiwelrrZ88bFmPGDILrqxOyAgI AAEgAASAABBwRqA2KmA7bTCRWjkXNL6X7R3RIpU5VzNPmG9DUc+3sZ4kpB3ZkZXO3S+QJ3vEswqx XJ5B5BxhadrLLdy5IGOlD7l++u3vHDU9ievjB4Gj2iMZEAACJgL1UAH2tMHCJup/6CKHGSvHD0f2 NzU79KBKerweLZ27z4lPBjPn45HzvMrO0I5T1nB2elB/YuXkD0zlyhlBfYgVRdbXODC1FO5G6Emp lO4J/BFwzxspgQAQUBCogQpwUZBLZ/8W008nkp5TZ5obPfKWG2CqicTDH9+rNAt5hQZx1kc2znrc 5FT3lGP1Xc5zbpSeVG1aQQWqRhT5AQEWgQAq0O9pg1ps4jwyYSokNxgb9xVbEVlFJzaQ0gclMXcm P5Gpz/P3k5xcpm7UI645fjsdefy8EVqmDq8Aiz9tKeqJicVmvL68V2B89EGnAiX63EQ9qdDWggpU CCayAgLFCNRJBTROkAnqavrNKBs+i4vKCnRZHHRuhuYyc8sbIJ7Dla9/In62qrPjow9+VKCRelKp wZU00jlyWKVlIzMgMFYI1EAFRJHFewU8TH/5uFrQmgONqx3TADezhvjZwVRgyPVBd7MUV6eRelKh 9YRXoEIwkRUQaIRX4EeHWi+/23rl9fUX961xcZG9vQLDE39dc5KrTWIGzVRsIHmW3DccDJMTKc9w 3pjote3Omj/ZbanUKU8sbqsWnZWzggWCKPimFxmg6SlsirNHG3FFjfr2EbH6sDrZTifBxkA4HHqS BpA228GUX+oMdz9g4ySsPRAAAoEIBHgFQsIRaVSA8QqYHn9pULj75k+lAwG3J4AWoWfSr+Une7tk xdUCbKZQEaedvU9Icppot6Pg5HlW+SOlICS64kUFSCPQ/LWmSX5SX7a0VVeFYbzirBfqQw6F3oxD oifs0A4qEGij8RgQGAACAVQg5Igh0yuAI4YG0LrFRfhRgdrFhQA1IVCLnsTEwZXU1gQMigUCo4NA ABVYvfv0xMWHH1/aOHlpM7vEn+I6PvN46uLmsfMbN+4+iabs579KThsEFWigytRi4huIA0QCZYQO AIExR8CXCvzH9C1HxD44+4f17+6BCjjChWRAAAgAASAABOpBwJcKfPdw88DRG28fXnzz4NIbBxfN 6633l395ePnAsbVvN7bqoALGQmy6L2GPnY11lVuP2gxPqXW1S13lDk/LQFIgAASag4AvFdjd3XEX vg4q4C4dUgIBIAAEgAAQAALPn/tSAYHZ/fXewm0RmXD7/LWtMwtbn85vnZ57LPYSilMIp2e2jn/x +OiFR7fub4uUt39/BwsE0DIgAASAABAAAo1GIIAKCB5w55tnN+8/W7rTu/q73YW13vzq7uUbUczi C9d7Zxd7n8zviO2EotpXvloDFWh080M4IAAEgAAQAAIBVED4AwQPWLnbu/r1riQBl1Z6F5Z7FxYj HvDZQu+TuZ1TXz4S2H46exNUADoGBIAAEAACQKDRCARQgfNLW9IfMLfaEyRAXDPLXcEATs/vykt4 BT75MvIKTJ1dBhVodPNDOCAABIAAEAACAVTgs4Wn0aLAWrwocL0rL8EATs31Ts51xb/iklTgN6eX QAWgY0AACAABIAAEGo1AABUQ+wSFP2DuZu+nP/+l9AoIHiBIgLjEHflFUoHDHy+CCjS6+SEcEAAC QAAIAIEAKiAPHhajvrw+X+yKqzMf8QB5Rb6B2WivwKFpUAGoGBAAAkAACACBZiMQQAXES4NyUYCy gey74AQd4RiYjbwCoALNbnxIBwSAABAAAkAg6FwBGZlQXhkDkF8iHjDfnZ7bmY5fJjw4fQ0LBNAy IAAEgAAQAAKNRiDAKzD1xRPx0qA4QkBeGRv46EpXXlOzOyIuEahAoxsewgEBIAAEgAAQkAgEUIEP zz0Rrw4KNnBucffsck9cgg2cWuqdWOwdv9o7Ot89cnlnagZeAagYEAACQAAIAIFhQCCACvz27GPx uqBgA59f6352tSeuTxe7ggd0rkYugaNfdj+8tD11AVRgGJofMgIBIAAEgAAQCKACH5zZPDG7fXK+ Gx0lNL9zen775JVoq+BHc91js9uCBxyZ2Tp2YUNgi22DUDAgAASAABAAAk1HIIAKrN59euLiw48v bYhAA/IS38XmAHF9NPNo6uLmsfMbN+4+ETU/cuY6tg02XQMgHxAAAkAACIw5Ar5U4NzSA0fEjpy/ hyDFjlghGRAAAkAACACB2hDwpQLfPdz84MydA1M33vn1ytuHF988tPTWwWtvHFwUl/gur18cvn7g 2Nq3G1s6FfjBz+698vr6i/vW/uTfvvG9IvcCLiAABIAAEAACQGDoEHjtVusfPmv96FDr5XdbL/3L zT//99t/9q83vv/PK75X68drIZcovrHXj2+1fK/X1loh12BACJLNF4EofYM1YWCyDaygEH0L0oQB 9dNByRai2KKfBog3mN49crI1uoEC1EA8EqAJYQUFPHWr9U8Lrb//pPXqryIq0Hr1UOvV9+N/B3aJ 4nyvQckm+NFgrgC0AwTzxjlul4EVFAKCEM/zCigl6RS+WhqU3rc6YenDQAgoK0zlQp4alE2AbGHK M7CnQrQ0QHmCeneI8gysIAHCryKD/8P/jKmA+A8XEAACQAAIAAEgMK4I/D+cwyrrrraySQAAAABJ RU5ErkJggg== --001636498e6d5160a104743ba61c-- From lekktu@gmail.com Wed Sep 23 03:51:55 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 23 Sep 2009 10:51:55 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.7 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER, IMPRONONCABLE_2 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-bw0-f223.google.com (mail-bw0-f223.google.com [209.85.218.223]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8NApref007803 for <4534@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 03:51:54 -0700 Received: by bwz23 with SMTP id 23so484834bwz.1 for <4534@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 03:51:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=d+AY6u4gAVz7E6GgLmxlGE06IN3N/DnacwjP3XBfvJM=; b=Seyy8WHDpqF1FkXAGTrVN1+mFzsDvFDTo7urfkLHxNGPsm2JJeNNUwdm0bTWf+VRb+ kyVTgt8EF2DFnVWFrflvQ9yfJNiE2vw28QY3Qk9xmGtrpYve4sJwGMI1Q/MM9CpRIUJU UEh/I7ingmeKh/QARhWmGphq5KiwAJfD3Spls= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=ckKOSNzgBxVq5+HupBAKaBoyYC0FeRVxNiV2SAIfm14858Mw/9nFbdc9bpbuLasNY4 Qeqb/cJGXY0Jn1T6igekSrumZ5MRBaJ3FlEZ+rBuh8xKohBDPXrJogSWMpYIxmj9SV4O uJBwYEHR/lyMd3CN/AtNFxIob+1/IPrMUuCVk= MIME-Version: 1.0 Received: by 10.239.139.199 with SMTP id u7mr178349hbu.96.1253703107249; Wed, 23 Sep 2009 03:51:47 -0700 (PDT) In-Reply-To: References: <4AB9CE11.9040300@gmx.at> From: Juanma Barranquero Date: Wed, 23 Sep 2009 12:51:27 +0200 Message-ID: Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window To: martin rudalics Cc: 4534@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 FWIW, commenting out this chunk from shrink_mini_window, it works as expected. Juanma diff --git a/src/window.c b/src/window.c index 08fd8c8..c892436 100644 --- a/src/window.c +++ b/src/window.c @@ -4677,17 +4677,18 @@ void shrink_mini_window (w) struct window *w; { - struct frame *f = XFRAME (w->frame); - struct window *root = XWINDOW (FRAME_ROOT_WINDOW (f)); - - if (save_restore_orig_size (root, CHECK_ORIG_SIZES)) - { - save_restore_orig_size (root, RESTORE_ORIG_SIZES); - adjust_glyphs (f); - FRAME_WINDOW_SIZES_CHANGED (f) = 1; - windows_or_buffers_changed = 1; - } - else if (XFASTINT (w->total_lines) > 1) + /* struct frame *f = XFRAME (w->frame); */ + /* struct window *root = XWINDOW (FRAME_ROOT_WINDOW (f)); */ + /* */ + /* if (save_restore_orig_size (root, CHECK_ORIG_SIZES)) */ + /* { */ + /* save_restore_orig_size (root, RESTORE_ORIG_SIZES); */ + /* adjust_glyphs (f); */ + /* FRAME_WINDOW_SIZES_CHANGED (f) = 1; */ + /* windows_or_buffers_changed = 1; */ + /* } */ + /* else if (XFASTINT (w->total_lines) > 1) */ + if (XFASTINT (w->total_lines) > 1) { /* Distribute the additional lines of the mini-window among the other windows. */ From rudalics@gmx.at Wed Sep 23 05:21:28 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 23 Sep 2009 12:21:29 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.4 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with SMTP id n8NCLQcn022093 for <4534@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 05:21:28 -0700 Received: (qmail invoked by alias); 23 Sep 2009 12:21:20 -0000 Received: from 62-47-54-210.adsl.highway.telekom.at (EHLO [62.47.54.210]) [62.47.54.210] by mail.gmx.net (mp069) with SMTP; 23 Sep 2009 14:21:20 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18Y1gs3n2kYSnMRuWbdryy5M3GAkU+VkMJJk3fh4n 05/81VkjCXlh1a Message-ID: <4ABA12BF.8070205@gmx.at> Date: Wed, 23 Sep 2009 14:21:19 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Juanma Barranquero CC: 4534@debbugs.gnu.org Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window References: <4AB9CE11.9040300@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.68 > Well, yes, commenting that code out avoids the failure (which happens > in that call to grow_mini_window). But the point is, the miniwindow is > not shrunk as it should. See attached image. Well that code was probably intended to serve some purpose ;-) I just wanted to spot the culprit. Would writing if (height > WINDOW_TOTAL_LINES (w)) { freeze_window_starts (f, 1); grow_mini_window (w, height - WINDOW_TOTAL_LINES (w)); } instead do better? I don't want to delve deeper into this because I'd like to get rid of this weird height/position save/restore code soon. martin From rudalics@gmx.at Wed Sep 23 05:21:49 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 23 Sep 2009 12:21:49 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.8 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER, IMPRONONCABLE_2 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with SMTP id n8NCLl5m022110 for <4534@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 05:21:49 -0700 Received: (qmail invoked by alias); 23 Sep 2009 12:21:40 -0000 Received: from 62-47-54-210.adsl.highway.telekom.at (EHLO [62.47.54.210]) [62.47.54.210] by mail.gmx.net (mp008) with SMTP; 23 Sep 2009 14:21:40 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/rp+5uwyfrU1cGctB5c53mqwPonLBE3cvDu4/1/9 q9c1iYQmbcsZah Message-ID: <4ABA12D3.3060507@gmx.at> Date: Wed, 23 Sep 2009 14:21:39 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Juanma Barranquero CC: 4534@debbugs.gnu.org Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window References: <4AB9CE11.9040300@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.57 > FWIW, commenting out this chunk from shrink_mini_window, it works as expected. > > Juanma > > > > diff --git a/src/window.c b/src/window.c > index 08fd8c8..c892436 100644 > --- a/src/window.c > +++ b/src/window.c > @@ -4677,17 +4677,18 @@ void > shrink_mini_window (w) > struct window *w; > { > - struct frame *f = XFRAME (w->frame); > - struct window *root = XWINDOW (FRAME_ROOT_WINDOW (f)); > - > - if (save_restore_orig_size (root, CHECK_ORIG_SIZES)) > - { > - save_restore_orig_size (root, RESTORE_ORIG_SIZES); > - adjust_glyphs (f); > - FRAME_WINDOW_SIZES_CHANGED (f) = 1; > - windows_or_buffers_changed = 1; > - } > - else if (XFASTINT (w->total_lines) > 1) This would make the whole save/restore code obsolete. Unfortunately, the resulting alternative (enlarge_window) is even worse because it might delete windows (when it tries to enlarge them) :-( martin From lekktu@gmail.com Wed Sep 23 06:41:53 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 23 Sep 2009 13:41:53 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.2 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-bw0-f223.google.com (mail-bw0-f223.google.com [209.85.218.223]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8NDfpPm002035 for <4534@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 06:41:52 -0700 Received: by bwz23 with SMTP id 23so607011bwz.1 for <4534@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 06:41:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=wV5rtmyM9RXCe0yHjpuSw/SLXwTaiQdhF81ieEcSHo8=; b=vGBe/BHHmo+MZfWfw5MBztOPVsZ8U6GwMMghFdP8FhSi8UtPT4Ckdk3PZ52l7ybU/I bOq9mq+Bnj97SOjolonkHwJr5KfMnCGAMxilgUXgs3ArmD2thVJrZL1yPLef5B4rz+xJ DaU6t/cuqXpepRr7I9rI4EASUHOUYAyRnZieM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=oo+TWIHPiT8R3wD5Xpo5yZMBA0xQkwl6vQo+BzrUP5sRgYN3WTHVL21so4ORITwUu+ psBFJagic2w2N1tnRgksQcBvxDqPXm6DXuaPTbKkMNJWIa0PJ6A2jFdt6wqnCfU4YlhV qp0v2phLj6B51pAJ9IRNZsGVr0JFfIC7c5bs4= MIME-Version: 1.0 Received: by 10.239.130.31 with SMTP id 31mr198952hbh.134.1253713305205; Wed, 23 Sep 2009 06:41:45 -0700 (PDT) In-Reply-To: <4ABA12BF.8070205@gmx.at> References: <4AB9CE11.9040300@gmx.at> <4ABA12BF.8070205@gmx.at> From: Juanma Barranquero Date: Wed, 23 Sep 2009 15:41:24 +0200 Message-ID: Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window To: martin rudalics Cc: 4534@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, Sep 23, 2009 at 14:21, martin rudalics wrote: > Would writing > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (height > WINDOW_TOTAL= _LINES (w)) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{ > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0freeze_wind= ow_starts (f, 1); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0grow_mini_w= indow (w, height - WINDOW_TOTAL_LINES (w)); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} > > instead do better? In my case, height < WINDOW_TOTAL_LINES (w) at that point (that's what triggers the xassert), so adding the above check works exactly like removing the if() altogether: it does not crash, but it does not shrink the minibuffer to 5 lines, which would be the correct height. Juanma From lekktu@gmail.com Wed Sep 23 06:42:39 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 23 Sep 2009 13:42:39 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.2 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-fx0-f207.google.com (mail-fx0-f207.google.com [209.85.220.207]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8NDgbgP002342 for <4534@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 06:42:38 -0700 Received: by fxm3 with SMTP id 3so584150fxm.44 for <4534@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 06:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=cMQgcitm2LYnZWfIBEbC1JlTI+4kpbL9BqbI5hzaOxo=; b=sYzS3Z+rmTSMTNehJe18XK87Abm7f3N0Xu9KQUdQl6Wz3QqsVmlUgsA2xVDbcI74xj Ullt5gtk8IbpJ9hZFTBxEGHwJpIQlLJ3SwBsB2ZfDMnTuydT50yZJDUs7KAB0/nPB5uS hHV9Rr/cdDzIbRipA3+v8gNr3UZkHccPNjnyo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=COIHM1zCI/Z+ffxnAKO/JjYttOBOakHTDZvvH8AHAvSh0uWFl/DCGGg9UclQvCloyz r4DfcBIShGBsYpLZBq6t2X7EkZT3v2xtvvWWYDwd/KHjLOganJB8lKvHuj3Y14dEY5Ls +dUujjbXktlLAezQOHYHKXoCYZwt+dI8uklpQ= MIME-Version: 1.0 Received: by 10.239.182.158 with SMTP id q30mr194028hbg.23.1253713351146; Wed, 23 Sep 2009 06:42:31 -0700 (PDT) In-Reply-To: <4ABA12D3.3060507@gmx.at> References: <4AB9CE11.9040300@gmx.at> <4ABA12D3.3060507@gmx.at> From: Juanma Barranquero Date: Wed, 23 Sep 2009 15:42:11 +0200 Message-ID: Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window To: martin rudalics Cc: 4534@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, Sep 23, 2009 at 14:21, martin rudalics wrote: > This would make the whole save/restore code obsolete. =C2=A0Unfortunately= , > the resulting alternative (enlarge_window) is even worse because it > might delete windows (when it tries to enlarge them) :-( Hey, you're the expert :-) I was merely pointing out that the save/restore code is doing the wrong thing here. Juanma From rudalics@gmx.at Wed Sep 23 23:49:30 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 24 Sep 2009 06:49:30 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.4 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with SMTP id n8O6nSGo023583 for <4534@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 23:49:29 -0700 Received: (qmail invoked by alias); 24 Sep 2009 06:49:22 -0000 Received: from 62-47-53-69.adsl.highway.telekom.at (EHLO [62.47.53.69]) [62.47.53.69] by mail.gmx.net (mp020) with SMTP; 24 Sep 2009 08:49:22 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19w87gKeb5w19fYqf7UEaYdyj7gj/AGTL1/TlJv0a EtWTUW5CHyNlmR Message-ID: <4ABB1671.4060009@gmx.at> Date: Thu, 24 Sep 2009 08:49:21 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Juanma Barranquero CC: 4534@debbugs.gnu.org Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window References: <4AB9CE11.9040300@gmx.at> <4ABA12D3.3060507@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.85 > I was merely pointing out that the save/restore code is doing the > wrong thing here. I see. Perdona mi estupidez. martin From rudalics@gmx.at Wed Sep 23 23:49:39 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 24 Sep 2009 06:49:39 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.4 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with SMTP id n8O6nbA9023588 for <4534@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 23:49:38 -0700 Received: (qmail invoked by alias); 24 Sep 2009 06:49:31 -0000 Received: from 62-47-53-69.adsl.highway.telekom.at (EHLO [62.47.53.69]) [62.47.53.69] by mail.gmx.net (mp069) with SMTP; 24 Sep 2009 08:49:31 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/c00cK1mDcWyjcH2Cje4aXku93dxu/U7HKKiSY8B rCowH1LFCvTL0k Message-ID: <4ABB167A.4070801@gmx.at> Date: Thu, 24 Sep 2009 08:49:30 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Juanma Barranquero CC: 4534@debbugs.gnu.org Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window References: <4AB9CE11.9040300@gmx.at> <4ABA12BF.8070205@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.6 >> Would writing >> >> if (height > WINDOW_TOTAL_LINES (w)) >> { >> freeze_window_starts (f, 1); >> grow_mini_window (w, height - WINDOW_TOTAL_LINES (w)); >> } >> >> instead do better? > > In my case, height < WINDOW_TOTAL_LINES (w) at that point (that's what > triggers the xassert), so adding the above check works exactly like > removing the if() altogether: it does not crash, but it does not > shrink the minibuffer to 5 lines, which would be the correct height. Seems I'm too silly to understand what's going on in resize_mini_window. Apparently if (EQ (Vresize_mini_windows, Qgrow_only)) ... fails so ... else ... gets executed ... { /* Always resize to exact size needed. */ if (height > WINDOW_TOTAL_LINES (w)) ... fails again, so ... else if (height < WINDOW_TOTAL_LINES (w)) ... we're here ... { int old_height = WINDOW_TOTAL_LINES (w); freeze_window_starts (f, 0); shrink_mini_window (w); ... should resize the mini_window down to one line ... if (height) { freeze_window_starts (f, 1); ... and the following causes the assertion failure to trigger because the second arguments gets less than zero ... grow_mini_window (w, height - WINDOW_TOTAL_LINES (w)); } window_height_changed_p = WINDOW_TOTAL_LINES (w) != old_height; } } Now if I replace the check if (height) by if (height > WINDOW_TOTAL_LINES (w)) I should be able to avoid the delta = -1 assertion failure in grow_mini_window. Can you confirm my reasoning so far? The fact that `height' is something like zero or less seems to stem from some miscalculation (probably caused by the line-wrapping part) earlier in the code of resize_mini_window. If that's so could you try to find out why height is not at least one line? martin From lekktu@gmail.com Thu Sep 24 05:58:35 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 24 Sep 2009 12:58:35 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.7 required=4.0 tests=AWL,HAS_BUG_NUMBER, IMPRONONCABLE_2 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-fx0-f207.google.com (mail-fx0-f207.google.com [209.85.220.207]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8OCwX1W014119 for <4534@emacsbugs.donarmstrong.com>; Thu, 24 Sep 2009 05:58:34 -0700 Received: by fxm3 with SMTP id 3so1372428fxm.44 for <4534@emacsbugs.donarmstrong.com>; Thu, 24 Sep 2009 05:58:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=rnd/HzS4UwIPE4ovoy5+1hd4bHuKxJE9kV2uQjL/2Js=; b=GqQ26anFFiDxiUBdwe7+S9oBrm3F7vDWUhJ6feJw0uKWZbyINdgOeo/2D6bZPSexG0 ZFZtei1sO7KHxr5qFp2EvOYTniH0EZnh5IQwhD+BZUOjlo7NBKupVHu+2eSGOzx9YCDg MI7vhOD3Hw6BdhHA2UxGxeYQYWpJyZ9pBDJSQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=axFufbkAW+yN7ousFI3M1BKYCVOP9a4wdfQQOLFdiO+zpnOO+oD5RY42IPyJf/tAAd MvD6M0I0/cC/AL4FwoaZsWpNI9Na6kAlrDVbbHU1KqIaGi6NOQ/1WIsI24GFaqHPIEfr 0YCnhWcn3PPu9ZnXyVwRXo96GFEIJWfnewSvU= MIME-Version: 1.0 Received: by 10.239.139.97 with SMTP id s33mr314175hbs.24.1253797107100; Thu, 24 Sep 2009 05:58:27 -0700 (PDT) In-Reply-To: <4ABB167A.4070801@gmx.at> References: <4AB9CE11.9040300@gmx.at> <4ABA12BF.8070205@gmx.at> <4ABB167A.4070801@gmx.at> From: Juanma Barranquero Date: Thu, 24 Sep 2009 14:58:07 +0200 Message-ID: Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window To: martin rudalics Cc: 4534@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, Sep 24, 2009 at 08:49, martin rudalics wrote: > =C2=A0 =C2=A0 =C2=A0if (EQ (Vresize_mini_windows, Qgrow_only)) > =C2=A0 =C2=A0 =C2=A0 =C2=A0... fails so ... > =C2=A0 =C2=A0 =C2=A0else > =C2=A0 =C2=A0 =C2=A0 =C2=A0... gets executed ... > =C2=A0 =C2=A0 =C2=A0 =C2=A0{ > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/* Always resize to exact size needed. = =C2=A0*/ > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (height > WINDOW_TOTAL_LINES (w)) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0... fails again, so ... > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0else if (height < WINDOW_TOTAL_LINES (w= )) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0... we're here ... > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{ > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0int old_height =3D WINDOW= _TOTAL_LINES (w); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0freeze_window_starts (f, = 0); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0shrink_mini_window (w); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0... should resize the min= i_window down to one line ... That's exactly what happens, except that shrink_mini_window (w) does *not* resize the miniwindow; it's still 6 lines height. So > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (height) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{ > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0freeze_wind= ow_starts (f, 1); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0... and the= following causes the assertion failure to > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0trigger because the second arguments gets less > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0than zero ... > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0grow_mini_w= indow (w, height - WINDOW_TOTAL_LINES (w)); at this point, height =3D=3D 5, WINDOW_TOTAL_LINES (w) =3D=3D 6. > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0window_height_changed_p = =3D WINDOW_TOTAL_LINES (w) !=3D old_height; > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} > =C2=A0 =C2=A0 =C2=A0 =C2=A0} > > Now if I replace the check > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (height) > > by > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (height > WINDOW_TOTAL= _LINES (w)) > > I should be able to avoid the delta =3D -1 assertion failure in > grow_mini_window. =C2=A0Can you confirm my reasoning so far? It's correct. Except that, as shrink_mini_window didn't shrink the window, it remains at 6 lines. > The fact that `height' is something like zero or less seems to stem from > some miscalculation (probably caused by the line-wrapping part) earlier > in the code of resize_mini_window. =C2=A0If that's so could you try to fi= nd > out why height is not at least one line? I'm attaching the trace from inside shrink_mini_window. The call happens just after I type '7'. At this moment, as said, the minibuffer contains six lines of completion candidates, and the 7 reduces the number of candidates so they fit in 5 lines. If you need me to look into something specific that could help you pinpoint the problem, just say so. Juanma Breakpoint 3, shrink_mini_window (w=3D0x2fb1c00) at window.c:4680 4680 struct frame *f =3D XFRAME (w->frame); (gdb) p *f $1 =3D { size =3D 3053453312, next =3D 0x5b900313, name =3D 66312, icon_name =3D 65536, title =3D 0, focus_frame =3D 1588658176, root_window =3D -658373880, selected_window =3D -1241251100, minibuffer_window =3D 268698387, param_alist =3D 553976571, scroll_bars =3D 742, condemned_scroll_bars =3D 1588396032, menu_bar_items =3D -1940914176, face_alist =3D 357, menu_bar_vector =3D 279576576, buffer_predicate =3D 279576576, buffer_list =3D 0, buried_buffer_list =3D 1342177280, menu_bar_window =3D 525044, tool_bar_window =3D 524288, tool_bar_items =3D 4096, desired_tool_bar_string =3D 8519680, current_tool_bar_string =3D 1342193680, face_cache =3D 0x180308, menu_bar_items_used =3D 536870912, namebuf =3D 0xa2240010
, current_pool =3D 0xa22402f5, desired_pool =3D 0xa22402f5, desired_matrix =3D 0xa22402f5, current_matrix =3D 0xa22402f5, glyphs_initialized_p =3D 1, resized_p =3D 0, force_flush_display_p =3D 1, default_face_done_p =3D 0, already_hscrolled_p =3D 1, updated_p =3D 1, minimize_tool_bar_window_p =3D 1, tool_bar_lines =3D -1574698251, n_tool_bar_rows =3D -1574698251, n_tool_bar_items =3D -1574698251, decode_mode_spec_buffer =3D 0xa22402f5
= , insert_line_cost =3D 0xa22402f5, delete_line_cost =3D 0xa22402f5, insert_n_lines_cost =3D 0xa22402f5, delete_n_lines_cost =3D 0xa22402f5, text_lines =3D -1574698251, text_cols =3D -1574698251, total_lines =3D -1574698251, total_cols =3D -1574698251, new_text_lines =3D -1574698251, new_text_cols =3D -1574698251, left_pos =3D -1574698251, top_pos =3D -1574698251, pixel_height =3D -1574698251, pixel_width =3D -1574698251, resx =3D -3.2051845696591629e-144, resy =3D -3.2051845696591629e-144, x_pixels_diff =3D -1574698251, y_pixels_diff =3D -1574698251, win_gravity =3D -1574698251, size_hint_flags =3D -1574698251, border_width =3D -1574698251, internal_border_width =3D -1574698251, column_width =3D -1574698251, space_width =3D -1574698251, line_height =3D -1574698251, output_method =3D 2720269045, terminal =3D 0xa22402f5, output_data =3D { tty =3D 0xa22402f5, x =3D 0xa22402f5, w32 =3D 0xa22402f5, ns =3D 0xa22402f5, nothing =3D -1574698251 }, font_driver_list =3D 0xa22402f5, font_data_list =3D 0xa22402f5, fringe_cols =3D -1574698251, left_fringe_width =3D -1574698251, right_fringe_width =3D -1574698251, want_fullscreen =3D 2720269045, menu_bar_lines =3D -1574698251, external_menu_bar =3D 1, display_preempted =3D 0 '\0', visible =3D 1 '\001', iconified =3D 1 '\001', async_visible =3D 2 '\002', async_iconified =3D 36 '$', garbaged =3D -94 '\242', has_minibuffer =3D 1 '\001', wants_modeline =3D 0 '\0', can_have_scroll_bars =3D 2 '\002', auto_raise =3D 0 '\0', auto_lower =3D 0 '\0', no_split =3D 1 '\001', explicit_name =3D 0 '\0', window_sizes_changed =3D 0 '\0', mouse_moved =3D 1 '\001', pointer_invisible =3D 0 '\0', vertical_scroll_bar_type =3D 2720269045, desired_cursor =3D -1574698251, cursor_width =3D -1574698251, blink_off_cursor =3D -1574698251, blink_off_cursor_width =3D -1574698251, message_buf =3D 0xa22402f5
, scroll_bottom_vpos =3D -1574698251, config_scroll_bar_width =3D -1574698251, config_scroll_bar_cols =3D -1574698251, scroll_bar_actual_width =3D -1574698251, cost_calculation_baud_rate =3D -1574698251, alpha =3D {-3.2051845696591629e-144, -3.2051845696591629e-144}, gamma =3D -3.2051845696591629e-144, extra_line_spacing =3D -1574698251, background_pixel =3D 2720269045, foreground_pixel =3D 2720269045 } (gdb) n 4681 struct window *root =3D XWINDOW (FRAME_ROOT_WINDOW (f)); (gdb) p *root $2 =3D { size =3D 1073873018, vec_next =3D 0x3433200, frame =3D 55866552, mini_p =3D 365, next =3D 365, prev =3D 365, hchild =3D 365, vchild =3D 1668, parent =3D 77, left_col =3D 77, top_line =3D 0, total_lines =3D 17, total_cols =3D 28, buffer =3D 0, start =3D 74, pointm =3D 17, force_start =3D 55556516, optional_new_start =3D 50879400, hscroll =3D 20788139, min_hscroll =3D 51623432, use_time =3D 30, sequence_number =3D 30, temslot =3D 1, last_modified =3D 1, last_overlay_modified =3D 365, last_point =3D 365, last_had_star =3D 0, vertical_scroll_bar =3D 0, left_margin_cols =3D 0, right_margin_cols =3D 0, left_fringe_width =3D 0, right_fringe_width =3D 0, fringes_outside_margins =3D 0, scroll_bar_width =3D 0, vertical_scroll_bar_type =3D 0, last_mark_x =3D 0, last_mark_y =3D 16777216, window_end_pos =3D 48273409, window_end_vpos =3D 49329729, window_end_valid =3D 48273409, update_mode_line =3D 0, start_at_line_beg =3D 0, display_table =3D 0, dedicated =3D -1, base_line_number =3D 1, base_line_pos =3D 0, region_showing =3D 0, column_number_displayed =3D 0, redisplay_end_trigger =3D 48273456, resize_proportionally =3D 0, orig_total_lines =3D 0, orig_top_line =3D 321, window_parameters =3D 55653125, current_matrix =3D 0x347c2e3, desired_matrix =3D 0x2e09801, nrows_scale_factor =3D 49860659, ncols_scale_factor =3D 48273409, last_cursor =3D { x =3D 0, y =3D 48273409, hpos =3D 48273409, vpos =3D 50879186 }, cursor =3D { x =3D 54359045, y =3D 48273601, hpos =3D 48272499, vpos =3D 48628621 }, phys_cursor =3D { x =3D 48273409, y =3D 52445245, hpos =3D 49214980, vpos =3D 48300036 }, phys_cursor_type =3D 48303620, phys_cursor_width =3D 48273457, phys_cursor_ascent =3D 64, phys_cursor_height =3D 560, phys_cursor_on_p =3D 0, cursor_off_p =3D 0, last_cursor_off_p =3D 0, must_be_updated_p =3D 0, pseudo_window_p =3D 0, frozen_window_start_p =3D 0, vscroll =3D 48273409, window_end_bytepos =3D 48273409 } (gdb) n 4683 if (save_restore_orig_size (root, CHECK_ORIG_SIZES)) (gdb) n 4685 save_restore_orig_size (root, RESTORE_ORIG_SIZES); (gdb) p *root $3 =3D { size =3D 1073745971, vec_next =3D 0x300f0c0, frame =3D 50008068, mini_p =3D 48273409, next =3D 50011140, prev =3D 48273409, hchild =3D 48273409, vchild =3D 50011652, parent =3D 48273409, left_col =3D 0, top_line =3D 24, total_lines =3D 264, total_cols =3D 680, buffer =3D 48273409, start =3D 48273409, pointm =3D 48273409, force_start =3D 48273409, optional_new_start =3D 48273409, hscroll =3D 0, min_hscroll =3D 0, use_time =3D 56, sequence_number =3D 48, temslot =3D 0, last_modified =3D 0, last_overlay_modified =3D 0, last_point =3D 1536, last_had_star =3D 48273409, vertical_scroll_bar =3D 54873988, left_margin_cols =3D 48273409, right_margin_cols =3D 48273409, left_fringe_width =3D 48273409, right_fringe_width =3D 48273409, fringes_outside_margins =3D 48273409, scroll_bar_width =3D 48273409, vertical_scroll_bar_type =3D 48273457, last_mark_x =3D 48273409, last_mark_y =3D 48273409, window_end_pos =3D 0, window_end_vpos =3D 0, window_end_valid =3D 48273409, update_mode_line =3D 48273409, start_at_line_beg =3D 48273457, display_table =3D 48273409, dedicated =3D 48273409, base_line_number =3D 8, base_line_pos =3D 8, region_showing =3D 48273409, column_number_displayed =3D 48273409, redisplay_end_trigger =3D 48273409, resize_proportionally =3D 48273409, orig_total_lines =3D 272, orig_top_line =3D 24, window_parameters =3D 48273409, current_matrix =3D 0x0, desired_matrix =3D 0x0, nrows_scale_factor =3D 1, ncols_scale_factor =3D 1, last_cursor =3D { x =3D 0, y =3D 0, hpos =3D 0, vpos =3D 0 }, cursor =3D { x =3D 0, y =3D 0, hpos =3D 0, vpos =3D 0 }, phys_cursor =3D { x =3D 0, y =3D 0, hpos =3D 0, vpos =3D 0 }, phys_cursor_type =3D -1, phys_cursor_width =3D -1, phys_cursor_ascent =3D 12, phys_cursor_height =3D 16, phys_cursor_on_p =3D 1, cursor_off_p =3D 0, last_cursor_off_p =3D 0, must_be_updated_p =3D 0, pseudo_window_p =3D 0, frozen_window_start_p =3D 0, vscroll =3D 0, window_end_bytepos =3D 0 } (gdb) n 4686 adjust_glyphs (f); (gdb) p *f $4 =3D { size =3D 1073742869, next =3D 0x3245200, name =3D 49997459, icon_name =3D 48273409, title =3D 48273409, focus_frame =3D 48273409, root_window =3D 51028484, selected_window =3D 50011140, minibuffer_window =3D 50011140, param_alist =3D 52445997, scroll_bars =3D 54873092, condemned_scroll_bars =3D 48273409, menu_bar_items =3D 50027780, face_alist =3D 48839941, menu_bar_vector =3D 54169604, buffer_predicate =3D 48273409, buffer_list =3D 52389701, buried_buffer_list =3D 48273409, menu_bar_window =3D 48273409, tool_bar_window =3D 51028996, tool_bar_items =3D 55373828, desired_tool_bar_string =3D 49919939, current_tool_bar_string =3D 55037811, face_cache =3D 0x2fe9140, menu_bar_items_used =3D 0, namebuf =3D 0x2e32fa8 "emacs", current_pool =3D 0x0, desired_pool =3D 0x0, desired_matrix =3D 0x0, current_matrix =3D 0x0, glyphs_initialized_p =3D 1, resized_p =3D 0, force_flush_display_p =3D 0, default_face_done_p =3D 1, already_hscrolled_p =3D 0, updated_p =3D 1, minimize_tool_bar_window_p =3D 0, tool_bar_lines =3D 3, n_tool_bar_rows =3D 1, n_tool_bar_items =3D 14, decode_mode_spec_buffer =3D 0x30aa000 '-' ..., insert_line_cost =3D 0x0, delete_line_cost =3D 0x0, insert_n_lines_cost =3D 0x0, delete_n_lines_cost =3D 0x0, text_lines =3D 43, text_cols =3D 80, total_lines =3D 0, total_cols =3D 85, new_text_lines =3D 0, new_text_cols =3D 0, left_pos =3D 66, top_pos =3D 87, pixel_height =3D 688, pixel_width =3D 680, resx =3D 96, resy =3D 96, x_pixels_diff =3D 4, y_pixels_diff =3D 50, win_gravity =3D 1, size_hint_flags =3D 0, border_width =3D 2, internal_border_width =3D 0, column_width =3D 8, space_width =3D 8, line_height =3D 16, output_method =3D output_w32, terminal =3D 0x3263700, output_data =3D { tty =3D 0x2f97300, x =3D 0x2f97300, w32 =3D 0x2f97300, ns =3D 0x2f97300, nothing =3D 49902336 }, font_driver_list =3D 0x2fb7eb0, font_data_list =3D 0x0, fringe_cols =3D 2, left_fringe_width =3D 8, right_fringe_width =3D 8, want_fullscreen =3D FULLSCREEN_NONE, menu_bar_lines =3D 0, external_menu_bar =3D 1, display_preempted =3D 0 '\0', visible =3D 1 '\001', iconified =3D 0 '\0', async_visible =3D 1 '\001', async_iconified =3D 0 '\0', garbaged =3D 0 '\0', has_minibuffer =3D 1 '\001', wants_modeline =3D 1 '\001', can_have_scroll_bars =3D 1 '\001', auto_raise =3D 0 '\0', auto_lower =3D 0 '\0', no_split =3D 0 '\0', explicit_name =3D 0 '\0', window_sizes_changed =3D 0 '\0', mouse_moved =3D 0 '\0', pointer_invisible =3D 0 '\0', vertical_scroll_bar_type =3D vertical_scroll_bar_right, desired_cursor =3D FILLED_BOX_CURSOR, cursor_width =3D 48257509, blink_off_cursor =3D DEFAULT_CURSOR, blink_off_cursor_width =3D 0, message_buf =3D 0x313b000 "\200\002>\003P\034e\001", scroll_bottom_vpos =3D -1, config_scroll_bar_width =3D 17, config_scroll_bar_cols =3D 3, scroll_bar_actual_width =3D 24, cost_calculation_baud_rate =3D 19200, alpha =3D {-1, -1}, gamma =3D 0, extra_line_spacing =3D 0, background_pixel =3D 50331647, foreground_pixel =3D 33554432 } (gdb) n 4687 FRAME_WINDOW_SIZES_CHANGED (f) =3D 1; (gdb) cont From rudalics@gmx.at Thu Sep 24 08:35:24 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 24 Sep 2009 15:35:25 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.8 required=4.0 tests=AWL,HAS_BUG_NUMBER,MIXEDBDN, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with SMTP id n8OFZMtO005664 for <4534@emacsbugs.donarmstrong.com>; Thu, 24 Sep 2009 08:35:24 -0700 Received: (qmail invoked by alias); 24 Sep 2009 15:35:11 -0000 Received: from 62-47-37-172.adsl.highway.telekom.at (EHLO [62.47.37.172]) [62.47.37.172] by mail.gmx.net (mp027) with SMTP; 24 Sep 2009 17:35:11 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18Rs6xJmqwR3yv3f+9kcsD+RcA71umTi9qEXqAosd mZv7a9+wMcI6Ka Message-ID: <4ABB9106.1090306@gmx.at> Date: Thu, 24 Sep 2009 17:32:22 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Juanma Barranquero CC: 4534@debbugs.gnu.org Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window References: <4AB9CE11.9040300@gmx.at> <4ABA12BF.8070205@gmx.at> <4ABB167A.4070801@gmx.at> In-Reply-To: Content-Type: multipart/mixed; boundary="------------000102020806050305050002" X-Y-GMX-Trusted: 0 X-FuHaFi: 0.76,0.57 This is a multi-part message in MIME format. --------------000102020806050305050002 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >> shrink_mini_window (w); >> ... should resize the mini_window down to one line ... > > That's exactly what happens, except that shrink_mini_window (w) does > *not* resize the miniwindow; it's still 6 lines height. So Too bad. Anyway, this configuration is completely useless to get the original sizes back when we're done with the miniwindow. Could you try brute force as in the untested patch attached? martin --------------000102020806050305050002 Content-Type: text/plain; name="xdisp.c.diff" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="xdisp.c.diff" KioqIHhkaXNwLmMufjEuMTI5NS5+CTIwMDktMDgtMjAgMTA6NDc6MTkuNjg3NTAwMDAwICsw MjAwDQotLS0geGRpc3AuYwkyMDA5LTA5LTI0IDE3OjIzOjIzLjkzNzUwMDAwMCArMDIwMA0K KioqKioqKioqKioqKioqDQoqKiogODc4OSw4ODE2ICoqKioNCiAgCX0NCiAgICAgICAgZWxz ZQ0KICAJew0KISAJICAvKiBBbHdheXMgcmVzaXplIHRvIGV4YWN0IHNpemUgbmVlZGVkLiAg Ki8NCiEgCSAgaWYgKGhlaWdodCA+IFdJTkRPV19UT1RBTF9MSU5FUyAodykpDQohIAkgICAg ew0KISAJICAgICAgaW50IG9sZF9oZWlnaHQgPSBXSU5ET1dfVE9UQUxfTElORVMgKHcpOw0K ISAJICAgICAgZnJlZXplX3dpbmRvd19zdGFydHMgKGYsIDEpOw0KISAJICAgICAgZ3Jvd19t aW5pX3dpbmRvdyAodywgaGVpZ2h0IC0gV0lORE9XX1RPVEFMX0xJTkVTICh3KSk7DQohIAkg ICAgICB3aW5kb3dfaGVpZ2h0X2NoYW5nZWRfcCA9IFdJTkRPV19UT1RBTF9MSU5FUyAodykg IT0gb2xkX2hlaWdodDsNCiEgCSAgICB9DQohIAkgIGVsc2UgaWYgKGhlaWdodCA8IFdJTkRP V19UT1RBTF9MSU5FUyAodykpDQohIAkgICAgew0KISAJICAgICAgaW50IG9sZF9oZWlnaHQg PSBXSU5ET1dfVE9UQUxfTElORVMgKHcpOw0KISAJICAgICAgZnJlZXplX3dpbmRvd19zdGFy dHMgKGYsIDApOw0KISAJICAgICAgc2hyaW5rX21pbmlfd2luZG93ICh3KTsNCiEgDQohIAkg ICAgICBpZiAoaGVpZ2h0KQ0KISAJCXsNCiEgCQkgIGZyZWV6ZV93aW5kb3dfc3RhcnRzIChm LCAxKTsNCiEgCQkgIGdyb3dfbWluaV93aW5kb3cgKHcsIGhlaWdodCAtIFdJTkRPV19UT1RB TF9MSU5FUyAodykpOw0KISAJCX0NCiEgDQohIAkgICAgICB3aW5kb3dfaGVpZ2h0X2NoYW5n ZWRfcCA9IFdJTkRPV19UT1RBTF9MSU5FUyAodykgIT0gb2xkX2hlaWdodDsNCiEgCSAgICB9 DQogIAl9DQogIA0KICAgICAgICBpZiAob2xkX2N1cnJlbnRfYnVmZmVyKQ0KLS0tIDg3ODks ODc5OSAtLS0tDQogIAl9DQogICAgICAgIGVsc2UNCiAgCXsNCiEgCSAgaW50IG9sZF9oZWln aHQgPSBXSU5ET1dfVE9UQUxfTElORVMgKHcpOw0KISAJICBmcmVlemVfd2luZG93X3N0YXJ0 cyAoZiwgMSk7DQohIAkgIHNocmlua19taW5pX3dpbmRvdyAodyk7DQohIAkgIGdyb3dfbWlu aV93aW5kb3cgKHcsIGhlaWdodCAtIFdJTkRPV19UT1RBTF9MSU5FUyAodykpOw0KISAJICB3 aW5kb3dfaGVpZ2h0X2NoYW5nZWRfcCA9IFdJTkRPV19UT1RBTF9MSU5FUyAodykgIT0gb2xk X2hlaWdodDsNCiAgCX0NCiAgDQogICAgICAgIGlmIChvbGRfY3VycmVudF9idWZmZXIpDQo= --------------000102020806050305050002-- From lekktu@gmail.com Thu Sep 24 08:54:15 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 24 Sep 2009 15:54:16 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.2 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-fx0-f207.google.com (mail-fx0-f207.google.com [209.85.220.207]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8OFsEq1007984 for <4534@emacsbugs.donarmstrong.com>; Thu, 24 Sep 2009 08:54:15 -0700 Received: by fxm3 with SMTP id 3so1525653fxm.44 for <4534@emacsbugs.donarmstrong.com>; Thu, 24 Sep 2009 08:54:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=ltoIp+WYVfk4jLcGXSbVadYyUFsOdC0l1MKdxSr24F4=; b=fP0yeCQLxDI+FbB5abIjC4shhRSpgwRNM70GVISVLvV60bkT1ShUb38HAgwDBh/TmD IR1ySyupYrf6I756N/XBjLJOB1SZYUvV2CB4sTTJOdqZRaFFZrccbBGnFWo6i07zZ+M6 dsNumEsPAUY4ECxR38M3MPJO5J9roYOrJtLMA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=j0Xia9mPbwHFKMsHKAoVn3QMkZ+V4UJUwugfl6IFWGIJaJllihuiH7yFFh3JRtdiUq SBxJPROw7Qo8SSD3sqKlALo9Oj2f2pBHsgDVbEvH2CNjwrAbcvE+yTjy6xsNYyU4ETR2 ep92jUhTjsgm83DucQcDu+B0hEg108kLe1vYY= MIME-Version: 1.0 Received: by 10.239.182.137 with SMTP id q9mr361548hbg.72.1253807648160; Thu, 24 Sep 2009 08:54:08 -0700 (PDT) In-Reply-To: <4ABB9106.1090306@gmx.at> References: <4AB9CE11.9040300@gmx.at> <4ABA12BF.8070205@gmx.at> <4ABB167A.4070801@gmx.at> <4ABB9106.1090306@gmx.at> From: Juanma Barranquero Date: Thu, 24 Sep 2009 17:53:48 +0200 Message-ID: Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window To: martin rudalics Cc: 4534@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, Sep 24, 2009 at 17:32, martin rudalics wrote: > Too bad. =C2=A0Anyway, this configuration is completely useless to get th= e > original sizes back when we're done with the miniwindow. =C2=A0Could you = try > brute force as in the untested patch attached? With that patch, and emacs -Q --eval "(setq resize-mini-windows t)" the assertion triggers (delta =3D=3D -1) as soon as I hit C-x Juanma From rudalics@gmx.at Thu Sep 24 09:11:02 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 24 Sep 2009 16:11:02 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.8 required=4.0 tests=AWL,HAS_BUG_NUMBER,MIXEDBDN, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with SMTP id n8OGB0LN011046 for <4534@emacsbugs.donarmstrong.com>; Thu, 24 Sep 2009 09:11:01 -0700 Received: (qmail invoked by alias); 24 Sep 2009 16:10:54 -0000 Received: from 62-47-37-172.adsl.highway.telekom.at (EHLO [62.47.37.172]) [62.47.37.172] by mail.gmx.net (mp056) with SMTP; 24 Sep 2009 18:10:54 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+gW1l6xVugezLV6HKsN+HRJ1BGIK8GfUD1qGonK/ BwckweuHinioGA Message-ID: <4ABB99E4.6030200@gmx.at> Date: Thu, 24 Sep 2009 18:10:12 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Juanma Barranquero CC: 4534@debbugs.gnu.org Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window References: <4AB9CE11.9040300@gmx.at> <4ABA12BF.8070205@gmx.at> <4ABB167A.4070801@gmx.at> <4ABB9106.1090306@gmx.at> In-Reply-To: Content-Type: multipart/mixed; boundary="------------090102070305030309060702" X-Y-GMX-Trusted: 0 X-FuHaFi: 0.75,0.57 This is a multi-part message in MIME format. --------------090102070305030309060702 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > With that patch, and > > emacs -Q --eval "(setq resize-mini-windows t)" > > the assertion triggers (delta == -1) as soon as I hit C-x Because I removed the corresponding check. Please try again. martin --------------090102070305030309060702 Content-Type: text/plain; name="xdisp.c.diff" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="xdisp.c.diff" KioqIHhkaXNwLmMufjEuMTI5NS5+CTIwMDktMDgtMjAgMTA6NDc6MTkuNjg3NTAwMDAwICsw MjAwDQotLS0geGRpc3AuYwkyMDA5LTA5LTI0IDE4OjA0OjE4LjM0Mzc1MDAwMCArMDIwMA0K KioqKioqKioqKioqKioqDQoqKiogODc4OSw4ODE2ICoqKioNCiAgCX0NCiAgICAgICAgZWxz ZQ0KICAJew0KISAJICAvKiBBbHdheXMgcmVzaXplIHRvIGV4YWN0IHNpemUgbmVlZGVkLiAg Ki8NCiAgCSAgaWYgKGhlaWdodCA+IFdJTkRPV19UT1RBTF9MSU5FUyAodykpDQohIAkgICAg ew0KISAJICAgICAgaW50IG9sZF9oZWlnaHQgPSBXSU5ET1dfVE9UQUxfTElORVMgKHcpOw0K ISAJICAgICAgZnJlZXplX3dpbmRvd19zdGFydHMgKGYsIDEpOw0KISAJICAgICAgZ3Jvd19t aW5pX3dpbmRvdyAodywgaGVpZ2h0IC0gV0lORE9XX1RPVEFMX0xJTkVTICh3KSk7DQohIAkg ICAgICB3aW5kb3dfaGVpZ2h0X2NoYW5nZWRfcCA9IFdJTkRPV19UT1RBTF9MSU5FUyAodykg IT0gb2xkX2hlaWdodDsNCiEgCSAgICB9DQohIAkgIGVsc2UgaWYgKGhlaWdodCA8IFdJTkRP V19UT1RBTF9MSU5FUyAodykpDQohIAkgICAgew0KISAJICAgICAgaW50IG9sZF9oZWlnaHQg PSBXSU5ET1dfVE9UQUxfTElORVMgKHcpOw0KISAJICAgICAgZnJlZXplX3dpbmRvd19zdGFy dHMgKGYsIDApOw0KISAJICAgICAgc2hyaW5rX21pbmlfd2luZG93ICh3KTsNCiEgDQohIAkg ICAgICBpZiAoaGVpZ2h0KQ0KISAJCXsNCiEgCQkgIGZyZWV6ZV93aW5kb3dfc3RhcnRzIChm LCAxKTsNCiEgCQkgIGdyb3dfbWluaV93aW5kb3cgKHcsIGhlaWdodCAtIFdJTkRPV19UT1RB TF9MSU5FUyAodykpOw0KISAJCX0NCiEgDQohIAkgICAgICB3aW5kb3dfaGVpZ2h0X2NoYW5n ZWRfcCA9IFdJTkRPV19UT1RBTF9MSU5FUyAodykgIT0gb2xkX2hlaWdodDsNCiEgCSAgICB9 DQogIAl9DQogIA0KICAgICAgICBpZiAob2xkX2N1cnJlbnRfYnVmZmVyKQ0KLS0tIDg3ODks ODgwMCAtLS0tDQogIAl9DQogICAgICAgIGVsc2UNCiAgCXsNCiEgCSAgaW50IG9sZF9oZWln aHQgPSBXSU5ET1dfVE9UQUxfTElORVMgKHcpOw0KISAJICBmcmVlemVfd2luZG93X3N0YXJ0 cyAoZiwgMSk7DQohIAkgIHNocmlua19taW5pX3dpbmRvdyAodyk7DQogIAkgIGlmIChoZWln aHQgPiBXSU5ET1dfVE9UQUxfTElORVMgKHcpKQ0KISAJICAgIGdyb3dfbWluaV93aW5kb3cg KHcsIGhlaWdodCAtIFdJTkRPV19UT1RBTF9MSU5FUyAodykpOw0KISAJICB3aW5kb3dfaGVp Z2h0X2NoYW5nZWRfcCA9IFdJTkRPV19UT1RBTF9MSU5FUyAodykgIT0gb2xkX2hlaWdodDsN CiAgCX0NCiAgDQogICAgICAgIGlmIChvbGRfY3VycmVudF9idWZmZXIpDQo= --------------090102070305030309060702-- From lekktu@gmail.com Thu Sep 24 09:23:13 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 24 Sep 2009 16:23:14 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.4 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.155]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8OGNBjN012788 for <4534@emacsbugs.donarmstrong.com>; Thu, 24 Sep 2009 09:23:13 -0700 Received: by fg-out-1718.google.com with SMTP id 16so574313fgg.13 for <4534@emacsbugs.donarmstrong.com>; Thu, 24 Sep 2009 09:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=PRwQX6v8SxiDYMAR/tkCYAXzgnMq+ebxVPYkYdK08E0=; b=aShxGIB7w4lRXczSNjFGOUePhzIjjOVaXJjwJyCmr0c8Z2x3pt2Gr+5RgmeT7njKN7 MjuiP/6lXGAJ3la/lssQk+9swdx03Uvk48TdL+YY3pLUFIk+A7966Cmj++FdEUHVkBm/ xud2rynruUbTYVpua7Agp6gwAD5C7NWRu5HDg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=B+len4eFn5NzZbrORJA2YvMjzCOEcrKkmX+Z2Q0inOZD48uuGnl6SUv1bdNNf0EZ6H mp7oq72Nhp8WzO32YbKgOnxmufaiQxhjQMYUqHYJ0xDbbf5bGJgl9eoC6u+C1EMMRtBX CGC572Rh5arMeKbVJK5mAudecTa65+beeVKyE= MIME-Version: 1.0 Received: by 10.239.142.155 with SMTP id g27mr342928hba.62.1253809391138; Thu, 24 Sep 2009 09:23:11 -0700 (PDT) In-Reply-To: <4ABB99E4.6030200@gmx.at> References: <4AB9CE11.9040300@gmx.at> <4ABA12BF.8070205@gmx.at> <4ABB167A.4070801@gmx.at> <4ABB9106.1090306@gmx.at> <4ABB99E4.6030200@gmx.at> From: Juanma Barranquero Date: Thu, 24 Sep 2009 18:22:51 +0200 Message-ID: Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window To: martin rudalics Cc: 4534@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, Sep 24, 2009 at 18:10, martin rudalics wrote: > Because I removed the corresponding check. =C2=A0Please try again. Yeah, it works now. Cool. Juanma From rudalics@gmx.at Thu Sep 24 10:35:58 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 24 Sep 2009 17:35:59 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.3 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with SMTP id n8OHZuoB026883 for <4534@emacsbugs.donarmstrong.com>; Thu, 24 Sep 2009 10:35:58 -0700 Received: (qmail invoked by alias); 24 Sep 2009 17:35:51 -0000 Received: from 62-47-37-172.adsl.highway.telekom.at (EHLO [62.47.37.172]) [62.47.37.172] by mail.gmx.net (mp047) with SMTP; 24 Sep 2009 19:35:51 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18SL0dPgosSw1Jr4b1EeVuy1728P0cE+S4tyoxN/7 6BoZLsK1B4zIcW Message-ID: <4ABBADF6.9040509@gmx.at> Date: Thu, 24 Sep 2009 19:35:50 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Juanma Barranquero CC: 4534@debbugs.gnu.org Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window References: <4AB9CE11.9040300@gmx.at> <4ABA12BF.8070205@gmx.at> <4ABB167A.4070801@gmx.at> <4ABB9106.1090306@gmx.at> <4ABB99E4.6030200@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.78 > Yeah, it works now. Cool. Not really. Exactly 10 years now that Gerd checked in grow_mini_window and shrink_mini_window and apparently this bug has never been triggered in all that time. We could make `resize-mini-windows' a defcustom to find more such bugs. Or make it t by default ;-) martin From monnier@IRO.UMontreal.CA Thu Sep 24 10:36:35 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 24 Sep 2009 17:36:36 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.1 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from pruche.dit.umontreal.ca (pruche.dit.umontreal.ca [132.204.246.22]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8OHaXfY026897 for <4534@emacsbugs.donarmstrong.com>; Thu, 24 Sep 2009 10:36:35 -0700 Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n8OHaWoX003908; Thu, 24 Sep 2009 13:36:32 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id CE0453A122; Thu, 24 Sep 2009 13:36:32 -0400 (EDT) From: Stefan Monnier To: Juanma Barranquero Cc: 4534@debbugs.gnu.org, martin rudalics Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window Message-ID: References: <4AB9CE11.9040300@gmx.at> <4ABA12BF.8070205@gmx.at> <4ABB167A.4070801@gmx.at> <4ABB9106.1090306@gmx.at> Date: Thu, 24 Sep 2009 13:36:32 -0400 In-Reply-To: (Juanma Barranquero's message of "Thu, 24 Sep 2009 17:53:48 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3370=0 >> Too bad. =A0Anyway, this configuration is completely useless to get the >> original sizes back when we're done with the miniwindow. =A0Could you try >> brute force as in the untested patch attached? > With that patch, and > emacs -Q --eval "(setq resize-mini-windows t)" > the assertion triggers (delta =3D=3D -1) as soon as I hit C-x Now that's more like it: a simple and consistent interface. Stefan "just feeling silly, please ignore" From lekktu@gmail.com Thu Sep 24 10:46:05 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 24 Sep 2009 17:46:05 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.2 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-bw0-f223.google.com (mail-bw0-f223.google.com [209.85.218.223]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8OHk34u028238 for <4534@emacsbugs.donarmstrong.com>; Thu, 24 Sep 2009 10:46:04 -0700 Received: by bwz23 with SMTP id 23so1693881bwz.1 for <4534@emacsbugs.donarmstrong.com>; Thu, 24 Sep 2009 10:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=NGNvz1iiKiqAlAo+CVLLfgLZBeg/pQFnycrWKweWox4=; b=eLcyIsTvH83Vs5uWabPwThWStEx4LeIJJWyYJUlcwsEF/qDPHIQrBSPAWlttU5j/Oe yptIBtWsPpLnhWcCNlYBlCQfgId/CPhG93/ZwaVfrnqXZk6zXTdTbFU7apjEeo3W8ue5 WJImX90PUqlhYuteWG51jqweX6L27tTJwY8Zc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=KcPDSXKrrNka0o6ZWuX5mZsecAaM/cp5hN4s6BS6vHcE+eC0fSToqvtoG6dd3dL1YV UFgDcvmBxXZiirkX5OmwSD2lBJvJsw1XL89MjgwaDMshDzQgrMqXGBBpq4DU27FLxxt0 VgKSFCcHKKXNWi1S5MdoTuZ3y5f05O76b8K+E= MIME-Version: 1.0 Received: by 10.239.151.3 with SMTP id p3mr333015hbb.200.1253814357102; Thu, 24 Sep 2009 10:45:57 -0700 (PDT) In-Reply-To: <4ABBADF6.9040509@gmx.at> References: <4ABA12BF.8070205@gmx.at> <4ABB167A.4070801@gmx.at> <4ABB9106.1090306@gmx.at> <4ABB99E4.6030200@gmx.at> <4ABBADF6.9040509@gmx.at> From: Juanma Barranquero Date: Thu, 24 Sep 2009 19:45:37 +0200 Message-ID: Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window To: martin rudalics Cc: 4534@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, Sep 24, 2009 at 19:35, martin rudalics wrote: > Not really. =C2=A0Exactly 10 years now that Gerd checked in grow_mini_win= dow > and shrink_mini_window and apparently this bug has never been triggered > in all that time. I suppose my setup is somewhat non-typical. It's not the first time I stumble upon a bug that's been there for years, latent, waiting for an unsuspecting victim. At least it's been fast, not like the "missing LF in ChangeLogs" bug (#870) that I triggered dozens of times, Jason about two or three, and apparently no one else. It took me eight months to be able to reproduce it at will... > We could make `resize-mini-windows' a defcustom to find more such bugs. > Or make it t by default ;-) Yes, it's been a while since the last defaults-changing flamewar. :) Juanma From eliz@gnu.org Fri Sep 25 01:37:50 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 25 Sep 2009 08:37:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.4 required=4.0 tests=AWL,GMAIL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mtaout3.012.net.il (mtaout3.012.net.il [84.95.2.7]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8P8bmu0010443 for <4534@emacsbugs.donarmstrong.com>; Fri, 25 Sep 2009 01:37:49 -0700 Received: from conversion-daemon.i_mtaout3.012.net.il by i_mtaout3.012.net.il (HyperSendmail v2004.12) id <0KQI00G00Q8JJ100@i_mtaout3.012.net.il> for 4534@emacsbugs.donarmstrong.com; Fri, 25 Sep 2009 11:37:41 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.70.48.81]) by i_mtaout3.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KQI00M40QMSSXA0@i_mtaout3.012.net.il>; Fri, 25 Sep 2009 11:37:41 +0300 (IDT) Date: Fri, 25 Sep 2009 11:35:43 +0300 From: Eli Zaretskii Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window In-reply-to: X-012-Sender: halo1@inter.net.il To: Juanma Barranquero , 4534@debbugs.gnu.org Cc: rudalics@gmx.at Reply-to: Eli Zaretskii Message-id: <831vlvv2u8.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <4AB9CE11.9040300@gmx.at> <4ABA12BF.8070205@gmx.at> <4ABB167A.4070801@gmx.at> > From: Juanma Barranquero > Date: Thu, 24 Sep 2009 14:58:07 +0200 > Cc: 4534@emacsbugs.donarmstrong.com > > > Now if I replace the check > > > >              if (height) > > > > by > > > >              if (height > WINDOW_TOTAL_LINES (w)) > > > > I should be able to avoid the delta = -1 assertion failure in > > grow_mini_window.  Can you confirm my reasoning so far? > > It's correct. Except that, as shrink_mini_window didn't shrink the > window, it remains at 6 lines. Does this code cause an immediate redisplay? I think it doesn't, which means shrink_mini_window does not actually shrink the window, it just prepares the glyph matrices for that. The next redisplay will actually change how things are shown on the screen. From lekktu@gmail.com Fri Sep 25 04:31:06 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 25 Sep 2009 11:31:06 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.1 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-fx0-f207.google.com (mail-fx0-f207.google.com [209.85.220.207]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8PBV4Ln007617 for <4534@emacsbugs.donarmstrong.com>; Fri, 25 Sep 2009 04:31:05 -0700 Received: by fxm3 with SMTP id 3so2108541fxm.44 for <4534@emacsbugs.donarmstrong.com>; Fri, 25 Sep 2009 04:30:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=TN/oj2zJ5wtZiip/KyjRozQn5lmZGtJFmDgsPXxleEo=; b=DAh0UeLUTwR8vTLjNfxqRz0buN9b4LN4US+Grlk3bj+UOGkEO4tEPIxJY1op3R7VmT L4I7npnmkZh3xhIZY+W/1dtQqenm73jZhsXdltahKBLO5l23G9//2iBJDCz5BHpw+POj hDVMaX0/XUy6j89CsRPjnHTq5BP75k7xiH9xE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=TNb+f4Jv/q/PVPXwZ0RMgbKFpgBCUY6SKS0VaVKbLk7phqZ3a0bjwmP3vdUWURHnbB y2IfyCqVtZYuFWTUULiUgpPRRLBda9+PyanbVmgHiVVClbO4GIAwQtFYfaKAaUemNHkP dcDfbuSRLoHKVPqMa8mSG45IQEttj6h0zaFg0= MIME-Version: 1.0 Received: by 10.239.144.90 with SMTP id n26mr1859hba.133.1253878258261; Fri, 25 Sep 2009 04:30:58 -0700 (PDT) In-Reply-To: <831vlvv2u8.fsf@gnu.org> References: <4AB9CE11.9040300@gmx.at> <4ABA12BF.8070205@gmx.at> <4ABB167A.4070801@gmx.at> <831vlvv2u8.fsf@gnu.org> From: Juanma Barranquero Date: Fri, 25 Sep 2009 13:30:38 +0200 Message-ID: Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window To: Eli Zaretskii Cc: 4534@debbugs.gnu.org, rudalics@gmx.at Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, Sep 25, 2009 at 10:35, Eli Zaretskii wrote: > Does this code cause an immediate redisplay? =C2=A0I think it doesn't, > which means shrink_mini_window does not actually shrink the window, it > just prepares the glyph matrices for that. =C2=A0The next redisplay will > actually change how things are shown on the screen. Hmm. The "else" part of shrink_mini_window (which works, in this case, if you force it to go that route) definitely shrinks the window: Lisp_Object window; XSETWINDOW (window, w); enlarge_window (window, 1 - XFASTINT (w->total_lines), 0); As for the "if" part, I think you're right. Anyway, the last patch by Martin worked as expected, at least for this bug. Is there any downside to it? Juanma From eliz@gnu.org Fri Sep 25 06:16:51 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 25 Sep 2009 13:16:51 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.4 required=4.0 tests=AWL,GMAIL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mtaout3.012.net.il (mtaout4.012.net.il [84.95.2.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8PDGngH024323 for <4534@emacsbugs.donarmstrong.com>; Fri, 25 Sep 2009 06:16:51 -0700 Received: from conversion-daemon.i_mtaout3.012.net.il by i_mtaout3.012.net.il (HyperSendmail v2004.12) id <0KQJ009003A0YJ00@i_mtaout3.012.net.il> for 4534@emacsbugs.donarmstrong.com; Fri, 25 Sep 2009 16:16:43 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.70.48.81]) by i_mtaout3.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KQJ001EM3JUYDC0@i_mtaout3.012.net.il>; Fri, 25 Sep 2009 16:16:43 +0300 (IDT) Date: Fri, 25 Sep 2009 16:14:45 +0300 From: Eli Zaretskii Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window In-reply-to: X-012-Sender: halo1@inter.net.il To: Juanma Barranquero Cc: 4534@debbugs.gnu.org, rudalics@gmx.at Reply-to: Eli Zaretskii Message-id: <83pr9ftbcq.fsf@gnu.org> References: <4AB9CE11.9040300@gmx.at> <4ABA12BF.8070205@gmx.at> <4ABB167A.4070801@gmx.at> <831vlvv2u8.fsf@gnu.org> > From: Juanma Barranquero > Date: Fri, 25 Sep 2009 13:30:38 +0200 > Cc: 4534@emacsbugs.donarmstrong.com, rudalics@gmx.at > > Anyway, the last patch by Martin worked as expected, at least for this > bug. Is there any downside to it? I don't think so, I just wanted to maybe help explain the confusing behavior. From lekktu@gmail.com Fri Sep 25 07:08:57 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 25 Sep 2009 14:08:57 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.2 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-bw0-f223.google.com (mail-bw0-f223.google.com [209.85.218.223]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8PE8thN002363 for <4534@emacsbugs.donarmstrong.com>; Fri, 25 Sep 2009 07:08:56 -0700 Received: by bwz23 with SMTP id 23so2360751bwz.1 for <4534@emacsbugs.donarmstrong.com>; Fri, 25 Sep 2009 07:08:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=2YEdmEbIY+H0XXZDSXv/8PidRJKpac+s5IX1B6NPOy4=; b=g8S7PIOOV3T4hGdyhB/+I/ik/MHFSZPgVFOMErSbN1cbXfXBOmcEhuij2OBSK6RVQy BZGJIa06yvzloIpoOOvksXAk+hrH+kE6T6VWNfq/IdkqxfGBO8uDJa/GgqlqlFXNm2PP jZRugks3IHqdtvjdBGjaLeas6cRP4bAoswj3E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=TaPVUeyl2O26dHrKwT5icvoOmW+3VBsHLMq9SgBDeqt2d2M+FQUVvQeXV5M7jRnb31 dtQDUguYdg4jWo1dpPzDWrNUahztOpZZzFfjz+bD6ic8ejSjHQ8RF1zwzHOQJLvRj4ET vmEJBl4Zl883VZ22NCN7Uidiya/3+XKV0LJQI= MIME-Version: 1.0 Received: by 10.239.181.151 with SMTP id m23mr15784hbg.190.1253887729156; Fri, 25 Sep 2009 07:08:49 -0700 (PDT) In-Reply-To: <83pr9ftbcq.fsf@gnu.org> References: <4AB9CE11.9040300@gmx.at> <4ABA12BF.8070205@gmx.at> <4ABB167A.4070801@gmx.at> <831vlvv2u8.fsf@gnu.org> <83pr9ftbcq.fsf@gnu.org> From: Juanma Barranquero Date: Fri, 25 Sep 2009 16:08:29 +0200 Message-ID: Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window To: Eli Zaretskii Cc: 4534@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 On Fri, Sep 25, 2009 at 15:14, Eli Zaretskii wrote: > I don't think so, I just wanted to maybe help explain the confusing > behavior. And indeed you did. Thanks, Juanma From monnier@IRO.UMontreal.CA Fri Sep 25 10:53:24 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 25 Sep 2009 17:53:24 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from chene.dit.umontreal.ca (chene.dit.umontreal.ca [132.204.246.20]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8PHrLQW014021 for <4534@emacsbugs.donarmstrong.com>; Fri, 25 Sep 2009 10:53:23 -0700 Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n8PHrI20029351; Fri, 25 Sep 2009 13:53:18 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 95C3F3A1BA; Thu, 24 Sep 2009 18:03:55 -0400 (EDT) From: Stefan Monnier To: martin rudalics Cc: 4534@debbugs.gnu.org, Juanma Barranquero Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window Message-ID: References: <4AB9CE11.9040300@gmx.at> <4ABA12BF.8070205@gmx.at> <4ABB167A.4070801@gmx.at> <4ABB9106.1090306@gmx.at> <4ABB99E4.6030200@gmx.at> <4ABBADF6.9040509@gmx.at> Date: Thu, 24 Sep 2009 18:03:55 -0400 In-Reply-To: <4ABBADF6.9040509@gmx.at> (martin rudalics's message of "Thu, 24 Sep 2009 19:35:50 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0.5 X-NAI-Spam-Rules: 2 Rules triggered DATE_IN_PAST_12_24=0.5, RV3371=0 X-NAI-Spam-Level: > Not really. Exactly 10 years now that Gerd checked in grow_mini_window > and shrink_mini_window and apparently this bug has never been triggered > in all that time. IIUC, the bug triggered an assertion failure. Most Emacs users run without assertion checking, so that could explain the lack of ealier reports (many assertion failures don't actually cause a subsequent crash, they may not even cause a noticeable misbehavior in some cases). Stefan From lekktu@gmail.com Fri Sep 25 11:02:54 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 25 Sep 2009 18:02:54 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.1 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-fx0-f207.google.com (mail-fx0-f207.google.com [209.85.220.207]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8PI2qgu015694 for <4534@emacsbugs.donarmstrong.com>; Fri, 25 Sep 2009 11:02:54 -0700 Received: by fxm3 with SMTP id 3so2395587fxm.44 for <4534@emacsbugs.donarmstrong.com>; Fri, 25 Sep 2009 11:02:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=PCe8aObcHoHlORiH/Bo/+Qp2KEg3fwcFjQT5BeabYbE=; b=UmBVsmrlHZAQPZaSBNPKRaJ+y5jWOCKJD1Yea9sZrpo36WDJSB9tTw6fDjkB8kjhrm tcTCaq1oheCXrmFYCww2Ylu3nUB5jg3KkWgijW7+foTWFYW8ZoCFB/xfSH0EqD5zYTmP 3TeZEYK04JSo5AYjbdTtWklRiTTmXapdSrQVU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=V8TmhelbtutWwPuAKA6szZ2PYSxtezyy/wWjxey9BMa+ZKz+3teZP86tfgxBkyCY6L zilpsBAgBhkzoPx2fFgqvPEz8NXIzQGRzmoZ5ygXSsEm1ju79oyGjnpDMqTQIW2t7upE SKnwndEU9BoVaEOabxi/zj3UoNz8E7aypN2bc= MIME-Version: 1.0 Received: by 10.239.181.151 with SMTP id m23mr40964hbg.190.1253901766187; Fri, 25 Sep 2009 11:02:46 -0700 (PDT) In-Reply-To: References: <4ABB167A.4070801@gmx.at> <4ABB9106.1090306@gmx.at> <4ABB99E4.6030200@gmx.at> <4ABBADF6.9040509@gmx.at> From: Juanma Barranquero Date: Fri, 25 Sep 2009 20:02:26 +0200 Message-ID: Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window To: Stefan Monnier Cc: martin rudalics , 4534@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 On Fri, Sep 25, 2009 at 00:03, Stefan Monnier wrote: > IIUC, the bug triggered an assertion failure. Yes. xassert (delta >= 0); at window.c:4637 > Most Emacs users run > without assertion checking, so that could explain the lack of > ealier reports (many assertion failures don't actually cause > a subsequent crash, they may not even cause a noticeable misbehavior in > some cases). IMO, assertion checking should be enabled by default when compiling for debug. I use it continuously (on both debug and optimized builds) and Emacs is not noticeably slower; at least, not on the setups I've tried it. Juanma From lekktu@gmail.com Fri Oct 16 01:32:41 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 16 Oct 2009 08:32:42 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.7 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-ew0-f213.google.com (mail-ew0-f213.google.com [209.85.219.213]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9G8WdeR006570 for <4534@emacsbugs.donarmstrong.com>; Fri, 16 Oct 2009 01:32:41 -0700 Received: by ewy9 with SMTP id 9so1806160ewy.1 for <4534@emacsbugs.donarmstrong.com>; Fri, 16 Oct 2009 01:32:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=oASRwCbHScPX2ANlQfC3Bcx8ctwFuK7nY/7qDfKXQ3o=; b=mQEs6CRdltQM72M4HTqZVQH9Scbx8atJ+wGURMLqLYO0p4LQ3COSqqD97LacZkiABj UX3dUBTTcjPoeruLYocgvv6JT5rnKz9jXblIRCDzAlzvjn/ViRRbTO4eX5ZNilGT/KxZ 9zDcAB7HjTuYrFFOXDFFw16xQRSnboVbSmCHU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=XD5OTfwLVX4kXB5vhEU9thdLyDd5izfzfNhAC7tUG0Ewyyz61NZnEtHlNfvhBL/wtF +NliV32myuGgFWKKZQD82KTiwVgy6ubRc8iFZUWzhpqj/z6rasJSMmQ0FP62vm4N8Ich KH4D054IrQKUPSyYRrj2NfQLxlunq27/i2Ohk= MIME-Version: 1.0 Received: by 10.211.146.1 with SMTP id y1mr531642ebn.0.1255681954206; Fri, 16 Oct 2009 01:32:34 -0700 (PDT) In-Reply-To: References: <4ABB167A.4070801@gmx.at> <4ABB9106.1090306@gmx.at> <4ABB99E4.6030200@gmx.at> <4ABBADF6.9040509@gmx.at> From: Juanma Barranquero Date: Fri, 16 Oct 2009 10:32:14 +0200 Message-ID: Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window To: Stefan Monnier Cc: martin rudalics , 4534@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Martin spend a fair time debugging this problem, but he's now developing new window code (post 23.2) that will make this obsolete. AFAICS, the assertion is useless, because removing it causes no ill effect (i.e., the shrinking/growing minibuffer code seem to be able to cope with delta < 0). Even if it weren't so, most people are not running Emacs with xasserts enabled; so any trouble caused by the assertion not being true is not serious, or would likely have been reported already. So I'd suggest just commenting out the xassert. Thoughts? Juanma From lekktu@gmail.com Sat Oct 24 08:37:48 2009 Received: (at 4534) by emacsbugs.donarmstrong.com; 24 Oct 2009 15:37:48 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.3 required=4.0 tests=AWL,GMAIL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,SARE_LWSHORTT autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.26]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9OFbkIv028220 for <4534@emacsbugs.donarmstrong.com>; Sat, 24 Oct 2009 08:37:48 -0700 Received: by ey-out-2122.google.com with SMTP id 9so1898336eyd.15 for <4534@emacsbugs.donarmstrong.com>; Sat, 24 Oct 2009 08:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=EjOfdiKeg5Vj7fJv32tstmGR4Y7wL04oHRJg9/PILMQ=; b=RBzwxjIGSIWQ1XhubhVAYGjr3Pj2ainFoxkvNSkZEhichqJ8ucvM2pwLRMx6XhDGIt Rv3p/5Z6n1DWIapv0hMyiDZQyIm23GbN4HLlQsgadQFASrPZ9HsRlJrucmAJqQCuwYrv ABPkjmeo8ah2luci3+T+FAMUa04pIh7KeeXNU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=f1YaW0x87xhanO/IGCfZlpJ9hi6POJV62GSuzIxaUQLQNDKM2QlQfr0DdFKZ25Bd/l yaQeixaFWl+gkJj5ky6w30P5ru4njDriVBRFYFFcLk0XwR9QDiwa/g1b2q7PjLddD/1F Af0c3M3fBYaLQXMRh5sSt8SmmQxoOeFsVrVu8= MIME-Version: 1.0 Received: by 10.211.132.33 with SMTP id j33mr2065614ebn.20.1256398666114; Sat, 24 Oct 2009 08:37:46 -0700 (PDT) In-Reply-To: References: <4ABB9106.1090306@gmx.at> <4ABB99E4.6030200@gmx.at> <4ABBADF6.9040509@gmx.at> From: Juanma Barranquero Date: Sat, 24 Oct 2009 17:37:26 +0200 Message-ID: Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window To: Stefan Monnier Cc: martin rudalics , 4534@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 OK, unless someone opposes I'm going to commit the attached patch. Currently, both grow_mini_window() and shrink_window_lowest_first() do in fact accept negative deltas, and act accordingly; so, the names are misleading with respect to the actual behavior, if not the intent, of both functions. I'm not comfortable with this, but as Martin said he was going to rewrite the window code after 23.2, it's a short term situation anyway. Other than skipping a useless call to window_min_size() when delta < 0, the patch does not change current behavior, so for people building without -DXASSERTS it should not introduce any new bug. For those people with -DXASSERTS, the patch in fact avoids an unnecessary exception and allows Emacs to continue without incident. That means there's no obvious downside to this change; even assuming there's a problem with negative deltas in grow_mini_window(), etc., it is better to let the negative delta go through with the hope that it will cause a traceable bug. Most people does not have -DXASSERTS, though, and not such bug has even been reported. Juanma 2009-10-24 Juanma Barranquero * window.c (grow_mini_window): Comment out "delta >= 0" assertion. For delta < 0, skip check that only makes sense when the mini-window is going to be enlarged. (Bug#4534) Index: src/window.c =================================================================== RCS file: /cvsroot/emacs/emacs/src/window.c,v retrieving revision 1.642 diff -u -2 -r1.642 window.c --- src/window.c 23 Oct 2009 17:52:57 -0000 1.642 +++ src/window.c 24 Oct 2009 15:33:16 -0000 @@ -4649,10 +4649,13 @@ xassert (MINI_WINDOW_P (w)); - xassert (delta >= 0); + /* Commenting out the following assertion goes against the stated interface + of this function, but it currently does not seem to do anything useful. + See discussion of this issue in the thread for bug#4534. + xassert (delta >= 0); */ /* Compute how much we can enlarge the mini-window without deleting other windows. */ root = XWINDOW (FRAME_ROOT_WINDOW (f)); - if (delta) + if (delta > 0) { int min_height = window_min_size (root, 0, 0, 0, 0); From lekktu@gmail.com Mon Oct 26 03:06:16 2009 Received: (at 4534-done) by emacsbugs.donarmstrong.com; 26 Oct 2009 10:06:17 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.3 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.25]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9QA6Ebb009340 for <4534-done@emacsbugs.donarmstrong.com>; Mon, 26 Oct 2009 03:06:16 -0700 Received: by ey-out-2122.google.com with SMTP id 9so2086056eyd.15 for <4534-done@emacsbugs.donarmstrong.com>; Mon, 26 Oct 2009 03:06:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=2h7fByyceiUQ5REnRz/se0wqFG9JYhFrGmUDSctkAek=; b=qJkoHAShTw3XeAb7wymEvqSes9FCDWFSqSUSofmhPPTuZyifT4tRljDxhMTOoyMWqK MPwWaoRl/m3K1CllS/94Toldsc597bsEUZV5IGYAXKrhxB3+AQVdC1USKl75iA+EML+1 /RXrB2V89aGEemXqOg9XzDCbRkPbkycbPFCEU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=tCz6eKJ5q13l1RL/uLS+ss4qeEmo+4rkjXheeNPl5UOr+erkdcVjZSjJzeKdtPX4bf f5EPXzUvXwu9KFq7GyHO7PTDI7hpx6ChSLT3C3OxIvbVQ06ddeTK1D0clEGMyU8yjVLD UTYetGfOBTMaPmdixicSSKL38pi6cKvTfIy6I= MIME-Version: 1.0 Received: by 10.211.128.9 with SMTP id f9mr5188850ebn.93.1256551574131; Mon, 26 Oct 2009 03:06:14 -0700 (PDT) In-Reply-To: References: <4ABB9106.1090306@gmx.at> <4ABB99E4.6030200@gmx.at> <4ABBADF6.9040509@gmx.at> From: Juanma Barranquero Date: Mon, 26 Oct 2009 11:05:54 +0100 Message-ID: Subject: Re: bug#4534: assertion failure at window.c:grow_mini_window To: Stefan Monnier Cc: martin rudalics , 4534-done@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 > OK, unless someone opposes I'm going to commit the attached patch. Done. Juanma From unknown Tue Jun 24 05:08:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 23 Nov 2009 15:24:13 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A long time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator