GNU bug report logs - #45330
28.0.50; debbugs-gnu: Can't select reports before having started Gnus

Previous Next

Full log

View this message in rfc822 format

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 45330 <at> debbugs.gnu.org
Subject: bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
Date: Thu, 23 Dec 2021 14:42:04 -0800

[Message part 1 (text/plain, inline)]

On 12/12/21 03:46 AM, Michael Heerdegen wrote:
> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> I can switch the test to be something more explicit, but how about --
>
> Please let's not forget about this again.
>
> What has yet to be done to fix this issue?

Okay, dang it, here we go. Having thought about it, it seems like the
solutions might be simpler than I thought. `gnus-registry-initialize'
looks like this:

(defun gnus-registry-initialize ()
  "Initialize the Gnus registry."
  (interactive)
  (gnus-message 5 "Initializing the registry")
  (gnus-registry-install-hooks) => sets gnus-registry-enabled = t
  (gnus-registry-install-shortcuts)
  (if (gnus-alive-p)
      (gnus-registry-load)
    (add-hook 'gnus-read-newsrc-el-hook #'gnus-registry-load)))

It makes no sense to set `gnus-registry-enabled' to t when we haven't
fully loaded the registry. How about we move
`gnus-registry-install-hooks' and `gnus-registry-install-shortcuts' into
`gnus-registry-load', after the actual loading, a la the attached patch?
Does this solve the problems you're seeing?

Eric

[gnusregistryguard.diff (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.