Subject: bug#45300: closed (Re: bug#45300: [PATCH] Add option --with-patch)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 27 Dec 2020 16:26:03 +0000

Your bug report

#45300: [Suggestion] Add option --with-patch

which was filed against the guix package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
45300: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=45300
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#45300: [PATCH] Add option --with-patch
From: Ludovic Courtès <[email-masked]>
To: Philippe SWARTVAGHER <[email-masked]>
Cc: [email-masked]
Date: Sun, 27 Dec 2020 17:25:43 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Ludovic Courtès <[email-masked]> skribis:

>>>From 12c8df7c61537e3834fac4bf0e8e340cbac2d2df Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= <[email-masked]>
> Date: Mon, 21 Dec 2020 14:52:38 +0100
> Subject: [PATCH] transformations: Add '--with-patch'.
>
> Suggested by Philippe Swartvagher <[email-masked]>.
>
> * guix/transformations.scm (transform-package-patches): New procedure.
> (%transformations): Add it as 'with-patch'.
> (%transformation-options, show-transformation-options-help/detailed):
> Add '--with-patch'.
> * tests/transformations.scm ("options->transformation, with-patch"): New
> test.
> * doc/guix.texi (Package Transformation Options): Document it.

Pushed as e38d90d497e19e00263fa28961c688a433154386!

Ludo’.

Subject: [Suggestion] Add option --with-patch
From: Philippe SWARTVAGHER <[email-masked]>
To: [email-masked]
Date: Thu, 17 Dec 2020 12:42:34 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

We already have `--with-branch=`, `with-commit=`, ... An additional
option could be `--with-patch=package=add-extra-feature.patch` which
would apply the patch file `add-extra-feature.patch` located in the my
current directory to the sources of `package` before Guix starts
building `package`.

This would bring the possibility to easily share patches (for tests,
reviews, ... for instance) without having to commit the patch in the
source repository of the package, without changing the package
definition, and without applying ourselves the patch to our local source
repository of the package.

Thanks !

-- 
Philippe SWARTVAGHER

PhD Student
TADaaM team, Inria Bordeaux Sud-Ouest