GNU bug report logs - #45293
[PATCH] gnu: Add skim.

Previous Next

Package: guix-patches;

Reported by: Z572 <873216071 <at> qq.com>

Date: Thu, 17 Dec 2020 13:11:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: John Soo <jsoo1 <at> asu.edu>
To: Z572 <873216071 <at> qq.com>
Cc: 45293 <at> debbugs.gnu.org
Subject: [bug#45293] [PATCH] gnu: Add skim.
Date: Sun, 24 Jan 2021 10:46:07 -0800
Hello,

I made some patches for skim also. Yours look good but there are some
extras not installed. In particular the manpages, vim plugins and shell
completions are missing. Can you add something like the following to the
#:phases part of the arguments?

(modify-phases %standard-phases
  (add-after 'install 'install-extras
    (lambda* (#:key outputs #:allow-other-keys)
      (let* ((out (assoc-ref outputs "out"))
             (bin (string-append out "/bin"))
             (share (string-append out "/share"))
             (man (string-append out "/share/man"))
             (vimfiles (string-append share "/vim/vimfiles/plugin"))
             (bash-completion (string-append share "/bash-completions/completions"))
             (zsh-site (string-append share "/zsh/site-functions"))
             (fish-vendor (string-append share "/fish/vendor-completions.d")))
        ;; Binaries
        (for-each
         (lambda (binary) (install-file binary bin))
         (find-files "bin"))
        (mkdir-p share)
        ;; Manpages
        (copy-recursively "man" man)
        ;; Vim plugins
        (mkdir-p vimfiles)
        (copy-recursively "plugin" vimfiles)
        ;; Completions
        (mkdir-p bash-completion)
        (copy-file
         "shell/completion.bash"
         (string-append bash-completion "/skim"))
        (copy-file
         "shell/key-bindings.bash"
         (string-append bash-completion "/skim-bindings"))
        (mkdir-p zsh-site)
        (copy-file
         "shell/completion.zsh"
         (string-append zsh-site "/_skim"))
        (copy-file
         "shell/key-bindings.zsh"
         (string-append zsh-site "/_skim-bindings"))
        (mkdir-p fish-vendor)
        (copy-file
         "shell/key-bindings.fish"
         (string-append fish-vendor "/skim-bindings.fish"))))))

Thanks!

John




This bug report was last modified 4 years and 105 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.