From unknown Mon Jun 23 02:25:37 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4528: list/term/ns-win.el should not fiddle with the standard menus Reply-To: Dan Nicolaescu , 4528@debbugs.gnu.org Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Tue, 22 Sep 2009 21:55:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 4528 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12536562624728 (code B ref -1); Tue, 22 Sep 2009 21:55:05 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 22 Sep 2009 21:51:02 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.0 required=4.0 tests=AWL,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8MLp0i6004724 for ; Tue, 22 Sep 2009 14:51:01 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MqDGG-0005Ul-4A for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2009 17:51:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MqDGA-0005UZ-I2 for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2009 17:50:58 -0400 Received: from [199.232.76.173] (port=54124 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqDGA-0005UW-EB for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2009 17:50:54 -0400 Received: from barrelv2.ics.uci.edu ([128.195.1.114]:49568) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MqDG9-0005Yv-SX for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2009 17:50:54 -0400 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n8MLmuAn016350 for ; Tue, 22 Sep 2009 14:48:56 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n8MLmtoG020207; Tue, 22 Sep 2009 14:48:55 -0700 (PDT) Date: Tue, 22 Sep 2009 14:48:55 -0700 (PDT) Message-Id: <200909222148.n8MLmtoG020207@godzilla.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs@gnu.org Lines: 77 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n8MLmuAn016350 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.209, required 5, autolearn=disabled, ALL_TRUSTED -1.44, TW_FN 0.08, TW_LV 0.08, TW_PL 0.08) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) The code below in list/term/ns-win.el is better put in menu-bar.el where the menus are defined, just make it conditional there. That would avoid having to preload easymenu.el on this platform (no other platform does that) and would simplify the code (no need to play games with removing menu items). ;; Add a couple of menus and rearrange some others; easiest just to redo toplvl ;; Note keymap defns must be given last-to-first (define-key global-map [menu-bar] (make-sparse-keymap "menu-bar")) (setq menu-bar-final-items (cond ((eq system-type 'darwin) '(buffer windows services help-menu)) ;; Otherwise, GNUstep. (t '(buffer windows services hide-app quit)))) ;; Add standard top-level items to GNUstep menu. (unless (eq system-type 'darwin) (define-key global-map [menu-bar quit] '("Quit" . save-buffers-kill-emacs)) (define-key global-map [menu-bar hide-app] '("Hide" . ns-do-hide-emacs))) (define-key global-map [menu-bar services] (cons "Services" (make-sparse-keymap "Services"))) (define-key global-map [menu-bar buffer] (cons "Buffers" global-buffers-menu-map)) ;; (cons "Buffers" (make-sparse-keymap "Buffers"))) (define-key global-map [menu-bar tools] (cons "Tools" menu-bar-tools-menu)) (define-key global-map [menu-bar options] (cons "Options" menu-bar-options-menu)) (define-key global-map [menu-bar edit] (cons "Edit" menu-bar-edit-menu)) (define-key global-map [menu-bar file] (cons "File" menu-bar-file-menu)) ;; If running under GNUstep, rename "Help" to "Info" (cond ((eq system-type 'darwin) (define-key global-map [menu-bar help-menu] (cons "Help" menu-bar-help-menu))) (t (let ((contents (reverse (cdr menu-bar-help-menu)))) (setq menu-bar-help-menu (append (list 'keymap) (cdr contents) (list "Info")))) (define-key global-map [menu-bar help-menu] (cons "Info" menu-bar-help-menu)))) (if (not (eq system-type 'darwin)) ;; in OS X it's in the app menu already (define-key menu-bar-help-menu [info-panel] '("About Emacs..." . ns-do-emacs-info-panel))) ;;;; Edit menu: Modify slightly ;; Substitute a Copy function that works better under X (for GNUstep). (easy-menu-remove-item global-map '("menu-bar" "edit") 'copy) (define-key-after menu-bar-edit-menu [copy] '(menu-item "Copy" ns-copy-including-secondary :enable mark-active :help "Copy text in region between mark and current position") 'cut) ;; Change to same precondition as select-and-paste, as we don't have ;; `x-selection-exists-p'. (easy-menu-remove-item global-map '("menu-bar" "edit") 'paste) (define-key-after menu-bar-edit-menu [paste] '(menu-item "Paste" yank :enable (and (cdr yank-menu) (not buffer-read-only)) :help "Paste (yank) text most recently cut/copied") 'copy) ;; Change text to be more consistent with surrounding menu items `paste', etc. (easy-menu-remove-item global-map '("menu-bar" "edit") 'paste-from-menu) (define-key-after menu-bar-edit-menu [select-paste] '(menu-item "Select and Paste" yank-menu :enable (and (cdr yank-menu) (not buffer-read-only)) :help "Choose a string from the kill ring and paste it") 'paste) From rgm@gnu.org Mon Sep 28 18:15:30 2009 Received: (at control) by emacsbugs.donarmstrong.com; 29 Sep 2009 01:15:30 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.5 required=4.0 tests=AWL,ONEWORD,VALID_BTS_CONTROL, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8T1FSnq011937 for ; Mon, 28 Sep 2009 18:15:29 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1MsRJO-0004kk-WE; Mon, 28 Sep 2009 21:15:27 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19137.24494.912438.999717@fencepost.gnu.org> Date: Mon, 28 Sep 2009 21:15:26 -0400 From: Glenn Morris To: control Subject: control X-Debbugs-No-Ack: yes severity 4571 minor severity 4568 minor reassign 4529 emacs,ns severity 4268 wishlist severity 4019 wishlist reassign 4019 emacs,cc-mode close 4464 reassign 4528 emacs,ns From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 09 19:30:12 2011 Received: (at control) by debbugs.gnu.org; 10 Mar 2011 00:30:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PxTlb-0004Qv-PI for submit@debbugs.gnu.org; Wed, 09 Mar 2011 19:30:12 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PxTla-0004GH-Ew for control@debbugs.gnu.org; Wed, 09 Mar 2011 19:30:10 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1PxTlV-0003Il-7x for control@debbugs.gnu.org; Wed, 09 Mar 2011 19:30:05 -0500 Date: Wed, 09 Mar 2011 19:30:05 -0500 Message-Id: Subject: control message for bug 4528 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) close 4528 24.1