GNU bug report logs - #45279
[core-updates] copy-recursively does not throw an error on missing directory

Previous Next

To reply to this bug, email your comments to 45279 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: bug-guix <at> gnu.org
Subject: [core-updates] copy-recursively does not throw an error on missing
 directory
Date: Wed, 16 Dec 2020 22:26:37 +0100

[Message part 1 (text/plain, inline)]

Hello,

On the 'core-updates' branch, using copy-recursively on a nonexistent
directory does not cause a build failure.  Instead an error is printed
and the script continues:

  (copy-recursively "doesnotexist" output)
  [...]
  starting phase `install'
  i/o error: doesnotexist: No such file or directory
  phase `install' succeeded after 0.0 seconds

This is on cc6cb6e80a42355147809b4830053a34d1563994.

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 45279 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Marius Bakke <marius <at> gnu.org>
Cc: 45279 <at> debbugs.gnu.org
Subject: Re: bug#45279: [core-updates] copy-recursively does not throw an
 error on missing directory
Date: Thu, 17 Dec 2020 12:03:21 +0100

Hi,

Marius Bakke <marius <at> gnu.org> skribis:

> On the 'core-updates' branch, using copy-recursively on a nonexistent
> directory does not cause a build failure.  Instead an error is printed
> and the script continues:
>
>   (copy-recursively "doesnotexist" output)
>   [...]
>   starting phase `install'
>   i/o error: doesnotexist: No such file or directory
>   phase `install' succeeded after 0.0 seconds
>
> This is on cc6cb6e80a42355147809b4830053a34d1563994.

I think it’s always been this way.  Do you think we should change it?

Thanks,
Ludo’.

Message #11 received at 45279 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Ludovic Courtès <ludo <at> gnu.org>, Marius Bakke
 <marius <at> gnu.org>
Cc: 45279 <at> debbugs.gnu.org
Subject: Re: bug#45279: [core-updates] copy-recursively does not throw an
 error on missing directory
Date: Thu, 17 Dec 2020 15:23:44 -0500

Ludovic Courtès <ludo <at> gnu.org> writes:

> Marius Bakke <marius <at> gnu.org> skribis:
>
>> On the 'core-updates' branch, using copy-recursively on a nonexistent
>> directory does not cause a build failure.  Instead an error is printed
>> and the script continues:
>>
>>   (copy-recursively "doesnotexist" output)
>>   [...]
>>   starting phase `install'
>>   i/o error: doesnotexist: No such file or directory
>>   phase `install' succeeded after 0.0 seconds
>>
>> This is on cc6cb6e80a42355147809b4830053a34d1563994.
>
> I think it’s always been this way.  Do you think we should change it?

In general, I think it's a good idea to raise errors for things like
this.  Warnings that only end up in build logs are likely to go
unnoticed for a long time.

      Mark

Message #14 received at 45279 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>, Marius Bakke
 <marius <at> gnu.org>
Cc: 45279 <at> debbugs.gnu.org
Subject: Re: bug#45279: [core-updates] copy-recursively does not throw an
 error on missing directory
Date: Fri, 18 Dec 2020 04:33:45 +0100

Hi,

On Thu, 17 Dec 2020 at 12:03, Ludovic Courtès <ludo <at> gnu.org> wrote:
> Marius Bakke <marius <at> gnu.org> skribis:
>
>> On the 'core-updates' branch, using copy-recursively on a nonexistent
>> directory does not cause a build failure.  Instead an error is printed
>> and the script continues:
>>
>>   (copy-recursively "doesnotexist" output)
>>   [...]
>>   starting phase `install'
>>   i/o error: doesnotexist: No such file or directory
>>   phase `install' succeeded after 0.0 seconds
>>
>> This is on cc6cb6e80a42355147809b4830053a34d1563994.
>
> I think it’s always been this way.  Do you think we should change it?

An example from bug#45308 [1] using ’copy-file’, it raises an error and
so a failure.  If ’copy-recursively’ is used instead, it means that the
build would say «success» and print “i/o error:” somewhere in the long
build log, right?  Harder to notice.

As The Zen of Python (python -c 'import this') says: :-)

        Errors should never pass silently.
        Unless explicitly silenced.


All the best,
simon

1: <http://issues.guix.gnu.org/issue/45308>

Message #17 received at 45279 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 45279 <at> debbugs.gnu.org, Marius Bakke <marius <at> gnu.org>
Subject: Re: bug#45279: [core-updates] copy-recursively does not throw an
 error on missing directory
Date: Fri, 10 May 2024 09:25:50 -0400

Hello,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> Marius Bakke <marius <at> gnu.org> skribis:
>
>> On the 'core-updates' branch, using copy-recursively on a nonexistent
>> directory does not cause a build failure.  Instead an error is printed
>> and the script continues:
>>
>>   (copy-recursively "doesnotexist" output)
>>   [...]
>>   starting phase `install'
>>   i/o error: doesnotexist: No such file or directory
>>   phase `install' succeeded after 0.0 seconds
>>
>> This is on cc6cb6e80a42355147809b4830053a34d1563994.
>
> I think it’s always been this way.  Do you think we should change it?

Just stumbled on that.  I think we should change it, yes.  Maybe we need
a core-updates-next branch, uh.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.