GNU bug report logs - #45269
Incorrect Gnus summary line number after toggle-thread and limiting

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45269 in the body.
You can then email your comments to 45269 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pankaj Jangid <pankaj <at> codeisgreat.org>
To: bug-gnu-emacs <at> gnu.org
Subject: Incorrect Gnus summary line number after toggle-thread and limiting
Date: Wed, 16 Dec 2020 18:54:55 +0530

[Message part 1 (text/plain, inline)]

Tags: patch

Set summary line format to display line number. Something like this,

(setq gnus-summary-line-format
      "%4P %U%R%z %-16&user-date; %(%[%4L:%*%-23,23f%]%) %B%s\n"

This will display line number in the first column.

Start Gnus and enter any group with few emails in it (better if there
are threads in it).

Invoke T-T (gnus-summary-toggle-threads) or any of the limiting
functions like /-/ (gnus-summary-limit-to-subject). These calls invoke
gnus-summary-prepare function.

And every time gnus-summary-prepare is invoked it starts increamenting
line-number from the previous max.

The result is that, on each refresh the line number keep on
increasing. And showing incorrect values.

I have moved these two lines from gnus-summary-read-group-1 to
gnus-summary-prepare function.

    (when (boundp 'gnus-pick-line-number)
      (setq gnus-pick-line-number 0))

This fixes the issue. Unless there are side-effects that I am unaware
of.

In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0)
 of 2020-12-16 built on lt
Repository revision: fda9a2bbfd3adcce046c03bee72ba848c61a3e29
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12004000
System Description: Debian GNU/Linux 10 (buster)

Configured using:
 'configure --prefix=/home/pankaj/.local'

[gnus-summary-line-number-fix.patch (text/patch, attachment)]

Message #8 received at 45269 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 45269 <at> debbugs.gnu.org
Subject: Re: bug#45269: Incorrect Gnus summary line number after
 toggle-thread and limiting
Date: Wed, 16 Dec 2020 23:34:53 +0100

Pankaj Jangid <pankaj <at> codeisgreat.org> writes:

> I have moved these two lines from gnus-summary-read-group-1 to
> gnus-summary-prepare function.
>
>     (when (boundp 'gnus-pick-line-number)
>       (setq gnus-pick-line-number 0))
>
> This fixes the issue. Unless there are side-effects that I am unaware
> of.

Looks good to me; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.