From unknown Fri Jun 20 05:26:19 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#45264 <45264@debbugs.gnu.org> To: bug#45264 <45264@debbugs.gnu.org> Subject: Status: 26.3; `face-remap-set-base' seems to be bugged Reply-To: bug#45264 <45264@debbugs.gnu.org> Date: Fri, 20 Jun 2025 12:26:19 +0000 retitle 45264 26.3; `face-remap-set-base' seems to be bugged reassign 45264 emacs submitter 45264 Drew Adams severity 45264 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 15 19:31:40 2020 Received: (at submit) by debbugs.gnu.org; 16 Dec 2020 00:31:40 +0000 Received: from localhost ([127.0.0.1]:59474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kpKjE-000638-7t for submit@debbugs.gnu.org; Tue, 15 Dec 2020 19:31:40 -0500 Received: from lists.gnu.org ([209.51.188.17]:57648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kpKjC-000631-DO for submit@debbugs.gnu.org; Tue, 15 Dec 2020 19:31:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpKjC-0008Sx-3k for bug-gnu-emacs@gnu.org; Tue, 15 Dec 2020 19:31:38 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:37704) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpKj9-0007X2-Kc for bug-gnu-emacs@gnu.org; Tue, 15 Dec 2020 19:31:37 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BG0E238102090 for ; Wed, 16 Dec 2020 00:31:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=bKnueE7ywfvszfX4OxHz2f0iZ2cZn7X+m7L46K5mkqU=; b=o1+avGOmp8XDvBg9OLZk45BWoDxI0YI+LmcPNGxRS5WMh2jrs8wOmoN2JhsAPRByFxQU 70aquWrjK1qoo1Gt2Awti6aAjdbwd5WfK4socbD9qHjv0uBzD327rl/5OuMvit2CYCE5 HZLDJ/o7Jh38UHvJ1ej1hWq7N+GjUjQ4nWdBtAU3DD0oQCvokjUL9hf3bp8sPvFNtEbk SNC9QENQYUjb3VOjWQunbICweRdRfxM/IdnlHJE4gjHxwJNJN7+SahTtrlEEt795tfHu PtgakaFSJJH2HzyctUyLfwbtRU6BxEwxmQpffJ5cWTo2QMqLHYpbjRW9xaCGBvsYMCfY pw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 35cntm5f0v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 16 Dec 2020 00:31:33 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BG0FEHT112997 for ; Wed, 16 Dec 2020 00:31:33 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 35d7enrwmg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 16 Dec 2020 00:31:33 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0BG0VW4q026306 for ; Wed, 16 Dec 2020 00:31:32 GMT MIME-Version: 1.0 Message-ID: Date: Tue, 15 Dec 2020 16:31:31 -0800 (PST) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 26.3; `face-remap-set-base' seems to be bugged X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5071.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9836 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 bulkscore=0 suspectscore=0 adultscore=0 mlxscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012160000 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9836 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 mlxscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999 impostorscore=0 priorityscore=1501 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012160000 Received-SPF: pass client-ip=141.146.126.78; envelope-from=drew.adams@oracle.com; helo=aserp2120.oracle.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) See https://emacs.stackexchange.com/a/62301/105 (defface foo '((t (:background "red"))) "...") (face-remap-set-base 'font-lock-keyword-face 'foo) The &rest arg SPECS is `(foo)', which is, as required, a list of (one) face. But the code actually expects `foo' itself to be a list. It raises an error, because it sets SPECS to just `foo' and then tries to take the car of it. (while (and (consp specs) (not (null (car specs))) (null (cdr specs))) (setq specs (car specs))) ; <=3D=3D=3D=3D=3D=3D=3D=3D=3D (if (or (null specs) (and (eq (car specs) face) ; <=3D=3D=3D=3D=3D=3D=3D=3D=3D (null (cdr specs)))) Is there a doc bug (both manual and doc string)? Or is there a code bug? Or am I missing something? In GNU Emacs 26.3 (build 1, x86_64-w64-mingw32) of 2019-08-29 Repository revision: 96dd0196c28bc36779584e47fffcca433c9309cd Windowing system distributor `Microsoft Corp.', version 10.0.18362 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3'' From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 19 05:20:29 2020 Received: (at 45264) by debbugs.gnu.org; 19 Dec 2020 10:20:29 +0000 Received: from localhost ([127.0.0.1]:40843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqZLh-0001I6-7I for submit@debbugs.gnu.org; Sat, 19 Dec 2020 05:20:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqZLg-0001Ht-1u for 45264@debbugs.gnu.org; Sat, 19 Dec 2020 05:20:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53908) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqZLa-0003en-PW; Sat, 19 Dec 2020 05:20:22 -0500 Received: from [176.228.60.248] (port=2905 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kqZLa-0003hL-1T; Sat, 19 Dec 2020 05:20:22 -0500 Date: Sat, 19 Dec 2020 12:20:04 +0200 Message-Id: <833602umgb.fsf@gnu.org> From: Eli Zaretskii To: Drew Adams In-Reply-To: (message from Drew Adams on Tue, 15 Dec 2020 16:31:31 -0800 (PST)) Subject: Re: bug#45264: 26.3; `face-remap-set-base' seems to be bugged References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45264 Cc: 45264@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 15 Dec 2020 16:31:31 -0800 (PST) > From: Drew Adams > > (defface foo '((t (:background "red"))) "...") > > (face-remap-set-base 'font-lock-keyword-face 'foo) > > The &rest arg SPECS is `(foo)', which is, as required, a list of > (one) face. > > But the code actually expects `foo' itself to be a list. It raises > an error, because it sets SPECS to just `foo' and then tries to > take the car of it. > > (while (and (consp specs) > (not (null (car specs))) > (null (cdr specs))) > (setq specs (car specs))) ; <========= > > (if (or (null specs) > (and (eq (car specs) face) ; <========= > (null (cdr specs)))) > > Is there a doc bug (both manual and doc string)? Or is there a code > bug? Or am I missing something? I don't see anything wrong with the documentation yet. One needs to know and understand what is a "face spec", and then everything falls into its place. The &rest part is also a big hint. Can I turn the table and ask you why you thought the argument could be a list of one or more faces? The doc string says "should FORM a list of faces", it doesn't say it should BE a list of faces. And since when does &rest specify a single argument that is a list? From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 19 13:34:29 2020 Received: (at 45264) by debbugs.gnu.org; 19 Dec 2020 18:34:29 +0000 Received: from localhost ([127.0.0.1]:43147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqh3l-0001X0-74 for submit@debbugs.gnu.org; Sat, 19 Dec 2020 13:34:29 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:33974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqh3j-0001Wm-AU for 45264@debbugs.gnu.org; Sat, 19 Dec 2020 13:34:28 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BJIYJ8B069043; Sat, 19 Dec 2020 18:34:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=jSneAbaN6oN/7Kn7qX+/NgIrV9xgzhC2prRAMOiSgqQ=; b=qju8PxMWdfbjBQfOVXBT+UY+OgxUEyny/Bm025EOFH1LQZjBtkSd6PSypQDcMYKPgFo6 LYnv7xbtye1OcqAYpSrZk7P0WL35o4Va/pCpmZl0j/TE8+2D3tQaZoSL+cNvSCXVJDSM nbxUxGgfH8RwBHVs6F10kmMtAn/KmTgW344SjYvWhgAAezy2+YBeqLoAKab8MjQZOLRU qL1lipP83DkMj8oqw5QK59T+0jljVhRh9m4SfcWDPO7I7F3Asl+WWzA/5BlXXAPV1Dli wVZVlByULX2r4EY0zdNEt7qHNt6Zne3BaIB3U4BWdTZKmXLrQ+lGsQy3VwT29ZV09z26 ww== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2130.oracle.com with ESMTP id 35h71asdjs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 19 Dec 2020 18:34:19 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BJIPPJe032721; Sat, 19 Dec 2020 18:32:18 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 35h8uh14hx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 19 Dec 2020 18:32:18 +0000 Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0BJIWHVv029141; Sat, 19 Dec 2020 18:32:17 GMT MIME-Version: 1.0 Message-ID: <4efb5c63-6636-449f-8e2b-4b8533a9cc8c@default> Date: Sat, 19 Dec 2020 10:32:16 -0800 (PST) From: Drew Adams To: Eli Zaretskii , Drew Adams Subject: RE: bug#45264: 26.3; `face-remap-set-base' seems to be bugged References: <> <<833602umgb.fsf@gnu.org>> In-Reply-To: <<833602umgb.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5071.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9839 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 phishscore=0 malwarescore=0 suspectscore=0 spamscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012190137 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9839 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 clxscore=1011 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0 mlxscore=0 impostorscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012190138 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45264 Cc: 45264@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > Is there a doc bug (both manual and doc string)? Or is there a code > > bug? Or am I missing something? >=20 > I don't see anything wrong with the documentation yet. One needs to > know and understand what is a "face spec", and then everything falls > into its place. The &rest part is also a big hint. >=20 > Can I turn the table and ask you why you thought the argument could be > a list of one or more faces? The doc string says "should FORM a list > of faces", it doesn't say it should BE a list of faces. And since > when does &rest specify a single argument that is a list? The confusion is not from not understanding what a face spec is. I think I know what a face spec is. The confusion is from the doc not saying explicitly that each element of SPECS is a face spec, and NOT a face. Please consider making that explicit (clear). 1. I didn't suggest (at all) that &rest specifies a single arg that is a list. Quite the contrary - the answer I gave to that SE question explicitly made that exact point. 2. "why you thought the argument could be a list of one or more faces?" The doc string explicitly says that elements of SPECS can be face names: Each list element should be either a face name or... 3. The predicate that tests for a face is `facep', and it doesn't return non-nil for a face spec. Its doc explicitly says that it tests whether its arg is a "face name", which can be a string or a symbol. Putting #2 and #3 together, the doc for SPECS does indeed say that elements of SPECS can be faces. 4. I strongly suggest that you change the language. "FORM" as a verb here is not clear, and this is apparently not about faces as arguments; it's about face specs. Face specs can be said to define (or "form") faces, but they are not faces - they don't satisfy `facep'. ___ Another possibility is perhaps to fix the behavior, so that it does what its doc says: allow elements of SPECS to "be either a face name or a property list of...". Allow faces, not just face specs. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 19 13:58:37 2020 Received: (at 45264-done) by debbugs.gnu.org; 19 Dec 2020 18:58:37 +0000 Received: from localhost ([127.0.0.1]:43162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqhR6-00026B-Q7 for submit@debbugs.gnu.org; Sat, 19 Dec 2020 13:58:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqhR3-00025q-Uf for 45264-done@debbugs.gnu.org; Sat, 19 Dec 2020 13:58:35 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59794) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqhQy-0005KL-4X; Sat, 19 Dec 2020 13:58:28 -0500 Received: from [176.228.60.248] (port=3102 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kqhQr-0001DA-SU; Sat, 19 Dec 2020 13:58:24 -0500 Date: Sat, 19 Dec 2020 20:58:02 +0200 Message-Id: <83a6u9tyh1.fsf@gnu.org> From: Eli Zaretskii To: Drew Adams In-Reply-To: <4efb5c63-6636-449f-8e2b-4b8533a9cc8c@default> (message from Drew Adams on Sat, 19 Dec 2020 10:32:16 -0800 (PST)) Subject: Re: bug#45264: 26.3; `face-remap-set-base' seems to be bugged References: <> <<833602umgb.fsf@gnu.org>> <4efb5c63-6636-449f-8e2b-4b8533a9cc8c@default> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45264-done Cc: 45264-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 19 Dec 2020 10:32:16 -0800 (PST) > From: Drew Adams > Cc: 45264@debbugs.gnu.org > > The confusion is from the doc not saying explicitly > that each element of SPECS is a face spec, and NOT a > face. SPECS has no "elements". SPECS stands for arguments to the function beyond the 1st arg FACE. Each such argument is either a face name or a list of attribute/value pairs. I changed the doc string to be more clear about that. > 2. "why you thought the argument could be a list of > one or more faces?" > > The doc string explicitly says that elements of > SPECS can be face names: > > Each list element should be either a face name or... That's after it says that you should consider SPECS as "forming" a list of elements. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 19 14:28:42 2020 Received: (at 45264-done) by debbugs.gnu.org; 19 Dec 2020 19:28:42 +0000 Received: from localhost ([127.0.0.1]:43197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqhuD-0002rL-Tf for submit@debbugs.gnu.org; Sat, 19 Dec 2020 14:28:42 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:49738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqhuB-0002r6-0S for 45264-done@debbugs.gnu.org; Sat, 19 Dec 2020 14:28:40 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BJJKCbV144414; Sat, 19 Dec 2020 19:28:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=OOda8gVKEOzVRGEcvYS+asblk2bmWQ4u+FJvHtwG4z0=; b=RIPzdMGLlHcsG9N6IAxnLjdAWgD/0PBmp+Cwr26OoGVXFUlil6ro1zTDn9UtBm01d6lI sIkSpUMfUyHqQhLlq8UtgSnAitkPKBXRvrTEOAcfhMflg8neXSTxoq5bqdcOPBZ1EuZT OCRHZdSNklUL01K4XJqfyarraCQbTcz56bvuAsS5Kwz6ZCLlGdHJWJ27f7RkSLVbWsQj L3gU0Y9NydgeYgxdW1DdStRk9Yk4PFwEAOEmFcP+Ck1Enbb5JF00T0/JmXbrUeue9Xtp fFrmTEcQhKG0UTfQy+pHil9ZsQIAohhymr+UAgy/0cbQIAWV0VKWtgPBgCYaxSZUZXWL fQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 35h9fks8ky-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 19 Dec 2020 19:28:33 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BJJLTnW186388; Sat, 19 Dec 2020 19:28:32 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 35h7j9f367-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 19 Dec 2020 19:28:32 +0000 Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0BJJSV2E020833; Sat, 19 Dec 2020 19:28:32 GMT MIME-Version: 1.0 Message-ID: <8397c6ee-966d-4d34-9a64-2dde3515cedd@default> Date: Sat, 19 Dec 2020 11:28:31 -0800 (PST) From: Drew Adams To: Eli Zaretskii , Drew Adams Subject: RE: bug#45264: 26.3; `face-remap-set-base' seems to be bugged References: <<>> <<<833602umgb.fsf@gnu.org>>> <<4efb5c63-6636-449f-8e2b-4b8533a9cc8c@default>> <<83a6u9tyh1.fsf@gnu.org>> In-Reply-To: <<83a6u9tyh1.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5071.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9839 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 malwarescore=0 bulkscore=0 adultscore=0 spamscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012190144 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9839 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 adultscore=0 clxscore=1011 spamscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012190144 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45264-done Cc: 45264-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > The confusion is from the doc not saying explicitly > > that each element of SPECS is a face spec, and NOT a > > face. >=20 > SPECS has no "elements". SPECS stands for arguments to the function > beyond the 1st arg FACE. As with any &rest, you supply zero or more actual args that correspond to SPECS. The function itself receives a single list argument that corresponds to SPECS. In the function body, variable SPECS is a list. And as the doc says, "Each list element...". > Each such argument is either a face name or > a list of attribute/value pairs. AFAICT, the function doesn't work if such an arg is a face name. See what I said about that previously, please. > I changed the doc string to be more clear about that. Great. Thanks for taking a look. Please check for the behavior bug I pointed to: If the doc is correct then the behavior seems bugged. It's not true that you can pass face names, AFAICT. > > 2. "why you thought the argument could be a list of > > one or more faces?" > > > > The doc string explicitly says that elements of > > SPECS can be face names: > > > > Each list element should be either a face name or... >=20 > That's after it says that you should consider SPECS as "forming" a > list of elements. "Forming" a list of elements is unclear, as I said. And SPECS is, itself, from the point of view of the function, a list of elements. See above. There is _nothing_ special about this. Every &rest parameter behaves the same in this regard. BTW, the exact same misleading and inexact text is used for function `face-map-add-relative'. For functions `buffer-face-(set|toggle)', however, we instead say, as we usually do, "Each argument in SPECS should be a face, i.e., either a face name or a property list...". And we explicitly speak of SPECS as a list (singular): "if SPECS is omitted or nil..." From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 19 14:40:38 2020 Received: (at 45264) by debbugs.gnu.org; 19 Dec 2020 19:40:38 +0000 Received: from localhost ([127.0.0.1]:43211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqi5l-0003Av-QL for submit@debbugs.gnu.org; Sat, 19 Dec 2020 14:40:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqi5i-0003Ag-Hy for 45264@debbugs.gnu.org; Sat, 19 Dec 2020 14:40:36 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60485) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqi5c-0006fo-E6; Sat, 19 Dec 2020 14:40:28 -0500 Received: from [176.228.60.248] (port=1722 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kqi5b-0004cL-Kv; Sat, 19 Dec 2020 14:40:28 -0500 Date: Sat, 19 Dec 2020 21:40:06 +0200 Message-Id: <835z4xtwix.fsf@gnu.org> From: Eli Zaretskii To: Drew Adams In-Reply-To: <8397c6ee-966d-4d34-9a64-2dde3515cedd@default> (message from Drew Adams on Sat, 19 Dec 2020 11:28:31 -0800 (PST)) Subject: Re: bug#45264: 26.3; `face-remap-set-base' seems to be bugged References: <<>> <<<833602umgb.fsf@gnu.org>>> <<4efb5c63-6636-449f-8e2b-4b8533a9cc8c@default>> <<83a6u9tyh1.fsf@gnu.org>> <8397c6ee-966d-4d34-9a64-2dde3515cedd@default> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45264 Cc: 45264@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 19 Dec 2020 11:28:31 -0800 (PST) > From: Drew Adams > Cc: 45264-done@debbugs.gnu.org > > > > The confusion is from the doc not saying explicitly > > > that each element of SPECS is a face spec, and NOT a > > > face. > > > > SPECS has no "elements". SPECS stands for arguments to the function > > beyond the 1st arg FACE. > > As with any &rest, you supply zero or more actual > args that correspond to SPECS. The function itself > receives a single list argument that corresponds to > SPECS. > > In the function body, variable SPECS is a list. > And as the doc says, "Each list element...". The doc string shouldn't explain how the function's body sees SPECS, it should explain how to provide those args. > Please check for the behavior bug I pointed to: If it doesn't work according to the doc string, then yes, it's a bug. From unknown Fri Jun 20 05:26:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 17 Jan 2021 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator