GNU bug report logs - #45256
Viewing images over network using TRAMP (errors and unexpected prompts)

Previous Next

Full log

View this message in rfc822 format

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Juri Linkov <juri <at> linkov.net>
Cc: Mikhail P <mikpom <at> fastmail.com>, 45256 <at> debbugs.gnu.org
Subject: bug#45256: Viewing images over network using TRAMP (errors and unexpected prompts)
Date: Fri, 18 Dec 2020 09:05:45 +0100

Juri Linkov <juri <at> linkov.net> writes:

Hi Juri,

> Additionally to these changes, I also added canceling the previous timer
> before starting a new timer to avoid several simultaneously started timers.
> This improved responsiveness in non-remote case.  In remote case it helps
> a little too, but still needs the lock for extremely slow connections.

Why cancelling the *previous* timer? It has done already part of the
job, so I would expect it will finish faster than a newly started timer.

> Here is a complete patch (BTW, I'm not sure if the check for file-remote-p
> can be removed now):

Yes. file-readable-p has performed already a remote operation (it runs
"test -r <filename>"), so a test file-remote-p doesn't make sense.

You haven't protected the timer function against the
remote-file-error. Are you sure it cannot happen?

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.