GNU bug report logs - #45256
Viewing images over network using TRAMP (errors and unexpected prompts)

Previous Next

Package: emacs;

Reported by: Mikhail P <mikpom <at> fastmail.com>

Date: Tue, 15 Dec 2020 15:44:02 UTC

Severity: normal

Tags: fixed

Fixed in version 28.0.50

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

Full log


Message #11 received at 45256 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: Mikhail P <mikpom <at> fastmail.com>, 45256 <at> debbugs.gnu.org
Subject: Re: bug#45256: Viewing images over network using TRAMP (errors and
 unexpected prompts)
Date: Wed, 16 Dec 2020 22:52:05 +0200
> That is, two calls of timer-event-handler([t 0 1 0 nil image-fit-to-window ...])
>
> image-fit-to-window calls remote file operations,
> verify-visited-file-modtime the first time, file-readable-p the second
> time. The first call of image-fit-to-window hasn't finished, when the
> second call of image-fit-to-window happens one second later. That is
> relevant, this situation happens only for slow remote connections (I had
> a hard time to reconstruct the scenario).
>
> From my pov, image-fit-to-window must be hardened in order to avoid this
> reentrant call. Maybe an internal lock at entry, which is honored by
> every next call until the lock is removed.

The simplest solution is just to increase the number of seconds
in the user option 'image-auto-resize-on-window-resize'
proportionally to network latency.

Locking could be implemented as well.  How would be better to do this?
Maybe by using a buffer-local variable?




This bug report was last modified 4 years and 209 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.