GNU bug report logs - #45194
[PATCH] gnu: Add okular.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45194 in the body.
You can then email your comments to 45194 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Z572 <873216071 <at> qq.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add okular.
Date: Sat, 12 Dec 2020 18:54:31 +0800

[ebook-tools.patch (text/x-patch, attachment)]

[kdegraphics-mobipocket.patch (text/x-patch, attachment)]

[libkexiv2.patch (text/x-patch, attachment)]

[okular.patch (text/x-patch, attachment)]

Message #8 received at 45194 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Z572 <873216071 <at> qq.com>
Cc: 45194 <at> debbugs.gnu.org
Subject: Re: [bug#45194] [PATCH] gnu: Add okular.
Date: Sat, 12 Dec 2020 18:23:03 -0500

[Message part 1 (text/plain, inline)]

Thank you for these patches!

On Sat, Dec 12, 2020 at 06:54:31PM +0800, Z572 wrote:
> +(define-public ebook-tools

> +       (uri (string-append "mirror://sourceforge/ebook-tools/"
> +                           name "-" version ".tar.gz"))

I corrected this to:

(uri (string-append "mirror://sourceforge/ebook-tools/ebook-tools/"
                    version "/ebook-tools-" version ".tar.gz"))

> +    (description "Tools and library for dealing with various ebook file formats")

Thanks! I made the description use "complete sentences" and pushed.

> +(define-public kdegraphics-mobipocket

> +       (file-name (string-append name "-" version "-checkout"))

I removed this line.

> +    (arguments
> +     `(#:tests? #f))

I removed this. There are no tests but it's better to "use the defaults"
when they work.

> +    (home-page "https://apps.kde.org/graphics/")

I changed this to <https://apps.kde.org/en/kdegraphics_mobipocket>

> +    (synopsis "Tools and library for dealing with various ebook file formats")
> +    (description "Tools and library for dealing with various ebook file formats")

I changed these to describe kdegraphics-mobipocket.

> +(define-public libkexiv2

> +       (file-name (string-append name "-" version "-checkout"))

I removed this line.

> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)
> +       ("pkg-config" ,pkg-config)))

I removed pkg-config, which seems to be unusued.

> +    (home-page "https://apps.kde.org/graphics/")

I changed this to <https://invent.kde.org/graphics/libkexiv2>.

> +    (synopsis "A library to manipulate pictures metadata")
> +    (description "A library to manipulate pictures metadata")

I adjusted these to be more descriptive.

With those changes, I pushed libkexiv2, kdegraphics-mobipocket, and
ebook-tools as commit fdfa25ed7b993597993f0afb355d1da928143e17.

> +(define-public okular

Overall, the Okular package looks good.

> +    (arguments
> +     `(#:tests? #f))

The only problem is that the test suite fails. In Guix, we aim for our
packages to pass upstream test suites unless there is a good reason not to.

I've attached the log of the test failures. Most of the failures seem to
caused by missing mimetype plugins. Does anyone know how to fix it?
Should we skip the tests?

[tests.log (text/plain, attachment)]

Message #11 received at 45194 <at> debbugs.gnu.org (full text, mbox):

From: Z572 <873216071 <at> qq.com>
To: 45194 <at> debbugs.gnu.org
Date: Tue, 15 Dec 2020 17:01:23 +0800

[Message part 1 (text/plain, inline)]

Hi

This is an updated patch, increasing several missed inputs, remove
several invalid inputs.

> I've attached the log of the test failures. Most of the failures seem to
> caused by missing mimetype plugins. Does anyone know how to fix it?
> Should we skip the tests?

I don't know.

[okular.patch (text/x-patch, attachment)]

Message #16 received at 45194-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Z572 <873216071 <at> qq.com>
Cc: 45194-done <at> debbugs.gnu.org
Subject: Re: [bug#45194] (no subject)
Date: Tue, 15 Dec 2020 15:35:52 -0500

On Tue, Dec 15, 2020 at 05:01:23PM +0800, Z572 wrote:
> > Should we skip the tests?
> 
> I don't know.

Okay, I added a comment explaining why they are skipped.

> +       (uri (string-append "mirror://kde/stable/release-service/" version
> +                           "/src/" name "-" version ".tar.xz"))
> +       (file-name (string-append name "-" version "-checkout"))

This file-name field is extraneous, so I removed it. We only set the
file-name when building from a Git checkout.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.