GNU bug report logs - #45191
[PATCH] Improve reproducibility of package ECL

Previous Next

Full log

Message #11 received at 45191 <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: 45191 <at> debbugs.gnu.org
Subject: Re: [bug#45191] [PATCH] Improve reproducibility of package ECL
Date: Mon, 14 Dec 2020 19:21:01 +0800

[Message part 1 (text/plain, inline)]

Guillaume Le Vaillant writes:

> Zhu Zihao <all_but_last <at> 163.com> skribis:
>
>> +             (use-modules (ice-9 ftw))
>> +             (let* ((lib (string-append (assoc-ref outputs "out") "/lib"))
>> +                    (dir (car (scandir lib (lambda (x)
>> +                                             (string-prefix? "ecl-" x))))))
>> +               (delete-file (string-append lib "/" dir "/build-stamp")))
>
> Wouldn't something like the following suffice?
>
> --8<---------------cut here---------------start------------->8---
> (delete-file (string-append (assoc-ref outputs "out")
>                             "/lib/ecl-" ,version "/build-stamp"))
> --8<---------------cut here---------------end--------------->8---


Changed and submit a new patch now.

Actually I hope upstream can help fix this problem[1](e.g. Add a configure
option --disable-time-stamp) but get no reply

[signature.asc (application/pgp-signature, inline)]

[0001-gnu-ecl-Return-t-in-wrap-phase.patch (text/x-patch, inline)]

From cad4e253aefa52cacda5df37970dad6cc32e6600 Mon Sep 17 00:00:00 2001
From: Zhu Zihao <all_but_last <at> 163.com>
Date: Sat, 12 Dec 2020 10:33:37 +0800
Subject: [PATCH 1/2] gnu: ecl: Return #t in wrap phase.

* gnu/packages/lisp.scm(ecl)[arguments]<phases>: In phase "wrap", return #t.
---
 gnu/packages/lisp.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index 3d446290a7..4592724867 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -280,7 +280,8 @@ interface to the Tk widget system.")
                            (input-path lib "/include"))
                          `("kernel-headers" ,@libraries)))
                  `("LIBRARY_PATH" suffix ,library-directories)
-                 `("LD_LIBRARY_PATH" suffix ,library-directories)))))
+                 `("LD_LIBRARY_PATH" suffix ,library-directories))
+               #t)))
          (add-after 'wrap 'check (assoc-ref %standard-phases 'check))
          (add-before 'check 'fix-path-to-ecl
            (lambda _
-- 
2.29.2

[0002-gnu-ecl-Remove-build-stamp-to-improve-reproducibilit.patch (text/x-patch, inline)]

From 1554e044a3e2eede8bf4637395ca4da2388d8e9e Mon Sep 17 00:00:00 2001
From: Zhu Zihao <all_but_last <at> 163.com>
Date: Sat, 12 Dec 2020 10:34:37 +0800
Subject: [PATCH 2/2] gnu: ecl: Remove build-stamp to improve reproducibility.

* gnu/packages/lisp.scm(ecl)[arguments]<phases>: Add "remove-build-stamp" phase.
Move "wrap" phase after "remove-build-stamp" phase.
---
 gnu/packages/lisp.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index 4592724867..f250e8804b 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -16,6 +16,7 @@
 ;;; Copyright © 2019 Jesse Gildersleve <jessejohngildersleve <at> protonmail.com>
 ;;; Copyright © 2019, 2020 Guillaume Le Vaillant <glv <at> posteo.net>
 ;;; Copyright © 2020 Marius Bakke <mbakke <at> fastmail.com>
+;;; Copyright © 2020 Zhu Zihao <all_but_last <at> 163.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -258,7 +259,12 @@ interface to the Tk widget system.")
                     (contrib-asdf "contrib/asdf/asdf.lisp"))
                (copy-file guix-asdf contrib-asdf))
              #t))
-         (add-after 'install 'wrap
+         (add-after 'install 'remove-build-stamp
+           (lambda* (#:key outputs #:allow-other-keys)
+             (delete-file (string-append (assoc-ref outputs "out")
+                                         "/lib/ecl-" ,version "/build-stamp"))
+             #t))
+         (add-after 'remove-build-stamp 'wrap
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (let* ((ecl (assoc-ref outputs "out"))
                     (input-path (lambda (lib path)
-- 
2.29.2

[Message part 5 (text/plain, inline)]

[1]: https://gitlab.com/embeddable-common-lisp/ecl/-/issues/616
-- 
Retrieve my PGP public key:

  gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F

Zihao

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.