From unknown Fri Aug 15 16:55:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#45190] [PATCH 0/1] Add pinentry-rofi Resent-From: Fredrik Salomonsson Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 12 Dec 2020 02:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45190 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 45190@debbugs.gnu.org Cc: Fredrik Salomonsson X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16077396515209 (code B ref -1); Sat, 12 Dec 2020 02:21:01 +0000 Received: (at submit) by debbugs.gnu.org; 12 Dec 2020 02:20:51 +0000 Received: from localhost ([127.0.0.1]:43726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knuWh-0001Lx-0e for submit@debbugs.gnu.org; Fri, 11 Dec 2020 21:20:51 -0500 Received: from lists.gnu.org ([209.51.188.17]:57676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knuWd-0001Ln-Pc for submit@debbugs.gnu.org; Fri, 11 Dec 2020 21:20:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knuWd-0002PZ-K5 for guix-patches@gnu.org; Fri, 11 Dec 2020 21:20:47 -0500 Received: from mout01.posteo.de ([185.67.36.65]:56684) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knuWT-0008DS-NT for guix-patches@gnu.org; Fri, 11 Dec 2020 21:20:47 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 9651116005C for ; Sat, 12 Dec 2020 03:20:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1607739633; bh=OzzmBb/pEfedalS1RHpwODboDKLa0XVJAJxRuEeuNAI=; h=From:To:Cc:Subject:Date:From; b=QwZqQVnjzDMIKzN9qekQPY7sv8BFDnQxgWNufUD40ES6o1a+L/7ILYCPRgP1hUr9C v6Hq/tvpvhDnT4nshWwM2r3eJOs6YKWXBEky2RxcAJZp79TRNcrsKKEB1JfzlGKC0F 1VVgccqI+9OW6DbpAOYKvjCWWWZpt31idXuwh68GmKbCEzHZo1jXZ109CmqQvbXsgt 90g2IeyVvJhgKjYKq4kkhUxPveKdkSfWnKQ3Uc7dQL/mJHbplGg6PyJGBQoyYlOkDQ WTYoWD4ppNKaz0Y2c+z6pccawyvhgy52wmyNzd09bm4D+pNbwTIhE7WcAEIHXIRTLc 80uWXDp9sp2ZQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CtBFr2lYCz9rxM; Sat, 12 Dec 2020 03:20:32 +0100 (CET) From: Fredrik Salomonsson Date: Fri, 11 Dec 2020 18:19:54 -0800 Message-Id: <20201212021954.78983-1-plattfot@posteo.net> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.65; envelope-from=plattfot@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Add pinentry program that is using rofi to input the passphrase. Fredrik Salomonsson (1): gnu: Add pinentry-rofi. gnu/packages/gnupg.scm | 81 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 81 insertions(+) -- 2.29.2 From unknown Fri Aug 15 16:55:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#45190] [PATCH 1/1] gnu: Add pinentry-rofi. References: <20201212021954.78983-1-plattfot@posteo.net> In-Reply-To: <20201212021954.78983-1-plattfot@posteo.net> Resent-From: Fredrik Salomonsson Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 12 Dec 2020 02:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45190 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 45190@debbugs.gnu.org Cc: Fredrik Salomonsson Received: via spool by 45190-submit@debbugs.gnu.org id=B45190.16077402837941 (code B ref 45190); Sat, 12 Dec 2020 02:32:01 +0000 Received: (at 45190) by debbugs.gnu.org; 12 Dec 2020 02:31:23 +0000 Received: from localhost ([127.0.0.1]:43731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knugt-00023z-1B for submit@debbugs.gnu.org; Fri, 11 Dec 2020 21:31:23 -0500 Received: from mout01.posteo.de ([185.67.36.65]:44658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knugp-00023C-65 for 45190@debbugs.gnu.org; Fri, 11 Dec 2020 21:31:21 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id A833816005C for <45190@debbugs.gnu.org>; Sat, 12 Dec 2020 03:31:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1607740271; bh=L0DZLYSod634J+t5VKGJE5FLJgiM8GQirxUwrObowgE=; h=From:To:Cc:Subject:Date:From; b=rSICJ5DPf2vPvCOIMHF+5CjZcjRNzFwlvvHcbUtVQIvOF8ovPnv2xFauU+7xvcOwB v4JghM+k95d/AGjq7W1KFM87/Y4PGU4ywE7+NSMeqlz8VkE6LsZH30VsNn79XeI/ej eZcGs2s3pKdlUJQJ6ACSkMPCi/gMNsTmHrtYgHOcFNJ80tE1F4eZStp2tvtATUgruv EeNYZ5MvzOLFYXL2p7GR+aI1sf2Kw3WEixuFTDxD3pL61pfrNFHJuo8/xAVWp5XIBu mFUHhZM+B4hc6koQ/+tJB9hh9PiWMllxPPhhB5irIegQSBvCuZRymxk1yPDEZEzFI5 Y1GdppNWJ3fRA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CtBV66p6Pz9rxM; Sat, 12 Dec 2020 03:31:10 +0100 (CET) From: Fredrik Salomonsson Date: Fri, 11 Dec 2020 18:31:03 -0800 Message-Id: <20201212023103.79992-1-plattfot@posteo.net> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/gnupg.scm (pinentry-rofi): New variable. --- gnu/packages/gnupg.scm | 81 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 81 insertions(+) diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm index 3620efea3a..dad6a1de81 100644 --- a/gnu/packages/gnupg.scm +++ b/gnu/packages/gnupg.scm @@ -17,6 +17,7 @@ ;;; Copyright © 2018, 2019 Marius Bakke ;;; Copyright © 2018 Björn Höfling ;;; Copyright © 2019 Mathieu Othacehe +;;; Copyright © 2020 Fredrik Salomonsson ;;; ;;; This file is part of GNU Guix. ;;; @@ -67,6 +68,7 @@ #:use-module (gnu packages tor) #:use-module (gnu packages web) #:use-module (gnu packages xorg) + #:use-module (gnu packages xdisorg) #:use-module (gnu packages xml) #:use-module (guix packages) #:use-module (guix download) @@ -892,6 +894,85 @@ passphrase when @code{gpg} is run and needs it."))) @dfn{Enlightenment Foundation Libraries} (EFL) that allows users to enter a passphrase when @code{gpg} is run and needs it."))) +(define-public pinentry-rofi + (package + (name "pinentry-rofi") + (version "2.0.1") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/plattfot/pinentry-rofi/") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 "044bnldz7k74s873jwsjgff176l1jsvpbaka7d1wcj8b5pwqv2av")))) + (build-system gnu-build-system) + (arguments + `(#:strip-binaries? #f ;; Has no binaries and the strip phase is failing + #:modules + ((ice-9 match) + (ice-9 ftw) + ,@%gnu-build-system-modules) + #:phases + (modify-phases + %standard-phases + (add-after + 'install + 'hall-wrap-binaries + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((compiled-dir + (lambda (out version) + (string-append out "/lib/guile/" version "/site-ccache"))) + (uncompiled-dir + (lambda (out version) + (string-append + out + "/share/guile/site" + (if (string-null? version) "" "/") + version))) + (dep-path + (lambda (env modules path) + (list env + ":" + 'prefix + (cons modules + (map (lambda (input) + (string-append + (assoc-ref inputs input) + path)) + ,''("rofi")))))) + (out (assoc-ref outputs "out")) + (bin (string-append out "/bin/")) + (site (uncompiled-dir out ""))) + (match (scandir site) + (("." ".." version) + (for-each + (lambda (file) + (wrap-program + (string-append bin file) + (dep-path + "GUILE_LOAD_PATH" + (uncompiled-dir out version) + (uncompiled-dir "" version)) + (dep-path + "GUILE_LOAD_COMPILED_PATH" + (compiled-dir out version) + (compiled-dir "" version)))) + ,''("pinentry-rofi")) + #t)))))))) + (native-inputs + `(("autoconf" ,autoconf) + ("automake" ,automake) + ("pkg-config" ,pkg-config) + ("texinfo" ,texinfo))) + (inputs `(("guile" ,guile-3.0))) + (propagated-inputs `(("rofi" ,rofi))) + (synopsis "Rofi GUI for GnuPG's passphrase input") + (description "Simple pinentry GUI using rofi that allows users to enter a +passphrase when required by @code{gpg} or other software.") + (home-page "https://github.com/plattfot/pinentry-rofi/") + (license license:gpl3+))) + (define-public pinentry (package (inherit pinentry-gtk2) (name "pinentry"))) -- 2.29.2 From unknown Fri Aug 15 16:55:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#45190] [PATCH 1/1] gnu: Add pinentry-rofi. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 03 Jan 2021 21:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45190 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Fredrik Salomonsson Cc: 45190@debbugs.gnu.org Received: via spool by 45190-submit@debbugs.gnu.org id=B45190.160970869125385 (code B ref 45190); Sun, 03 Jan 2021 21:19:01 +0000 Received: (at 45190) by debbugs.gnu.org; 3 Jan 2021 21:18:11 +0000 Received: from localhost ([127.0.0.1]:38718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwAlO-0006bM-S1 for submit@debbugs.gnu.org; Sun, 03 Jan 2021 16:18:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwAlN-0006b5-6p for 45190@debbugs.gnu.org; Sun, 03 Jan 2021 16:18:09 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49700) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwAlH-0005w6-9L; Sun, 03 Jan 2021 16:18:03 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=33848 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kwAlG-0005uQ-KT; Sun, 03 Jan 2021 16:18:03 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201212021954.78983-1-plattfot@posteo.net> <20201212023103.79992-1-plattfot@posteo.net> Date: Sun, 03 Jan 2021 22:18:01 +0100 In-Reply-To: <20201212023103.79992-1-plattfot@posteo.net> (Fredrik Salomonsson's message of "Fri, 11 Dec 2020 18:31:03 -0800") Message-ID: <87o8i5zpme.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Fredrik, Fredrik Salomonsson skribis: > * gnu/packages/gnupg.scm (pinentry-rofi): New variable. Overall LGTM, with some minor issues highlighted below: > +(define-public pinentry-rofi > + (package > + (name "pinentry-rofi") Indentation is off here (should be offset by two). > + (arguments > + `(#:strip-binaries? #f ;; Has no binaries and the strip phase is fai= ling Hmm the =E2=80=98strip=E2=80=99 phase should not fail. Are you sure this i= s necessary? > + #:phases > + (modify-phases > + %standard-phases > + (add-after > + 'install > + 'hall-wrap-binaries Nitpick: please indent as in other files. > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((compiled-dir > + (lambda (out version) > + (string-append out "/lib/guile/" version "/site-c= cache"))) > + (uncompiled-dir > + (lambda (out version) > + (string-append > + out > + "/share/guile/site" > + (if (string-null? version) "" "/") > + version))) > + (dep-path > + (lambda (env modules path) > + (list env > + ":" > + 'prefix > + (cons modules > + (map (lambda (input) > + (string-append > + (assoc-ref inputs input) > + path)) > + ,''("rofi")))))) > + (out (assoc-ref outputs "out")) > + (bin (string-append out "/bin/")) > + (site (uncompiled-dir out ""))) > + (match (scandir site) > + (("." ".." version) > + (for-each > + (lambda (file) > + (wrap-program > + (string-append bin file) > + (dep-path > + "GUILE_LOAD_PATH" > + (uncompiled-dir out version) > + (uncompiled-dir "" version)) > + (dep-path > + "GUILE_LOAD_COMPILED_PATH" > + (compiled-dir out version) > + (compiled-dir "" version)))) > + ,''("pinentry-rofi")) > + #t)))))))) Since I think you=E2=80=99re also upstream :-), how about adding something = like that at the top of the installed executable: (eval-when (load expand eval) (set! %load-path (cons "@moddir@" %load-path)) (set! %laod-compiled-path (cons "@godir@" %load-compiled-path))) ? > + (propagated-inputs `(("rofi" ,rofi))) It=E2=80=99s best to avoid propagating. Perhaps you can replace the =E2=80= =9Crofi=E2=80=9D string in =E2=80=98pinentry-rofi=E2=80=99 by =E2=80=9C/gnu/store/=E2=80=A6/= bin/rofi=E2=80=9D in a post-install phase? > + (synopsis "Rofi GUI for GnuPG's passphrase input") > + (description "Simple pinentry GUI using rofi that allows users to ente= r a > +passphrase when required by @code{gpg} or other software.") Please make it a full sentence. Also, to give context, perhaps replace =E2=80=9Crofi=E2=80=9D by =E2=80=9Cthe Rofi application launcher=E2=80=9D. Could you send an updated patch? Thanks in advance and sorry for the delay! Ludo=E2=80=99. From unknown Fri Aug 15 16:55:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#45190] [PATCH v2] gnu: Add pinentry-rofi. References: <20201212021954.78983-1-plattfot@posteo.net> In-Reply-To: <20201212021954.78983-1-plattfot@posteo.net> Resent-From: Fredrik Salomonsson Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 09 Jan 2021 01:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45190 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 45190@debbugs.gnu.org Cc: Fredrik Salomonsson Received: via spool by 45190-submit@debbugs.gnu.org id=B45190.161015686610063 (code B ref 45190); Sat, 09 Jan 2021 01:48:02 +0000 Received: (at 45190) by debbugs.gnu.org; 9 Jan 2021 01:47:46 +0000 Received: from localhost ([127.0.0.1]:51028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ky3M1-0002cE-NF for submit@debbugs.gnu.org; Fri, 08 Jan 2021 20:47:46 -0500 Received: from mout01.posteo.de ([185.67.36.65]:43721) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ky3Lz-0002c0-BF for 45190@debbugs.gnu.org; Fri, 08 Jan 2021 20:47:44 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id D4BC916005C for <45190@debbugs.gnu.org>; Sat, 9 Jan 2021 02:47:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1610156856; bh=co0i00ssmmE2AxUOa9rIMxdRJ5YI0Nq36xhih5imgtc=; h=From:To:Cc:Subject:Date:From; b=Tf5oFof/23USDEPAOLzrSMa90oHZfnCPW6Ni87el6kp6+tK8TXUs3aSvjIcCBv+vd 3q7LGntmITYjFTKPqKsftRMYSvIGn0XHVm3/ACEsVvZuyIcbhNbzkTt2pnalFvNBOp 712YpjZctEEG8P+2Q2rMv56/bkCge5aSheeVZGzRApCQwAY7kZLcnP1iO6cxp/gttb SEiy38jbj4mpST2uO95CNStj02wvY49vsqbtEn606Banokq7N31HHVinO/Z+mfi8Rj kwHkcSqGm3LNfE7kCqeJfJCuu6fLIA8gGhhJ72x/KfMC5yAE1fx02nQ9WYK471tGyM dGRaRphKmy9gA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4DCNBv6G2Kz6tmD; Sat, 9 Jan 2021 02:47:35 +0100 (CET) From: Fredrik Salomonsson Date: Fri, 8 Jan 2021 17:47:07 -0800 Message-Id: <20210109014707.81676-1-plattfot@posteo.net> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/gnupg.scm (pinentry-rofi): New variable. --- gnu/packages/gnupg.scm | 73 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm index 3620efea3a..c2ebefc203 100644 --- a/gnu/packages/gnupg.scm +++ b/gnu/packages/gnupg.scm @@ -17,6 +17,7 @@ ;;; Copyright © 2018, 2019 Marius Bakke ;;; Copyright © 2018 Björn Höfling ;;; Copyright © 2019 Mathieu Othacehe +;;; Copyright © 2020 Fredrik Salomonsson ;;; ;;; This file is part of GNU Guix. ;;; @@ -67,6 +68,7 @@ #:use-module (gnu packages tor) #:use-module (gnu packages web) #:use-module (gnu packages xorg) + #:use-module (gnu packages xdisorg) #:use-module (gnu packages xml) #:use-module (guix packages) #:use-module (guix download) @@ -892,6 +894,77 @@ passphrase when @code{gpg} is run and needs it."))) @dfn{Enlightenment Foundation Libraries} (EFL) that allows users to enter a passphrase when @code{gpg} is run and needs it."))) +(define-public pinentry-rofi + (package + (name "pinentry-rofi") + (version "2.0.1") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/plattfot/pinentry-rofi/") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 "044bnldz7k74s873jwsjgff176l1jsvpbaka7d1wcj8b5pwqv2av")))) + (build-system gnu-build-system) + (arguments + `(#:modules + ((ice-9 match) + (ice-9 ftw) + ,@%gnu-build-system-modules) + #:phases + (modify-phases + %standard-phases + (add-after 'install 'hall-wrap-binaries + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((compiled-dir + (lambda (out version) + (string-append out "/lib/guile/" version "/site-ccache"))) + (uncompiled-dir + (lambda (out version) + (string-append + out + "/share/guile/site" + (if (string-null? version) "" "/") + version))) + (dep-path + (lambda (env path) + (list env ":" 'prefix (list path)))) + (out (assoc-ref outputs "out")) + (bin (string-append out "/bin/")) + (site (uncompiled-dir out ""))) + (match (scandir site) + (("." ".." version) + (for-each + (lambda (file) + (wrap-program + (string-append bin file) + (dep-path + "PATH" + (string-append (assoc-ref inputs "rofi") "/bin")) + (dep-path + "GUILE_LOAD_PATH" + (uncompiled-dir out version)) + (dep-path + "GUILE_LOAD_COMPILED_PATH" + (compiled-dir out version)))) + ,''("pinentry-rofi")) + #t)))))))) + (native-inputs + `(("autoconf" ,autoconf) + ("automake" ,automake) + ("pkg-config" ,pkg-config) + ("texinfo" ,texinfo))) + (inputs `(("guile" ,guile-3.0) + ("rofi" ,rofi))) + (synopsis "Rofi GUI for GnuPG's passphrase input") + (description "Pinentry-rofi is a simple graphical user interface for +passphrase or PIN when required by @code{gpg} or other software. It is using +the Rofi application launcher as the user interface. Which makes it combined +with @code{rofi-pass} a good front end for @code{password-store}.") + (home-page "https://github.com/plattfot/pinentry-rofi/") + (license license:gpl3+))) + (define-public pinentry (package (inherit pinentry-gtk2) (name "pinentry"))) -- 2.29.2 From unknown Fri Aug 15 16:55:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#45190] [PATCH 1/1] gnu: Add pinentry-rofi. Resent-From: Fredrik Salomonsson Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 09 Jan 2021 02:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45190 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 45190@debbugs.gnu.org Received: via spool by 45190-submit@debbugs.gnu.org id=B45190.161015845312461 (code B ref 45190); Sat, 09 Jan 2021 02:15:01 +0000 Received: (at 45190) by debbugs.gnu.org; 9 Jan 2021 02:14:13 +0000 Received: from localhost ([127.0.0.1]:51037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ky3ld-0003Eu-1v for submit@debbugs.gnu.org; Fri, 08 Jan 2021 21:14:13 -0500 Received: from mout01.posteo.de ([185.67.36.65]:41179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ky3la-0003Eg-LE for 45190@debbugs.gnu.org; Fri, 08 Jan 2021 21:14:11 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 73B7E16005C for <45190@debbugs.gnu.org>; Sat, 9 Jan 2021 03:14:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1610158444; bh=/QcF6HBLJA6gLiHGLL9s/DEIPvId9eKKv3HXj1OGq78=; h=From:To:Cc:Subject:Date:From; b=Y9LjF697VY0xKZ3OBHQKTpzuNYY73LWEmSn3/ruvpjPLQk3JSV4feZuUKoqlq6i7S 1WnjE/qI1qw1WuqERIuoatCgT9xvA00gAV7ytg5/EFcWgERH0OlHT0iAdqTgpG9d2w Lj+yKYrQgM0DzavKzq2YM1qju+qPAsceL4ngn+D+Yn6NhbOpSZGsSxu+RXi1ixMBVx CQ0R0ZyTJowYy/zUvNoxdXO6+wiBlr64dy82+5F8E/BePPzJsYkWzJHFLHwh5D6hvS 8BkgHPSTLaMzIBOVtPcrNGvd6qfVsmpdnB5GvUrhwKqKWMKvxoKxYshLp3OMfgmgwd 9lE8TLDbyIbOQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4DCNnR3Qwxz9rxM; Sat, 9 Jan 2021 03:14:03 +0100 (CET) From: Fredrik Salomonsson In-Reply-To: <87o8i5zpme.fsf@gnu.org> References: <20201212021954.78983-1-plattfot@posteo.net> <20201212023103.79992-1-plattfot@posteo.net> <87o8i5zpme.fsf@gnu.org> Date: Fri, 08 Jan 2021 18:14:01 -0800 Message-ID: <878s926emu.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Ludovic, Ludovic Court=C3=A8s writes: >> +(define-public pinentry-rofi >> + (package >> + (name "pinentry-rofi") > > Indentation is off here (should be offset by two). Fixed in v2. >> + (arguments >> + `(#:strip-binaries? #f ;; Has no binaries and the strip phase is fa= iling > > Hmm the =E2=80=98strip=E2=80=99 phase should not fail. Are you sure this= is necessary? It was failing with a warning as there are no binaries to strip. But it's not an error so I removed this in v2. >> + #:phases >> + (modify-phases >> + %standard-phases >> + (add-after >> + 'install >> + 'hall-wrap-binaries > > Nitpick: please indent as in other files. Fixed in v2. > Since I think you=E2=80=99re also upstream :-), how about adding somethin= g like > that at the top of the installed executable: > > (eval-when (load expand eval) > (set! %load-path (cons "@moddir@" %load-path)) > (set! %laod-compiled-path (cons "@godir@" %load-compiled-path))) > > ? Yup, I'm upstream as well. I don't mind adding that, just need to know what it solves :). I'm guessing that it removes the need to wrap the executable, is that correct? And are the "@moddir@" and "@godir@" expected to be expanded by automake? I tested to just add it in the source code and automake did nothing with them. For now I left it out in v2 as I'm a bit unsure of it. >> + (propagated-inputs `(("rofi" ,rofi))) > It=E2=80=99s best to avoid propagating. Perhaps you can replace the =E2= =80=9Crofi=E2=80=9D > string in =E2=80=98pinentry-rofi=E2=80=99 by =E2=80=9C/gnu/store/=E2=80= =A6/bin/rofi=E2=80=9D in a post-install > phase? Is there a rule of thumb or something to know when to use propagating inputs? I'm a bit confused when to use is it. Is it just when dealing with libraries? What are the downsides of using propagating inputs? Apologize if this is already mentioned in the manual. Only sections I could find that mentions propagated inputs are section 5.2 and 8.2.1. Anyway this is fixed in v2, I added the rofi's binary path to PATH for the wrapper of pinentry-rofi.=20 >> + (synopsis "Rofi GUI for GnuPG's passphrase input") >> + (description "Simple pinentry GUI using rofi that allows users to ent= er a >> +passphrase when required by @code{gpg} or other software.") > > Please make it a full sentence. Also, to give context, perhaps replace > =E2=80=9Crofi=E2=80=9D by =E2=80=9Cthe Rofi application launcher=E2=80=9D. I fleshed out the description in v2, let me know if it sounds better. > Could you send an updated patch? All updates should be in PATCH v2 > Thanks in advance and sorry for the delay! Thank you for reviewing my patch and no worries about the delay. --=20 s/Fred[re]+i[ck]+/Fredrik/g From unknown Fri Aug 15 16:55:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#45190] [PATCH 0/1] Add pinentry-rofi Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 13 Jan 2021 15:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45190 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Fredrik Salomonsson Cc: 45190@debbugs.gnu.org Received: via spool by 45190-submit@debbugs.gnu.org id=B45190.16105515051242 (code B ref 45190); Wed, 13 Jan 2021 15:26:01 +0000 Received: (at 45190) by debbugs.gnu.org; 13 Jan 2021 15:25:05 +0000 Received: from localhost ([127.0.0.1]:36302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzi1B-0000Jy-5R for submit@debbugs.gnu.org; Wed, 13 Jan 2021 10:25:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzi1A-0000JN-49 for 45190@debbugs.gnu.org; Wed, 13 Jan 2021 10:25:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57986) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzi14-0004oR-UE; Wed, 13 Jan 2021 10:24:58 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=39546 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kzi13-0005NJ-PO; Wed, 13 Jan 2021 10:24:58 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201212021954.78983-1-plattfot@posteo.net> <20201212023103.79992-1-plattfot@posteo.net> <87o8i5zpme.fsf@gnu.org> <878s926emu.fsf@posteo.net> Date: Wed, 13 Jan 2021 16:24:56 +0100 In-Reply-To: <878s926emu.fsf@posteo.net> (Fredrik Salomonsson's message of "Fri, 08 Jan 2021 18:14:01 -0800") Message-ID: <875z4097w7.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Fredrik Salomonsson skribis: >>> + (arguments >>> + `(#:strip-binaries? #f ;; Has no binaries and the strip phase is f= ailing >> >> Hmm the =E2=80=98strip=E2=80=99 phase should not fail. Are you sure thi= s is necessary? > > It was failing with a warning as there are no binaries to strip. But > it's not an error so I removed this in v2. Right, it=E2=80=99s just a warning, due to the fact that .go files are ELF = but the =E2=80=98strip=E2=80=99 command doesn=E2=80=99t know what to do with th= em. >> Since I think you=E2=80=99re also upstream :-), how about adding somethi= ng like >> that at the top of the installed executable: >> >> (eval-when (load expand eval) >> (set! %load-path (cons "@moddir@" %load-path)) >> (set! %laod-compiled-path (cons "@godir@" %load-compiled-path))) >> >> ? > > Yup, I'm upstream as well. I don't mind adding that, just need to know > what it solves :). I'm guessing that it removes the need to wrap the > executable, is that correct? > > And are the "@moddir@" and "@godir@" expected to be expanded by > automake? I tested to just add it in the source code and automake did > nothing with them. It=E2=80=99s replaced provided =E2=80=98configure.ac=E2=80=99 defines them = and AC_SUBSTs them, along these lines (here they have a longer name): https://notabug.org/guile-zstd/guile-zstd/src/master/configure.ac#L43 >> It=E2=80=99s best to avoid propagating. Perhaps you can replace the =E2= =80=9Crofi=E2=80=9D >> string in =E2=80=98pinentry-rofi=E2=80=99 by =E2=80=9C/gnu/store/=E2=80= =A6/bin/rofi=E2=80=9D in a post-install >> phase? > > Is there a rule of thumb or something to know when to use propagating > inputs? I'm a bit confused when to use is it. Is it just when dealing > with libraries? What are the downsides of using propagating inputs? > Apologize if this is already mentioned in the manual. Only sections I > could find that mentions propagated inputs are section 5.2 and 8.2.1. In general, propagated inputs should be avoided as they =E2=80=9Cpollute=E2= =80=9D the user=E2=80=99s profile (you install X and find yourself with X, Y, and Z). The preferred method in situations like this is to patch the source so it uses absolute file names for commands. Thanks for sending an updated patch! Ludo=E2=80=99. From unknown Fri Aug 15 16:55:30 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Fredrik Salomonsson Subject: bug#45190: closed (Re: bug#45190: [PATCH 0/1] Add pinentry-rofi) Message-ID: References: <871reo97tt.fsf_-_@gnu.org> <20201212021954.78983-1-plattfot@posteo.net> X-Gnu-PR-Message: they-closed 45190 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 45190@debbugs.gnu.org Date: Wed, 13 Jan 2021 15:27:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1610551622-1428-1" This is a multi-part message in MIME format... ------------=_1610551622-1428-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #45190: [PATCH 0/1] Add pinentry-rofi which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 45190@debbugs.gnu.org. --=20 45190: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D45190 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1610551622-1428-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 45190-done) by debbugs.gnu.org; 13 Jan 2021 15:26:31 +0000 Received: from localhost ([127.0.0.1]:36306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzi2Z-0000MK-IT for submit@debbugs.gnu.org; Wed, 13 Jan 2021 10:26:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzi2X-0000M4-Ic for 45190-done@debbugs.gnu.org; Wed, 13 Jan 2021 10:26:29 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58002) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzi2S-0005jT-D2; Wed, 13 Jan 2021 10:26:24 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=39586 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kzi2R-0005jH-CZ; Wed, 13 Jan 2021 10:26:23 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Fredrik Salomonsson Subject: Re: bug#45190: [PATCH 0/1] Add pinentry-rofi References: <20201212021954.78983-1-plattfot@posteo.net> <20210109014707.81676-1-plattfot@posteo.net> Date: Wed, 13 Jan 2021 16:26:22 +0100 In-Reply-To: <20210109014707.81676-1-plattfot@posteo.net> (Fredrik Salomonsson's message of "Fri, 8 Jan 2021 17:47:07 -0800") Message-ID: <871reo97tt.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45190-done Cc: 45190-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Fredrik Salomonsson skribis: > * gnu/packages/gnupg.scm (pinentry-rofi): New variable. Applied, thanks! > + (match (scandir site) > + (("." ".." version) > + (for-each > + (lambda (file) > + (wrap-program > + (string-append bin file) > + (dep-path > + "PATH" > + (string-append (assoc-ref inputs "rofi") "/bin")) > + (dep-path > + "GUILE_LOAD_PATH" > + (uncompiled-dir out version)) > + (dep-path > + "GUILE_LOAD_COMPILED_PATH" > + (compiled-dir out version)))) > + ,''("pinentry-rofi")) As I wrote, it=E2=80=99ll be nicer when this is handled upstream, but we can adjust it on the next release. Ludo=E2=80=99. ------------=_1610551622-1428-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 12 Dec 2020 02:20:51 +0000 Received: from localhost ([127.0.0.1]:43726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knuWh-0001Lx-0e for submit@debbugs.gnu.org; Fri, 11 Dec 2020 21:20:51 -0500 Received: from lists.gnu.org ([209.51.188.17]:57676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knuWd-0001Ln-Pc for submit@debbugs.gnu.org; Fri, 11 Dec 2020 21:20:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knuWd-0002PZ-K5 for guix-patches@gnu.org; Fri, 11 Dec 2020 21:20:47 -0500 Received: from mout01.posteo.de ([185.67.36.65]:56684) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knuWT-0008DS-NT for guix-patches@gnu.org; Fri, 11 Dec 2020 21:20:47 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 9651116005C for ; Sat, 12 Dec 2020 03:20:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1607739633; bh=OzzmBb/pEfedalS1RHpwODboDKLa0XVJAJxRuEeuNAI=; h=From:To:Cc:Subject:Date:From; b=QwZqQVnjzDMIKzN9qekQPY7sv8BFDnQxgWNufUD40ES6o1a+L/7ILYCPRgP1hUr9C v6Hq/tvpvhDnT4nshWwM2r3eJOs6YKWXBEky2RxcAJZp79TRNcrsKKEB1JfzlGKC0F 1VVgccqI+9OW6DbpAOYKvjCWWWZpt31idXuwh68GmKbCEzHZo1jXZ109CmqQvbXsgt 90g2IeyVvJhgKjYKq4kkhUxPveKdkSfWnKQ3Uc7dQL/mJHbplGg6PyJGBQoyYlOkDQ WTYoWD4ppNKaz0Y2c+z6pccawyvhgy52wmyNzd09bm4D+pNbwTIhE7WcAEIHXIRTLc 80uWXDp9sp2ZQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CtBFr2lYCz9rxM; Sat, 12 Dec 2020 03:20:32 +0100 (CET) From: Fredrik Salomonsson To: guix-patches@gnu.org Subject: [PATCH 0/1] Add pinentry-rofi Date: Fri, 11 Dec 2020 18:19:54 -0800 Message-Id: <20201212021954.78983-1-plattfot@posteo.net> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.65; envelope-from=plattfot@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Fredrik Salomonsson X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Add pinentry program that is using rofi to input the passphrase. Fredrik Salomonsson (1): gnu: Add pinentry-rofi. gnu/packages/gnupg.scm | 81 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 81 insertions(+) -- 2.29.2 ------------=_1610551622-1428-1--