From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 09 17:16:16 2020 Received: (at submit) by debbugs.gnu.org; 9 Dec 2020 22:16:16 +0000 Received: from localhost ([127.0.0.1]:36429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kn7kt-0004OT-AF for submit@debbugs.gnu.org; Wed, 09 Dec 2020 17:16:16 -0500 Received: from lists.gnu.org ([209.51.188.17]:50478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kn7DZ-0003Wm-5z for submit@debbugs.gnu.org; Wed, 09 Dec 2020 16:41:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44282) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kn7DY-0006ic-Sq for guix-patches@gnu.org; Wed, 09 Dec 2020 16:41:48 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:57085) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kn7DW-0003b7-AL for guix-patches@gnu.org; Wed, 09 Dec 2020 16:41:48 -0500 Received: from neinpad.lan (unknown [79.175.1.140]) (Authenticated sender: mail@davie.li) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 607A8100002; Wed, 9 Dec 2020 21:41:39 +0000 (UTC) From: David Dashyan To: guix-patches@gnu.org Subject: [PATCH 0/1] Add openfortivpn Date: Thu, 10 Dec 2020 00:41:23 +0300 Message-Id: <20201209214123.27762-1-mail@davie.li> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=217.70.178.231; envelope-from=mail@davie.li; helo=relay11.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 09 Dec 2020 17:16:14 -0500 Cc: David Dashyan X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) base-commit: 2a23e3f582941aee3461aa7b52e0ccb78c9e540d >From 2612f19ac8d9fcc70e01de84f7a7017747bd3d83 Mon Sep 17 00:00:00 2001 Hey! Don't know all ins and outs of this package but I'm using this package and it works fine. gnu/packages/vpn.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) David Dashyan (1): gnu: Add openfortivpn -- 2.29.2 Date: Wed, 09 Dec 2020 23:56:05 +0300 Message-ID: <87sg8evguy.fsf@davie.li> From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 09 17:56:55 2020 Received: (at 45151) by debbugs.gnu.org; 9 Dec 2020 22:56:55 +0000 Received: from localhost ([127.0.0.1]:36511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kn8OA-0005PH-Uz for submit@debbugs.gnu.org; Wed, 09 Dec 2020 17:56:55 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:37081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kn8O8-0005P3-9B for 45151@debbugs.gnu.org; Wed, 09 Dec 2020 17:56:49 -0500 X-Originating-IP: 79.175.1.140 Received: from neinpad.lan (unknown [79.175.1.140]) (Authenticated sender: mail@davie.li) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 23BDEFF802; Wed, 9 Dec 2020 22:56:39 +0000 (UTC) From: David Dashyan To: 45151@debbugs.gnu.org Subject: [PATCH 1/1] gnu: Add openfortivpn Date: Thu, 10 Dec 2020 01:55:53 +0300 Message-Id: <20201209225553.28596-1-mail@davie.li> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45151 Cc: David Dashyan X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --- gnu/packages/vpn.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm index 04c34c3d4d..8af9b89414 100644 --- a/gnu/packages/vpn.scm +++ b/gnu/packages/vpn.scm @@ -14,6 +14,7 @@ ;;; Copyright © 2020 Brice Waegeneire ;;; Copyright © 2020 Ryan Prior ;;; Copyright © 2020 Ivan Kozlov +;;; Copyright © 2020 David Dashyan ;;; ;;; This file is part of GNU Guix. ;;; @@ -287,6 +288,35 @@ and probably others.") (license license:lgpl2.1) (home-page "https://www.infradead.org/openconnect/"))) +(define-public openfortivpn + (package + (name "openfortivpn") + (version "1.15.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/adrienverge/openfortivpn") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1qsfgpxg553s8rc9cyrc4k96z0pislxsdxb9wyhp8fdprkak2mw2")))) + (build-system gnu-build-system) + (native-inputs + `(("openssl" ,openssl) + ("autoconf" ,autoconf) + ("autotools" ,automake) + ("pkg-config" ,pkg-config))) + (propagated-inputs + `(("ppp" ,ppp))) + (home-page "https://openvpn.net/") + (synopsis "Client for PPP+SSL VPN tunnel services") + (description + "Client for PPP+SSL VPN tunnel services. It spawns a pppd process and +operates the communication between the gateway and this process. It is +compatible with Fortinet VPNs.") + (license license:gpl3+))) + (define-public openvpn (package (name "openvpn") -- 2.29.2 From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 10 13:21:11 2020 Received: (at 45151) by debbugs.gnu.org; 10 Dec 2020 18:21:11 +0000 Received: from localhost ([127.0.0.1]:39254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knQYx-0003NI-8H for submit@debbugs.gnu.org; Thu, 10 Dec 2020 13:21:11 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:46047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knQYs-0003MS-Sb for 45151@debbugs.gnu.org; Thu, 10 Dec 2020 13:21:10 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 930365C004B; Thu, 10 Dec 2020 13:21:01 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 10 Dec 2020 13:21:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=mesmtp; bh=LJHq9BCV3pFSB8hwMESdMnB85qELfyXcCgA8eT4J6sc=; b=u7jW1HsIlpmQ yCaR8UkZLgZjZZuhlaKu/Yir1oweCoCcLlJnQAl66Wtyv+w0oiANNLmst8vH4W8t mtshUhmVJTHaSFZ9udOHM0ypKIzYvjLn/6ffGAQTFFGIAw3UXKFaNpOpL5CIKnF4 ihU0fSGsBfgXSplNZdyPVSlN1Uwthsg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=LJHq9BCV3pFSB8hwMESdMnB85qELfyXcCgA8eT4J6 sc=; b=UeC5ETR5vYlfgoOuFT2uZTd07ed4djK9l+GcVEPb+m+B512dUNPyo34HF IXdzq9Q+2fRrLXecw+F+T2tEcAlUIahJgtWza/ENyjSburKt77JdDgF07ZA2ZShb kQfqTwG8r+nA2vnau5Qbu10LfkkiuHQ/aCMKiyrkDj6bR45lLpIIyTkCFD+Xtj7U cisf/ec3RWfPi1ktt3wmkD3Iu+FcprUpgd75hCFxBOlFJkk1NVM1DGxKMuYUmCwB wHuxEcsklQPyXoTuFbdq99eTEgw6K2ifF4A+vbUwU9qj7dlAgrX9KJiez9DCa9RX vtpjZJWM648prC50QfEbOgIT5aIUw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudektddgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtugfgjgesth ekredttddtjeenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhu lhgrrhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhephefgvedvhfeljeetudffleevue eliedtveekfeevhefffeeutdelvedvjeeiffelnecuffhomhgrihhnpehophgvnhhvphhn rdhnvghtnecukfhppeejfedrudeguddruddvjedrudegieenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgr mhgv X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id D819924005A; Thu, 10 Dec 2020 13:20:59 -0500 (EST) Date: Thu, 10 Dec 2020 13:20:58 -0500 From: Leo Famulari To: David Dashyan Subject: Re: [bug#45151] [PATCH 1/1] gnu: Add openfortivpn Message-ID: References: <20201209214123.27762-1-mail@davie.li> <20201209225553.28596-1-mail@davie.li> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201209225553.28596-1-mail@davie.li> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45151 Cc: 45151@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, Dec 10, 2020 at 01:55:53AM +0300, David Dashyan wrote: > +(define-public openfortivpn Thanks! Overall, looks good to me. > + (native-inputs > + `(("openssl" ,openssl) > + ("autoconf" ,autoconf) > + ("autotools" ,automake) > + ("pkg-config" ,pkg-config))) In general, native-inputs are dependencies that are only used while building the package. Typically, OpenSSL is also used at run-time, so it probably should be a regular input. What do you think? > + (propagated-inputs > + `(("ppp" ,ppp))) Propagated-inputs are dependencies that will be installed along with your package when installing the package with e.g. `guix install openfortivpn`. This is for situations where the dependency is needed at run-time but for which the program lacks the ability to refer to dependencies directly. For example, a shell script that needs to invoke `ls` will need to find it on $PATH. It would not be easy to automatically substitute calls to `ls` to the full store path of `/gnu/store/...-coreutils-8.32/bin/ls`. However, most dependencies can be regular inputs, because the built package will refer to the full "/gnu/store/...-ppp-version/" path wherever it needs to invoke the dependency. So, does the package work if the openssl and ppp dependencies are just 'inputs' rather than native-inputs and propagated-inputs? You can use `guix gc --references $(guix build openfortinet)` to see what store references the built package has kept. These references are literally just strings that look like filenames in /gnu/store, found by scanning when the package build is completed. This tool can help one decide if an input should be propagated — if the built package refers to ppp, it likely can find it without propagation. Of course, practical testing is still the true measure. I hope that helps! > + (home-page "https://openvpn.net/") Is this the "home-page" of this program? Usually this field points to the site where the project is coordinated or marketed. It may even be the GitHub repo page. Can you send a revised patch based on this feedback? Please don't hesitate to ask any followup questions :) From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 12 14:59:29 2020 Received: (at 45151) by debbugs.gnu.org; 12 Dec 2020 19:59:29 +0000 Received: from localhost ([127.0.0.1]:46715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koB3B-0007A4-8a for submit@debbugs.gnu.org; Sat, 12 Dec 2020 14:59:29 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:35131) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koB37-00079o-JN for 45151@debbugs.gnu.org; Sat, 12 Dec 2020 14:59:27 -0500 Received: from neinpad (unknown [79.175.1.142]) (Authenticated sender: mail@davie.li) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 1D68D100003; Sat, 12 Dec 2020 19:59:17 +0000 (UTC) References: <20201209214123.27762-1-mail@davie.li> <20201209225553.28596-1-mail@davie.li> User-agent: mu4e 1.4.13; emacs 27.1 From: David Dashyan To: Leo Famulari Subject: Re: [bug#45151] [PATCH 1/1] gnu: Add openfortivpn In-reply-to: Date: Sat, 12 Dec 2020 22:58:26 +0300 Message-ID: <87mtyilrtp.fsf@davie.li> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45151 Cc: David Dashyan , 45151@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hello Leo! > I hope that helps! This does help. Thank you very much for detailed review and tips! I remember when I packaged it first it didn't run without ppp binary: ERROR: /usr/sbin/pppd: No such file or directory. Mistakenly I assumed that propagated inputs is THE way to include runtime dependencies such as commands. I greped the binary -- is does point to /gnu/store/xxx-ppp-2.4.8-1.yyy/sbin/pppd :) Didn't think of that. > So, does the package work if the openssl and ppp dependencies are just > 'inputs' rather than native-inputs and propagated-inputs? I've tested the package with suggested changes. It does work with ppp and openssl in inputs field. ldd points to libssl okay. $ guix environment --pure --ad-hoc openfortivpn [env]$ /run/setuid-programs/sudo --preserve-env \ openfortivpn -c ~/path/to/my/config > You can use `guix gc --references $(guix build openfortinet)` to see > what store references the built package has kept. These references are > literally just strings that look like filenames in /gnu/store, found > by scanning when the package build is completed. Great I will use it! > Is this the "home-page" of this program? Whoops I think i copypasted from definition below. This package doesn't have a home page it seems. BTW I'm what is the right way to send fixes patch? Sending the whole thing again is easier on your side then adding commit patch on top? =2D-=20 David aka zzappie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO/jjc8vL6ogZzi191p8mXoi/t8oFAl/VIOUACgkQ1p8mXoi/ t8rXLw//VafPtXNLlQ+VQzKhxySh27mA+AA+ZQdIzjtcSBtmDJ4OZLvb7LmQ0/Zk m/TxEnbml5r8hZtkOY+Pr6m9Y+tGpzPwqGZmbZopbiarniTP49bnLpbhOMEXjkBR ymt8BNn3EAWKWO25GLD3byccBXkE+epWnbA3PCVFopvh39rfZ1Uw/uaq2fxA/v+U a9yxcye3uDliwJI+TsaVeaL0O18wcp8VYNKE2XLZQiG2iWICf0cNROyhgu3GmZT3 hW7ex1uvDNSYAZBSB1as6DNRr69rd90DKPZ/QRROA0t88ebptAcbWxQbq849sl7M Xd6dQXB4t3KBrEvTnhgNE8l6ZvGCGQiKIiS/GEkxlcxnBunqCZby0XM0Ky3sXR/A Djtlk56cChlXnCEjx2C2QU8UNCRtm/R5DdMEksinmxgCTUiOGhkNZVfN5WtevlKi Nchom/pBWnFogmk4+fc5gsBJ62vty+aaBwiWCoerGPG6vLMablnGylDJZcDlOqy2 1qQSwCLj1B5EEJjOpuAaich/1b6vmk9y3aGn1KJZy6UKHsx6nVFukBwyiwji3I+H ORsR2/kBfsKcGyXxHnMUddnp5t8fDNCSyD1Gd+WmpqXjZXgsP2naCJy6gSRXfNtH EqpnOCu/ecdBDCgSzsLs85SHeZN0occd4Cy2BgDudPxR6voMM3g= =iOzU -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 12 15:03:50 2020 Received: (at 45151) by debbugs.gnu.org; 12 Dec 2020 20:03:50 +0000 Received: from localhost ([127.0.0.1]:46719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koB7K-0000x7-RD for submit@debbugs.gnu.org; Sat, 12 Dec 2020 15:03:50 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:47253) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koB7I-0000ws-75 for 45151@debbugs.gnu.org; Sat, 12 Dec 2020 15:03:45 -0500 Received: from neinpad.lan (unknown [79.175.1.142]) (Authenticated sender: mail@davie.li) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 4C58D100003; Sat, 12 Dec 2020 20:03:37 +0000 (UTC) From: David Dashyan To: 45151@debbugs.gnu.org Subject: [PATCH] gnu: Add openfortivpn Date: Sat, 12 Dec 2020 23:03:03 +0300 Message-Id: <20201212200303.13683-1-mail@davie.li> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45151 Cc: David Dashyan X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) gnu: openfortivpn: adjust inputs and homepage --- gnu/packages/vpn.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm index 04c34c3d4d..90e6778ead 100644 --- a/gnu/packages/vpn.scm +++ b/gnu/packages/vpn.scm @@ -14,6 +14,7 @@ ;;; Copyright © 2020 Brice Waegeneire ;;; Copyright © 2020 Ryan Prior ;;; Copyright © 2020 Ivan Kozlov +;;; Copyright © 2020 David Dashyan ;;; ;;; This file is part of GNU Guix. ;;; @@ -287,6 +288,35 @@ and probably others.") (license license:lgpl2.1) (home-page "https://www.infradead.org/openconnect/"))) +(define-public openfortivpn + (package + (name "openfortivpn") + (version "1.15.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/adrienverge/openfortivpn") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1qsfgpxg553s8rc9cyrc4k96z0pislxsdxb9wyhp8fdprkak2mw2")))) + (build-system gnu-build-system) + (native-inputs + `(("autoconf" ,autoconf) + ("autotools" ,automake) + ("pkg-config" ,pkg-config))) + (inputs + `(("openssl" ,openssl) + ("ppp" ,ppp))) + (home-page "https://github.com/adrienverge/openfortivpn") + (synopsis "Client for PPP+SSL VPN tunnel services") + (description + "Client for PPP+SSL VPN tunnel services. It spawns a pppd process and +operates the communication between the gateway and this process. It is +compatible with Fortinet VPNs.") + (license license:gpl3+))) + (define-public openvpn (package (name "openvpn") base-commit: 91e35e32a4938e0e37499c64fa8ed3e7cf51dce3 -- 2.29.2 From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 12 16:57:44 2020 Received: (at 45151) by debbugs.gnu.org; 12 Dec 2020 21:57:44 +0000 Received: from localhost ([127.0.0.1]:46998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koCtc-0008IP-2O for submit@debbugs.gnu.org; Sat, 12 Dec 2020 16:57:44 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:36273) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koCtb-0008IA-0G for 45151@debbugs.gnu.org; Sat, 12 Dec 2020 16:57:43 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 4BE4C386; Sat, 12 Dec 2020 16:57:37 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 12 Dec 2020 16:57:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=wy48mLvuTl7yr8jgnwR5kfUE hE6aJsu7JM9vZdmgaXA=; b=BVe3NvFVYIlN79T91q/QbYrWa2bBrrpUx6JFJ2Py Eys0+VU7S62UjIQzcYytp1gcz9gnV8qAeNNahLUjo1Jm8S2IN4BlIX2uK+cBVkLQ aslB8693bzAXRnTwlo9FsQ6KhmcAX34pGPLc3Klkqbo8cpvq8TQp/Jem6YrhXkWQ Khc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=wy48mL vuTl7yr8jgnwR5kfUEhE6aJsu7JM9vZdmgaXA=; b=VMYSpx8BABdnCZxHL7BS4A LjTjiqt9MApLX4YO7D0phoyyaJLIG1H15rOY6MT6xas0MGWLaj+jnGYGj4rKGSco Jam/iDqDfW+8y1lYF14kKbIfwluRrS6UTgY7XsoKgSL5rWTEg77hVd14nWtp3Fi5 5H6K25xeZ3FRIRT1mrLwqjR/aC7VncbAHi2Q4p3hVMLOnAJdd/J+PFRkvLueoEKD CBGPAZR+5pBRsBV+/oGy/DI1xhOfIq6Ww402zKmRAE3Bzy+/UVGBIiY/t1ow6Iwb AMs8dp7y7DlvY3Sg827TD9u+sayZA5vZvTgXnxoO2gFwaTYXqShKwxK2AZkYMhkA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudekgedgudehiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjsehgtd erredttddvnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhl rghrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpedukeevgeetkeeltefgiedtjefgje ekffduteehvdfhueekudelieekjeefheffteenucfkphepjeefrddugedurdduvdejrddu geeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplh gvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id BDC87240057; Sat, 12 Dec 2020 16:57:36 -0500 (EST) Date: Sat, 12 Dec 2020 16:57:35 -0500 From: Leo Famulari To: David Dashyan Subject: Re: [bug#45151] [PATCH 1/1] gnu: Add openfortivpn Message-ID: References: <20201209214123.27762-1-mail@davie.li> <20201209225553.28596-1-mail@davie.li> <87mtyilrtp.fsf@davie.li> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="j8WnaNvoiCbpd7xl" Content-Disposition: inline In-Reply-To: <87mtyilrtp.fsf@davie.li> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45151 Cc: 45151@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --j8WnaNvoiCbpd7xl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Dec 12, 2020 at 10:58:26PM +0300, David Dashyan wrote: > BTW I'm what is the right way to send fixes patch? Sending the whole > thing again is easier on your side then adding commit patch on top? Yes, it's easier if you send a completely new patch rather than an incremental patch. Thanks again! --j8WnaNvoiCbpd7xl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAl/VPM8ACgkQJkb6MLrK fwhWQQ//ZVGJMaVEfJQ3hyo7pxWJKg2B9+Ke7UBs2t7paBWQw4Cm6fLqfBHxYo6I OHizIHDYxXkmqImECuxlcIw7jummB3bJ6yK717wTFZ4wiyms8AvES8XmuVTP4SA5 BvisJt5gZ6mEzq97NZ++yH5ySqF2rKL4U2DydbM8X4BP60A4ayPWCLCXMAwv7Dxp YAH7vhPFthLJGmAgSwMLWbPX5rMHSVYaVJjUjizpbrG7RyanBvUpbLHVXQ+bp/3+ ogxtLpEOUAm8LhvJ9PUdlaf9zoZXbb6I1fD3HcbwBNY1DSoc51tLuzAuAR2w0soV Gc3bSTKUoKlSzY5QHBkC07OUgG54eZvXWE7KSNf2E1ch2W3uwIiNdfi4rQFpYzub g6xqBCOOlPCzoqov3E9eMugntci38Tv1Nis7mA0/3mDIJjF34dcdnYTSU551OO4R XqQsa2AerOkf3VTjHBTkVaXHBtOrdfQYy9svabpk1msYxqKykYJizRieKlsKAUZy gmsG2IFEZsseOy04jy0Iz8Vd682mX7VN8OD1t8MDkEYM72+/HFpxaD2kMRcl1Y7L KMpQNP/30SjdUeg1+NGVsWOMYS+b29YzVvkamYpps9El3YAerMLtuioAqtAJIHDV YDLH2Z+gtm0sGX7PNz6Uj1U11ybWs1lHO2jznT/PZGX0NCztXTg= =XTO9 -----END PGP SIGNATURE----- --j8WnaNvoiCbpd7xl-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 12 16:57:13 2020 Received: (at 45151-done) by debbugs.gnu.org; 12 Dec 2020 21:57:13 +0000 Received: from localhost ([127.0.0.1]:46994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koCt6-0008Ha-PW for submit@debbugs.gnu.org; Sat, 12 Dec 2020 16:57:12 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:55797) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koCt4-0008HJ-Dq for 45151-done@debbugs.gnu.org; Sat, 12 Dec 2020 16:57:11 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id A2F36548; Sat, 12 Dec 2020 16:57:03 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 12 Dec 2020 16:57:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=hZZOf8/oujbpyJ7RzPkQx8CG 8EnmI7vGHC9i5WIhXgc=; b=M9rJu/tSUbsNHKLI3QmtJ3G+tXKAyC2E8QY3VyKz p5ruEjJ8JqHLmXr6ROyqbHYsETYKv5WAxpTkgfKMq6a4d8ygNc6KA5t7PmvDnKcU BmT5pfqjKojA1qm6/3t4j7YasGbLC9J/Bf6MoCdimhebocH5k4YA4lkpjM5MmzQI o7Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=hZZOf8 /oujbpyJ7RzPkQx8CG8EnmI7vGHC9i5WIhXgc=; b=hrF2K/xJekW7dHXiz+o1X8 AdKFzJ1ZWHNg33jIbPVMOISChXiJKfx4qvMR6/tp3qkwHx2w8fpGXb9xpiSDXjXD XnlOgXl6W8szn2ZOug+AlRtf1opTQ/HbZGHetO4tMWzI95jBqVJUS//Z+HpDsEfm VxCVGMR0RH0q+6HqSCqse2NsCAcIRWonxKBCxeEHFmPpZkFmbdRzBdIk8wEUJPmn h57n/dZB+rXSd9hx7fFPqOcXUZCVLUFA8D18o0jwPaaiwZdIQ55wRLfYtU1sNWYO Ky+DoTAbOJqACtfoYWCK9W+fGW6E2/qSF7W5RTgBFruUnH8ZkFIcu5805nWU0Ryw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudekgedgudehiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjsehttd ertddttddvnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhl rghrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeeukeektdffvddtudegjeegtdevhf eufeeivdejiedtieegtdevjedvjeehffevgfenucfkphepjeefrddugedurdduvdejrddu geeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplh gvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id 04EF6240062; Sat, 12 Dec 2020 16:57:01 -0500 (EST) Date: Sat, 12 Dec 2020 16:56:59 -0500 From: Leo Famulari To: David Dashyan Subject: Re: [bug#45151] [PATCH] gnu: Add openfortivpn Message-ID: References: <20201209214123.27762-1-mail@davie.li> <20201212200303.13683-1-mail@davie.li> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201212200303.13683-1-mail@davie.li> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45151-done Cc: 45151-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sat, Dec 12, 2020 at 11:03:03PM +0300, David Dashyan wrote: > gnu: openfortivpn: adjust inputs and homepage Thanks! I adjusted the commit message, made sure the description was composed of complete sentences, and pushed as 18918ebeeb152731e06634a003e8cf3edd24f6a3. From unknown Fri Sep 05 20:37:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 10 Jan 2021 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator