GNU bug report logs - #45150
[PATCH 1/5] gnu: libid3tag: Install pkg-config file.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Kei Kebreau <kkebreau <at> posteo.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#45150: closed ([PATCH 1/5] gnu: libid3tag: Install pkg-config
 file.)
Date: Sun, 27 Dec 2020 22:05:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 27 Dec 2020 17:04:29 -0500
with message-id <87v9cmq51u.fsf_-_ <at> posteo.net>
and subject line Re: bug#45150: [PATCH 1/5] gnu: libid3tag: Install pkg-config file.
has caused the debbugs.gnu.org bug report #45150,
regarding [PATCH 1/5] gnu: libid3tag: Install pkg-config file.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
45150: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=45150
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Kei Kebreau <kkebreau <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Kei Kebreau <kkebreau <at> posteo.net>
Subject: [PATCH 1/5] gnu: libid3tag: Install pkg-config file.
Date: Wed,  9 Dec 2020 17:11:43 -0500

* gnu/packages/mp3.scm (libid3tag)[arguments]: Add 'install-pkg-config phase.
---
 gnu/packages/mp3.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
index 4bdbe8b487..d5c8ee14b4 100644
--- a/gnu/packages/mp3.scm
+++ b/gnu/packages/mp3.scm
@@ -106,6 +106,28 @@ This package contains the library.")
              (base32
               "0lb1w883dc46dajbdvnia5870brl5lvnlk7g7y58y9wpg5p4znk3"))))
    (build-system gnu-build-system)
+   (arguments
+    `(#:phases
+      (modify-phases %standard-phases
+        (add-after 'install 'install-pkg-config
+          (lambda* (#:key outputs #:allow-other-keys)
+            (let* ((out (assoc-ref outputs "out"))
+                   (pkg-config-dir (string-append out "/lib/pkgconfig")))
+              (mkdir-p pkg-config-dir)
+              (with-output-to-file (string-append pkg-config-dir "/id3tag.pc")
+                (lambda _
+                  (format #t
+                          "prefix=~@*~a~@
+                           libdir=${prefix}/lib~@
+                           includedir=${prefix}/include~@
+
+                           Name: libid3tag~@
+                           Description:~@
+                           Version: ~a~@
+                           Libs: -L${libdir} -lid3tag -lz~@
+                           Cflags: -I${includedir}~%"
+                          out
+                          ,version)))))))))
    (inputs `(("zlib" ,zlib)))
    (synopsis "Library for reading ID3 tags")
    (description
-- 
2.29.2

[Message part 3 (message/rfc822, inline)]

From: Kei Kebreau <kkebreau <at> posteo.net>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 45150-done <at> debbugs.gnu.org
Subject: Re: bug#45150: [PATCH 1/5] gnu: libid3tag: Install pkg-config file.
Date: Sun, 27 Dec 2020 17:04:29 -0500

[Message part 4 (text/plain, inline)]

Efraim Flashner <efraim <at> flashner.co.il> writes:

> Looks good. Thanks for making all the pkg-config files. My only
> suggestion is to move ,out and version to the same line on the
> pkg-config file creation phases.

Done and pushed to master.  Thanks for reviewing!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.