From oscarfv@telefonica.net Mon Sep 21 19:27:26 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 22 Sep 2009 02:27:27 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8M2RP8h007372 for ; Mon, 21 Sep 2009 19:27:26 -0700 Received: from mail.gnu.org ([199.232.76.166]:51129 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Mpv6C-00035k-E3 for emacs-pretest-bug@gnu.org; Mon, 21 Sep 2009 22:27:24 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Mpv6A-00046d-VK for emacs-pretest-bug@gnu.org; Mon, 21 Sep 2009 22:27:24 -0400 Received: from impaqm4.telefonica.net ([213.4.138.4]:35031) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mpv6A-00045T-EB for emacs-pretest-bug@gnu.org; Mon, 21 Sep 2009 22:27:22 -0400 Received: from IMPmailhost4.adm.correo ([10.20.102.125]) by IMPaqm4.telefonica.net with bizsmtp id jeRp1c00G2iL0W23QeSyKi; Tue, 22 Sep 2009 04:26:58 +0200 Received: from qcore ([83.43.52.24]) by IMPmailhost4.adm.correo with BIZ IMP id jePk1c0030XKxp71kePlmB; Tue, 22 Sep 2009 04:23:45 +0200 X-TE-authinfo: authemail="981711563$telefonica.net" |auth_email="981711563@telefonica.net" X-TE-AcuTerraCos: auth_cuTerraCos="cosuitnetc01" From: ofv@wanadoo.es (=?windows-1252?Q?=D3scar?= Fuentes) To: emacs-pretest-bug@gnu.org Subject: 23.1.50; Reverting changes on versioned file does not revert vc modeline status Date: Tue, 22 Sep 2009 04:26:57 +0200 Message-ID: <87ws3rlnny.fsf@telefonica.net> MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing lis= t. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: When a modified versioned file is edited in such a way that the modifications undoes previous changes to the file, after saving it the VC-dired buffer for the working copy is automatically updated showing that the status of the file is "up to date", but the VC modeline for the buffer that visits the file does not change and keeps indicating that the file state is "locally modified". If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. If you would like to further debug the crash, please read the file /usr/local/share/emacs/23.1.50/etc/DEBUG for instructions. In GNU Emacs 23.1.50.1 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d scroll b= ars) of 2009-09-06 on qcore Windowing system distributor `The X.Org Foundation', version 11.0.10600000 configured using `configure '--with-x-toolkit=3Dlucid'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: C++/lah Minor modes in effect: erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-netsplit-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t show-paren-mode: t diff-auto-refine-mode: t iswitchb-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t abbrev-mode: t Recent input: n d ( ) SPC ) ; } / / - - - - - - - - - -=20 - - - =20 =20 =20 =20 =20 M-d =20 / / - - - - - - - - - - - - - -=20 - - =20 - =20 =20 =20 C-x C-s M-x c m a k e C-g=20 M-x s e t SPC a c t i v e SPC c o m =20 g c c M-x c m a k e =20 =20 C-x=20 b e x e C-r t y p e d e f C-a C-x b =20 M-d C-y C-x C-s C-e =20 - > C-a C-k C-k C-x C-s =20 C-e =20 M-d f f i c g C-x C-s C-x o =20 =20 =20 =20 M-d C-d C-x=20 C-s M-x g n u s =20 d q d q q y M-x g n u s q=20 y =20 Recent messages: Opening nnfolder server on archive...done Reading active file from archive via nnfolder...done Generating the cache active file...done No new newsgroups Checking new news... Opening nntp server on news.gmane.org...done Checking new news...done No more unread newsgroups Are you sure you want to quit reading news? (y or n)=20 (No changes need to be saved) Load-path shadows: None found. --=20 =D3scar Fuentes Desarrollo de Software From dann@godzilla.ics.uci.edu Tue Sep 22 22:53:27 2009 Received: (at 4515) by emacsbugs.donarmstrong.com; 23 Sep 2009 05:53:27 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.5 required=4.0 tests=AWL,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8N5rQRX028587 for <4515@emacsbugs.donarmstrong.com>; Tue, 22 Sep 2009 22:53:27 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n8N5rFSu019003; Tue, 22 Sep 2009 22:53:15 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n8N5rEsT023798; Tue, 22 Sep 2009 22:53:14 -0700 (PDT) Date: Tue, 22 Sep 2009 22:53:14 -0700 (PDT) Message-Id: <200909230553.n8N5rEsT023798@godzilla.ics.uci.edu> From: Dan Nicolaescu To: =C3=93scar?= Fuentes Cc: 4515@debbugs.gnu.org Subject: Re: bug#4515: 23.1.50; Reverting changes on versioned file does not revert vc modeline status References: <87ws3rlnny.fsf@telefonica.net> X-Debbugs-No-Ack: yes In-Reply-To: <87ws3rlnny.fsf@telefonica.net> (ofv@wanadoo.es. =?utf-8?Q?=22=28=C3=B3scar=22?= fuentes 's message of "Tue, 22 Sep 2009 04:26:57 +0200") Lines: 19 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n8N5rFSu019003 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu ofv@wanadoo.es. "(=C3=93scar" Fuentes) writes: > Please write in English if possible, because the Emacs maintainers > usually do not have translators to read other languages for them. >=20 > Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing= list. >=20 > Please describe exactly what actions triggered the bug > and the precise symptoms of the bug: >=20 > When a modified versioned file is edited in such a way that the > modifications undoes previous changes to the file, after saving it the > VC-dired buffer for the working copy is automatically updated showing > that the status of the file is "up to date", but the VC modeline for the > buffer that visits the file does not change and keeps indicating that > the file state is "locally modified". Can you please describe step by step the actions necessary to reproduce this starting from emacs -Q? From oscarfv@telefonica.net Tue Sep 22 23:50:03 2009 Received: (at 4515) by emacsbugs.donarmstrong.com; 23 Sep 2009 06:50:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.4 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from IMPaqm5.telefonica.net (impaqm5.telefonica.net [213.4.138.5]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8N6o0Vt004402 for <4515@emacsbugs.donarmstrong.com>; Tue, 22 Sep 2009 23:50:02 -0700 Received: from IMPmailhost6.adm.correo ([10.20.102.127]) by IMPaqm5.telefonica.net with bizsmtp id k6Sm1c0272kvMAa3R6q0Sk; Wed, 23 Sep 2009 08:50:00 +0200 Received: from qcore ([83.43.52.24]) by IMPmailhost6.adm.correo with BIZ IMP id k6ov1c0010XKxp71m6ovrs; Wed, 23 Sep 2009 08:48:58 +0200 X-TE-authinfo: authemail="981711563$telefonica.net" |auth_email="981711563@telefonica.net" X-TE-AcuTerraCos: auth_cuTerraCos="cosuitnetc01" From: =?windows-1252?Q?=D3scar_Fuentes?= To: Dan Nicolaescu Cc: 4515@debbugs.gnu.org Subject: Re: bug#4515: 23.1.50; Reverting changes on versioned file does not revert vc modeline status References: <87ws3rlnny.fsf@telefonica.net> <200909230553.n8N5rEsT023798@godzilla.ics.uci.edu> Date: Wed, 23 Sep 2009 08:49:56 +0200 In-Reply-To: <200909230553.n8N5rEsT023798@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Tue, 22 Sep 2009 22:53:14 -0700 (PDT)") Message-ID: <87eipykve3.fsf@telefonica.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Dan Nicolaescu writes: > ofv@wanadoo.es. "(=D3scar" Fuentes) writes: > > > Please write in English if possible, because the Emacs maintainers > > usually do not have translators to read other languages for them. > >=20 > > Your bug report will be posted to the emacs-pretest-bug@gnu.org maili= ng list. > >=20 > > Please describe exactly what actions triggered the bug > > and the precise symptoms of the bug: > >=20 > > When a modified versioned file is edited in such a way that the > > modifications undoes previous changes to the file, after saving it the > > VC-dired buffer for the working copy is automatically updated showing > > that the status of the file is "up to date", but the VC modeline for = the > > buffer that visits the file does not change and keeps indicating that > > the file state is "locally modified". > > Can you please describe step by step the actions necessary to reproduce > this starting from emacs -Q? emacs -Q C-x C-f some-versioned-unmodified-file do some edition C-x C-s (the VC status modeline indicator changes from `-' to `:') undo previous edition C-x C-s Now you just turned the file to its original state and is unmodified as far as the version control system is concerned, but the VC modeline keeps showing `:' (for example Bzr:836) indicating that the file is edited. After saving a versioned file, VC should check if the VC backend flags the file as edited and update the modeline accordingly. --=20 =D3scar From dann@godzilla.ics.uci.edu Wed Sep 23 11:36:26 2009 Received: (at 4515) by emacsbugs.donarmstrong.com; 23 Sep 2009 18:36:26 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.5 required=4.0 tests=AWL,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8NIaPkg019249 for <4515@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 11:36:26 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n8NIa7OO019246; Wed, 23 Sep 2009 11:36:07 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n8NIa6Lv029481; Wed, 23 Sep 2009 11:36:06 -0700 (PDT) Date: Wed, 23 Sep 2009 11:36:06 -0700 (PDT) Message-Id: <200909231836.n8NIa6Lv029481@godzilla.ics.uci.edu> From: Dan Nicolaescu To: =?utf-8?Q?=C3=93scar?= Fuentes Cc: 4515@debbugs.gnu.org Subject: Re: bug#4515: 23.1.50; Reverting changes on versioned file does not revert vc modeline status References: <87ws3rlnny.fsf@telefonica.net> <200909230553.n8N5rEsT023798@godzilla.ics.uci.edu> <87eipykve3.fsf@telefonica.net> X-Debbugs-No-Ack: yes In-Reply-To: <87eipykve3.fsf@telefonica.net> (=?utf-8?Q?=22=C3=93scar?= Fuentes"'s message of "Wed, 23 Sep 2009 08:49:56 +0200") Lines: 43 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n8NIa7OO019246 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu =C3=93scar Fuentes writes: > Dan Nicolaescu writes: >=20 > > ofv@wanadoo.es. "(=C3=93scar" Fuentes) writes: > > > > > Please write in English if possible, because the Emacs maintainers > > > usually do not have translators to read other languages for them. > > >=20 > > > Your bug report will be posted to the emacs-pretest-bug@gnu.org m= ailing list. > > >=20 > > > Please describe exactly what actions triggered the bug > > > and the precise symptoms of the bug: > > >=20 > > > When a modified versioned file is edited in such a way that the > > > modifications undoes previous changes to the file, after saving i= t the > > > VC-dired buffer for the working copy is automatically updated sho= wing > > > that the status of the file is "up to date", but the VC modeline = for the > > > buffer that visits the file does not change and keeps indicating = that > > > the file state is "locally modified". > > > > Can you please describe step by step the actions necessary to reprodu= ce > > this starting from emacs -Q? >=20 > emacs -Q >=20 > C-x C-f some-versioned-unmodified-file > do some edition > C-x C-s (the VC status modeline indicator changes from `-' to `:') > undo previous edition > C-x C-s >=20 > Now you just turned the file to its original state and is unmodified as > far as the version control system is concerned, but the VC modeline > keeps showing `:' (for example Bzr:836) indicating that the file is > edited. After saving a versioned file, VC should check if the VC backend > flags the file as edited and update the modeline accordingly. You can do M-x revert-buffer or C-x v u and that would reset the VC state accordingly. Checking for this condition after each save is prohibitively expensive, and it's an extremely rare event, so it's not worth optimizing for. So this is neither a bug, not something worth improving. From oscarfv@telefonica.net Wed Sep 23 13:36:07 2009 Received: (at 4515) by emacsbugs.donarmstrong.com; 23 Sep 2009 20:36:07 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.2 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from IMPaqm4.telefonica.net (impaqm4.telefonica.net [213.4.138.4]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8NKa4ZZ012595 for <4515@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 13:36:06 -0700 Received: from IMPmailhost5.adm.correo ([10.20.102.126]) by IMPaqm4.telefonica.net with bizsmtp id kFUl1c00U2jdgqJ3QKX4xk; Wed, 23 Sep 2009 21:31:04 +0200 Received: from qcore ([83.43.52.24]) by IMPmailhost5.adm.correo with BIZ IMP id kKWK1c00B0XKxp71lKWKgt; Wed, 23 Sep 2009 21:30:20 +0200 X-TE-authinfo: authemail="981711563$telefonica.net" |auth_email="981711563@telefonica.net" X-TE-AcuTerraCos: auth_cuTerraCos="cosuitnetc01" From: =?windows-1252?Q?=D3scar_Fuentes?= To: Dan Nicolaescu Cc: 4515@debbugs.gnu.org Subject: Re: bug#4515: 23.1.50; Reverting changes on versioned file does not revert vc modeline status References: <87ws3rlnny.fsf@telefonica.net> <200909230553.n8N5rEsT023798@godzilla.ics.uci.edu> <87eipykve3.fsf@telefonica.net> <200909231836.n8NIa6Lv029481@godzilla.ics.uci.edu> Date: Wed, 23 Sep 2009 21:31:03 +0200 In-Reply-To: <200909231836.n8NIa6Lv029481@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Wed, 23 Sep 2009 11:36:06 -0700 (PDT)") Message-ID: <874oqtlaq0.fsf@telefonica.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Dan Nicolaescu writes: > =D3scar Fuentes writes: > > > Dan Nicolaescu writes: > >=20 > > > ofv@wanadoo.es. "(=D3scar" Fuentes) writes: > > > > > > > Please write in English if possible, because the Emacs maintain= ers > > > > usually do not have translators to read other languages for the= m. > > > >=20 > > > > Your bug report will be posted to the emacs-pretest-bug@gnu.org= mailing list. > > > >=20 > > > > Please describe exactly what actions triggered the bug > > > > and the precise symptoms of the bug: > > > >=20 > > > > When a modified versioned file is edited in such a way that the > > > > modifications undoes previous changes to the file, after saving= it the > > > > VC-dired buffer for the working copy is automatically updated s= howing > > > > that the status of the file is "up to date", but the VC modelin= e for the > > > > buffer that visits the file does not change and keeps indicatin= g that > > > > the file state is "locally modified". > > > > > > Can you please describe step by step the actions necessary to repro= duce > > > this starting from emacs -Q? > >=20 > > emacs -Q > >=20 > > C-x C-f some-versioned-unmodified-file > > do some edition > > C-x C-s (the VC status modeline indicator changes from `-' to `:') > > undo previous edition > > C-x C-s > >=20 > > Now you just turned the file to its original state and is unmodified = as > > far as the version control system is concerned, but the VC modeline > > keeps showing `:' (for example Bzr:836) indicating that the file is > > edited. After saving a versioned file, VC should check if the VC back= end > > flags the file as edited and update the modeline accordingly. > > You can do M-x revert-buffer or C-x v u and that would reset the VC > state accordingly. Yes, I know. > Checking for this condition after each save is prohibitively expensive, > and it's an extremely rare event, so it's not worth optimizing for. Automatically checking the VC state after each save is actually performed if there is a vc-dired buffer for the working copy where the file resides. That check updates the vc-dired with the correct state of the saved file. Part of my job is experimenting tweaks and micro-improvements on existing code bases. After every session I end with lots of buffers showing the "edited" vc modeline indicator when in fact only one or two are effectively edited. This renders useless the vc state indicator and turns its meaning into "When `:' is shown, this file was edited, but it may be up-to-date now". > So this is neither a bug, not something worth improving. Well, the vc status on the modeline is showing the wrong state. Would you accept a patch that implements an option for checking after every save and updating the vc state on the modeline accordingly? --=20 =D3scar From dann@godzilla.ics.uci.edu Wed Sep 23 14:21:50 2009 Received: (at 4515) by emacsbugs.donarmstrong.com; 23 Sep 2009 21:21:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.5 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8NLLn7v019469 for <4515@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 14:21:50 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n8NLLb2u016656; Wed, 23 Sep 2009 14:21:37 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n8NLLb89001068; Wed, 23 Sep 2009 14:21:37 -0700 (PDT) Date: Wed, 23 Sep 2009 14:21:37 -0700 (PDT) Message-Id: <200909232121.n8NLLb89001068@godzilla.ics.uci.edu> From: Dan Nicolaescu To: =?utf-8?Q?=C3=93scar?= Fuentes Cc: 4515@debbugs.gnu.org Subject: Re: bug#4515: 23.1.50; Reverting changes on versioned file does not revert vc modeline status References: <87ws3rlnny.fsf@telefonica.net> <200909230553.n8N5rEsT023798@godzilla.ics.uci.edu> <87eipykve3.fsf@telefonica.net> <200909231836.n8NIa6Lv029481@godzilla.ics.uci.edu> <874oqtlaq0.fsf@telefonica.net> X-Debbugs-No-Ack: yes In-Reply-To: <874oqtlaq0.fsf@telefonica.net> (=?utf-8?Q?=22=C3=93scar?= Fuentes"'s message of "Wed, 23 Sep 2009 21:31:03 +0200") Lines: 73 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n8NLLb2u016656 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu =C3=93scar Fuentes writes: > Dan Nicolaescu writes: >=20 > > =C3=93scar Fuentes writes: > > > > > Dan Nicolaescu writes: > > >=20 > > > > ofv@wanadoo.es. "(=C3=93scar" Fuentes) writes: > > > > > > > > > Please write in English if possible, because the Emacs main= tainers > > > > > usually do not have translators to read other languages for= them. > > > > >=20 > > > > > Your bug report will be posted to the emacs-pretest-bug@gnu= .org mailing list. > > > > >=20 > > > > > Please describe exactly what actions triggered the bug > > > > > and the precise symptoms of the bug: > > > > >=20 > > > > > When a modified versioned file is edited in such a way that= the > > > > > modifications undoes previous changes to the file, after sa= ving it the > > > > > VC-dired buffer for the working copy is automatically updat= ed showing > > > > > that the status of the file is "up to date", but the VC mod= eline for the > > > > > buffer that visits the file does not change and keeps indic= ating that > > > > > the file state is "locally modified". > > > > > > > > Can you please describe step by step the actions necessary to r= eproduce > > > > this starting from emacs -Q? > > >=20 > > > emacs -Q > > >=20 > > > C-x C-f some-versioned-unmodified-file > > > do some edition > > > C-x C-s (the VC status modeline indicator changes from `-' to `:') > > > undo previous edition > > > C-x C-s > > >=20 > > > Now you just turned the file to its original state and is unmodif= ied as > > > far as the version control system is concerned, but the VC modeli= ne > > > keeps showing `:' (for example Bzr:836) indicating that the file = is > > > edited. After saving a versioned file, VC should check if the VC = backend > > > flags the file as edited and update the modeline accordingly. > > > > You can do M-x revert-buffer or C-x v u and that would reset the VC > > state accordingly. >=20 > Yes, I know. >=20 > > Checking for this condition after each save is prohibitively expensiv= e, > > and it's an extremely rare event, so it's not worth optimizing for. >=20 > Automatically checking the VC state after each save is actually > performed if there is a vc-dired buffer for the working copy where the > file resides. That check updates the vc-dired with the correct state of > the saved file. >=20 > Part of my job is experimenting tweaks and micro-improvements on > existing code bases. After every session I end with lots of buffers > showing the "edited" vc modeline indicator when in fact only one or two > are effectively edited. This renders useless the vc state indicator and > turns its meaning into "When `:' is shown, this file was edited, but it > may be up-to-date now". >=20 > > So this is neither a bug, not something worth improving. >=20 > Well, the vc status on the modeline is showing the wrong state. > Would you accept a patch that implements an option for checking after > every save and updating the vc state on the modeline accordingly? Although I've done a lot of work on VC, I am not an official maintainer of VC, so I am in no position to do that. But I don't think such a change is a good idea. From geb-bug-gnu-emacs@m.gmane.org Wed Sep 23 19:09:17 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 24 Sep 2009 02:09:18 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.7 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8O29EOk007463 for ; Wed, 23 Sep 2009 19:09:17 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mqdli-0006DG-AV for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2009 22:09:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mqdld-0006D4-5k for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2009 22:09:14 -0400 Received: from [199.232.76.173] (port=32899 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mqdld-0006D0-1P for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2009 22:09:09 -0400 Received: from lo.gmane.org ([80.91.229.12]:57357) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mqdlc-00012E-JU for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2009 22:09:08 -0400 Received: from list by lo.gmane.org with local (Exim 4.50) id 1MqdlZ-0002f0-N1 for bug-gnu-emacs@gnu.org; Thu, 24 Sep 2009 04:09:05 +0200 Received: from c-71-237-24-138.hsd1.co.comcast.net ([71.237.24.138]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 24 Sep 2009 04:09:05 +0200 Received: from kevin.d.rodgers by c-71-237-24-138.hsd1.co.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 24 Sep 2009 04:09:05 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Kevin Rodgers Subject: Re: bug#4515: 23.1.50; Reverting changes on versioned file does not revert vc modeline status Date: Wed, 23 Sep 2009 20:08:50 -0600 Lines: 32 Message-ID: References: <87ws3rlnny.fsf@telefonica.net> <200909230553.n8N5rEsT023798@godzilla.ics.uci.edu> <87eipykve3.fsf@telefonica.net> <200909231836.n8NIa6Lv029481@godzilla.ics.uci.edu> <874oqtlaq0.fsf@telefonica.net> <200909232121.n8NLLb89001068@godzilla.ics.uci.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: c-71-237-24-138.hsd1.co.comcast.net User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) In-Reply-To: <200909232121.n8NLLb89001068@godzilla.ics.uci.edu> Sender: news X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Dan Nicolaescu wrote: > Óscar Fuentes writes: > > > Dan Nicolaescu writes: ... > > > Checking for this condition after each save is prohibitively expensive, > > > and it's an extremely rare event, so it's not worth optimizing for. > > > > Automatically checking the VC state after each save is actually > > performed if there is a vc-dired buffer for the working copy where the > > file resides. That check updates the vc-dired with the correct state of > > the saved file. ... > > > So this is neither a bug, not something worth improving. > > > > Well, the vc status on the modeline is showing the wrong state. > > > Would you accept a patch that implements an option for checking after > > every save and updating the vc state on the modeline accordingly? > > Although I've done a lot of work on VC, I am not an official maintainer > of VC, so I am in no position to do that. But I don't think such a > change is a good idea. Should that feature be removed from vc-dired, so that it is consistent with the buffer's mode line? (No, I'm not serious.) -- Kevin Rodgers Denver, Colorado, USA From monnier@iro.umontreal.ca Wed Sep 23 19:25:39 2009 Received: (at 4515) by emacsbugs.donarmstrong.com; 24 Sep 2009 02:25:39 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.8 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.pppoe.ca (ironport2-out.teksavvy.com [206.248.154.183]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8O2Pb0r010785 for <4515@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 19:25:39 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ar4EAFt1ukpFpYEz/2dsb2JhbACBUdRbhBsFh34 X-IronPort-AV: E=Sophos;i="4.44,442,1249272000"; d="scan'208";a="46463106" Received: from 69-165-129-51.dsl.teksavvy.com (HELO pastel.home) ([69.165.129.51]) by ironport2-out.pppoe.ca with ESMTP; 23 Sep 2009 22:25:31 -0400 Received: by pastel.home (Postfix, from userid 20848) id B8B0B807A; Wed, 23 Sep 2009 22:25:31 -0400 (EDT) From: Stefan Monnier To: =?iso-8859-1?Q?=D3scar?= Fuentes Cc: 4515@debbugs.gnu.org, Dan Nicolaescu Subject: Re: bug#4515: 23.1.50; Reverting changes on versioned file does not revert vc modeline status Message-ID: References: <87ws3rlnny.fsf@telefonica.net> <200909230553.n8N5rEsT023798@godzilla.ics.uci.edu> <87eipykve3.fsf@telefonica.net> <200909231836.n8NIa6Lv029481@godzilla.ics.uci.edu> <874oqtlaq0.fsf@telefonica.net> Date: Wed, 23 Sep 2009 22:25:31 -0400 In-Reply-To: <874oqtlaq0.fsf@telefonica.net> (=?iso-8859-1?Q?=22=D3scar?= Fuentes"'s message of "Wed, 23 Sep 2009 21:31:03 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > Automatically checking the VC state after each save is actually > performed if there is a vc-dired buffer for the working copy where the > file resides. That check updates the vc-dired with the correct state of > the saved file. Indeed. That requires the status info to be obtainable cheaply. > Would you accept a patch that implements an option for checking after > every save and updating the vc state on the modeline accordingly? I'd consider it, yes. Stefan From dann@godzilla.ics.uci.edu Wed Sep 23 21:25:05 2009 Received: (at 4515) by emacsbugs.donarmstrong.com; 24 Sep 2009 04:25:06 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.5 required=4.0 tests=AWL,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8O4P4lI031364 for <4515@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 21:25:05 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n8O4Okfd029015; Wed, 23 Sep 2009 21:24:46 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n8O4OjLB004582; Wed, 23 Sep 2009 21:24:45 -0700 (PDT) Date: Wed, 23 Sep 2009 21:24:45 -0700 (PDT) Message-Id: <200909240424.n8O4OjLB004582@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Stefan Monnier Cc: =?utf-8?Q?=C3=93scar?= Fuentes , 4515@debbugs.gnu.org Subject: Re: bug#4515: 23.1.50; Reverting changes on versioned file does not revert vc modeline status References: <87ws3rlnny.fsf@telefonica.net> <200909230553.n8N5rEsT023798@godzilla.ics.uci.edu> <87eipykve3.fsf@telefonica.net> <200909231836.n8NIa6Lv029481@godzilla.ics.uci.edu> <874oqtlaq0.fsf@telefonica.net> X-Debbugs-No-Ack: yes In-Reply-To: (Stefan Monnier's message of "Wed, 23 Sep 2009 22:25:31 -0400") Lines: 12 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n8O4Okfd029015 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Stefan Monnier writes: > > Automatically checking the VC state after each save is actually > > performed if there is a vc-dired buffer for the working copy where the > > file resides. That check updates the vc-dired with the correct state of > > the saved file. > > Indeed. That requires the status info to be obtainable cheaply. There's a major difference: vc-dir is asynchronous, whereas updating the same info when saving a file is synchronous, so it will be on the critical path. From oscarfv@telefonica.net Wed Sep 23 23:24:06 2009 Received: (at 4515) by emacsbugs.donarmstrong.com; 24 Sep 2009 06:24:07 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.5 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from IMPaqm2.telefonica.net (impaqm2.telefonica.net [213.4.138.2]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8O6O4Rg019544 for <4515@emacsbugs.donarmstrong.com>; Wed, 23 Sep 2009 23:24:06 -0700 Received: from IMPmailhost4.adm.correo ([10.20.102.125]) by IMPaqm2.telefonica.net with bizsmtp id kVyW1c00D2iL0W23MWQ3yz; Thu, 24 Sep 2009 08:24:03 +0200 Received: from qcore ([83.43.52.24]) by IMPmailhost4.adm.correo with BIZ IMP id kWLl1c00F0XKxp71kWLm52; Thu, 24 Sep 2009 08:20:47 +0200 X-TE-authinfo: authemail="981711563$telefonica.net" |auth_email="981711563@telefonica.net" X-TE-AcuTerraCos: auth_cuTerraCos="cosuitnetc01" From: =?windows-1252?Q?=D3scar_Fuentes?= To: Dan Nicolaescu Cc: Stefan Monnier , 4515@debbugs.gnu.org Subject: Re: bug#4515: 23.1.50; Reverting changes on versioned file does not revert vc modeline status References: <87ws3rlnny.fsf@telefonica.net> <200909230553.n8N5rEsT023798@godzilla.ics.uci.edu> <87eipykve3.fsf@telefonica.net> <200909231836.n8NIa6Lv029481@godzilla.ics.uci.edu> <874oqtlaq0.fsf@telefonica.net> <200909240424.n8O4OjLB004582@godzilla.ics.uci.edu> Date: Thu, 24 Sep 2009 08:24:02 +0200 In-Reply-To: <200909240424.n8O4OjLB004582@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Wed, 23 Sep 2009 21:24:45 -0700 (PDT)") Message-ID: <87skeckghp.fsf@telefonica.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Dan Nicolaescu writes: > Stefan Monnier writes: > > > > Automatically checking the VC state after each save is actually > > > performed if there is a vc-dired buffer for the working copy where the > > > file resides. That check updates the vc-dired with the correct state of > > > the saved file. > > > > Indeed. That requires the status info to be obtainable cheaply. > > There's a major difference: vc-dir is asynchronous, whereas updating the > same info when saving a file is synchronous, so it will be on the > critical path. Are you saying that vc-dir updates the file status asynchronously after a file is saved? vc-dir-recompute-file-state does (state (vc-call-backend vc-dir-backend 'state fname)) (extra (vc-call-backend vc-dir-backend 'status-fileinfo-extra fname))) which looks like the same stuff vc-after-save is trying to avoid. I've implemented the option for checking the state after every save. It is almost instantaneous on a GNU/Linux machine with bzr. On a Windows XP netbook there is almost no noticeable delay with a hot cache. Using bzr 2.0rc on a 1000 rev branch. The option is off by default so the user must toggle the option before complaining about the performance. The docstring of the defcustom warns about that posibility. 2009-09-24 Oscar Fuentes * lisp/vc-hooks.el (vc-always-update-modeline-after-save): new defcustom. (vc-after-save): Use it and when non-nil check the vc file state so the modeline reflects its actual state. diff -cp "c:/apps/emacs/lisp/vc-hooks.el" "d:/vc-hooks.el" *** c:/apps/emacs/lisp/vc-hooks.el 2009-09-24 07:25:53.000000000 +0200 --- d:/vc-hooks.el 2009-09-24 08:10:01.062500000 +0200 *************** If nil (the default), files covered by v *** 96,101 **** --- 96,110 ---- :group 'vc :group 'backup) + (defcustom vc-always-update-modeline-after-save nil + "If non-nil, always update the state shown in the modeline + after saving the file. This may be time-consuming for some + backends. If nil, the modeline changes to `edited' when the file + is saved for the first time and it is not updated on subsequent + saves." + :type 'boolean + :group 'vc) + (defcustom vc-follow-symlinks 'ask "What to do if visiting a symbolic link to a file under version control. Editing such a file through the link bypasses the version control system, *************** Before doing that, check if there are an *** 743,751 **** ;; to avoid confusion. (vc-file-setprop file 'vc-checkout-time nil)) t) - (vc-up-to-date-p file) (eq (vc-checkout-model backend (list file)) 'implicit) ! (vc-file-setprop file 'vc-state 'edited) (vc-mode-line file backend) ;; Try to avoid unnecessary work, a *vc-dir* buffer is ;; present if and only if this is true. --- 752,766 ---- ;; to avoid confusion. (vc-file-setprop file 'vc-checkout-time nil)) t) (eq (vc-checkout-model backend (list file)) 'implicit) ! (if vc-always-update-modeline-after-save ! (progn ! ;; Avoid using cached value on `vc-state': ! (vc-file-setprop file 'vc-state 'nil) ! (vc-file-setprop file 'vc-state (vc-state file backend))) ! (and ! (vc-up-to-date-p file) ! (vc-file-setprop file 'vc-state 'edited))) (vc-mode-line file backend) ;; Try to avoid unnecessary work, a *vc-dir* buffer is ;; present if and only if this is true. From dann@godzilla.ics.uci.edu Thu Sep 24 10:21:08 2009 Received: (at 4515) by emacsbugs.donarmstrong.com; 24 Sep 2009 17:21:09 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.5 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8OHL738024962 for <4515@emacsbugs.donarmstrong.com>; Thu, 24 Sep 2009 10:21:08 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n8OHKpTw011757; Thu, 24 Sep 2009 10:20:52 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n8OHKpiG010343; Thu, 24 Sep 2009 10:20:51 -0700 (PDT) Date: Thu, 24 Sep 2009 10:20:51 -0700 (PDT) Message-Id: <200909241720.n8OHKpiG010343@godzilla.ics.uci.edu> From: Dan Nicolaescu To: =?utf-8?Q?=C3=93scar?= Fuentes Cc: 4515@debbugs.gnu.org Subject: Re: bug#4515: 23.1.50; Reverting changes on versioned file does not revert vc modeline status References: <87ws3rlnny.fsf@telefonica.net> <200909230553.n8N5rEsT023798@godzilla.ics.uci.edu> <87eipykve3.fsf@telefonica.net> <200909231836.n8NIa6Lv029481@godzilla.ics.uci.edu> <874oqtlaq0.fsf@telefonica.net> <200909240424.n8O4OjLB004582@godzilla.ics.uci.edu> <87skeckghp.fsf@telefonica.net> X-Debbugs-No-Ack: yes In-Reply-To: <87skeckghp.fsf@telefonica.net> (=?utf-8?Q?=22=C3=93scar?= Fuentes"'s message of "Thu, 24 Sep 2009 08:24:02 +0200") Lines: 31 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n8OHKpTw011757 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu =C3=93scar Fuentes writes: > Dan Nicolaescu writes: >=20 > > Stefan Monnier writes: > > > > > > Automatically checking the VC state after each save is actually > > > > performed if there is a vc-dired buffer for the working copy wh= ere the > > > > file resides. That check updates the vc-dired with the correct = state of > > > > the saved file. > > >=20 > > > Indeed. That requires the status info to be obtainable cheaply. > > > > There's a major difference: vc-dir is asynchronous, whereas updating = the > > same info when saving a file is synchronous, so it will be on the > > critical path. >=20 > Are you saying that vc-dir updates the file status asynchronously after > a file is saved? vc-dir-recompute-file-state does Hmm, I implemented that probably 2 years ago ago, but it does not look like I checked it in... and I can't seem to find that patch anymore. :-( > (state (vc-call-backend vc-dir-backend 'state fname)) > (extra (vc-call-backend vc-dir-backend > 'status-fileinfo-extra fname))) This function should instead be using `vc-dir-refresh-files' to work asynchronously. Given that nobody noticed this until now, maybe it's not too bad. From lekktu@gmail.com Thu Oct 22 02:35:31 2009 Received: (at control) by emacsbugs.donarmstrong.com; 22 Oct 2009 09:35:32 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=AWL,MISSING_SUBJECT, MURPHY_DRUGS_REL8,NOSUBJECT,VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-fx0-f213.google.com (mail-fx0-f213.google.com [209.85.220.213]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9M9ZTNW004084 for ; Thu, 22 Oct 2009 02:35:31 -0700 Received: by fxm9 with SMTP id 9so9696363fxm.1 for ; Thu, 22 Oct 2009 02:35:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=8EmqKmTQZFxRHmBqMf0mAHPBq3MFliknc0lztWoJq6Y=; b=HxQYupT4FFltZz1ItMJj0h3XTFYNK5e7ryT0Cek2T3YESYQLNQM8G9V9i2CKiMAEbc EvYuLj8f7w1qApk14qvzihjcYCGQUOU+1DBevO5UhGKLQhzQ6+vBiuihHNGFYaXeeEYe kJYg0CmwEGM5xp9e/Qz4pt4br7Ml4TcpNJkWo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=Y5ybjjcxlLdLgAFAm7oQwPF4q6enZ/vhDgoBesbKLPsYfKZBy2gNxuVUArd1lZsA9C Mqc9bcUQhekOxrkhuBrM/oRLNjZDm8m0DPtCnEMhvvK6rKfs9H9j6QMJR6VObUwlfUeo 7VB35jQ8OYFrwvpcsbgPdQA8bmjmcb1XFRU14= MIME-Version: 1.0 Received: by 10.239.145.8 with SMTP id q8mr761204hba.122.1256204124158; Thu, 22 Oct 2009 02:35:24 -0700 (PDT) From: Juanma Barranquero Date: Thu, 22 Oct 2009 11:35:04 +0200 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 reassign 4326 emacs,ns merge 4261 4434 merge 1589 3359 4207 merge 3829 4077 tags 4781 + patch tags 4747 + patch tags 4579 + patch tags 4471 + patch tags 4434 + patch tags 4234 + patch tags 4221 + patch tags 4147 + patch tags 4144 + patch tags 4139 + patch tags 4023 + patch tags 4736 + moreinfo unreproducible tags 4547 + notabug tags 4451 + notabug tags 4448 + moreinfo tags 4427 + moreinfo tags 4373 + notabug tags 4360 + notabug tags 4271 + moreinfo tags 4236 + moreinfo tags 4143 + moreinfo unreproducible tags 4120 + moreinfo unreproducible tags 4070 + moreinfo unreproducible severity 4422 wishlist severity 4396 minor severity 4394 minor severity 4341 wishlist severity 4300 minor severity 4263 minor severity 4178 minor severity 4172 wishlist severity 4110 wishlist severity 4056 wishlist close 4772 close 4700 close 4599 close 4515 close 4463 close 4445 close 4395 close 4334 close 4289 close 4219 quit From unknown Wed Jun 18 00:27:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 19 Nov 2009 15:24:15 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A long time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator