GNU bug report logs - #45147
Org-like cycling in outline-minor-mode

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: larsi <at> gnus.org, 45147 <at> debbugs.gnu.org
Subject: bug#45147: Org-like cycling in outline-minor-mode
Date: Wed, 19 May 2021 15:10:37 +0300

> From: Juri Linkov <juri <at> linkov.net>
> Date: Tue, 18 May 2021 23:12:46 +0300
> Cc: 45147 <at> debbugs.gnu.org
> 
> +(defcustom describe-bindings-after-hook '(describe-bindings-outline)
> +  "Hook run at the end of `describe-bindings'."
> +  :type 'hook
> +  :options '(describe-bindings-outline)
> +  :group 'help
> +  :version "28.1")

What's the rationale for populating the hook by default?  That's not
what we normally do: hooks are for Lisp programs to use, not for the
core functionality to invoke itself.

> +(defun describe-bindings-outline ()
> +  "Hook to enable outlines in the output buffer of `describe-bindings'."

First, this is not a hook.

And second, if we want a feature whereby the buffer describing
bindings could be put in Outline mode, why not offer a simple option
for users to customize, not a hook for users to tweak?  Once again,
having user options that accept only function values is
user-unfriendly.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.