GNU bug report logs - #4513
NS: File menu missing

unarchive 4513

From: David Reitter <david.reitter <at> gmail.com>
To: emacs-pretest-bug <at> gnu.org
Subject: NS: File menu missing
Date: Mon, 21 Sep 2009 18:55:31 -0400

package: ns
X-Debbugs-Cc: Adrian Robert <adrian.b.robert <at> gmail.com>


The file menu is missing; its contents are in the application menu  
(titled "Emacs"), and the usual contents of the application menu are  
completely gone.

So I've got "Emacs Edit Options"

Is this intentional (if so which change - had a long hard look at  
change logs)?

Have been trying to debug without success so far.

This was introduced at some point in between the Emacs 23.1 pretest  
branch cut and the current master branch.


Thanks
- David

In GNU Emacs 23.1.50.7 (i386-apple-darwin10.0.0, NS apple- 
appkit-1038.11)
 of 2009-09-21 on scarlett.psy.cmu.edu
Windowing system distributor `Apple', version 10.3.1038
configured using `configure  '--with-ns' '--without-x' 'CC=gcc -arch  
i386''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: en_US.us-ascii
  value of $LC_CTYPE: en_US.us-ascii
  value of $LC_MESSAGES: en_US.us-ascii
  value of $LC_MONETARY: en_US.us-ascii
  value of $LC_NUMERIC: en_US.us-ascii
  value of $LC_TIME: en_US.us-ascii
  value of $LANG: de_DE.ISO8859-15
  value of $XMODIFIERS: nil
  locale-coding-system: us-ascii-unix
  default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<menu-bar> <help-menu> <send-emacs-bug-report>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.




From: Adrian Robert <adrian.b.robert <at> gmail.com>
To: David Reitter <david.reitter <at> gmail.com>, 4513 <at> debbugs.gnu.org
Subject: Re: bug#4513: NS: File menu missing
Date: Mon, 21 Sep 2009 21:00:11 -0400

On Sep 21, 2009, at 6:55 PM, David Reitter wrote:

> package: ns
> X-Debbugs-Cc: Adrian Robert <adrian.b.robert <at> gmail.com>
>
>
> The file menu is missing; its contents are in the application menu  
> (titled "Emacs"), and the usual contents of the application menu  
> are completely gone.
>
> So I've got "Emacs Edit Options"

Very odd.  I have not made any changes that I *think* could affect  
this.  Have not seen the bug (10.4) -- even tried setting my lang to  
German, but it might be I need to do another bootstrap build or  
something.  There look like there were a lot of menu-related changes  
in the lisp subdirectory on 2009-09-17.




From: David Reitter <david.reitter <at> gmail.com>
To: Adrian Robert <adrian.b.robert <at> gmail.com>
Cc: 4513 <at> debbugs.gnu.org
Subject: Re: bug#4513: NS: File menu missing
Date: Mon, 21 Sep 2009 22:56:20 -0400

[Message part 1 (text/plain, inline)]
On Sep 21, 2009, at 9:00 PM, Adrian Robert wrote:
> Very odd.  I have not made any changes that I *think* could affect  
> this.  Have not seen the bug (10.4) -- even tried setting my lang to  
> German, but it might be I need to do another bootstrap build or  
> something.  There look like there were a lot of menu-related changes  
> in the lisp subdirectory on 2009-09-17.
>

I'm on 10.6.1.

I tried to compile various revisions, but this doesn't really work  
(due to unrelated 10.6 compatibility issues).

git checkout emacs
make extraclean
export MACOSX_DEPLOYMENT_TARGET=
CC='gcc -arch i386' ./configure --with-ns --without-x
make bootstrap
make install

I also tried backing out the 09-17 changes - no success.

Even if you add an extra (empty) menu to global-map, the file entries  
appear in the Emacs menu.

I wonder if it has something to do with 10.6.  Couldn't check it (my  
10.5 machine at home is PPC), but will attempt to run it on 10.5  
tomorrow.

- D


[PastedGraphic-1.png (image/png, inline)]
[Message part 3 (text/plain, inline)]


From: Adrian Robert <adrian.b.robert <at> gmail.com>
To: David Reitter <david.reitter <at> gmail.com>
Cc: 4513 <at> debbugs.gnu.org
Subject: Re: bug#4513: NS: File menu missing
Date: Tue, 22 Sep 2009 08:55:10 -0400

> I also tried backing out the 09-17 changes - no success.
>
> Even if you add an extra (empty) menu to global-map, the file  
> entries appear in the Emacs menu.
>
> I wonder if it has something to do with 10.6.  Couldn't check it  
> (my 10.5 machine at home is PPC), but will attempt to run it on  
> 10.5 tomorrow.

I'm confused why no one ever mentioned this before in any of the 10.6  
discussions.

Note the top-level menubar is redone in ns-win.el, though nearly  
identically to menu-bar.el.  No reason not to comment that stuff out  
and retry.

I started looking at the 64-bit stuff and wanted to use Erik's patch  
directly but am not sure how long his copyright assignment will  
take.  Also there are some changes in common code that I'm not 100%  
sure about (limited experience in 64-bit ATM).  For instance, %ld in  
printfs, at the very least I think casts of the arguments to (long)  
will be needed to avoid problems on 32-bit systems.

I updated nsfont.m to pay attention to registries, will check that in  
soon.




From: David Reitter <david.reitter <at> gmail.com>
To: Adrian Robert <adrian.b.robert <at> gmail.com>
Cc: 4513 <at> debbugs.gnu.org
Subject: Re: bug#4513: NS: File menu missing
Date: Tue, 22 Sep 2009 09:46:29 -0400

[Message part 1 (text/plain, inline)]
On Sep 22, 2009, at 8:55 AM, Adrian Robert wrote:
> I'm confused why no one ever mentioned this before in any of the  
> 10.6 discussions.

Same here.

> Note the top-level menubar is redone in ns-win.el, though nearly  
> identically to menu-bar.el.  No reason not to comment that stuff out  
> and retry.

Ah, that got me somewhere.

This line:

(define-key global-map [menu-bar] (make-sparse-keymap "menu-bar"))

removes the top level.  Commenting it out makes the file menu appear  
again.
However, even then the application menu is empty.

There are no changes to nsterm.m where the application menu is set up.
Also note that this call:

[NSApp setAppleMenu: appMenu]

is undocumented...


> I started looking at the 64-bit stuff and wanted to use Erik's patch  
> directly but am not sure how long his copyright assignment will  
> take.  Also there are some changes in common code that I'm not 100%  
> sure about (limited experience in 64-bit ATM).  For instance, %ld in  
> printfs, at the very least I think casts of the arguments to (long)  
> will be needed to avoid problems on 32-bit systems.

Well, I wouldn't break 32 bit compilation, but otherwise, changes to  
the 64-bit build can only make things better.

Comments on the event loop crashes (attached)?

Also, I got a complaint regarding line spacing.  Indeed, Courier 11  
isn't spaced as wide as in Cocoa text views.  Will take a look at this  
again.

- D




[collected-emacs-crashes.txt (text/plain, attachment)]
From: David Reitter <david.reitter <at> gmail.com>
To: Adrian Robert <adrian.b.robert <at> gmail.com>
Cc: 4513 <at> debbugs.gnu.org,
        Jean-Philippe SCHILLE <jp.schille <at> sentesoftware.co.uk>
Subject: Fwd: [Aquamacs-devel] Where are the menu sub-items in Aquamacs version 2.
Date: Tue, 22 Sep 2009 14:57:42 -0400

[Message part 1 (text/plain, inline)]
Further to this, here's another menu bug:

I see that the submenus (except for the application) menu are missing  
in 23.1 based builds made on 10.5 and run on 10.5.  That is, only the  
titles show, but not the menus.

The bug is not a recent regression in Emacs - even a build from back  
in April shows this.
See also the bug report we got from a user, who had similar trouble in  
10.5.  A reasonable hypothesis here is that it is a late point-release  
of 10.5 causing this.

The master branch built on 10.5 shows missing submenus (just titles)  
when run on 10.5.
When run on 10.6 it works fine and has no problems.

I have tried moving menu-bar.el loading around in loadup.el just in  
case this is an artifact of some dumping / pure-space problem.
I'm puzzled...


PS: As for the bug with the collapsed applications menu: even a 23.1  
build (with Yamamoto's Aug 28 patch applied), made on 10.6 (and 32  
bit) shows the problem.  I
I can't make the File menu appear by removing the define-key global- 
map [menu-bar] ... expression from ns-win in this case.



Begin forwarded message:

> From: Jean-Philippe SCHILLE <jp.schille <at> sentesoftware.co.uk>
> Date: September 1, 2009 10:13:00 AM EDT
> To: aquamacs-devel <at> aquamacs.org
> Subject: [Aquamacs-devel] Where are the menu sub-items in Aquamacs  
> version 2.
> Reply-To: Aquamacs Developers <aquamacs-devel <at> aquamacs.org>
>
> Hello,
>
> For the 2.0 branch versions, I cannot see any sub-items in the menu  
> bar.
> The Aquamacs item is fine as all expected sub-items (About,  
> Check,Services...) are visible but the menu items File Edit Options  
> Tools Window Help do not show any sub-item when I click on them.
>
> Everything is fine with Aquamacs Emacs 1.8 though.
>
> I am running OS X 10.5.8 and I am using the latest X11 version 2.4.0  
> from http://xquartz.macosforge.org/trac/wiki/Releases (I wonder if  
> this is the culprit?)
>
> Thanks in advance for your help and advice.
>
> Regards,
>
> Jean-Philippe Schillé
> Sente Software Ltd
> 40 Occam Road
> Guildford GU2 7YG
> United-Kingdom
> www.sentesoftware.co.uk
>
> _______________________________________________
> Aquamacs-devel mailing list
> Aquamacs-devel <at> aquamacs.org
> http://lists.aquamacs.org/mailman/listinfo.cgi/aquamacs-devel


[smime.p7s (application/pkcs7-signature, attachment)]
From: David Reitter <david.reitter <at> gmail.com>
To: David Reitter <david.reitter <at> gmail.com>
Cc: Adrian Robert <adrian.b.robert <at> gmail.com>, 4513 <at> debbugs.gnu.org,
        Jean-Philippe SCHILLE <jp.schille <at> sentesoftware.co.uk>
Subject: Re: [Aquamacs-devel] Where are the menu sub-items in Aquamacs version 2.
Date: Tue, 22 Sep 2009 14:59:52 -0400

[Message part 1 (text/plain, inline)]
Erratum: s/master branch/23.1 branch/

On Sep 22, 2009, at 2:57 PM, David Reitter wrote:

> Further to this, here's another menu bug:
>
> I see that the submenus (except for the application) menu are  
> missing in 23.1 based builds made on 10.5 and run on 10.5.  That is,  
> only the titles show, but not the menus.
>
> The bug is not a recent regression in Emacs - even a build from back  
> in April shows this.
> See also the bug report we got from a user, who had similar trouble  
> in 10.5.  A reasonable hypothesis here is that it is a late point- 
> release of 10.5 causing this.
>
> The master branch built on 10.5 shows missing submenus (just titles)  
> when run on 10.5.
> When run on 10.6 it works fine and has no problems.
>
> I have tried moving menu-bar.el loading around in loadup.el just in  
> case this is an artifact of some dumping / pure-space problem.
> I'm puzzled...
>
>
> PS: As for the bug with the collapsed applications menu: even a 23.1  
> build (with Yamamoto's Aug 28 patch applied), made on 10.6 (and 32  
> bit) shows the problem.  I
> I can't make the File menu appear by removing the define-key global- 
> map [menu-bar] ... expression from ns-win in this case.
>
>
>
> Begin forwarded message:
>
>> From: Jean-Philippe SCHILLE <jp.schille <at> sentesoftware.co.uk>
>> Date: September 1, 2009 10:13:00 AM EDT
>> To: aquamacs-devel <at> aquamacs.org
>> Subject: [Aquamacs-devel] Where are the menu sub-items in Aquamacs  
>> version 2.
>> Reply-To: Aquamacs Developers <aquamacs-devel <at> aquamacs.org>
>>
>> Hello,
>>
>> For the 2.0 branch versions, I cannot see any sub-items in the menu  
>> bar.
>> The Aquamacs item is fine as all expected sub-items (About,  
>> Check,Services...) are visible but the menu items File Edit Options  
>> Tools Window Help do not show any sub-item when I click on them.
>>
>> Everything is fine with Aquamacs Emacs 1.8 though.
>>
>> I am running OS X 10.5.8 and I am using the latest X11 version  
>> 2.4.0 from http://xquartz.macosforge.org/trac/wiki/Releases (I  
>> wonder if this is the culprit?)
>>
>> Thanks in advance for your help and advice.
>>
>> Regards,
>>
>> Jean-Philippe Schillé
>> Sente Software Ltd
>> 40 Occam Road
>> Guildford GU2 7YG
>> United-Kingdom
>> www.sentesoftware.co.uk
>>
>> _______________________________________________
>> Aquamacs-devel mailing list
>> Aquamacs-devel <at> aquamacs.org
>> http://lists.aquamacs.org/mailman/listinfo.cgi/aquamacs-devel
>


[smime.p7s (application/pkcs7-signature, attachment)]
From: David Reitter <david.reitter <at> gmail.com>
To: Adrian Robert <adrian.b.robert <at> gmail.com>
Cc: 4513 <at> debbugs.gnu.org
Subject: Re: [Aquamacs-devel] Where are the menu sub-items in Aquamacs version 2.
Date: Tue, 22 Sep 2009 16:55:27 -0400

[Message part 1 (text/plain, inline)]
Further to this:

When building the master branch [based Aquamacs] on 10.5, it will run  
without menu problems on 10.6.
The application menu is present and all menus are visible.

When run on 10.5.8, submenus are missing.

Inspecting this with the Accessibility Inspector, I see that  
AXChildren of the submenu is size 11 for the applications menu,  but 1  
for the File / Edit etc. menus.


On Sep 22, 2009, at 2:59 PM, David Reitter wrote:

> Erratum: s/master branch/23.1 branch/
>
> On Sep 22, 2009, at 2:57 PM, David Reitter wrote:
>
>> Further to this, here's another menu bug:
>>
>> I see that the submenus (except for the application) menu are  
>> missing in 23.1 based builds made on 10.5 and run on 10.5.  That  
>> is, only the titles show, but not the menus.
>>
>> The bug is not a recent regression in Emacs - even a build from  
>> back in April shows this.
>> See also the bug report we got from a user, who had similar trouble  
>> in 10.5.  A reasonable hypothesis here is that it is a late point- 
>> release of 10.5 causing this.
>>
>> The master branch built on 10.5 shows missing submenus (just  
>> titles) when run on 10.5.
>> When run on 10.6 it works fine and has no problems.
>>
>> I have tried moving menu-bar.el loading around in loadup.el just in  
>> case this is an artifact of some dumping / pure-space problem.
>> I'm puzzled...
>>
>>
>> PS: As for the bug with the collapsed applications menu: even a  
>> 23.1 build (with Yamamoto's Aug 28 patch applied), made on 10.6  
>> (and 32 bit) shows the problem.  I
>> I can't make the File menu appear by removing the define-key global- 
>> map [menu-bar] ... expression from ns-win in this case.
>>
>>
>>
>> Begin forwarded message:
>>
>>> From: Jean-Philippe SCHILLE <jp.schille <at> sentesoftware.co.uk>
>>> Date: September 1, 2009 10:13:00 AM EDT
>>> To: aquamacs-devel <at> aquamacs.org
>>> Subject: [Aquamacs-devel] Where are the menu sub-items in Aquamacs  
>>> version 2.
>>> Reply-To: Aquamacs Developers <aquamacs-devel <at> aquamacs.org>
>>>
>>> Hello,
>>>
>>> For the 2.0 branch versions, I cannot see any sub-items in the  
>>> menu bar.
>>> The Aquamacs item is fine as all expected sub-items (About,  
>>> Check,Services...) are visible but the menu items File Edit  
>>> Options Tools Window Help do not show any sub-item when I click on  
>>> them.
>>>
>>> Everything is fine with Aquamacs Emacs 1.8 though.
>>>
>>> I am running OS X 10.5.8 and I am using the latest X11 version  
>>> 2.4.0 from http://xquartz.macosforge.org/trac/wiki/Releases (I  
>>> wonder if this is the culprit?)
>>>
>>> Thanks in advance for your help and advice.
>>>
>>> Regards,
>>>
>>> Jean-Philippe Schillé
>>> Sente Software Ltd
>>> 40 Occam Road
>>> Guildford GU2 7YG
>>> United-Kingdom
>>> www.sentesoftware.co.uk
>>>
>>> _______________________________________________
>>> Aquamacs-devel mailing list
>>> Aquamacs-devel <at> aquamacs.org
>>> http://lists.aquamacs.org/mailman/listinfo.cgi/aquamacs-devel
>>
>


[smime.p7s (application/pkcs7-signature, attachment)]
From: David Reitter <david.reitter <at> gmail.com>
To: 4513 <at> debbugs.gnu.org
Cc: Adrian Robert <adrian.b.robert <at> gmail.com>
Subject: Re: [Aquamacs-devel] Where are the menu sub-items in Aquamacs version 2.
Date: Tue, 22 Sep 2009 17:24:10 -0400

[Message part 1 (text/plain, inline)]
And one more bit of information:  the missing menu issue only occurs  
when I run Emacs in VNC (Apple's VNC).  When I run it locally, 10.5.8  
poses no problems.

So let's split this issue from 4513, which is about the mangle  
applications menu when compiling on 10.6


On Sep 22, 2009, at 4:55 PM, David Reitter wrote:

> Further to this:
>
> When building the master branch [based Aquamacs] on 10.5, it will  
> run without menu problems on 10.6.
> The application menu is present and all menus are visible.
>
> When run on 10.5.8, submenus are missing.
>
> Inspecting this with the Accessibility Inspector, I see that  
> AXChildren of the submenu is size 11 for the applications menu,  but  
> 1 for the File / Edit etc. menus.
>
>
> On Sep 22, 2009, at 2:59 PM, David Reitter wrote:
>
>> Erratum: s/master branch/23.1 branch/
>>
>> On Sep 22, 2009, at 2:57 PM, David Reitter wrote:
>>
>>> Further to this, here's another menu bug:
>>>
>>> I see that the submenus (except for the application) menu are  
>>> missing in 23.1 based builds made on 10.5 and run on 10.5.  That  
>>> is, only the titles show, but not the menus.
>>>
>>> The bug is not a recent regression in Emacs - even a build from  
>>> back in April shows this.
>>> See also the bug report we got from a user, who had similar  
>>> trouble in 10.5.  A reasonable hypothesis here is that it is a  
>>> late point-release of 10.5 causing this.
>>>
>>> The master branch built on 10.5 shows missing submenus (just  
>>> titles) when run on 10.5.
>>> When run on 10.6 it works fine and has no problems.
>>>
>>> I have tried moving menu-bar.el loading around in loadup.el just  
>>> in case this is an artifact of some dumping / pure-space problem.
>>> I'm puzzled...
>>>
>>>
>>> PS: As for the bug with the collapsed applications menu: even a  
>>> 23.1 build (with Yamamoto's Aug 28 patch applied), made on 10.6  
>>> (and 32 bit) shows the problem.  I
>>> I can't make the File menu appear by removing the define-key  
>>> global-map [menu-bar] ... expression from ns-win in this case.
>>>
>>>
>>>
>>> Begin forwarded message:
>>>
>>>> From: Jean-Philippe SCHILLE <jp.schille <at> sentesoftware.co.uk>
>>>> Date: September 1, 2009 10:13:00 AM EDT
>>>> To: aquamacs-devel <at> aquamacs.org
>>>> Subject: [Aquamacs-devel] Where are the menu sub-items in  
>>>> Aquamacs version 2.
>>>> Reply-To: Aquamacs Developers <aquamacs-devel <at> aquamacs.org>
>>>>
>>>> Hello,
>>>>
>>>> For the 2.0 branch versions, I cannot see any sub-items in the  
>>>> menu bar.
>>>> The Aquamacs item is fine as all expected sub-items (About,  
>>>> Check,Services...) are visible but the menu items File Edit  
>>>> Options Tools Window Help do not show any sub-item when I click  
>>>> on them.
>>>>
>>>> Everything is fine with Aquamacs Emacs 1.8 though.
>>>>
>>>> I am running OS X 10.5.8 and I am using the latest X11 version  
>>>> 2.4.0 from http://xquartz.macosforge.org/trac/wiki/Releases (I  
>>>> wonder if this is the culprit?)
>>>>
>>>> Thanks in advance for your help and advice.
>>>>
>>>> Regards,
>>>>
>>>> Jean-Philippe Schillé
>>>> Sente Software Ltd
>>>> 40 Occam Road
>>>> Guildford GU2 7YG
>>>> United-Kingdom
>>>> www.sentesoftware.co.uk
>>>>
>>>> _______________________________________________
>>>> Aquamacs-devel mailing list
>>>> Aquamacs-devel <at> aquamacs.org
>>>> http://lists.aquamacs.org/mailman/listinfo.cgi/aquamacs-devel
>>>
>>
>


[smime.p7s (application/pkcs7-signature, attachment)]
From: David Reitter <david.reitter <at> gmail.com>
To: Adrian Robert <adrian.b.robert <at> gmail.com>
Cc: 4513 <at> debbugs.gnu.org
Subject: Re: [Aquamacs-devel] Where are the menu sub-items in Aquamacs version 2.
Date: Tue, 22 Sep 2009 19:05:44 -0400

[Message part 1 (text/plain, inline)]
On Sep 22, 2009, at 6:35 PM, Adrian Robert wrote:
>> So let's split this issue from 4513, which is about the mangle  
>> applications menu when compiling on 10.6
>
> Or absent File menu you mean.  It seems strange that only File and  
> not all others are affected...

I think it just grabs the first menu available and sticks it into the  
application menu.  Hence "mangled".  Attaching screenshot to illustrate.



[PastedGraphic-3.png (image/png, inline)]
[Message part 3 (text/plain, inline)]


> Regarding the event loop crashes, I looked at the code a bit and I  
> can't see where anything is wrong with the timer handling.  Emacs  
> should be running with one thread, so add scheduling and  
> invalidation should be correct.  Can you remember if a common factor  
> in the crashes is the use of one or more popup dialogs during the  
> run prior to the crash?  The only thing I can think of here is that  
> there could be some funny business with the modal and nonmodal run  
> loops.  Otherwise, you could try uncommenting the assertion in  
> ns_select().


Note that all of the crashes occurred with 23.1, but I don't think  
you've changed / fixed anything in that area since then -?

As a common factor I can only say that I wasn't doing anything on the  
Emacs side.  I actually remember working with other apps and maybe  
switching back to an Emacs window.

I've added an assert() (in the Aquamacs master branch).  Maybe we'll  
get some bug reports this way.

- D
[smime.p7s (application/pkcs7-signature, attachment)]
From: Glenn Morris <rgm <at> gnu.org>
To: David Reitter <david.reitter <at> gmail.com>
Cc: 4513 <at> debbugs.gnu.org
Subject: Re: NS: File menu missing
Date: Wed, 23 Sep 2009 02:29:24 -0400

David Reitter wrote:

> package: ns

Just in case you were unaware, if you don't put bugs in the "emacs"
package as well, none of the correspondence gets sent out to the
bug-gnu-emacs list (maybe this was intentional?). Ie, use:

Package: emacs,ns

(I hope these messages doesn't sound like a list of lectures/complaints.)



From: CHENG Gao <chenggao <at> cyberhut.org>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#4513: [Aquamacs-devel] Where are the menu sub-items in Aquamacs version 2.
Date: Wed, 23 Sep 2009 14:30:04 +0800

*On Tue, 22 Sep 2009 19:05:44 -0400
* Also sprach David Reitter <david.reitter <at> gmail.com>:

> On Sep 22, 2009, at 6:35 PM, Adrian Robert wrote:
>>> So let's split this issue from 4513, which is about the mangle
>>> applications menu when compiling on 10.6
>>
>> Or absent File menu you mean.  It seems strange that only File and
>> not all others are affected...
>
> I think it just grabs the first menu available and sticks it into the
> application menu.  Hence "mangled".  Attaching screenshot to
> illustrate.

As I know it's 10.6 SDK specific problem. The first menu is treated
magically. I saw some workarounds to overcome this  in cocoa-dev mailing
list. I found it[1] via googling.

Footnotes: 
[1]  http://osdir.com/ml/cocoa-dev/2009-09/msg00347.html






From: David Reitter <david.reitter <at> gmail.com>
To: Adrian Robert <adrian.b.robert <at> gmail.com>
Cc: 4513 <at> debbugs.gnu.org
Subject: Re: bug#4513: NS: File menu missing
Date: Wed, 23 Sep 2009 17:55:58 -0400

[Message part 1 (text/plain, inline)]
On Sep 21, 2009, at 9:00 PM, Adrian Robert wrote:
>> The file menu is missing; its contents are in the application menu  
>> (titled "Emacs"), and the usual contents of the application menu  
>> are completely gone.
>>
>> So I've got "Emacs Edit Options"
>
> Very odd.  I have not made any changes that I *think* could affect  
> this.  Have not seen the bug (10.4) -- even tried setting my lang to  
> German, but it might be I need to do another bootstrap build or  
> something.  There look like there were a lot of menu-related changes  
> in the lisp subdirectory on 2009-09-17.

OK, so it seems to me that the culprit may be:

      [menu clear];

in ns_update_menubar.

Removing the [menu clear] brings the File menu back.

I can't find the implementation of EmacsMenu's -clear, and it is not  
documented as a NSMenu (or NSObject) function.
This makes me think it's something undocumented implemented by the  
AppKit framework.  Didn't manage to class-dump that framework.

If the behavior of -clear has changed in the 10.6 SDK in this respect,  
I would not be surprised if, when compiled on 10.6, it may link  
against the new behavior (clearing everything), and when compiled on  
10.5, it's the old one.

If OS X forces the first menu to be the application name (and I think  
it does, see Info.plist setting), then we get the behavior I'm  
observing.

The patch below seems to do the job.  Hope this works in Nextstep as  
well.
I'll check that in unless you see a problem.

diff --git a/src/nsterm.h b/src/nsterm.h
index 96f65d2..c4935f2 100644
--- a/src/nsterm.h
+++ b/src/nsterm.h
@@ -118,7 +118,6 @@ along with GNU Emacs.  If not, see <http://www.gnu.org/licenses/ 
>.  */
 - (NSMenuItem *)addItemWithWidgetValue: (void *)wvptr;
 - (void)fillWithWidgetValue: (void *)wvptr;
 - (EmacsMenu *)addSubmenuWithTitle: (char *)title forFrame: (struct  
frame *)f;
-- (void) clear;
 - (Lisp_Object)runMenuAt: (NSPoint)p forFrame: (struct frame *)f
                  keymaps: (int)keymaps;
 @end
diff --git a/src/nsmenu.m b/src/nsmenu.m
index 98a086b..f63852c 100644
--- a/src/nsmenu.m
+++ b/src/nsmenu.m
@@ -440,7 +440,10 @@ ns_update_menubar (struct frame *f, int deep_p,  
EmacsMenu *submenu)
             }
         }

-      [menu clear];
+      /* clear menu, leaving the first item (application menu) */
+      for (i = [menu numberOfItems]-1; i>0 ; i--)
+	[menu removeItemAtIndex:1];
+
       for (i = 0; i < XVECTOR (items)->size; i += 4)
 	{
 	  string = XVECTOR (items)->contents[i + 1];


[smime.p7s (application/pkcs7-signature, attachment)]
From: David Reitter <david.reitter <at> gmail.com>
To: Adrian Robert <adrian.b.robert <at> gmail.com>
Cc: 4513 <at> debbugs.gnu.org
Subject: Re: bug#4513: NS: File menu missing
Date: Wed, 23 Sep 2009 21:34:24 -0400

[Message part 1 (text/plain, inline)]
Further to this issue to confirm our diagnosis:



http://developer.apple.com/mac/library/releasenotes/Cocoa/AppKit.html

Backward Compatibility

One backward compatibility mechanism that is occasionally used in the  
frameworks is to check for the version of the system an application  
was built against, and if an older system, modify the behavior to be  
more compatible. This is done in cases where bad incompatibility  
problems are predicted or discovered; and most of these are listed  
below in these notes.

Typically we detect where an application was built by looking at the  
version of the System, Cocoa, AppKit, or Foundation frameworks the  
application was linked against. Thus, as a result of relinking your  
application on Leopard, you might notice different behaviors, some of  
which might cause incompatibilities.

...

NSApplication application menu item title (New since WWDC 2008)

In Leopard, the first item in the main menu (the application menu)  
would have its title modified to the empty string. In SnowLeopard,  
this is only done for apps linked on Leopard or earlier: new apps will  
not see this title modified. The title of the this menu item is  
ignored for display purposes - the application menu always reflects  
the application name.


[smime.p7s (application/pkcs7-signature, attachment)]
From: David Reitter <david.reitter <at> gmail.com>
To: Adrian Robert <adrian.b.robert <at> gmail.com>
Cc: 4513 <at> debbugs.gnu.org, 4513-done <at> debbugs.gnu.org
Subject: Re: bug#4513: NS: File menu missing
Date: Fri, 25 Sep 2009 13:45:14 -0400

[Message part 1 (text/plain, inline)]
On Sep 23, 2009, at 10:24 PM, Adrian Robert wrote:
> OK, after seeing this I'm more inclined to go with "ignore first  
> item at top level on OS X".
>
> (We have: 10.0-10.5.8 = @Apple, 10.5.8 = @"", 10.6+ = @<appname>.   
> Jeez...)

For now I went with the smallest change possible (checking for  
@"Emacs" in addition to the others) as I don't know about NS and  
future changes in NS.
This solution relies on only what is documented.

Suppose you could indeed adopt my earlier patch if this proves  
problematic.  No need for -clear anyways, unless it is used elsewhere.

D
[smime.p7s (application/pkcs7-signature, attachment)]

GNU bug report logs - #4513 NS: File menu missing

GNU bug report logs - #4513
NS: File menu missing