GNU bug report logs - #45110
[PATCH] gnu: gita: Install shell completions.

Previous Next

Package: guix-patches;

Reported by: Michael Rohleder <mike <at> rohleder.de>

Date: Tue, 8 Dec 2020 01:23:02 UTC

Severity: normal

Tags: patch

Done: Oleg Pykhalov <go.wigust <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #10 received at 45110-done <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 45110-done <at> debbugs.gnu.org
Subject: Re: [bug#45110] [PATCH] gnu: gita: Install shell completions.
Date: Tue, 08 Dec 2020 08:13:51 +0300
[Message part 1 (text/plain, inline)]
Hello.

Awesome, thank you!


Small addition.  As described in discussion [1] we don't need to return
a boolean in phases.

[1] https://lists.gnu.org/archive/html/guix-devel/2020-11/msg00585.html

[Message part 2 (text/x-patch, inline)]
diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 95d6c220c0..8504c8b006 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -2959,8 +2959,7 @@ defects faster.")
                             (string-append bash-completion "/gita"))
                  (mkdir-p zsh-completion)
                  (copy-file ".gita-completion.zsh"
-                            (string-append zsh-completion "/_gita"))
-                 #t))))))
+                            (string-append zsh-completion "/_gita"))))))))
       (home-page "https://github.com/nosarthur/gita")
       (synopsis "Command-line tool to manage multiple Git repos")
       (description "This package provides a command-line tool to manage
[Message part 3 (text/plain, inline)]
Pushed to master.

Oleg.
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 4 years and 224 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.