GNU bug report logs - #45108
Added emacs-burly

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45108 in the body.
You can then email your comments to 45108 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: rdes <rdes <at> protonmail.com>
To: rdes via Guix-patches via <guix-patches <at> gnu.org>
Subject: Added emacs-burly
Date: Mon, 07 Dec 2020 23:31:41 +0000

[Message part 1 (text/plain, inline)]

Hello,

The attached patches are to add emacs-burly. I've also attached a patch for emacs-map since it's required and not packaged yet. Please let me know in the future if this should be multiple emails.

Ryan

Sent with [ProtonMail](https://protonmail.com) Secure Email.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-emacs-map.patch (text/x-patch, attachment)]

[0002-gnu-Add-emacs-burly.patch (text/x-patch, attachment)]

Message #10 received at 45108-done <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: rdes <rdes <at> protonmail.com>
Cc: 45108-done <at> debbugs.gnu.org
Subject: Re: [bug#45108] Added emacs-burly
Date: Tue, 08 Dec 2020 08:01:32 +0300

[Message part 1 (text/plain, inline)]

Hello,

Thank you for patches.

rdes via Guix-patches via <guix-patches <at> gnu.org> writes:

[…]

> Please let me know in the future if this should be multiple emails.

It's a good practice to split an email with multiple patches, which is
described on webpage “Sending a Patch Series” [1].

[1] https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html

> Sent with [ProtonMail](https://protonmail.com) Secure Email.
> From 0e24818db4f22cff0d841b7b77866121e0f2d6a5 Mon Sep 17 00:00:00 2001
> From: Ryan Desfosses <rdes <at> protonmail.com>
> Date: Mon, 7 Dec 2020 18:17:52 -0500
> Subject: [PATCH 1/2] gnu: Add emacs-map
                                         ^
                                         missing dot

[…]

> +    (synopsis "Map manipulation functions")
> +    (description
> +     "map.el provides map-manipulation functions that work on alists,
> +hash-table and arrays.  All functions are prefixed with \"map-\".")

1. “description should start with an upper-case letter or digit” as
reported by "./pre-inst-env guix lint".

2. Istead of ‘\"map-\"’, please use ‘@code{map-}’.

[…]

> Subject: [PATCH 2/2] gnu: Add emacs-burly
                                           ^
                                           missing dot

Pushed with changes above to master.

Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 45108 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 45108 <at> debbugs.gnu.org
Cc: go.wigust <at> gmail.com, rdes <at> protonmail.com
Subject: Re: bug#45108: Added emacs-burly
Date: Tue, 08 Dec 2020 08:23:21 +0100

Hello,

Oleg Pykhalov <go.wigust <at> gmail.com> writes:

> Pushed with changes above to master.

I don't think the emacs-map package is needed as a propagated inputs
since it ships with Emacs. Have you tried building emacs-burly without
it?

For the same reason I'm not even sure we need to provide emacs-map at
all (we do not provide emacs-seq either).

WDYT?

Regards,
-- 
Nicolas Goaziou

Message #16 received at 45108 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: rdes <at> protonmail.com, 45108 <at> debbugs.gnu.org
Subject: Re: bug#45108: Added emacs-burly
Date: Tue, 08 Dec 2020 11:59:55 +0300

[Message part 1 (text/plain, inline)]

Hello,

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> I don't think the emacs-map package is needed as a propagated inputs
> since it ships with Emacs. Have you tried building emacs-burly without
> it?

No, I didn't try.


burly requires map 2.1, but Emacs provides 2.0 (M-x find-library map):
--8<---------------cut here---------------start------------->8---
;; Package-Requires: ((emacs "26.3") (map "2.1"))
--8<---------------cut here---------------end--------------->8---

I don't mind removing map from propagated inputs if it not break burly,
but I'm not a user of this package to decide ;-)


Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 45108 <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: go.wigust <at> gmail.com, 45108 <at> debbugs.gnu.org, rdes <at> protonmail.com
Subject: Re: [bug#45108] Added emacs-burly
Date: Tue, 08 Dec 2020 21:43:11 +0100

[Message part 1 (text/plain, inline)]

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:
> Oleg Pykhalov <go.wigust <at> gmail.com> writes:
>
>> Pushed with changes above to master.
>
> I don't think the emacs-map package is needed as a propagated inputs
> since it ships with Emacs. Have you tried building emacs-burly without
> it?
>
> For the same reason I'm not even sure we need to provide emacs-map at
> all (we do not provide emacs-seq either).
>
> WDYT?

I think, emacs-seq has shown that packages "extracted" from emacs (here:
map, xref, project) can be problematic if they become older than the one
that ship with emacs (and are deeper in the graph?).  Not sure, maybe
this is already an issue for emacs-next users?!


-- 
	Brian Kernighan has an automobile which he helped design.
Unlike most automobiles, it has neither speedometer, nor gas gauge, nor
any of the numerous idiot lights which plague the modern driver.
Rather, if the driver makes any mistake, a giant "?" lights up in the
center of the dashboard.  "The experienced driver", he says, "will
usually know what's wrong."

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.