GNU bug report logs - #45105
[PATCH] gnu: Add mbpfan service

Previous Next

Full log

Message #8 received at 45105 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Niklas Eklund <niklas.eklund <at> posteo.net>
Cc: 45105 <at> debbugs.gnu.org
Subject: Re: [bug#45105] [PATCH] gnu: Add mbpfan service
Date: Wed, 06 Jan 2021 11:11:08 +0100

Hello Niklas,

> * gnu/services/mbpfan.scm (mbpfan service): New variable.

Thanks for your contribution and sorry for the late review.

> +                       #$@(if verbose?
> +                            '("-v") ; verbose logging
> +                            '()))
> +                 #:log-file #$log-file))

The indentation is off here.

> +    (list (service-extension shepherd-root-service-type mbpfan-shepherd-service)))

You should wrap this line to stay under the 78 cols limit.

You also need to add this file to 'gnu/local.mk'. It would also be nice
to write some documentation, probably under "Power management services".

Could you please send an updated patch?

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.