GNU bug report logs - #45101
[PATCH] scripts: discover: Remove file locks.

Previous Next

Package: guix-patches;

Reported by: Mathieu Othacehe <othacehe <at> gnu.org>

Date: Mon, 7 Dec 2020 13:18:02 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 45101 <at> debbugs.gnu.org
Subject: [bug#45101] [PATCH] scripts: discover: Remove file locks.
Date: Sat, 12 Dec 2020 20:52:01 +0100

Hi!

Mathieu Othacehe <othacehe <at> gnu.org> skribis:

> * guix/scripts/discover.scm (call-once, call-with-output-file/atomic): New
> procedures copied from (system base compile).
> (call-with-read-file-lock, with-read-file-lock): Remove them.
> (write-publish-file): Use "call-with-output-file/atomic" instead of
> "with-file-lock".
> (read-substitute-urls): Remve file lock.

I think you could use ‘with-atomic-file-output’ from (guix utils).
(Apologies if I gave you the wrong name before!)

Apart from that LGTM, thanks!  :-)

Ludo’.
This bug report was last modified 4 years and 161 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.