From unknown Sun Jun 15 08:48:30 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4510: 23.1; Separate help-argument-face from downcasing Reply-To: "Drew Adams" , 4510@debbugs.gnu.org Resent-From: "Drew Adams" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Mon, 21 Sep 2009 21:45:09 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 4510 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125356891227014 (code B ref -1); Mon, 21 Sep 2009 21:45:09 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 21 Sep 2009 21:35:12 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.4 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8LLZATf026968 for ; Mon, 21 Sep 2009 14:35:12 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MpqXO-0000fp-4t for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 17:35:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MpqXI-0000eA-FX for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 17:35:09 -0400 Received: from [199.232.76.173] (port=47714 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MpqXI-0000dx-7r for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 17:35:04 -0400 Received: from acsinet11.oracle.com ([141.146.126.233]:25110) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MpqXH-0008WL-PT for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 17:35:04 -0400 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by acsinet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n8LLaFKn028873 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 21 Sep 2009 21:36:16 GMT Received: from abhmt012.oracle.com (abhmt012.oracle.com [141.146.116.21]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n8LLZRIA007701 for ; Mon, 21 Sep 2009 21:35:27 GMT Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 21 Sep 2009 14:34:58 -0700 From: "Drew Adams" To: Date: Mon, 21 Sep 2009 14:35:00 -0700 Message-ID: <49ADA31DA6A342CCB1E5FF47158A498A@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Aco7A18aOl2tGDhiRMCwXNdODwMFfQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt012.oracle.com [141.146.116.21] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090209.4AB7F182.01E3:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Emacs 22 introduced face `help-argument-name' and function `help-default-arg-highlight'. The Emacs 22 NEWS says this: To change the default, customize face `help-argument-name' or redefine the function `help-default-arg-highlight'. The problem is that function `help-default-arg-highlight' couples (a) the use of a face to highlight the arguments with (b) downcasing the arguments. These two should be separated, so users can highlight without downcasing (or downcase without highlighting). I, for instance, find lowercase italics (the default, starting with Emacs 22) to be much less readable than uppercase non-italics (the default before Emacs 22). But I would really prefer uppercase italics. There is no way to get this, short of redefining the function `help-default-arg-highlight'. That should not be the only alternative for users. Users should not be expected to redefine basic functions in order to customize such appearances. And in any case, it makes no sense for the face and the letter case to be hard-code-coupled. This is the definition of `help-default-arg-highlight': (defun help-default-arg-highlight (arg) "Default function to highlight arguments in *Help* buffers. It returns ARG in face `help-argument-name'; ARG is also downcased if it displays differently than the default face (according to `face-differs-from-default-p')." (propertize (if (face-differs-from-default-p 'help-argument-name) (downcase arg) arg) 'face 'help-argument-name)) If face `help-argument-name' is different from the default face, then the args are downcased. The logic should simply be to apply the face systematically: if it is the same as the default, then the face would have no effect. And then provide a separate option to control upcasing/downcasing. In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600) of 2009-07-29 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4)' From unknown Sun Jun 15 08:48:30 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4510: 23.1; Separate help-argument-face from downcasing Reply-To: Juanma Barranquero , 4510@debbugs.gnu.org Resent-From: Juanma Barranquero Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Mon, 21 Sep 2009 22:25:13 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4510 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4510-submit@emacsbugs.donarmstrong.com id=B4510.12535714611340 (code B ref 4510); Mon, 21 Sep 2009 22:25:13 +0000 Received: (at 4510) by emacsbugs.donarmstrong.com; 21 Sep 2009 22:17:41 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.3 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-bw0-f223.google.com (mail-bw0-f223.google.com [209.85.218.223]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8LMHcmu001254 for <4510@emacsbugs.donarmstrong.com>; Mon, 21 Sep 2009 15:17:39 -0700 Received: by bwz23 with SMTP id 23so2882098bwz.1 for <4510@emacsbugs.donarmstrong.com>; Mon, 21 Sep 2009 15:17:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=JnYo2ZwVaOMYBO48DCKD8GBRjdkd6rotjNDk6KPPkNs=; b=CfBPOxxoEzJBTKW7x1vrcrLgy3Novz0jeXYANnIi7eJrFEmLDh3mJCdbWOIkaFXOsL 32z3h+Qrm+jOZSod7o8G/+5Yt6L27vRqZXHUBLTYtJf+/+aXHvnGFvL/ucreCV54MjXO MxVxKa9aS4ATAtkjkDcYPKbWi6F3VUJq/abK8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=qFqOtjPBeItcWtrpGxyMp032BIwRXRwhQ9yhSsTjQs6i8ujW1LJSDdUHbXGhqlNStZ 4yKkIEKs9l5MwWALH3zZEZlkRizSCAVSMqJJyba3WwmIwLLjrkQp3R1/28dOxf2DAiCb 2nDXWQfPiNE4IT25vDMEml5ebMRw4jm1GK/ag= MIME-Version: 1.0 Received: by 10.239.141.136 with SMTP id c8mr14938hba.148.1253571452417; Mon, 21 Sep 2009 15:17:32 -0700 (PDT) In-Reply-To: <49ADA31DA6A342CCB1E5FF47158A498A@us.oracle.com> References: <49ADA31DA6A342CCB1E5FF47158A498A@us.oracle.com> From: Juanma Barranquero Date: Tue, 22 Sep 2009 00:17:12 +0200 Message-ID: To: Drew Adams Cc: 4510@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, Sep 21, 2009 at 23:35, Drew Adams wrote: > That should not be the only alternative for users. =C2=A0Users should not > be expected to redefine basic functions in order to customize such > appearances. =C2=A0And in any case, it makes no sense for the face and > the letter case to be hard-code-coupled. I agree. When help argument highlighting was introduced, there was some resistance to adding more configuration options (surely because we were in the long road to Emacs 22 and everybody was tired and wanting to speed things up), and the argument was put forward (by Richard, IIRC) that variables were just one option for the user to customize his Emacs environment, redefining functions being another. I was unconvinced then and I'm still unconvinced now. Redefining a standard Emacs function (or advising around it) in your .emacs is not a good idea; any change in the source of the original function will catch you off guard. Juanma From unknown Sun Jun 15 08:48:30 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4510: 23.1; Separate help-argument-face from downcasing Reply-To: Juanma Barranquero , 4510@debbugs.gnu.org Resent-From: Juanma Barranquero Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Mon, 21 Sep 2009 23:30:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4510 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4510-submit@emacsbugs.donarmstrong.com id=B4510.125357529811240 (code B ref 4510); Mon, 21 Sep 2009 23:30:05 +0000 Received: (at 4510) by emacsbugs.donarmstrong.com; 21 Sep 2009 23:21:38 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.3 required=4.0 tests=AWL,FOURLA,GMAIL, HAS_BUG_NUMBER,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.152]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8LNLZIL011237 for <4510@emacsbugs.donarmstrong.com>; Mon, 21 Sep 2009 16:21:37 -0700 Received: by fg-out-1718.google.com with SMTP id 16so1092473fgg.13 for <4510@emacsbugs.donarmstrong.com>; Mon, 21 Sep 2009 16:21:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=cY+3l4oI7qRI0qRwCNCYCZAVLIhfSAuSqUMplaNrR0A=; b=XM/hk4OmpOGWgRz7HAR8xpa51KUAYaoWrBfzcSaMZM6ENxMuhKplUqmNssHT+yaDR6 Y0WYovrm4q517yvYiumkMACRUD60s4pxhYy6vd0BcfcMg5BGw8/NDpI7tzcJi3MSS9ZY OggEK+Akha9x4ORRrW89VOThoHWSkCB1TrDXw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=izscmCk6Vqw6yqb9BHyydC1cIv7Hohs7Z7z3+7x3DwZQGm2yUuVmaHSmpUDczf5vMX 3389915n10FXOBQqbfRg9yKH6FmxO4pD0wEEmGA4Qwmj92iTI2fbrwd5kO/kp+oEnzgd pbLFPhA+S+rTq79Rz5BRLWDo1iPSMn4h3X1sI= MIME-Version: 1.0 Received: by 10.239.134.221 with SMTP id a29mr19002hba.20.1253575295114; Mon, 21 Sep 2009 16:21:35 -0700 (PDT) In-Reply-To: <49ADA31DA6A342CCB1E5FF47158A498A@us.oracle.com> References: <49ADA31DA6A342CCB1E5FF47158A498A@us.oracle.com> From: Juanma Barranquero Date: Tue, 22 Sep 2009 01:21:15 +0200 Message-ID: To: Drew Adams Cc: 4510@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, Sep 21, 2009 at 23:35, Drew Adams wrote: > The problem is that function `help-default-arg-highlight' couples > (a) the use of a face to highlight the arguments with (b) downcasing > the arguments. =C2=A0These two should be separated, so users can highligh= t > without downcasing (or downcase without highlighting). This is the proposed patch; it also renames `help-default-arg-highlight', which has an unfitting name. Juanma 2009-09-21 Juanma Barranquero * help-fns.el (help-downcase-arguments): New option. (help-default-arg-highlight): Obsolete. (help-highlight-arg): New function. (help-do-arg-highlight): Use it. Suggested by Drew Adams . (Bug#4510) diff --git a/lisp/help-fns.el b/lisp/help-fns.el index 2425310..fc80966 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -158,15 +158,22 @@ KIND should be `var' for a variable or `subr' for a subroutine." (concat "src/" file) file))))) -(defun help-default-arg-highlight (arg) - "Default function to highlight arguments in *Help* buffers. -It returns ARG in face `help-argument-name'; ARG is also -downcased if it displays differently than the default -face (according to `face-differs-from-default-p')." - (propertize (if (face-differs-from-default-p 'help-argument-name) - (downcase arg) - arg) - 'face 'help-argument-name)) +(defcustom help-downcase-arguments + (and (face-differs-from-default-p 'help-argument-name) t) + "If non-nil, argument names in *Help* buffers are downcased." + :type 'boolean + :group 'help + :version "23.2") + +(defun help-highlight-arg (arg) + "Highlight ARG as an argument name for a *Help* buffer. +Return ARG in face `help-argument-name'; ARG is also downcased +if the variable `help-downcase-arguments' is non-nil." + (propertize (if help-downcase-arguments (downcase arg) arg) + 'face 'help-argument-name)) + +(define-obsolete-function-alias 'help-default-arg-highlight + 'help-highlight-arg "23.2") (defun help-do-arg-highlight (doc args) (with-syntax-table (make-syntax-table emacs-lisp-mode-syntax-table) @@ -184,7 +191,7 @@ face (according to `face-differs-from-default-p')." "\\(?:-[a-z0-9-]+\\)?" ; for ARG-xxx, ARG-n "\\(?:-[{([<`\"].*?\\)?"; for ARG-{x}, (x), , [x], `x' "\\>") ; end of word - (help-default-arg-highlight arg) + (help-highlight-arg arg) doc t t 1))))) (defun help-highlight-arguments (usage doc &rest args) From unknown Sun Jun 15 08:48:30 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4510: 23.1; Separate help-argument-face from downcasing Reply-To: "Drew Adams" , 4510@debbugs.gnu.org Resent-From: "Drew Adams" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Tue, 22 Sep 2009 14:45:12 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4510 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4510-submit@emacsbugs.donarmstrong.com id=B4510.125363016927989 (code B ref 4510); Tue, 22 Sep 2009 14:45:12 +0000 Received: (at 4510) by emacsbugs.donarmstrong.com; 22 Sep 2009 14:36:09 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from rgminet12.oracle.com (rcsinet12.oracle.com [148.87.113.124]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8MEa8rt027984 for <4510@emacsbugs.donarmstrong.com>; Tue, 22 Sep 2009 07:36:09 -0700 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rgminet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n8MEZjDr007389 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 22 Sep 2009 14:35:46 GMT Received: from abhmt002.oracle.com (abhmt002.oracle.com [141.146.116.11]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n8MEa03E007439; Tue, 22 Sep 2009 14:36:01 GMT Received: from dradamslap1 (/141.144.169.188) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 22 Sep 2009 07:35:57 -0700 From: "Drew Adams" To: "'Juanma Barranquero'" Cc: <4510@debbugs.gnu.org> References: <49ADA31DA6A342CCB1E5FF47158A498A@us.oracle.com> Date: Tue, 22 Sep 2009 07:35:57 -0700 Message-ID: <6C58CFFF6FFE46968BA790F764525B8A@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Aco7EkvCjb3zgEOWTJmO6jmjvksbYgAf4x7Q X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 In-Reply-To: X-Source-IP: abhmt002.oracle.com [141.146.116.11] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090209.4AB8E0CF.0163:SCFSTAT5015188,ss=1,fgs=0 > This is the proposed patch; it also renames > `help-default-arg-highlight', which has an unfitting name. That works for me. Thx - Drew From unknown Sun Jun 15 08:48:30 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4510: 23.1; Separate help-argument-face from downcasing Reply-To: Juanma Barranquero , 4510@debbugs.gnu.org Resent-From: Juanma Barranquero Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Tue, 22 Sep 2009 14:50:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4510 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4510-submit@emacsbugs.donarmstrong.com id=B4510.125363051328828 (code B ref 4510); Tue, 22 Sep 2009 14:50:04 +0000 Received: (at 4510) by emacsbugs.donarmstrong.com; 22 Sep 2009 14:41:53 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.3 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-bw0-f223.google.com (mail-bw0-f223.google.com [209.85.218.223]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8MEfpKo028821 for <4510@emacsbugs.donarmstrong.com>; Tue, 22 Sep 2009 07:41:53 -0700 Received: by bwz23 with SMTP id 23so3350041bwz.1 for <4510@emacsbugs.donarmstrong.com>; Tue, 22 Sep 2009 07:41:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=KGLFE83mIYcQH/0Nwzl0xTULXC7Y9F2ygwwBEEiLST0=; b=CNlD8rOfjhZYOesfQitoUuLyAWTRIv+4hTteP9CS8ZD1Ahx8AceeKowyQ1FCu48Sxm ZaW6WgAe3ksRigvyYkpBM+eoSjiETkugrS1OtLNBKonUHvmnmn5XJQ33kOgzaohIX5E+ bw7uP+lfbkyUslsrQuFuHjoa6EUV/ipaBz55E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=LAeRm/ckrCxNcs4ASRXemTonkNO6//VRympZLkzVAr8ELEeatUvOv8MRpPnrOhtRgt qJFek36HihcJoklDeykarbzNopEDFCfjs03DZauSdbjgb6RNVhypRXHl+2y2RlxuLopb iTEu4L7K7ocrI5lX1BZOjGSwZp/GflAoiq7Ak= MIME-Version: 1.0 Received: by 10.239.139.199 with SMTP id u7mr82192hbu.96.1253630505161; Tue, 22 Sep 2009 07:41:45 -0700 (PDT) In-Reply-To: <6C58CFFF6FFE46968BA790F764525B8A@us.oracle.com> References: <49ADA31DA6A342CCB1E5FF47158A498A@us.oracle.com> <6C58CFFF6FFE46968BA790F764525B8A@us.oracle.com> From: Juanma Barranquero Date: Tue, 22 Sep 2009 16:41:25 +0200 Message-ID: To: Drew Adams Cc: 4510@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 On Tue, Sep 22, 2009 at 16:35, Drew Adams wrote: > That works for me. I'll commit it if nobody objects. Juanma From unknown Sun Jun 15 08:48:30 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: "Drew Adams" Subject: bug#4510 closed by Juanma Barranquero (Re: bug#4510: 23.1; Separate help-argument-face from downcasing) Message-ID: References: <49ADA31DA6A342CCB1E5FF47158A498A@us.oracle.com> X-Emacs-PR-Message: they-closed 4510 X-Emacs-PR-Package: emacs Reply-To: 4510@debbugs.gnu.org Date: Thu, 24 Sep 2009 19:30:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1253820604-11036-1" This is a multi-part message in MIME format... ------------=_1253820604-11036-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #4510: 23.1; Separate help-argument-face from downcasing It has been closed by Juanma Barranquero . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Juanma Barranquero by replying to this email. --=20 4510: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D4510 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1253820604-11036-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4510-done) by emacsbugs.donarmstrong.com; 24 Sep 2009 19:25:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.2 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=unavailable version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-bw0-f223.google.com (mail-bw0-f223.google.com [209.85.218.223]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8OJPmeb010684; Thu, 24 Sep 2009 12:25:49 -0700 Received: by bwz23 with SMTP id 23so1782142bwz.1 for ; Thu, 24 Sep 2009 12:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=qWCzoZ3I6JM5n3KC9s7XqDYmNWx1/91EVp8If/k/vTA=; b=LHKZjstdn+8CCgUzHWir6pJuHd+EVn5+3+caP9LQm4vQ9LktbnJr/fGxDhZx9sTlWV tSLRRhetq+zU0Ef/2Ogoy8BBd7njhVG5wuajo8HVZe+3XxQkFcuw/OXDRTfJl4hUOgc2 6jPz6X6xmS34GyiqbflQ0surRUV67bt3r0NfI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=Eo6A+hPj9nVhqViZ8pi46lCxB4wMCMdJmDTQaoCGeM6VYzjO/8j8r0IGPbAGabiFn0 QAcsASKOdpeWeCRmxkefes42tsRqQpAKLW3Lhj6nbjDYtD5w1pD9RkfKnTJi6SZy5ifi g8cgJvHJNaF1/Ruotbn2rDLOgw8zPc6R1ybJA= MIME-Version: 1.0 Received: by 10.239.168.153 with SMTP id k25mr304379hbe.68.1253820342151; Thu, 24 Sep 2009 12:25:42 -0700 (PDT) In-Reply-To: References: <49ADA31DA6A342CCB1E5FF47158A498A@us.oracle.com> <6C58CFFF6FFE46968BA790F764525B8A@us.oracle.com> From: Juanma Barranquero Date: Thu, 24 Sep 2009 21:25:22 +0200 Message-ID: Subject: Re: bug#4510: 23.1; Separate help-argument-face from downcasing To: Drew Adams , Dan Nicolaescu Cc: 4510-done@debbugs.gnu.org, 4520-done@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 I've installed the patch, defaulting `help-downcase-arguments' to nil as per Dan's request in bug#4520. If someone objects to the change in the default appearance of argument names we'll know soon enough... Juanma ------------=_1253820604-11036-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 21 Sep 2009 21:35:12 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.4 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8LLZATf026968 for ; Mon, 21 Sep 2009 14:35:12 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MpqXO-0000fp-4t for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 17:35:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MpqXI-0000eA-FX for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 17:35:09 -0400 Received: from [199.232.76.173] (port=47714 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MpqXI-0000dx-7r for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 17:35:04 -0400 Received: from acsinet11.oracle.com ([141.146.126.233]:25110) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MpqXH-0008WL-PT for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 17:35:04 -0400 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by acsinet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n8LLaFKn028873 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 21 Sep 2009 21:36:16 GMT Received: from abhmt012.oracle.com (abhmt012.oracle.com [141.146.116.21]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n8LLZRIA007701 for ; Mon, 21 Sep 2009 21:35:27 GMT Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 21 Sep 2009 14:34:58 -0700 From: "Drew Adams" To: Subject: 23.1; Separate help-argument-face from downcasing Date: Mon, 21 Sep 2009 14:35:00 -0700 Message-ID: <49ADA31DA6A342CCB1E5FF47158A498A@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Aco7A18aOl2tGDhiRMCwXNdODwMFfQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt012.oracle.com [141.146.116.21] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090209.4AB7F182.01E3:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Emacs 22 introduced face `help-argument-name' and function `help-default-arg-highlight'. The Emacs 22 NEWS says this: To change the default, customize face `help-argument-name' or redefine the function `help-default-arg-highlight'. The problem is that function `help-default-arg-highlight' couples (a) the use of a face to highlight the arguments with (b) downcasing the arguments. These two should be separated, so users can highlight without downcasing (or downcase without highlighting). I, for instance, find lowercase italics (the default, starting with Emacs 22) to be much less readable than uppercase non-italics (the default before Emacs 22). But I would really prefer uppercase italics. There is no way to get this, short of redefining the function `help-default-arg-highlight'. That should not be the only alternative for users. Users should not be expected to redefine basic functions in order to customize such appearances. And in any case, it makes no sense for the face and the letter case to be hard-code-coupled. This is the definition of `help-default-arg-highlight': (defun help-default-arg-highlight (arg) "Default function to highlight arguments in *Help* buffers. It returns ARG in face `help-argument-name'; ARG is also downcased if it displays differently than the default face (according to `face-differs-from-default-p')." (propertize (if (face-differs-from-default-p 'help-argument-name) (downcase arg) arg) 'face 'help-argument-name)) If face `help-argument-name' is different from the default face, then the args are downcased. The logic should simply be to apply the face systematically: if it is the same as the default, then the face would have no effect. And then provide a separate option to control upcasing/downcasing. In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600) of 2009-07-29 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4)' ------------=_1253820604-11036-1--