From unknown Mon Aug 18 09:06:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45095: [PATCH] lisp/progmodes/compile.el: only use comint-term-environment under comint Resent-From: Alyssa Ross Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Dec 2020 09:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45095 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 45095@debbugs.gnu.org Cc: Alyssa Ross X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160733192615890 (code B ref -1); Mon, 07 Dec 2020 09:06:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Dec 2020 09:05:26 +0000 Received: from localhost ([127.0.0.1]:52368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmCSU-00048E-25 for submit@debbugs.gnu.org; Mon, 07 Dec 2020 04:05:26 -0500 Received: from lists.gnu.org ([209.51.188.17]:48172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmCSS-000485-NT for submit@debbugs.gnu.org; Mon, 07 Dec 2020 04:05:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmCSS-0003cv-DR for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2020 04:05:24 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:51311) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmCSQ-0001uO-Aq for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2020 04:05:24 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id DE9215C013A for ; Mon, 7 Dec 2020 04:05:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 07 Dec 2020 04:05:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm1; bh=fN6EVBNYtUwlutBjyjvSLvW0aL SQDMa+pyJnUIy+9ws=; b=O38bITqKytL0n5/tvTwOfAWJQyQm4Qv58wiI4+Ls+Y K8ejuouhISKLq3CwnwbyRTvTMPZAx8gv41Ot1pIhJltgZEHgUCeCq9cMFfCRqEZN JdDSc5vSBmDCRP4rGFoR0iXPtaMdNfm6WtPymnzbjJYQWS/+mbZxKv6CEVPPfvcq lt7pPxeN1dbcVbY1RHV3DOvcGCBKK1cXLLD2LH8ZoE8+LJ4bGt1OVGQTEKyRJgGS ldLzvJPNl8efsC69kSM1LDrFRqby0XoVLoS285wTmLZWxCaLT3BteCuZo5lsouqX wbI4b7abbmYLwasSZezggiioLsETrGvOj6ezIUhh4AaQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=fN6EVBNYtUwlutBjy jvSLvW0aLSQDMa+pyJnUIy+9ws=; b=H44oLGVyCFcsH68uX2qSp+5k0bI6EgXcD uW70TZDWFxHJQtiyV2bxtgzREio8BHVU8uyBM9eoPsbOMiJpHx5tGXqu7urHdtwU 0UHlUrN2gqXmA1/JC48D3zxcMwsyuyEnRHLUnEdviSzr4Py/1/mR4ZYwlRQaFF5N rn8Negivv9SywmHjIoCWItGwn4kLHHtpHt0kheGQ6Gfxr2G3a+kkNYSZE9Y3LOZh cgdImhLBwCBskHVtBfmeNPNWs5YWnNrNYnZy6HlsSso/4G9TqGTkB5KWrWtMSrG9 UPGWpTiDrTyCoMPlDQK2qVGAD0o6+e0oJ3zD9jWpn3H1Ke5VH2dTg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudejfedguddvvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpeetlhihshhsrgcutfhoshhsuceohhhisegrlhihshhsrgdrihhs qeenucggtffrrghtthgvrhhnpeehvdffgffhteeijefgteeftdfghfdvheeuhedvjedugf eggfeljefgleefvefgfeenucfkphepgeeirddukeefrddutdefrddujeenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehqhihlihhsshesvghvvg drqhihlhhishhsrdhnvght X-ME-Proxy: Received: from eve.qyliss.net (unknown [46.183.103.17]) by mail.messagingengine.com (Postfix) with ESMTPA id 910AA108005C for ; Mon, 7 Dec 2020 04:05:19 -0500 (EST) Received: by eve.qyliss.net (Postfix, from userid 1000) id 36E6A1092; Mon, 7 Dec 2020 09:05:18 +0000 (UTC) From: Alyssa Ross Date: Mon, 7 Dec 2020 09:04:51 +0000 Message-Id: <20201207090450.2225-1-hi@alyssa.is> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: softfail client-ip=66.111.4.27; envelope-from=qyliss@eve.qyliss.net; helo=out3-smtp.messagingengine.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) comint-term-environment is used for configuring the environment for terminal output under comint. If compile is being used with a different major mode, that mode probably can't handle the fancy terminfo output that comint can, so comint-term-environment should only be used under comint or a derived mode. ; Tested with emacs -Q as follows: ; ; (1) Set comint-terminfo-terminal to "dumb-emacs-ansi", provided by ; recent ncurses: ; ; (setq comint-terminfo-terminal "dumb-emacs-ansi") C-x C-e ; ; (2) Verify that no uninterpreted control characters are displayed by ; (compile "grep --color=auto Emacs README") C-x C-e ; ; (3) Verify that grep knows it can output color when using comint: ; (compile "grep --color=auto Emacs README" t) C-x C-e ; ; Prior to this change, grep in (2) would output control characters, ; which would be displayed uninterpreted in the buffer. --- I haven't got my copyright papers sorted yet, so hopefully this change is also small enough that that doesn't matter. lisp/progmodes/compile.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 787f5d5ef3..b4bcc3f2d2 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -1868,7 +1868,8 @@ compilation-start (let ((process-environment (append compilation-environment - (comint-term-environment) + (when (derived-mode-p 'comint-mode) + (comint-term-environment)) (list (format "INSIDE_EMACS=%s,compile" emacs-version)) (copy-sequence process-environment)))) (set (make-local-variable 'compilation-arguments) -- 2.27.0 From unknown Mon Aug 18 09:06:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#45095: [PATCH] lisp/progmodes/compile.el: only use comint-term-environment under comint Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Dec 2020 15:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45095 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Alyssa Ross Cc: 45095@debbugs.gnu.org Received: via spool by 45095-submit@debbugs.gnu.org id=B45095.160735668726109 (code B ref 45095); Mon, 07 Dec 2020 15:59:02 +0000 Received: (at 45095) by debbugs.gnu.org; 7 Dec 2020 15:58:07 +0000 Received: from localhost ([127.0.0.1]:55032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmItq-0006n3-Sr for submit@debbugs.gnu.org; Mon, 07 Dec 2020 10:58:07 -0500 Received: from quimby.gnus.org ([95.216.78.240]:38638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmItp-0006mX-Oh for 45095@debbugs.gnu.org; Mon, 07 Dec 2020 10:58:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fbJ9SuUR+dBpuJc6BSeQ2vCEJOLohQdjns+yQscH1m0=; b=nRSfhtV4PweXeQiGbiC3UykZNU IrD9qX1JpBA3EcGg87N3TKgK9WVef3cU5dAavYWMoJpb7QcHo8mzyNG+kP0vwHg+4434iGDlS33WB CKUDLmb5lZ5DHazWbn+16uCmZfbRPhDEfhKkTlhBasLaLAs0W/b35Fo2xBQLL5Q325/o=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmIth-0007Ha-Cu; Mon, 07 Dec 2020 16:58:00 +0100 From: Lars Ingebrigtsen References: <20201207090450.2225-1-hi@alyssa.is> X-Now-Playing: Alva Noto's _Xerrox Vol. 04_: "Xerrox =?UTF-8?Q?=C3=8Ele?=" Date: Mon, 07 Dec 2020 16:57:56 +0100 In-Reply-To: <20201207090450.2225-1-hi@alyssa.is> (Alyssa Ross's message of "Mon, 7 Dec 2020 09:04:51 +0000") Message-ID: <87v9ddfw1n.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alyssa Ross writes: > comint-term-environment is used for configuring the environment for > terminal output under comint. If compile is being used with a > different major mode, that mode probably can't handle the fancy [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alyssa Ross writes: > comint-term-environment is used for configuring the environment for > terminal output under comint. If compile is being used with a > different major mode, that mode probably can't handle the fancy > terminfo output that comint can, so comint-term-environment should > only be used under comint or a derived mode. Makes sense -- applied to Emacs 28. [...] > I haven't got my copyright papers sorted yet, so hopefully this change > is also small enough that that doesn't matter. Yup. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 07 10:58:12 2020 Received: (at control) by debbugs.gnu.org; 7 Dec 2020 15:58:12 +0000 Received: from localhost ([127.0.0.1]:55035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmItw-0006nN-6u for submit@debbugs.gnu.org; Mon, 07 Dec 2020 10:58:12 -0500 Received: from quimby.gnus.org ([95.216.78.240]:38654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmItu-0006mw-Ut for control@debbugs.gnu.org; Mon, 07 Dec 2020 10:58:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=upAdtUYyYLMYjbdNgShecqMxJNxykM30GZTDbzS64Po=; b=SH2rxOa9S6iM2/GL997jZACfoS k0iOwKjInvI3M86UUB1Thbnrx6EB+09D8TOFtadABd34yYY9KuhzgtC/UHVX1UAcKSdcXJwuFxXV/ tFRLQSv6Wh2KBUzUhoQxTJf3TzMsya+rKQKDtRDTzk6zLuKz4U2GlZsczKi6SWYwH4a0=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmItn-0007Hm-6y for control@debbugs.gnu.org; Mon, 07 Dec 2020 16:58:05 +0100 Date: Mon, 07 Dec 2020 16:58:02 +0100 Message-Id: <87tusxfw1h.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #45095 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 45095 fixed close 45095 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 45095 fixed close 45095 28.1 quit