From unknown Tue Jun 17 01:28:39 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#45084 <45084@debbugs.gnu.org> To: bug#45084 <45084@debbugs.gnu.org> Subject: Status: so-long mode vs. dired-view-file Reply-To: bug#45084 <45084@debbugs.gnu.org> Date: Tue, 17 Jun 2025 08:28:39 +0000 retitle 45084 so-long mode vs. dired-view-file reassign 45084 emacs submitter 45084 =E7=A9=8D=E4=B8=B9=E5=B0=BC Dan Jacobson severity 45084 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 06 17:01:27 2020 Received: (at submit) by debbugs.gnu.org; 6 Dec 2020 22:01:27 +0000 Received: from localhost ([127.0.0.1]:51555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1km25u-0006KD-QU for submit@debbugs.gnu.org; Sun, 06 Dec 2020 17:01:27 -0500 Received: from lists.gnu.org ([209.51.188.17]:53960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1km25t-0006K6-TN for submit@debbugs.gnu.org; Sun, 06 Dec 2020 17:01:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1km25t-0000HJ-Lk for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 17:01:25 -0500 Received: from hamster.birch.relay.mailchannels.net ([23.83.209.80]:62126) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1km25r-0002Cm-Qg for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 17:01:25 -0500 X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 233A0700A68 for ; Sun, 6 Dec 2020 22:01:22 +0000 (UTC) Received: from pdx1-sub0-mail-a24.g.dreamhost.com (100-98-118-97.trex.outbound.svc.cluster.local [100.98.118.97]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id B8617700A00 for ; Sun, 6 Dec 2020 22:01:21 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org Received: from pdx1-sub0-mail-a24.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.11); Sun, 06 Dec 2020 22:01:22 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jidanni@jidanni.org X-MailChannels-Auth-Id: dreamhost X-Illegal-Grain: 55a169c05ad74728_1607292081959_702661945 X-MC-Loop-Signature: 1607292081959:1941194183 X-MC-Ingress-Time: 1607292081959 Received: from pdx1-sub0-mail-a24.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a24.g.dreamhost.com (Postfix) with ESMTP id 6DD8F8AD19 for ; Sun, 6 Dec 2020 14:01:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jidanni.org; h=from:to :subject:date:message-id:mime-version:content-type; s= jidanni.org; bh=K7kKZECw+32KHIZQZBeR25d3Okg=; b=QKUJcMw1Wk8SJXcG BsrBi5BLvSH8bh3tG333KL8du01sIcTiJwgU1VnsP4Oy3KoomC6BxCvMhYXFCKr3 gSuHQDpV1efQbRIJ9W+m/XeCXTpMa7XbAUum+VdKhhEL8bHfXxvSGeug25ZMAFmH 96/INjbrh9n+Pv4Ijg89EQ329eQ= Received: from jidanni.org (114-26-45-21.dynamic-ip.hinet.net [114.26.45.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jidanni@jidanni.org) by pdx1-sub0-mail-a24.g.dreamhost.com (Postfix) with ESMTPSA id 21E568A3D7 for ; Sun, 6 Dec 2020 14:01:20 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a24 From: =?utf-8?B?56mN5Li55bC8?= Dan Jacobson To: bug-gnu-emacs@gnu.org Subject: so-long mode vs. dired-view-file Date: Sun, 06 Dec 2020 20:22:01 +0800 Message-ID: <87v9dfunti.5.fsf@jidanni.org> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=23.83.209.80; envelope-from=jidanni@jidanni.org; helo=hamster.birch.relay.mailchannels.net X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_06_12=1.543, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) OK, here in emacs-version "27.1" we have (global-so-long-mode 1) in our .emacs file, and everything is working great. We are happily using dired, v ;; dired-view-file q ;; View-quit SPC ;; dired-next-line v ;; dired-view-file q ;; View-quit SPC ;; dired-next-line v ;; dired-view-file q ;; View-quit SPC ;; dired-next-line v ;; dired-view-file q ;; View-quit SPC ;; dired-next-line v ;; dired-view-file q ;; self-insert-command <------Notice anything NOT funny? C-x k ;; kill-buffer ;; minibuffer-complete-and-exit That's right. We stumbled into a file that triggers so-long mode. Our whole rhythm is busted. And we have to go through hoops to finally do what just a "q" did. So so-long mode and whatever dired-view-file calls should somehow make a deal not to mess up "q". The modeline says (So Long View). From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 06 23:24:17 2020 Received: (at 45084) by debbugs.gnu.org; 7 Dec 2020 04:24:17 +0000 Received: from localhost ([127.0.0.1]:51983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1km84P-0005Hj-2u for submit@debbugs.gnu.org; Sun, 06 Dec 2020 23:24:17 -0500 Received: from smtp-4.orcon.net.nz ([60.234.4.59]:53449) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1km84N-0005Ha-0M for 45084@debbugs.gnu.org; Sun, 06 Dec 2020 23:24:15 -0500 Received: from [10.253.37.70] (port=13199 helo=webmail.orcon.net.nz) by smtp-4.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1km84K-0001eL-Su; Mon, 07 Dec 2020 17:24:13 +1300 Received: from wlgwil-nat-wlan.catalyst.net.nz ([202.78.240.10]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Mon, 07 Dec 2020 17:24:12 +1300 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 07 Dec 2020 17:24:12 +1300 From: Phil Sainty To: =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC_Dan_Jacobson?= Subject: Re: bug#45084: so-long mode vs. dired-view-file In-Reply-To: <87v9dfunti.5.fsf@jidanni.org> References: <87v9dfunti.5.fsf@jidanni.org> Message-ID: <376f3bbf8aa9df9efc2fc798077ea954@webmail.orcon.net.nz> X-Sender: psainty@orcon.net.nz User-Agent: Orcon Webmail X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45084 Cc: 45084@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2020-12-07 01:22, 積丹尼 Dan Jacobson wrote: > That's right. We stumbled into a file that triggers so-long mode. > > Our whole rhythm is busted. And we have to go through hoops to finally > do what just a "q" did. > > So so-long mode and whatever dired-view-file calls should somehow make > a deal not to mess up "q". It's true that, by default, so-long changing the major mode is going to cause key bindings for the original mode to not be available. This is one of the trade-offs we make -- we have the benefit that Emacs isn't going to freeze up, with the cost that the file is being treated differently. I don't think it would be very practical to try to account for all of the special cases that might arise in people's workflows, and try to implement workarounds. Adding `view-mode' support wouldn't be hard, but I do worry about the slippery slope factor. You can alternatively use: (setq so-long-action 'so-long-minor-mode) And then the buffers would remain in view-mode, and "q" will work as normal. -Phil From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 08 00:30:40 2020 Received: (at 45084) by debbugs.gnu.org; 8 Dec 2020 05:30:40 +0000 Received: from localhost ([127.0.0.1]:56287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmVaC-00087Z-5L for submit@debbugs.gnu.org; Tue, 08 Dec 2020 00:30:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmVaA-00087I-0K for 45084@debbugs.gnu.org; Tue, 08 Dec 2020 00:30:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43935) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmVa2-0001kf-Rb; Tue, 08 Dec 2020 00:30:30 -0500 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1kmVa1-00016i-Dr; Tue, 08 Dec 2020 00:30:29 -0500 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Phil Sainty In-Reply-To: <376f3bbf8aa9df9efc2fc798077ea954@webmail.orcon.net.nz> (message from Phil Sainty on Mon, 07 Dec 2020 17:24:12 +1300) Subject: Re: bug#45084: so-long mode vs. dired-view-file References: <87v9dfunti.5.fsf@jidanni.org> <376f3bbf8aa9df9efc2fc798077ea954@webmail.orcon.net.nz> Message-Id: Date: Tue, 08 Dec 2020 00:30:29 -0500 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45084 Cc: 45084@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > > So so-long mode and whatever dired-view-file calls should somehow make > > a deal not to mess up "q". > It's true that, by default, so-long changing the major mode is going > to cause key bindings for the original mode to not be available. dired-view-file does something quite unusual: it visits a file and puts it in View mode. I think so-long needs to make a special case for View mode. For instance, if View mode is in effect, it could (1) turn off View mode, (2) switch modes however it does, then (3) reenable View mode. -- Dr Richard Stallman Chief GNUisance of the GNU Project (https://gnu.org) Founder, Free Software Foundation (https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 06 06:32:30 2021 Received: (at 45084) by debbugs.gnu.org; 6 Jun 2021 10:32:30 +0000 Received: from localhost ([127.0.0.1]:50723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpq50-0001IK-0q for submit@debbugs.gnu.org; Sun, 06 Jun 2021 06:32:30 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpq4y-0001I7-7Z for 45084@debbugs.gnu.org; Sun, 06 Jun 2021 06:32:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CsHK9Qboz6mhyNtPn+MRFYEmEHmYYxc7mffcZimmX20=; b=hO85XS/6KiXsxTef4zcn9jvmMZ 2pgnBsC+z7otYRIerX1uPJyBc4586hWyDnfJI9sdqVhg86AT0r1N4GVO4UfQUi9GvgYtNhcLNDSoH EFAG4Ufn7Gj4JLpisxTgNm5IIPwaS3/15CxOKV/p1+UODzvThhaNOCVtkFaT7F9H9sQM=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpq4p-0005WW-5R; Sun, 06 Jun 2021 12:32:21 +0200 From: Lars Ingebrigtsen To: Richard Stallman Subject: Re: bug#45084: so-long mode vs. dired-view-file References: <87v9dfunti.5.fsf@jidanni.org> <376f3bbf8aa9df9efc2fc798077ea954@webmail.orcon.net.nz> X-Now-Playing: Carolina Tar Heels's _Anthology of American Folk Music Volume 1: Ballads (2)_: "Got the Farm Land Blues" Date: Sun, 06 Jun 2021 12:32:18 +0200 In-Reply-To: (Richard Stallman's message of "Tue, 08 Dec 2020 00:30:29 -0500") Message-ID: <87y2bns2q5.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Richard Stallman writes: > dired-view-file does something quite unusual: it visits a file and puts > it in View mode. > > I think so-long needs to make a special case for View mode. > For instance, if View mode is in effect, [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45084 Cc: Phil Sainty , 45084@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Richard Stallman writes: > dired-view-file does something quite unusual: it visits a file and puts > it in View mode. > > I think so-long needs to make a special case for View mode. > For instance, if View mode is in effect, it could (1) turn off View mode, > (2) switch modes however it does, then (3) reenable View mode. It does feel a bit messy to special-case `view-mode' here, but on the other hand, not doing so will make the `v' command in Dired a less handy. So I've gone ahead with Richard's suggestion here in Emacs 28 -- `so-long' will now restore the view minor mode if it was switched on. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 06 06:33:35 2021 Received: (at control) by debbugs.gnu.org; 6 Jun 2021 10:33:35 +0000 Received: from localhost ([127.0.0.1]:50727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpq63-0001K2-Ai for submit@debbugs.gnu.org; Sun, 06 Jun 2021 06:33:35 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpq61-0001Jn-Ru for control@debbugs.gnu.org; Sun, 06 Jun 2021 06:33:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QuTGAx9RYAaYM9SX13a4n0u4Xp5Xj06M7j0NLfK5UmE=; b=BcEd27GUFrQ/A/B9uaQOBKVXCd yuGSBqWmNOxSKbkqAgZ1iNj1PBGpEA5+pCkZES8URLBUYXIPODX9F6Z3ZFSjcI8AnPySaMxPP7o9T zOzk+SwHpMGTphtLDr/G7pUPJCnZZXn8kdBvjI6lW/PARhEw+jLNd877I1ug5SSZuGC8=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpq5u-0005Wy-DO for control@debbugs.gnu.org; Sun, 06 Jun 2021 12:33:28 +0200 Date: Sun, 06 Jun 2021 12:33:25 +0200 Message-Id: <87wnr7s2oa.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #45084 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 45084 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 45084 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 07 04:14:35 2021 Received: (at 45084) by debbugs.gnu.org; 7 Jun 2021 08:14:35 +0000 Received: from localhost ([127.0.0.1]:54402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqAP1-0001lS-8A for submit@debbugs.gnu.org; Mon, 07 Jun 2021 04:14:34 -0400 Received: from smtp-3.orcon.net.nz ([60.234.4.44]:43951) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqAOv-0001lG-Tn for 45084@debbugs.gnu.org; Mon, 07 Jun 2021 04:14:29 -0400 Received: from [10.253.37.70] (port=52568 helo=webmail.orcon.net.nz) by smtp-3.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1lqAOh-0002Eu-6E; Mon, 07 Jun 2021 20:14:15 +1200 Received: from ip-116-251-149-206.kinect.net.nz ([116.251.149.206]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Mon, 07 Jun 2021 20:14:11 +1200 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 07 Jun 2021 20:14:11 +1200 From: Phil Sainty To: Lars Ingebrigtsen Subject: Re: bug#45084: so-long mode vs. dired-view-file In-Reply-To: <87y2bns2q5.fsf@gnus.org> References: <87v9dfunti.5.fsf@jidanni.org> <376f3bbf8aa9df9efc2fc798077ea954@webmail.orcon.net.nz> <87y2bns2q5.fsf@gnus.org> Message-ID: <5b60e019029d510150f5bd9f2b87ddf4@webmail.orcon.net.nz> X-Sender: psainty@orcon.net.nz User-Agent: Orcon Webmail X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45084 Cc: 45084@debbugs.gnu.org, Richard Stallman , jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Lars, Thanks for this. I've actually implemented a more general solution with default support for the view-mode case, so I'll revert your changes when I merge the scratch/so-long changes. https://git.savannah.gnu.org/cgit/emacs.git/commit/?h=scratch/so-long&id=6edeae3b4b7dd5105c9cf0dc0560d4c2c96a85bd I don't see a problem with leaving your change in place for the interim, though. It doesn't handle the `so-long-revert' case, but there's no need to address that as my changes will deal with it. -Phil On 2021-06-06 22:32, Lars Ingebrigtsen wrote: > Richard Stallman writes: > >> dired-view-file does something quite unusual: it visits a file and >> puts >> it in View mode. >> >> I think so-long needs to make a special case for View mode. >> For instance, if View mode is in effect, it could (1) turn off View >> mode, >> (2) switch modes however it does, then (3) reenable View mode. > > It does feel a bit messy to special-case `view-mode' here, but on the > other hand, not doing so will make the `v' command in Dired a less > handy. > > So I've gone ahead with Richard's suggestion here in Emacs 28 -- > `so-long' will now restore the view minor mode if it was switched on. From unknown Tue Jun 17 01:28:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 05 Jul 2021 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator