GNU bug report logs - #45068
[PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)

Previous Next

Full log

View this message in rfc822 format

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 45068 <at> debbugs.gnu.org
Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)
Date: Tue, 08 Dec 2020 12:03:27 +0000

Protesilaos Stavrou <info <at> protesilaos.com> writes:

> I have made some major changes to the Modus themes and tagged this as
> the first major release.  I am opening the present bug report because
> this change has implications on how the themes are distributed with
> Emacs.

Thanks for your work on these themes!

[...]

> Those are the issues I could identify.  As such, the attached patch
> removes the old files and places the new ones in ../lisp/modus-themes/.
> The themes' manual is updated to cover the new version.  The NEWS entry
> is edited accordingly.
>
> I understand you may object to the course of action covered by the
> patch.  Please inform me of a better way to address this issue.  My
> intent is to contribute version 1.0 of my themes to Emacs (1.0.2 to be
> precise) and am prepared to make the requisite changes based on your
> feedback.

FWIW, I'd sooner make the infrastructure changes needed to make themes
under etc/themes/ more modular and package-like, than start moving them
out of etc/themes/.

Otherwise, I'd expect themes under lisp/ to behave exactly like those
under etc/themes/, which would make the etc/themes/ directory redundant.
(Maybe we need a lisp/themes/ directory?)

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.