GNU bug report logs - #45068
[PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)

Previous Next

Package: emacs;

Reported by: Protesilaos Stavrou <info <at> protesilaos.com>

Date: Sun, 6 Dec 2020 12:25:02 UTC

Severity: normal

Tags: patch

Fixed in version 28.1

Done: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Christopher Dimech <dimech <at> gmx.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: contovob <at> tcd.ie, info <at> protesilaos.com, juri <at> linkov.net, Stefan Kangas <stefankangas <at> gmail.com>, 45068 <at> debbugs.gnu.org
Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)
Date: Fri, 11 Dec 2020 16:42:10 +0100
> Sent: Friday, December 11, 2020 at 4:32 PM
> From: "Eli Zaretskii" <eliz <at> gnu.org>
> To: "Stefan Kangas" <stefankangas <at> gmail.com>
> Cc: contovob <at> tcd.ie, info <at> protesilaos.com, 45068 <at> debbugs.gnu.org, juri <at> linkov.net
> Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)
>
> > From: Stefan Kangas <stefankangas <at> gmail.com>
> > Date: Fri, 11 Dec 2020 09:15:32 -0600
> > Cc: juri <at> linkov.net, info <at> protesilaos.com, contovob <at> tcd.ie,
> > 	45068 <at> debbugs.gnu.org
> >
> > > What theme-related files need to be byte-compiled, and why?
> >
> > I believe the issues involved are explained in some detail in the first
> > message in this bug report.
>
> If they are, I'm missing that.  All I see is an assertion that the
> files must be byte-compiled:
>
> > The problem with contributing this new code to Emacs is that it cannot
> > work if it is placed in ../etc/themes/.  Instead, the files need to be
> > in a path that handles byte-compilation, like ../lisp/modus-themes/.

Then a good idea to use "lisp/themes" for modus-themes :)

> I'm probably missing something, and that is what I'm asking to
> elaborate on.
>
> TIA
>
>
>
>




This bug report was last modified 4 years and 135 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.