GNU bug report logs - #45068
[PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)

Previous Next

Full log

Message #197 received at 45068 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: "Basil L. Contovounesios" <contovob <at> tcd.ie>, Eli Zaretskii <eliz <at> gnu.org>,
 45068 <at> debbugs.gnu.org
Subject: Re: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2
 (backward-incompatible)
Date: Thu, 04 Mar 2021 13:53:04 -0300

Hi Protesilaos,

Protesilaos Stavrou <info <at> protesilaos.com> writes:

> Hello again!
>
> As noted earlier, please find attached the patch that upgrades the
> themes to their newest version 1.2.0.  I tested it with Basil's latest
> patch for 'require-theme', though it still works with the variant of
> that function currently in trunk.

[...]

> ;;;###autoload
> (when (and (boundp 'custom-theme-load-path) load-file-name)
>   (add-to-list 'custom-theme-load-path
>                (file-name-as-directory (file-name-directory load-file-name))))

A nit: I think this code should avoid adding the value of
custom-theme-directory or the built-in theme directory name to
custom-theme-load-path , if `custom-theme-directory' (for the former) or
t (for the latter) are already present in custom-theme-load-path.  In
particular, a theme distributed with Emacs should at least check for t,
to avoid a repeated entry.

I've noticed that the leuven theme has a similar code as well: I think
that is a (really minor) bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.