GNU bug report logs - #45068
[PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)

Previous Next

Full log

View this message in rfc822 format

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: "Basil L. Contovounesios" <contovob <at> tcd.ie>, 45068 <at> debbugs.gnu.org
Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)
Date: Thu, 10 Dec 2020 13:46:36 +0200

[Message part 1 (text/plain, inline)]

On 2020-12-10, 02:25 -0600, Stefan Kangas <stefankangas <at> gmail.com> wrote:

> Protesilaos Stavrou <info <at> protesilaos.com> writes:
>
>> I agree that putting them all under lisp/ is not the right way to go
>> right now.  Today I will experiment with placing the libraries in
>> lisp/themes and the derivatives in etc/themes.  This will obfuscate the
>> source code though, but I will try nonetheless and report back to you
>> (without prejudice to any other ideas you or someone else may have).
>
> Thanks!  Looking forward to seeing the new version in Emacs.
>
> Could you explain how it would obfuscate the source code?  I'm not sure
> I understand that part.

I followed your advice in reviewing my patch.  Please find it attached.

In short:

+ The 'modus-operandi-theme' and 'modus-vivendi-theme' are in
  etc/themes.

  - Standard commands like 'load-theme' and 'enable-theme' work as
    intended.

  - Theme-level functions/commands, such as 'modus-themes-toggle' work
    as expected.

+ The other two files, 'modus-themes-core.el' and 'modus-themes.el' are
  placed under lisp/themes.

Note I tried to edit the texi file in light of bug#45141 and I think I
did everything right, but I cannot run that command locally---it is slow
and my hardware's temparature rises considerably.  Perhaps the texi file
needs to be edited further, in which case I am prepared to do whatever
is necessary (and apologies in advance for taking too much out of your
time).

* * *

On the "obfuscation" point I mentioned before: I expressed myself
poorly.  What I thought was that it would be difficult to study the
theme's code, but one upside (I think) of the aforementioned changes is
that M-x find-library now lists the files I placed in lisp/themes.

-- 
Protesilaos Stavrou
protesilaos.com

[0001-Update-Modus-themes-1.0.2-backward-incompatible.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.