GNU bug report logs - #45068
[PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)

Previous Next

Full log

View this message in rfc822 format

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Mauro Aranda <maurooaranda <at> gmail.com>, 45068 <at> debbugs.gnu.org
Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)
Date: Thu, 04 Mar 2021 06:53:06 +0200

On 2021-03-04, 02:04 +0000, "Basil L. Contovounesios" <contovob <at> tcd.ie> wrote:

> Protesilaos Stavrou <info <at> protesilaos.com> writes:
>
>> I applied it and it works for what I want to do.  The decoupling feels
>> more appropriate.
>
> Thanks for reviewing it.

You are welcome!

>> The major difference I see between evaluating 'require-theme' and
>> 'require' forms is that the latter errors with a backtrace buffer, while
>> the former logs a message.
>>
>> Compare those:
>>
>>     (require 'give-me-error)
>>     (require-theme 'give-me-error)
>
> Hm, how are you evaluating them?  Here's what I tried:
>
> [...]
>
> The patch implements require-theme in terms of require,
> so even the error symbol and data should be identical.

My bad!  I was trying the patch in emacs -Q and then went to my
unpatched Emacs' scratch buffer...

>> At any rate, tomorrow I will share with you the new version of my themes
>> and their manual.
>
> I look forward to it.

Will finalise the changelog entry and update this thread.  Probably
within 8 hours or so.

-- 
Protesilaos Stavrou
protesilaos.com

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.