GNU bug report logs - #45068
[PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)

Previous Next

Package: emacs;

Reported by: Protesilaos Stavrou <info <at> protesilaos.com>

Date: Sun, 6 Dec 2020 12:25:02 UTC

Severity: normal

Tags: patch

Fixed in version 28.1

Done: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Protesilaos Stavrou <info <at> protesilaos.com>, maurooaranda <at> gmail.com, 45068 <at> debbugs.gnu.org
Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)
Date: Tue, 02 Mar 2021 10:35:02 +0000
Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Protesilaos Stavrou <info <at> protesilaos.com>
>> Cc: Mauro Aranda <maurooaranda <at> gmail.com>,  Eli Zaretskii <eliz <at> gnu.org>,
>>   45068 <at> debbugs.gnu.org
>> Date: Tue, 02 Mar 2021 07:47:58 +0200
>> 
>> >   (defun require-theme (feature &optional noerror)
>> >     (let ((load-path (custom-theme--load-path)))
>> >       (require feature nil noerror)))
>> 
>> No the themes do not need that dual behaviour.  And yes, your version
>> works and I am happy with it: all I need is a 'require' that reads from
>> etc/themes.
>
> Won't the above version cause problems if the loaded theme needs to
> require some Emacs package?  Binding load-path would get in the way of
> that, no?

Probably, so locate-file is indeed the way to go.
(The above was mostly an illustration.)

Thanks,

-- 
Basil




This bug report was last modified 4 years and 135 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.