GNU bug report logs - #45068
[PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)

Previous Next

Full log

Message #14 received at 45068 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: "Basil L. Contovounesios" <contovob <at> tcd.ie>, 45068 <at> debbugs.gnu.org
Subject: Re: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2
 (backward-incompatible)
Date: Thu, 10 Dec 2020 09:57:46 +0200

On 2020-12-09, 15:58 -0600, Stefan Kangas <stefankangas <at> gmail.com> wrote:

> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>
>>> Those are the issues I could identify.  As such, the attached patch
>>> removes the old files and places the new ones in ../lisp/modus-themes/.
>>> The themes' manual is updated to cover the new version.  The NEWS entry
>>> is edited accordingly.
>>>
>>> I understand you may object to the course of action covered by the
>>> patch.  Please inform me of a better way to address this issue.  My
>>> intent is to contribute version 1.0 of my themes to Emacs (1.0.2 to be
>>> precise) and am prepared to make the requisite changes based on your
>>> feedback.
>>
>> FWIW, I'd sooner make the infrastructure changes needed to make themes
>> under etc/themes/ more modular and package-like, than start moving them
>> out of etc/themes/.
>>
>> Otherwise, I'd expect themes under lisp/ to behave exactly like those
>> under etc/themes/, which would make the etc/themes/ directory redundant.
>> (Maybe we need a lisp/themes/ directory?)
>
> Yes, I think if we start adding a number of these themes under
> "lisp/<foo>-theme/" it risks getting messy over time.
>
> Would it make sense to just add a "lisp/themes" directory, as Basil
> suggests, containing the new files modus-themes-core.el and
> modus-themes.el?
>
> That way, I assume that we can just keep the themes in "etc/themes" for
> now, while any theme that needs it can put its support libraries in
> "lisp/themes".  Does that make sense?  Would it work without any changes
> to load-theme?

Thank you Stefan and Basil!

I agree that putting them all under lisp/ is not the right way to go
right now.  Today I will experiment with placing the libraries in
lisp/themes and the derivatives in etc/themes.  This will obfuscate the
source code though, but I will try nonetheless and report back to you
(without prejudice to any other ideas you or someone else may have).

-- 
Protesilaos Stavrou
protesilaos.com

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.