Subject: Re: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)

From: "Basil L. Contovounesios" <[email-masked]>
Date: Thu, 04 Mar 2021 02:04:41 +0000

Protesilaos Stavrou <[email-masked]> writes:

> I applied it and it works for what I want to do.  The decoupling feels
> more appropriate.

Thanks for reviewing it.

> The major difference I see between evaluating 'require-theme' and
> 'require' forms is that the latter errors with a backtrace buffer, while
> the former logs a message.
>
> Compare those:
>
>     (require 'give-me-error)
>     (require-theme 'give-me-error)

Hm, how are you evaluating them?  Here's what I tried:

0. ./src/emacs -Q
1. (require 'give-me-error) C-j

  Debugger entered--Lisp error:
      (file-missing "Cannot open load file"
                    "No such file or directory"
                    "give-me-error")
    require(give-me-error)
    (progn (require 'give-me-error))
    eval((progn (require 'give-me-error)) t)
    elisp--eval-last-sexp(t)
    eval-last-sexp(t)
    eval-print-last-sexp(nil)
    funcall-interactively(eval-print-last-sexp nil)
    call-interactively(eval-print-last-sexp nil nil)
    command-execute(eval-print-last-sexp)

2. q
3. (require-theme 'give-me-error) C-j

  Debugger entered--Lisp error:
      (file-missing "Cannot open load file"
                    "No such file or directory"
                    "give-me-error")
    require(give-me-error)
    require-theme(give-me-error)
    (progn (require-theme 'give-me-error))
    eval((progn (require-theme 'give-me-error)) t)
    elisp--eval-last-sexp(t)
    eval-last-sexp(t)
    eval-print-last-sexp(nil)
    funcall-interactively(eval-print-last-sexp nil)
    call-interactively(eval-print-last-sexp nil nil)
    command-execute(eval-print-last-sexp)

The patch implements require-theme in terms of require,
so even the error symbol and data should be identical.

> At any rate, tomorrow I will share with you the new version of my themes
> and their manual.

I look forward to it.

Thanks,

-- 
Basil