Subject: Re: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)

From: "Basil L. Contovounesios" <[email-masked]>
Date: Tue, 02 Mar 2021 10:35:02 +0000

Eli Zaretskii <[email-masked]> writes:

>> From: Protesilaos Stavrou <[email-masked]>
>> Cc: Mauro Aranda <[email-masked]>,  Eli Zaretskii <[email-masked]>,
>>   [email-masked]
>> Date: Tue, 02 Mar 2021 07:47:58 +0200
>> 
>> >   (defun require-theme (feature &optional noerror)
>> >     (let ((load-path (custom-theme--load-path)))
>> >       (require feature nil noerror)))
>> 
>> No the themes do not need that dual behaviour.  And yes, your version
>> works and I am happy with it: all I need is a 'require' that reads from
>> etc/themes.
>
> Won't the above version cause problems if the loaded theme needs to
> require some Emacs package?  Binding load-path would get in the way of
> that, no?

Probably, so locate-file is indeed the way to go.
(The above was mostly an illustration.)

Thanks,

-- 
Basil