From unknown Wed Aug 20 05:15:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#45062] [PATCH 1/2] gnu: xfce4-session: Fix xfce4-panel plugin detection. Resent-From: Kei Kebreau Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Dec 2020 05:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45062 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 45062@debbugs.gnu.org Cc: Kei Kebreau X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16072309714380 (code B ref -1); Sun, 06 Dec 2020 05:03:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Dec 2020 05:02:51 +0000 Received: from localhost ([127.0.0.1]:48662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klmC3-00018O-O4 for submit@debbugs.gnu.org; Sun, 06 Dec 2020 00:02:51 -0500 Received: from lists.gnu.org ([209.51.188.17]:39232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klmBz-00018E-AX for submit@debbugs.gnu.org; Sun, 06 Dec 2020 00:02:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klmBy-00046E-Ob for guix-patches@gnu.org; Sun, 06 Dec 2020 00:02:38 -0500 Received: from mout02.posteo.de ([185.67.36.66]:50779) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klmBt-0008BS-BS for guix-patches@gnu.org; Sun, 06 Dec 2020 00:02:38 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 05B5C2400FB for ; Sun, 6 Dec 2020 06:02:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1607230948; bh=dqExPJMQuPqNyIw+n0CNlsQb40KKkDywF5lZDVsZ0jA=; h=From:To:Cc:Subject:Date:From; b=eB4QrAlqN1pJoZ8Obshe/mdhUkBNxK/G7EETBJCpXbIntLRi7jVGPqhd6NCXGpgm5 1M/e/rIRvA5qlioFmEdzV5HJLrbDHW6QfX/R0I8oXEsqxKQLAq9VJUXzKzoXg3+epz fgglk/lmYKmqHfo7LRDMjbCBNaQU8aRd4rO80EDgeHOZzludYfxjNs94sOH9ttMiYP A/HE4unX8eSIgfLnxHDNgTnkTJN8cTxBm+HfJKOt93qxfKyXIxBn6kaGhdPpnE7zXr OxlvFOEHqH1hzYUy760hkmGVo00ZfiL0M4399dfI9V0h8pRU07Gi3LuQ6vv5lAmYnl 5x9zzXrWs8hXw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CpZ7Q6x0tz9rxG; Sun, 6 Dec 2020 06:02:26 +0100 (CET) From: Kei Kebreau Date: Sun, 6 Dec 2020 00:02:24 -0500 Message-Id: <20201206050224.5355-1-kkebreau@posteo.net> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.66; envelope-from=kkebreau@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/xfce.scm (xfce4-session)[source]: Add patch to append the path to user-installed xfce4-panel plugins to the X_XFCE4_LIB_DIRS environment variable. * gnu/packages/patches/xfce4-session-xinitrc.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. --- gnu/local.mk | 3 ++- .../patches/xfce4-session-xinitrc.patch | 19 +++++++++++++++++++ gnu/packages/xfce.scm | 1 + 3 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/xfce4-session-xinitrc.patch diff --git a/gnu/local.mk b/gnu/local.mk index cbfefccbb9..ca6d90cced 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -4,7 +4,7 @@ # Copyright © 2016 Mathieu Lirzin # Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020 Mark H Weaver # Copyright © 2016 Chris Marusich -# Copyright © 2016, 2017, 2018 Kei Kebreau +# Copyright © 2016, 2017, 2018, 2020 Kei Kebreau # Copyright © 2016, 2017 Rene Saavedra # Copyright © 2016 Adonay "adfeno" Felipe Nogueira # Copyright © 2016, 2017, 2018, 2019, 2020 Ricardo Wurmus @@ -1721,6 +1721,7 @@ dist_patch_DATA = \ %D%/packages/patches/xf86-video-tga-remove-mibstore.patch \ %D%/packages/patches/xf86-video-voodoo-pcitag.patch \ %D%/packages/patches/xfce4-panel-plugins.patch \ + %D%/packages/patches/xfce4-session-xinitrc.patch \ %D%/packages/patches/xfce4-settings-defaults.patch \ %D%/packages/patches/xmonad-dynamic-linking.patch \ %D%/packages/patches/xplanet-1.3.1-cxx11-eof.patch \ diff --git a/gnu/packages/patches/xfce4-session-xinitrc.patch b/gnu/packages/patches/xfce4-session-xinitrc.patch new file mode 100644 index 0000000000..914890ff3d --- /dev/null +++ b/gnu/packages/patches/xfce4-session-xinitrc.patch @@ -0,0 +1,19 @@ +Ensure that xfce4 panel plugins in the user's Guix profile can +be found in the directories specified in X_XFCE4_LIB_DIRS. + +Partially fixes Guix bug #44916: +https://debbugs.gnu.org/cgi/bugreport.cgi?bug=44916. + +Patch by Kei Kebreau + +--- xfce4-session-4.14.2/scripts/xinitrc.in.in.orig 2020-12-05 15:01:43.932285134 -0500 ++++ xfce4-session-4.14.2/scripts/xinitrc.in.in 2020-12-05 15:22:06.171691694 -0500 +@@ -83,6 +83,8 @@ + dbus-update-activation-environment --systemd XAUTHLOCALHOSTNAME=$XAUTHLOCALHOSTNAME + fi + ++# load local Guix xfce4-panel plugins ++test -r "$HOME/.guix-profile/lib/xfce4" && export X_XFCE4_LIB_DIRS="$X_XFCE4_LIB_DIRS:$HOME/.guix-profile/lib/xfce4" + + # check if we start xfce4-session with ck-launch-session. this is only + # required for starting from a console, not a login manager diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm index 4090372805..685ddd3e18 100644 --- a/gnu/packages/xfce.scm +++ b/gnu/packages/xfce.scm @@ -684,6 +684,7 @@ your system in categories, so you can quickly find and launch them.") (sha256 (base32 "1bwpylcn7x9i301yz45wvkzah9bncv9b44nf4hh9ln4i1jka9qzv")) + (patches (search-patches "xfce4-session-xinitrc.patch")) (modules '((guix build utils))) (snippet '(begin -- 2.29.2 From unknown Wed Aug 20 05:15:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#45062] [PATCH 2/2] gnu: xfce4-whiskermenu-plugin: Fix installed shell script. References: <20201206050224.5355-1-kkebreau@posteo.net> In-Reply-To: <20201206050224.5355-1-kkebreau@posteo.net> Resent-From: Kei Kebreau Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Dec 2020 05:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45062 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 45062@debbugs.gnu.org Cc: Kei Kebreau , Michael Rohleder Received: via spool by 45062-submit@debbugs.gnu.org id=B45062.16072310834584 (code B ref 45062); Sun, 06 Dec 2020 05:05:01 +0000 Received: (at 45062) by debbugs.gnu.org; 6 Dec 2020 05:04:43 +0000 Received: from localhost ([127.0.0.1]:48667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klmDz-0001Bs-CV for submit@debbugs.gnu.org; Sun, 06 Dec 2020 00:04:43 -0500 Received: from mout02.posteo.de ([185.67.36.66]:36491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klmDy-0001Bf-5e for 45062@debbugs.gnu.org; Sun, 06 Dec 2020 00:04:42 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 70C232400FB for <45062@debbugs.gnu.org>; Sun, 6 Dec 2020 06:04:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1607231076; bh=fBOb8HzJc6N0tc48tyJrzIvzEjhe+FWO12/taGkGYPs=; h=From:To:Cc:Subject:Date:From; b=FQMFXVq4AfYcS1w8MVEbafLxuQTBE8wWpq74dfJ1pQ3R7iCtvaqjs6V9kST9zPM8+ fQwznOT5Pirbo9rG1cEHpc4ki+K824qpDjZKj+QTrBwknQOY+qolLrbWudzoarySON lAetZzn72xOIY3CQYviP/f+6paXIQZy3I+6219YoAyy646m30uMoANa2x4/WQqDSgj p8Vech56hX+5GNj++TtHfFZ5ZZcpqggpCXP6RS11vx/gfCf/0feClx7yylnKCJ3j3y y2xVbKmqGb6+uHood5+4EjlShigSlCt4XoBAoOaJxO/94pg8pR7Nl5beA/HKQMDSG6 vRS2aEtEiDwAQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CpZ9v1T9bz6tmH; Sun, 6 Dec 2020 06:04:34 +0100 (CET) From: Kei Kebreau Date: Sun, 6 Dec 2020 00:04:33 -0500 Message-Id: <20201206050433.5774-1-kkebreau@posteo.net> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) From: Michael Rohleder * gnu/packages/xfce.scm (xfce4-whiskermenu-plugin): Fix installed shell script. [arguments]: Add phase fix-shell-script to substitute paths to xfce4-panel and gettext. [inputs]: Add gettext-minimal. Co-authored-by: Kei Kebreau Signed-off-by: Kei Kebreau --- gnu/packages/xfce.scm | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm index 685ddd3e18..6f3fc34763 100644 --- a/gnu/packages/xfce.scm +++ b/gnu/packages/xfce.scm @@ -38,6 +38,7 @@ #:use-module (gnu packages cdrom) #:use-module (gnu packages fontutils) #:use-module (gnu packages freedesktop) + #:use-module (gnu packages gettext) #:use-module (gnu packages glib) #:use-module (gnu packages gnome) #:use-module (gnu packages gstreamer) @@ -592,11 +593,21 @@ keys for controlling the audio volume.") (inputs `(("xfce4-panel" ,xfce4-panel) ("garcon" ,garcon) + ("gettext" ,gettext-minimal) ("exo" ,exo) ("gtk+" ,gtk+) ("libxfce4ui" ,libxfce4ui))) (arguments - `(#:tests? #f)) ; no tests + `(#:tests? #f ; no tests + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'fix-shell-script + (lambda* (#:key inputs #:allow-other-keys) + (substitute* (string-append "panel-plugin/xfce4-popup-whiskermenu.in") + (("@CMAKE_INSTALL_FULL_BINDIR@") + (string-append (assoc-ref inputs "xfce4-panel") "/bin")) + (("gettext") (which "gettext"))) + #t))))) (home-page "https://goodies.xfce.org/projects/panel-plugins/xfce4-whiskermenu-plugin") (synopsis "Application menu panel plugin for Xfce") (description -- 2.29.2 From unknown Wed Aug 20 05:15:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#45062] [PATCH 1/2] gnu: xfce4-session: Fix xfce4-panel plugin detection. Resent-From: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Dec 2020 16:41:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45062 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Kei Kebreau Cc: 45062@debbugs.gnu.org Received: via spool by 45062-submit@debbugs.gnu.org id=B45062.160727283625495 (code B ref 45062); Sun, 06 Dec 2020 16:41:05 +0000 Received: (at 45062) by debbugs.gnu.org; 6 Dec 2020 16:40:36 +0000 Received: from localhost ([127.0.0.1]:51024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klx5P-0006d2-N8 for submit@debbugs.gnu.org; Sun, 06 Dec 2020 11:40:36 -0500 Received: from mail-oln040092255025.outbound.protection.outlook.com ([40.92.255.25]:20992 helo=APC01-HK2-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klns6-0003ye-8u for 45062@debbugs.gnu.org; Sun, 06 Dec 2020 01:50:15 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O9hXhVM8gaE24ei7SPIGq2sUSk0HmCLHr2XIIMlgqvVu/+x1MR45gM2VaIniSEkcO5i1umNv7YOzdNCpBEcA3D59nlDho7DjHldOW4BqMzZSZyLW0BJRZHf0Bz6CIvFcYNbVo7mju+U10I2jehDtCnk1XCVD27A8BUBWRVXIndPcT3VVmFjY5cc2l4mk39SjF0fViWyUi7v67WeOl0eUE/Lx6cZyShwns6fEfkYz5t6kbw5GkyqEPwbCcO/6lwY9vSfdHL60DrX1n7e/8Ov2cm+4pDzcKSuYn6yJTXyTtbvSKSPE4CO5aFduRVN9s0sqgvs2DG6iZa9qIjhwlaVpaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pXRHaJGe/+yCVyaFonNvQuViBfUJymvfP9+UkZ+94Qk=; b=P7kwCtfwTROISYwjPshk2hk0SrwqwY0uIMfNoZRPKd1Phu93Gro8NxsfqjM8ZDYVsf95d9jw6bGm2jCgxtRBc/WnbwemPwPymOLvSS+3OqkaTN0qXSmeBLCP4sNObXu11zMMOoepBi8GWUoMZq/VA9RcRVl5cq8hKL3an7LkOuAVrZhV7UNjSvnXXxW+J/0Krt+ovPH/rK71vaiWIo5ENURogtDf+hpx9LVH95v4VphG3xckK9j4KFy5qKvXxIGrsHHvR/oKFrVQnDYQwPaCP6+zXrDByeRliJK5iDj1/U8ojTP1ezBPgV11Aw+FBHRte1loPjk8H9/Jlht/cvL3lQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pXRHaJGe/+yCVyaFonNvQuViBfUJymvfP9+UkZ+94Qk=; b=kUmFCLsFSFmtw/0B416JN7tc1fbEYCKpX8ps/hBgpKzKl0kkYbOmJi6qFi5fEK8aWS2ZqYS5B60AQuuo1pkqMCOXrilmHXCmlkzjIe+2mTqfO1jlt2JUYPYIehFL0SNuxc7MqtP0Wmr74QKYlW14YyZdV0OwA/fkWNZN1bculho3J0alQ2UTvOKCafQcKQTf96pyp0VLyvoRPtocaonwB8dO6USVkHcwplmJC5PWFv6guNFw6hTMjokiM0HZMEIvsOEBKflIf+XEYuq21eFdfAmdkjoqrZ9ifvNcqWdmpsDakXY7kVtdtftYryr+Z8r5q56PPCwfjRPX6hkpstiK7Q== Received: from HK2APC01FT063.eop-APC01.prod.protection.outlook.com (2a01:111:e400:7ebc::45) by HK2APC01HT115.eop-APC01.prod.protection.outlook.com (2a01:111:e400:7ebc::272) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17; Sun, 6 Dec 2020 06:50:00 +0000 Received: from TYAP286MB0185.JPNP286.PROD.OUTLOOK.COM (10.152.248.55) by HK2APC01FT063.mail.protection.outlook.com (10.152.249.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17 via Frontend Transport; Sun, 6 Dec 2020 06:50:00 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:23A625E415B5CC4438F4F9C1938DF257665099D903B078FB9EAAB9E7CAED00B4; UpperCasedChecksum:7FD040F198FFC1B29DC6D2539EDEE5DDB06900AB8CE79A80EFE546159F46F6C5; SizeAsReceived:8741; Count:47 Received: from TYAP286MB0185.JPNP286.PROD.OUTLOOK.COM ([fe80::d802:80c9:f6bd:1fbb]) by TYAP286MB0185.JPNP286.PROD.OUTLOOK.COM ([fe80::d802:80c9:f6bd:1fbb%8]) with mapi id 15.20.3632.017; Sun, 6 Dec 2020 06:50:00 +0000 From: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= References: <20201206050224.5355-1-kkebreau@posteo.net> Date: Sun, 06 Dec 2020 14:50:32 +0800 In-Reply-To: <20201206050224.5355-1-kkebreau@posteo.net> (Kei Kebreau's message of "Sun, 6 Dec 2020 00:02:24 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TMN: [p/cqrfyOnySTTgsScTfOEZF62h0EUTdIKNGIg4eiFQxldCGcQNqTTXsFHvW6Hhyt] X-ClientProxiedBy: BYAPR11CA0089.namprd11.prod.outlook.com (2603:10b6:a03:f4::30) To TYAP286MB0185.JPNP286.PROD.OUTLOOK.COM (2603:1096:404:8038::14) X-Microsoft-Original-Message-ID: <87a6urjumf.fsf@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (2409:8a62:372:3600:2f1:f5ff:fe18:6bb) by BYAPR11CA0089.namprd11.prod.outlook.com (2603:10b6:a03:f4::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17 via Frontend Transport; Sun, 6 Dec 2020 06:49:58 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 47 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 2d0378c1-e675-403b-33d5-08d899b326bb X-MS-TrafficTypeDiagnostic: HK2APC01HT115: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DzW5htddEelm9xI3BtUaXoSRE/xaHtXTZ3uBR5BEpEBmTCTM+lWmUEwHwgaeus9cPDWotWNEs5vrtE1V3y4ButcYwsBod3PyxcKNYOXeGGLrpv59QEekcAi3pihb7EcEUCkRinrJ/XMsV+o8sMUACM0WPcvEtZQqtw6BAvMAIPAL2CIF/nfVCOscAjo/kyTRc/pIqf7Px0wggaCtgsUFMaPPPm8fk+4yv/hTyMeoK7HolP1O301SJx40blGHr+GV X-MS-Exchange-AntiSpam-MessageData: 9cXctW6xzCwnrvPop9aDA0LlIM2JapbkSVgScBbcq7cA2ZqT036MFRpAg5cGr+psR6RJ9P0WaUPhySh5bekGcH8IHngAS8iQAKiLZNbPs0SD13Lt1sMfmo8++hRCa+FMcXUSbNH8sz48VAUKweqJNcHtd9dpcnC7sbhjCL+98/DR36vyV5y/wVFGhKkOS2mCsbPF1IlVnb693OBtlAvV/g== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d0378c1-e675-403b-33d5-08d899b326bb X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2020 06:50:00.3034 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: HK2APC01FT063.eop-APC01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2APC01HT115 X-Spam-Score: -0.0 (/) X-Mailman-Approved-At: Sun, 06 Dec 2020 11:40:33 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Kei Kebreau writes: > * gnu/packages/xfce.scm (xfce4-session)[source]: Add patch to append the = path > to user-installed xfce4-panel plugins to the X_XFCE4_LIB_DIRS environment > variable. > [...] > +Ensure that xfce4 panel plugins in the user's Guix profile can > +be found in the directories specified in X_XFCE4_LIB_DIRS. > + > +Partially fixes Guix bug #44916: > +https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D44916. > Quote from #44916: >> Aside from that, it seems like Xfce, when installed as a system-wide >> desktop environment, does not look in the user's Guix profile for >> plugins. Panel modules are located by Xfce in the directories listed in >> the X_XFCE4_LIB_DIRS environment variable. For my Xfce configuration, >> X_XFCE4_LIB_DIRS contains only /run/current-system/profile/lib/xfce4. I think mix plugins from system and user profiles is a bad idea, the system profile tend to be updated less than the user profile, so there maybe some ABI problems between the xfce-panel in the system profile and its plugins in the user profile due to mismatched versions. =20 Does install both =E2=80=98xfce4-panel=E2=80=99 and =E2=80=98xfce4-whiskerm= enu-plugin=E2=80=99 into the user profile works (hopeful a system xfce4 session will first pickup a user installed xfce4-panel)? From unknown Wed Aug 20 05:15:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#45062] [PATCH 1/2] gnu: xfce4-session: Fix xfce4-panel plugin detection. Resent-From: Kei Kebreau Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Dec 2020 19:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45062 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Cc: 45062@debbugs.gnu.org Received: via spool by 45062-submit@debbugs.gnu.org id=B45062.160728456520478 (code B ref 45062); Sun, 06 Dec 2020 19:57:01 +0000 Received: (at 45062) by debbugs.gnu.org; 6 Dec 2020 19:56:05 +0000 Received: from localhost ([127.0.0.1]:51402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1km08b-0005KE-52 for submit@debbugs.gnu.org; Sun, 06 Dec 2020 14:56:05 -0500 Received: from mout01.posteo.de ([185.67.36.65]:42174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1km08Z-0005Jd-1I for 45062@debbugs.gnu.org; Sun, 06 Dec 2020 14:56:04 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 60FAF160062 for <45062@debbugs.gnu.org>; Sun, 6 Dec 2020 20:55:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1607284556; bh=T7FuhbPgzJcHjFTNjclUAhWawneyaR/8OTO+/9wGplY=; h=Date:From:To:Cc:Subject:From; b=eN5JspDJlhKzfYM1hMaPc4q6VKXjFtffcSVyu2oQ55Sf+DXD2xEPAGTvC5DVZzH1v tN0UJdqq+o7QWvKKb0MseISLeB5Kfj+wqAn7jRoqLeO4DKiUJnrdOrumAPSfBvGNH5 GCEfpsbdxhCLdpx7WYRGzjUOSzpuTwDsk+paAeMyhDVGIF4xW3ybqR9QhpqVZ4Fbv6 UyLoOSdpRQmENlwnsyEVoCTO+0mu7AfejiSRRF5UC5JMXhDjGcwE3bE+NpHidgia7k R+QNQgJbLbJTnNQ1eGPQlztjJTtp5/Udup7BMvOKwtxIHl7yTzS+8K/Hc3a1BTMR5k cucep1ZCHdugQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CpxyM2K63z6tmY; Sun, 6 Dec 2020 20:55:55 +0100 (CET) Date: Sun, 6 Dec 2020 14:55:52 -0500 From: Kei Kebreau Message-ID: <20201206145552.0cfe74d9@posteo.net> In-Reply-To: References: <20201206050224.5355-1-kkebreau@posteo.net> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Sun, 06 Dec 2020 14:50:32 +0800 =E5=AE=8B=E6=96=87=E6=AD=A6 wrote: > Kei Kebreau writes: >=20 > > * gnu/packages/xfce.scm (xfce4-session)[source]: Add patch to > > append the path to user-installed xfce4-panel plugins to the > > X_XFCE4_LIB_DIRS environment variable. > > [...] > > +Ensure that xfce4 panel plugins in the user's Guix profile can > > +be found in the directories specified in X_XFCE4_LIB_DIRS. > > + > > +Partially fixes Guix bug #44916: > > +https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D44916. > > =20 >=20 > Quote from #44916: > >> Aside from that, it seems like Xfce, when installed as a > >> system-wide desktop environment, does not look in the user's Guix > >> profile for plugins. Panel modules are located by Xfce in the > >> directories listed in the X_XFCE4_LIB_DIRS environment variable. > >> For my Xfce configuration, X_XFCE4_LIB_DIRS contains only > >> /run/current-system/profile/lib/xfce4. =20 >=20 > I think mix plugins from system and user profiles is a bad idea, the > system profile tend to be updated less than the user profile, so there > maybe some ABI problems between the xfce-panel in the system profile > and its plugins in the user profile due to mismatched versions. =20 >=20 > Does install both =E2=80=98xfce4-panel=E2=80=99 and =E2=80=98xfce4-whiske= rmenu-plugin=E2=80=99 into > the user profile works (hopeful a system xfce4 session will first > pickup a user installed xfce4-panel)? Installing both 'xfce4-panel' and 'xfce4-whiskermenu-plugin' into the user profile does work! Is there a way to make clear to users and administrators that xfce4-panel and its plugins should both be installed at the user or system level to ensure proper function? I don't think it's obvious since our Xfce desktop service implicitly installs the xfce4-panel. From unknown Wed Aug 20 05:15:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#45062] [PATCH 1/2] gnu: xfce4-session: Fix xfce4-panel plugin detection. Resent-From: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Dec 2020 11:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45062 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Kei Kebreau Cc: 45062@debbugs.gnu.org Received: via spool by 45062-submit@debbugs.gnu.org id=B45062.16073401044987 (code B ref 45062); Mon, 07 Dec 2020 11:22:01 +0000 Received: (at 45062) by debbugs.gnu.org; 7 Dec 2020 11:21:44 +0000 Received: from localhost ([127.0.0.1]:52633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmEaE-0001IA-0Q for submit@debbugs.gnu.org; Mon, 07 Dec 2020 06:21:44 -0500 Received: from mail-oln040092255094.outbound.protection.outlook.com ([40.92.255.94]:31711 helo=APC01-HK2-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmEaB-0001Hv-Gs for 45062@debbugs.gnu.org; Mon, 07 Dec 2020 06:21:32 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HMt9XOTyJr2CyGrcJUswBziObZI21H5J1BMCblD9DCyn4/qnbV19UEkqbI2QGfRtbnauTAtScmUDFgnyRKYIR8uC1yZ1hR5Fiz/m2bpx7po/jnDaogNBZdM5ZnOF4OEpFCjgLAtzJ2OzHbgyginz/zi6nbFZW9EJGNYfy1+dvrYR/yQPbgvhbXABoiUameHoCa8Aqi0f6erysIXfBcKgZVepVviz5fU4KeTbuoPFzjw0kMe9UkSJFtCA4STEsFfvdHWUA6VU0RbRvtC4DzywKKIaAvzUdSeF9JSuqLQ/NwXp6y8By8ISsovxpSzjE0wNSBZuaM14GX3OpNHMj4Xsfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DDrQ3to6NKnWYcSCp473N8gE5fSkgUOU+600zjbygjE=; b=di3zwxwZQM2SKaXdBSzdRkVDlrtdi9tYXm+4Ir+hQ6R/f4yHaWRPfCr08+DMct3zIqEVako8O5D2C972dj5OnQBpnyPPSaF1aHAZfjLOxch2xA/Jvb/5VINiSqyL7c215t028lL9/7JTxGZEH0XjbccfCS2mE0sC7zYAULULBknAsgym/f+x1/MK69UUv4ZXdsn5oXrFoZjVer2HEDdx/JASKafuBwH7YiOClB60vq6KFi8uQ3jJy09slmKJWGS9h24KzdfUbB3GgsSZPa2VGd67hiPHxZLtLBwhhl5GjrAETct1xS5cjrkJTuO/jE1VYgWV87/U0Z++OcbizCZUMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DDrQ3to6NKnWYcSCp473N8gE5fSkgUOU+600zjbygjE=; b=tLd2P/E7HHUJTAvjBqrNlDXWYCIap0PG8DkPIdeChBkDnHK5dn+WV4M06GsttzfrUOJnEkJEUS0sOtK5mAFKIerbsrRPg8vmTTRT3+JTnoMWCoNOUaCtdjmh8flmxwbSnvtoImvPgNDaWqWZrVihSeoiu/FWnBFYREkFRN8zay9Be5NgK8+hiNL/IwbVCY848il09/Q89FGUwJdf2QojBpAJRSXGTRRc0HrZk15wemJJyVFW2sPPoH4sx/TNTbb7CU3mjX4EDkuYq0hYXmJLtSP6JYUz63pTc09EQFk4jXMaJagYG/YncNBFBumjvRCpR49WhawYS6k0JP2yd0rJCg== Received: from HK2APC01FT064.eop-APC01.prod.protection.outlook.com (2a01:111:e400:7ebc::42) by HK2APC01HT121.eop-APC01.prod.protection.outlook.com (2a01:111:e400:7ebc::409) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17; Mon, 7 Dec 2020 11:21:19 +0000 Received: from TYAP286MB0185.JPNP286.PROD.OUTLOOK.COM (2a01:111:e400:7ebc::53) by HK2APC01FT064.mail.protection.outlook.com (2a01:111:e400:7ebc::364) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17 via Frontend Transport; Mon, 7 Dec 2020 11:21:19 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:7ADD4D7B910CBE1396D27EE326E3F0D6594552698E577FD99648D537CA58296F; UpperCasedChecksum:4D9EF2DB74C39A17F1B694C23E178B080FE470FCA13CF531BEC27E6AEE0BE024; SizeAsReceived:7649; Count:46 Received: from TYAP286MB0185.JPNP286.PROD.OUTLOOK.COM ([fe80::d802:80c9:f6bd:1fbb]) by TYAP286MB0185.JPNP286.PROD.OUTLOOK.COM ([fe80::d802:80c9:f6bd:1fbb%8]) with mapi id 15.20.3632.017; Mon, 7 Dec 2020 11:21:19 +0000 From: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= References: <20201206050224.5355-1-kkebreau@posteo.net> <20201206145552.0cfe74d9@posteo.net> Date: Mon, 07 Dec 2020 19:21:51 +0800 In-Reply-To: <20201206145552.0cfe74d9@posteo.net> (Kei Kebreau's message of "Sun, 6 Dec 2020 14:55:52 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [2ysjdbDxLJczBxa7rnqyL88ypk+GgpbXGhmWyQmUt/9/SNkdwGkP3TOZqfSRz3bt] X-ClientProxiedBy: BYAPR01CA0008.prod.exchangelabs.com (2603:10b6:a02:80::21) To TYAP286MB0185.JPNP286.PROD.OUTLOOK.COM (2603:1096:404:8038::14) X-Microsoft-Original-Message-ID: <87im9dyi7k.fsf@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (2409:8a62:372:3600:2f1:f5ff:fe18:6bb) by BYAPR01CA0008.prod.exchangelabs.com (2603:10b6:a02:80::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17 via Frontend Transport; Mon, 7 Dec 2020 11:21:17 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 46 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: f6ca8038-5512-44f6-967f-08d89aa23812 X-MS-TrafficTypeDiagnostic: HK2APC01HT121: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /U9NYUSk7UROGadiVS/WzJc6fxfGvNTzoeN3dPUyJ6ykGXMTr+F2EQ8rbrR4MK2qabqO+eFDwLWCUebL5ZExPEWORJE1PS3jUaGDG238hiaki8W7q0rlLuWC5HqrRhVOVikW5TWAL4qeJ02wDauIvfT2fYg3tiHypVGzVdyEV7dV+74AXFo87Wg5quTqCaWL8PQ3jHXDGCjX5Lv7QeWXqQ== X-MS-Exchange-AntiSpam-MessageData: VoCjpmVqFT+FZove5Ag5C9gEVFSm5C34FHIg6chVeAcT6bBypW+NqwyGFUpOG5LXUyPcFylO0LgSmJLxyxjGBUcsAGf9fkocadJIXsh7Fa1drfhGd9ObVB2fwywcX1XK/jpOMX+Kb2mqTTHkjqHrx3tTQGAYXp8D1zxeEdVr83QgsqD4gRa2R3Z5JuTFZIziffnsc326I2NetE4Mpqjyyw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6ca8038-5512-44f6-967f-08d89aa23812 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2020 11:21:19.1516 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: HK2APC01FT064.eop-APC01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2APC01HT121 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Kei Kebreau writes: > Installing both 'xfce4-panel' and 'xfce4-whiskermenu-plugin' into the > user profile does work! Okay, but I guess that will be some problem too, since then X_XFCE4_LIB_DIRS would contain both system and user paths... > Is there a way to make clear to users and > administrators that xfce4-panel and its plugins should both be > installed at the user or system level to ensure proper function? I > don't think it's obvious since our Xfce desktop service implicitly > installs the xfce4-panel. Yes, how about document it like this: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-doc-Document-about-xfce4-panel-plugins.patch >From 75fdb19ea4f68d7e8af899ef4611d269d4821f29 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Date: Mon, 7 Dec 2020 19:11:03 +0800 Subject: [PATCH] doc: Document about xfce4-panel plugins. * doc/guix.texi (Desktop Services): Document that xfce4-panel plugin packages should be added to the 'packages' field of OS. --- doc/guix.texi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/doc/guix.texi b/doc/guix.texi index a21c4d614e..5eb5b47e14 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -18563,6 +18563,12 @@ This service adds the @code{xfce} package to the system profile, and extends polkit with the ability for @code{thunar} to manipulate the file system as root from within a user session, after the user has authenticated with the administrator's password. + +Note that @code{xfce4-panel} and its plugin packages should in the same +profile to ensure compatibility, when use this @code{xfce} service, you +should add extra plugins (xfce4-whiskermenu-plugin, +xfce4-weather-plugin, etc.) to the @code{packages} field of your +@code{operating-system}. @end defvr @deftp {Data Type} xfce-desktop-configuration -- 2.29.2 --=-=-= Content-Type: text/plain BTW, your second patch for xfce4-whiskermenu-plugin LGTM, please push. Thank you! --=-=-=-- From unknown Wed Aug 20 05:15:53 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Kei Kebreau Subject: bug#45062: closed (Re: [bug#45062] [PATCH 1/2] gnu: xfce4-session: Fix xfce4-panel plugin detection.) Message-ID: References: <20201207161756.27f3609c@posteo.net> <20201206050224.5355-1-kkebreau@posteo.net> X-Gnu-PR-Message: they-closed 45062 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 45062@debbugs.gnu.org Date: Mon, 07 Dec 2020 21:19:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1607375941-8956-1" This is a multi-part message in MIME format... ------------=_1607375941-8956-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #45062: [PATCH 1/2] gnu: xfce4-session: Fix xfce4-panel plugin detection. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 45062@debbugs.gnu.org. --=20 45062: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D45062 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1607375941-8956-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 45062-done) by debbugs.gnu.org; 7 Dec 2020 21:18:10 +0000 Received: from localhost ([127.0.0.1]:55674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmNtZ-0002JQ-Uv for submit@debbugs.gnu.org; Mon, 07 Dec 2020 16:18:10 -0500 Received: from mout01.posteo.de ([185.67.36.65]:46008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmNtX-0002J1-9t for 45062-done@debbugs.gnu.org; Mon, 07 Dec 2020 16:18:08 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id BDD0A16005F for <45062-done@debbugs.gnu.org>; Mon, 7 Dec 2020 22:18:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1607375880; bh=UrxgSNTG18kSv1TU4mpTdb+uqZxjQoAc3sevshKNi/I=; h=Date:From:To:Cc:Subject:From; b=JjTAGFnXsFG8JVKvHTfxafX6n2wxQpwWpM5RX3VF8FFIvdTpazhMpTyeOaDKQMBVR CyF3Sl6R7gU6FzFfW1CtJdaThHEgndqsAldwxcwTBAgnPv1ODjjUHtLRwUaW+CP4iu BZQY6eDFIu77Uvk9GtZwc4Y7Ao4ArChanhCWhlQ+PS+PESXWoclrL7yIZ+xuDWleaX S/4N2/TLGa0lobbcShq/BAcepTDqKrekm2HlckC66+Jhip1y4sSagEpLj3NbfvNBmY Xbxx2oO58795jLTY0VXw0srNqyPFVbYdxWltacrmX/hXwrM5vcTdrguUxdAsSVywz0 fWhfEK/vnyT0w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Cqbkb5Kb3z6tmK; Mon, 7 Dec 2020 22:17:59 +0100 (CET) Date: Mon, 7 Dec 2020 16:17:56 -0500 From: Kei Kebreau To: =?UTF-8?B?5a6L5paH5q2m?= Subject: Re: [bug#45062] [PATCH 1/2] gnu: xfce4-session: Fix xfce4-panel plugin detection. Message-ID: <20201207161756.27f3609c@posteo.net> In-Reply-To: References: <20201206050224.5355-1-kkebreau@posteo.net> <20201206145552.0cfe74d9@posteo.net> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45062-done Cc: 45062-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I've edited your documentation patch a little bit and pushed it to master along with my second patch. Thanks for your input and patch! Kei On Mon, 07 Dec 2020 19:21:51 +0800 =E5=AE=8B=E6=96=87=E6=AD=A6 wrote: > Kei Kebreau writes: >=20 > > Installing both 'xfce4-panel' and 'xfce4-whiskermenu-plugin' into > > the user profile does work! =20 > Okay, but I guess that will be some problem too, since then > X_XFCE4_LIB_DIRS would contain both system and user paths... >=20 > > Is there a way to make clear to users and > > administrators that xfce4-panel and its plugins should both be > > installed at the user or system level to ensure proper function? I > > don't think it's obvious since our Xfce desktop service implicitly > > installs the xfce4-panel. =20 >=20 > Yes, how about document it like this: >=20 ------------=_1607375941-8956-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 Dec 2020 05:02:51 +0000 Received: from localhost ([127.0.0.1]:48662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klmC3-00018O-O4 for submit@debbugs.gnu.org; Sun, 06 Dec 2020 00:02:51 -0500 Received: from lists.gnu.org ([209.51.188.17]:39232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klmBz-00018E-AX for submit@debbugs.gnu.org; Sun, 06 Dec 2020 00:02:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klmBy-00046E-Ob for guix-patches@gnu.org; Sun, 06 Dec 2020 00:02:38 -0500 Received: from mout02.posteo.de ([185.67.36.66]:50779) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klmBt-0008BS-BS for guix-patches@gnu.org; Sun, 06 Dec 2020 00:02:38 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 05B5C2400FB for ; Sun, 6 Dec 2020 06:02:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1607230948; bh=dqExPJMQuPqNyIw+n0CNlsQb40KKkDywF5lZDVsZ0jA=; h=From:To:Cc:Subject:Date:From; b=eB4QrAlqN1pJoZ8Obshe/mdhUkBNxK/G7EETBJCpXbIntLRi7jVGPqhd6NCXGpgm5 1M/e/rIRvA5qlioFmEdzV5HJLrbDHW6QfX/R0I8oXEsqxKQLAq9VJUXzKzoXg3+epz fgglk/lmYKmqHfo7LRDMjbCBNaQU8aRd4rO80EDgeHOZzludYfxjNs94sOH9ttMiYP A/HE4unX8eSIgfLnxHDNgTnkTJN8cTxBm+HfJKOt93qxfKyXIxBn6kaGhdPpnE7zXr OxlvFOEHqH1hzYUy760hkmGVo00ZfiL0M4399dfI9V0h8pRU07Gi3LuQ6vv5lAmYnl 5x9zzXrWs8hXw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CpZ7Q6x0tz9rxG; Sun, 6 Dec 2020 06:02:26 +0100 (CET) From: Kei Kebreau To: guix-patches@gnu.org Subject: [PATCH 1/2] gnu: xfce4-session: Fix xfce4-panel plugin detection. Date: Sun, 6 Dec 2020 00:02:24 -0500 Message-Id: <20201206050224.5355-1-kkebreau@posteo.net> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.66; envelope-from=kkebreau@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Kei Kebreau X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/xfce.scm (xfce4-session)[source]: Add patch to append the path to user-installed xfce4-panel plugins to the X_XFCE4_LIB_DIRS environment variable. * gnu/packages/patches/xfce4-session-xinitrc.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. --- gnu/local.mk | 3 ++- .../patches/xfce4-session-xinitrc.patch | 19 +++++++++++++++++++ gnu/packages/xfce.scm | 1 + 3 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/xfce4-session-xinitrc.patch diff --git a/gnu/local.mk b/gnu/local.mk index cbfefccbb9..ca6d90cced 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -4,7 +4,7 @@ # Copyright © 2016 Mathieu Lirzin # Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020 Mark H Weaver # Copyright © 2016 Chris Marusich -# Copyright © 2016, 2017, 2018 Kei Kebreau +# Copyright © 2016, 2017, 2018, 2020 Kei Kebreau # Copyright © 2016, 2017 Rene Saavedra # Copyright © 2016 Adonay "adfeno" Felipe Nogueira # Copyright © 2016, 2017, 2018, 2019, 2020 Ricardo Wurmus @@ -1721,6 +1721,7 @@ dist_patch_DATA = \ %D%/packages/patches/xf86-video-tga-remove-mibstore.patch \ %D%/packages/patches/xf86-video-voodoo-pcitag.patch \ %D%/packages/patches/xfce4-panel-plugins.patch \ + %D%/packages/patches/xfce4-session-xinitrc.patch \ %D%/packages/patches/xfce4-settings-defaults.patch \ %D%/packages/patches/xmonad-dynamic-linking.patch \ %D%/packages/patches/xplanet-1.3.1-cxx11-eof.patch \ diff --git a/gnu/packages/patches/xfce4-session-xinitrc.patch b/gnu/packages/patches/xfce4-session-xinitrc.patch new file mode 100644 index 0000000000..914890ff3d --- /dev/null +++ b/gnu/packages/patches/xfce4-session-xinitrc.patch @@ -0,0 +1,19 @@ +Ensure that xfce4 panel plugins in the user's Guix profile can +be found in the directories specified in X_XFCE4_LIB_DIRS. + +Partially fixes Guix bug #44916: +https://debbugs.gnu.org/cgi/bugreport.cgi?bug=44916. + +Patch by Kei Kebreau + +--- xfce4-session-4.14.2/scripts/xinitrc.in.in.orig 2020-12-05 15:01:43.932285134 -0500 ++++ xfce4-session-4.14.2/scripts/xinitrc.in.in 2020-12-05 15:22:06.171691694 -0500 +@@ -83,6 +83,8 @@ + dbus-update-activation-environment --systemd XAUTHLOCALHOSTNAME=$XAUTHLOCALHOSTNAME + fi + ++# load local Guix xfce4-panel plugins ++test -r "$HOME/.guix-profile/lib/xfce4" && export X_XFCE4_LIB_DIRS="$X_XFCE4_LIB_DIRS:$HOME/.guix-profile/lib/xfce4" + + # check if we start xfce4-session with ck-launch-session. this is only + # required for starting from a console, not a login manager diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm index 4090372805..685ddd3e18 100644 --- a/gnu/packages/xfce.scm +++ b/gnu/packages/xfce.scm @@ -684,6 +684,7 @@ your system in categories, so you can quickly find and launch them.") (sha256 (base32 "1bwpylcn7x9i301yz45wvkzah9bncv9b44nf4hh9ln4i1jka9qzv")) + (patches (search-patches "xfce4-session-xinitrc.patch")) (modules '((guix build utils))) (snippet '(begin -- 2.29.2 ------------=_1607375941-8956-1--