Subject: Re: [bug#45050] [PATCH] gnu: Update emacs-guix to temporary repository.

From: Ludovic Courtès <[email-masked]>
Date: Fri, 11 Dec 2020 18:47:49 +0100

Hi!

John Soo <[email-masked]> skribis:

>>>From 28abdd7140c31425f6add54470ad683bc46e8de7 Mon Sep 17 00:00:00 2001
> From: John Soo <[email-masked]>
> Date: Thu, 12 Nov 2020 23:04:27 -0800
> Subject: [PATCH] gnu: Update emacs-guix.
>
> * gnu/packages/emacs-xyz.scm (emacs-guix): Update it, [inputs] Use guile for
> guix.

If it fixes one of the bugs in the tracker, we can mention it in the
commit log with “Fixes <https://bugs.gnu.org/XYZ>.”

>  (define-public emacs-guix
> -  (let ((commit "58a840d0671091e3064e36244790ef8839da87d6")
> -        (revision "2"))
> +  (let* ((commit "a694fdbcedb6edd2239a31d326e475c763ee32f8")
> +         (revision "1"))

Please increment the revision number rather than decrement it.

>      (package
> -      (name "emacs-guix")
> -      (version (git-version "0.5.2" revision commit))

Please don’t reindent, the original formatting was fine.  :-)

Could you send an updated patch?

I guess it’s fine to use your repo until we hear from Alex Kost.

Thanks for taking care of this!

Ludo’.