From unknown Sun Jun 22 00:50:31 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#45043] [PATCH] gnu: git-open: Remove unnecessary propagated input. Resent-From: EuAndreh Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 04 Dec 2020 20:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45043 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 45043@debbugs.gnu.org Cc: EuAndreh X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160711522717290 (code B ref -1); Fri, 04 Dec 2020 20:54:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Dec 2020 20:53:47 +0000 Received: from localhost ([127.0.0.1]:45967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klI5K-0004Uo-VM for submit@debbugs.gnu.org; Fri, 04 Dec 2020 15:53:47 -0500 Received: from lists.gnu.org ([209.51.188.17]:37256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klI5G-0004Ud-6y for submit@debbugs.gnu.org; Fri, 04 Dec 2020 15:53:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43162) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klI5F-00044a-Td for guix-patches@gnu.org; Fri, 04 Dec 2020 15:53:41 -0500 Received: from box.euandre.org ([46.101.160.115]:47925) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klI5D-0000VC-1R for guix-patches@gnu.org; Fri, 04 Dec 2020 15:53:41 -0500 Received: from authenticated-user (box.euandre.org [46.101.160.115]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.euandre.org (Postfix) with ESMTPSA id 840B2FC3D0; Fri, 4 Dec 2020 17:53:35 -0300 (-03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=euandre.org; s=mail; t=1607115216; bh=5vNTKXU8kTT0/XUgdTWGNWOeO9cDx3NvBW/7zrMrrDQ=; h=From:To:Cc:Subject:Date:From; b=VQ1ExT9hDl4+x4rzlP90GyQgCq47xzRAVjXl3T6hr/RxP90/cm3zU0jC2Kj5aqLYg XfhsW+92aBpL1EMeEUKVRJxinEwA9DGAFqko4tpK32KIpQqLNrOUsNqHms8OUE/mCb e0e0X9IAAaV7wtH9MptEjdhIk8e+tiTfBe9jpwSpu6faD4/7dT/lbvHX6crchZcS6P h/NJVVzi6nRcIL8IekElCammQzSDzjXlwbW5+braCyAwLSkwU1K0MnVIGz5AMUIrcL zFgzrSuV+ZuhOWr5PmhmDqHxBEprJYUpi0/20ogqCdE1R8av1TT2Gf4xDfxFHLt5D2 1UoEkBbNyDp5A== From: EuAndreh Date: Fri, 4 Dec 2020 17:53:32 -0300 Message-Id: <20201204205332.28505-1-eu@euandre.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=46.101.160.115; envelope-from=eu@euandre.org; helo=box.euandre.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/version-control.scm (git-open): Stop propagating xdg-utils package, and replace the runtime dependency by wrapping xdg-utils in the derivation. Also use copy-build-system instead of trivial-build-system. --- gnu/packages/version-control.scm | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index a8e6d2c4b9..eec57b3b6d 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -55,6 +55,7 @@ #:use-module (guix git-download) #:use-module (guix hg-download) #:use-module (guix build-system cmake) + #:use-module (guix build-system copy) #:use-module (guix build-system gnu) #:use-module (guix build-system go) #:use-module (guix build-system perl) @@ -2733,20 +2734,20 @@ file contents on a remote server.") (file-name (git-file-name name version)) (sha256 (base32 "11n46bngvca5wbdbfcxzjhjbfdbad7sgf7h9gf956cb1q8swsdm0")))) - (build-system trivial-build-system) - (propagated-inputs + (build-system copy-build-system) + (inputs `(("xdg-utils" ,xdg-utils))) (arguments - `(#:modules ((guix build utils)) - #:builder - (begin - (use-modules (guix build utils)) - (let ((source (assoc-ref %build-inputs "source")) - (out (assoc-ref %outputs "out"))) - (mkdir-p (string-append out "/bin")) - (copy-file (string-append source "/git-open") - (string-append out "/bin/git-open")) - #t)))) + `(#:phases + (modify-phases %standard-phases + (add-after 'install 'wrap-program + (lambda* (#:key outputs inputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out")) + (xdg-utils (assoc-ref inputs "xdg-utils"))) + (wrap-program (string-append out "/bin/git-open") + `("PATH" ":" prefix (,(string-append xdg-utils "/bin")))))))) + #:install-plan + '(("git-open" "bin/git-open")))) (home-page "https://github.com/paulirish/git-open") (synopsis "Open a Git repository's homepage from the command-line") (description -- 2.29.2 From unknown Sun Jun 22 00:50:31 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#45043] [PATCH] gnu: git-open: Remove unnecessary propagated input. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 05 Dec 2020 04:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45043 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 45043@debbugs.gnu.org Cc: EuAndreh , 45043-done@debbugs.gnu.org X-Debbugs-Original-To: EuAndreh via Guix-patches via Received: via spool by submit@debbugs.gnu.org id=B.160714338228160 (code B ref -1); Sat, 05 Dec 2020 04:44:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 Dec 2020 04:43:02 +0000 Received: from localhost ([127.0.0.1]:46369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klPPS-0007K3-4o for submit@debbugs.gnu.org; Fri, 04 Dec 2020 23:43:02 -0500 Received: from lists.gnu.org ([209.51.188.17]:51744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klPPP-0007JW-BB for submit@debbugs.gnu.org; Fri, 04 Dec 2020 23:43:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klPPP-00086z-3k for guix-patches@gnu.org; Fri, 04 Dec 2020 23:42:59 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:53707) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klPPM-0001JU-TA for guix-patches@gnu.org; Fri, 04 Dec 2020 23:42:58 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id E5DB45C00DF; Fri, 4 Dec 2020 23:42:50 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 04 Dec 2020 23:42:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=ATVPR07CoAzg5VI1gA1Q/xMy +qO6lthVIJbXC6XHUOo=; b=ArgcOY/N+I13pvi6cO4kgPbZ8eel0EsyIP0jm5uI tbSiN895fvX/YFeBuVfVNzS9lk+P7cfXowmAkIEUB/HCF/SbLqJecbW9gw1OCoP+ 6QZR8Ye1fvJtdGXPvIaC9CoHtoitYrX6X1GeNfH5ulhoKLqt0k84TfpvtDiE2p4o IMg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ATVPR0 7CoAzg5VI1gA1Q/xMy+qO6lthVIJbXC6XHUOo=; b=BJ/cxDAszFOwy4tZxp24h+ X9One92Je3KHhHAy1FeF2yrK1ob2exioaQoS4Fn0k4fzjm3jjBqvBy3yrjkhNXvn xfPwwj9PgjQk4cDf7nC7mtntQGOn2I1Tci3+zuCALQl8uRcmM+NRNjirpd0GypzM OQKzb0RrqMFHFU6Dd/fNmh7pS95xUiRCfppV4LfD6xWZeXvedt6T9n3F2QH/10Dq z0Pw3ml5UBK6LJISTsbEQ5jCRd456G0cA8RdCWL2xgXEIVpDPvfYSErVk/2zDAG0 ECPVIZdD5DXDxWmakxpOCG4QJryOJInjcr1lZ/ANe3BIcb/3fUOHiPuKPmiKsY9g == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeiledgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpedvvddugefffeeitddthfefvdeuhffgkeeikeegkeevteeghfeftefggeeuudff ieenucffohhmrghinhepghhnuhdrohhrghenucfkphepjeefrddugedurdduvdejrdduge einecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhgv ohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id 3BE31240057; Fri, 4 Dec 2020 23:42:50 -0500 (EST) Date: Fri, 4 Dec 2020 23:42:47 -0500 From: Leo Famulari Message-ID: References: <20201204205332.28505-1-eu@euandre.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201204205332.28505-1-eu@euandre.org> Received-SPF: pass client-ip=66.111.4.25; envelope-from=leo@famulari.name; helo=out1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) On Fri, Dec 04, 2020 at 05:53:32PM -0300, EuAndreh via Guix-patches via wrote: > * gnu/packages/version-control.scm (git-open): Stop propagating xdg-utils > package, and replace the runtime dependency by wrapping xdg-utils in the > derivation. Also use copy-build-system instead of trivial-build-system. Thanks! I rewrote the commit to be more idiomatic and pushed as 4cf3734c56d669ee2d78082e5d7c4d0a58e0f800. About the commit message, we write them in the GNU ChangeLog format: https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html Basically, we describe changes to the code, organized by file and variable. The linked chapter in the GNU coding manual is instructive when combined with `git log` of the Guix repo. From unknown Sun Jun 22 00:50:31 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: EuAndreh Subject: bug#45043: closed (Re: [bug#45043] [PATCH] gnu: git-open: Remove unnecessary propagated input.) Message-ID: References: <20201204205332.28505-1-eu@euandre.org> X-Gnu-PR-Message: they-closed 45043 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 45043@debbugs.gnu.org Date: Sat, 05 Dec 2020 04:44:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1607143442-28241-1" This is a multi-part message in MIME format... ------------=_1607143442-28241-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #45043: [PATCH] gnu: git-open: Remove unnecessary propagated input. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 45043@debbugs.gnu.org. --=20 45043: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D45043 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1607143442-28241-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 45043-done) by debbugs.gnu.org; 5 Dec 2020 04:43:02 +0000 Received: from localhost ([127.0.0.1]:46367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klPPR-0007Jq-NZ for submit@debbugs.gnu.org; Fri, 04 Dec 2020 23:43:02 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:39217) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klPPM-0007JK-6y for 45043-done@debbugs.gnu.org; Fri, 04 Dec 2020 23:42:59 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id E5DB45C00DF; Fri, 4 Dec 2020 23:42:50 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 04 Dec 2020 23:42:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=ATVPR07CoAzg5VI1gA1Q/xMy +qO6lthVIJbXC6XHUOo=; b=ArgcOY/N+I13pvi6cO4kgPbZ8eel0EsyIP0jm5uI tbSiN895fvX/YFeBuVfVNzS9lk+P7cfXowmAkIEUB/HCF/SbLqJecbW9gw1OCoP+ 6QZR8Ye1fvJtdGXPvIaC9CoHtoitYrX6X1GeNfH5ulhoKLqt0k84TfpvtDiE2p4o IMg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ATVPR0 7CoAzg5VI1gA1Q/xMy+qO6lthVIJbXC6XHUOo=; b=BJ/cxDAszFOwy4tZxp24h+ X9One92Je3KHhHAy1FeF2yrK1ob2exioaQoS4Fn0k4fzjm3jjBqvBy3yrjkhNXvn xfPwwj9PgjQk4cDf7nC7mtntQGOn2I1Tci3+zuCALQl8uRcmM+NRNjirpd0GypzM OQKzb0RrqMFHFU6Dd/fNmh7pS95xUiRCfppV4LfD6xWZeXvedt6T9n3F2QH/10Dq z0Pw3ml5UBK6LJISTsbEQ5jCRd456G0cA8RdCWL2xgXEIVpDPvfYSErVk/2zDAG0 ECPVIZdD5DXDxWmakxpOCG4QJryOJInjcr1lZ/ANe3BIcb/3fUOHiPuKPmiKsY9g == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeiledgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpedvvddugefffeeitddthfefvdeuhffgkeeikeegkeevteeghfeftefggeeuudff ieenucffohhmrghinhepghhnuhdrohhrghenucfkphepjeefrddugedurdduvdejrdduge einecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhgv ohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id 3BE31240057; Fri, 4 Dec 2020 23:42:50 -0500 (EST) Date: Fri, 4 Dec 2020 23:42:47 -0500 From: Leo Famulari To: EuAndreh via Guix-patches via Subject: Re: [bug#45043] [PATCH] gnu: git-open: Remove unnecessary propagated input. Message-ID: References: <20201204205332.28505-1-eu@euandre.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201204205332.28505-1-eu@euandre.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45043-done Cc: EuAndreh , 45043-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, Dec 04, 2020 at 05:53:32PM -0300, EuAndreh via Guix-patches via wrote: > * gnu/packages/version-control.scm (git-open): Stop propagating xdg-utils > package, and replace the runtime dependency by wrapping xdg-utils in the > derivation. Also use copy-build-system instead of trivial-build-system. Thanks! I rewrote the commit to be more idiomatic and pushed as 4cf3734c56d669ee2d78082e5d7c4d0a58e0f800. About the commit message, we write them in the GNU ChangeLog format: https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html Basically, we describe changes to the code, organized by file and variable. The linked chapter in the GNU coding manual is instructive when combined with `git log` of the Guix repo. ------------=_1607143442-28241-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 4 Dec 2020 20:53:47 +0000 Received: from localhost ([127.0.0.1]:45967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klI5K-0004Uo-VM for submit@debbugs.gnu.org; Fri, 04 Dec 2020 15:53:47 -0500 Received: from lists.gnu.org ([209.51.188.17]:37256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klI5G-0004Ud-6y for submit@debbugs.gnu.org; Fri, 04 Dec 2020 15:53:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43162) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klI5F-00044a-Td for guix-patches@gnu.org; Fri, 04 Dec 2020 15:53:41 -0500 Received: from box.euandre.org ([46.101.160.115]:47925) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klI5D-0000VC-1R for guix-patches@gnu.org; Fri, 04 Dec 2020 15:53:41 -0500 Received: from authenticated-user (box.euandre.org [46.101.160.115]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.euandre.org (Postfix) with ESMTPSA id 840B2FC3D0; Fri, 4 Dec 2020 17:53:35 -0300 (-03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=euandre.org; s=mail; t=1607115216; bh=5vNTKXU8kTT0/XUgdTWGNWOeO9cDx3NvBW/7zrMrrDQ=; h=From:To:Cc:Subject:Date:From; b=VQ1ExT9hDl4+x4rzlP90GyQgCq47xzRAVjXl3T6hr/RxP90/cm3zU0jC2Kj5aqLYg XfhsW+92aBpL1EMeEUKVRJxinEwA9DGAFqko4tpK32KIpQqLNrOUsNqHms8OUE/mCb e0e0X9IAAaV7wtH9MptEjdhIk8e+tiTfBe9jpwSpu6faD4/7dT/lbvHX6crchZcS6P h/NJVVzi6nRcIL8IekElCammQzSDzjXlwbW5+braCyAwLSkwU1K0MnVIGz5AMUIrcL zFgzrSuV+ZuhOWr5PmhmDqHxBEprJYUpi0/20ogqCdE1R8av1TT2Gf4xDfxFHLt5D2 1UoEkBbNyDp5A== From: EuAndreh To: guix-patches@gnu.org Subject: [PATCH] gnu: git-open: Remove unnecessary propagated input. Date: Fri, 4 Dec 2020 17:53:32 -0300 Message-Id: <20201204205332.28505-1-eu@euandre.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=46.101.160.115; envelope-from=eu@euandre.org; helo=box.euandre.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: EuAndreh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/version-control.scm (git-open): Stop propagating xdg-utils package, and replace the runtime dependency by wrapping xdg-utils in the derivation. Also use copy-build-system instead of trivial-build-system. --- gnu/packages/version-control.scm | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index a8e6d2c4b9..eec57b3b6d 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -55,6 +55,7 @@ #:use-module (guix git-download) #:use-module (guix hg-download) #:use-module (guix build-system cmake) + #:use-module (guix build-system copy) #:use-module (guix build-system gnu) #:use-module (guix build-system go) #:use-module (guix build-system perl) @@ -2733,20 +2734,20 @@ file contents on a remote server.") (file-name (git-file-name name version)) (sha256 (base32 "11n46bngvca5wbdbfcxzjhjbfdbad7sgf7h9gf956cb1q8swsdm0")))) - (build-system trivial-build-system) - (propagated-inputs + (build-system copy-build-system) + (inputs `(("xdg-utils" ,xdg-utils))) (arguments - `(#:modules ((guix build utils)) - #:builder - (begin - (use-modules (guix build utils)) - (let ((source (assoc-ref %build-inputs "source")) - (out (assoc-ref %outputs "out"))) - (mkdir-p (string-append out "/bin")) - (copy-file (string-append source "/git-open") - (string-append out "/bin/git-open")) - #t)))) + `(#:phases + (modify-phases %standard-phases + (add-after 'install 'wrap-program + (lambda* (#:key outputs inputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out")) + (xdg-utils (assoc-ref inputs "xdg-utils"))) + (wrap-program (string-append out "/bin/git-open") + `("PATH" ":" prefix (,(string-append xdg-utils "/bin")))))))) + #:install-plan + '(("git-open" "bin/git-open")))) (home-page "https://github.com/paulirish/git-open") (synopsis "Open a Git repository's homepage from the command-line") (description -- 2.29.2 ------------=_1607143442-28241-1-- From unknown Sun Jun 22 00:50:31 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#45043] [PATCH] gnu: git-open: Remove unnecessary propagated input. Resent-From: EuAndreh Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 05 Dec 2020 11:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45043 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: leo@famulari.name, 45043@debbugs.gnu.org Cc: , 45043-done@debbugs.gnu.org X-Debbugs-Original-To: Leo Famulari , EuAndreh via Guix-patches via Received: via spool by 45043-done@debbugs.gnu.org id=D45043.16071671918636 (code D ref 45043); Sat, 05 Dec 2020 11:20:02 +0000 Received: (at 45043-done) by debbugs.gnu.org; 5 Dec 2020 11:19:51 +0000 Received: from localhost ([127.0.0.1]:46626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klVbT-0002FE-1D for submit@debbugs.gnu.org; Sat, 05 Dec 2020 06:19:51 -0500 Received: from box.euandre.org ([46.101.160.115]:36077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klVbQ-0002Ez-Dx for 45043-done@debbugs.gnu.org; Sat, 05 Dec 2020 06:19:50 -0500 Received: from authenticated-user (box.euandre.org [46.101.160.115]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.euandre.org (Postfix) with ESMTPSA id 844DBFC3CD; Sat, 5 Dec 2020 08:19:40 -0300 (-03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=euandre.org; s=mail; t=1607167182; bh=AoIjMl7wGlYCdo3YH89bEjJPe4LP30fPIpzsTD/ytIk=; h=From:To:Cc:Cc:Subject:In-Reply-To:References:Date:From; b=H7W8YaGLAb7sNoGO+yv8XyX+7C9A78P1dpLsv1N+zhDkzQ7ZXb/Dxa1NY29xHHYRY nIpiGWOww8JYeq7EB9VkQnltuLkWE9Eps5/B1quH6rm9PdhIHMTnCHtyyznajWWpFf iIlwUoFdPnJd4X3QdBBDarMkaHFb//cfw3QmoU+R8NsWLc5wJhK6R1Poto8CyOud6F Z+TnOAJvZi7LoyW7ch5DnD716FOJv94rkO/PayEATVWpGApZzMkIGzYwpp4UA4D+62 5joiQmPRObXyNuGHFpQTBHBH33uTpJO+yuQOvSh85ciRLk9LBOCi7hQo6vX7gLS/Qn JPgeojBAMCl2w== From: EuAndreh In-Reply-To: References: <20201204205332.28505-1-eu@euandre.org> Date: Sat, 05 Dec 2020 08:19:17 -0300 Message-ID: <87v9dgmrey.fsf@euandre.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Leo Famulari writes: > Thanks! I rewrote the commit to be more idiomatic and pushed as > 4cf3734c56d669ee2d78082e5d7c4d0a58e0f800. > > About the commit message, we write them in the GNU ChangeLog format: > > https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html > > Basically, we describe changes to the code, organized by file and > variable. The linked chapter in the GNU coding manual is instructive > when combined with `git log` of the Guix repo. Hmm, makes sense. Thanks for the tip. I see my commit message was only partially compliant.