From unknown Fri Aug 15 16:19:02 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#45034 <45034@debbugs.gnu.org> To: bug#45034 <45034@debbugs.gnu.org> Subject: Status: [PATCH] * lisp/simple.el (async-shell-command): use comint-term-environment Reply-To: bug#45034 <45034@debbugs.gnu.org> Date: Fri, 15 Aug 2025 23:19:02 +0000 retitle 45034 [PATCH] * lisp/simple.el (async-shell-command): use comint-te= rm-environment reassign 45034 emacs submitter 45034 Alyssa Ross severity 45034 normal tag 45034 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 03 19:58:19 2020 Received: (at submit) by debbugs.gnu.org; 4 Dec 2020 00:58:19 +0000 Received: from localhost ([127.0.0.1]:42242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkzQQ-0003sk-FY for submit@debbugs.gnu.org; Thu, 03 Dec 2020 19:58:18 -0500 Received: from lists.gnu.org ([209.51.188.17]:45460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkygZ-0002nV-Fz for submit@debbugs.gnu.org; Thu, 03 Dec 2020 19:10:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35110) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkygZ-0002T5-50 for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2020 19:10:55 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:35661) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkygW-0002Qc-SL for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2020 19:10:54 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 7AD6D5C01E7 for ; Thu, 3 Dec 2020 19:03:38 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 03 Dec 2020 19:03:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm1; bh=QS17CvH1RjgFcNPCttGTHbgBBi L1zKkb/dMjyXe2K10=; b=p3UDVH4A3CA9UUQoOK8R0f5iDS8MpKa9F/n4IvSL5W FkcUFqJdqBcjyA0Naegry9qUy7bqbD1YnS5qfuEGFB/7J8Eg4wFwUBen3fWz4OiJ sWaY9ucsojVAQ6PxxVX5Psacvtbwj7KkG0oxXhhH6OT77ijsUDjmXGX5RQkI/ExD 3XMbYT8KD5KufVlGLJ6txlWD2n6kQP9e+mPuY8QWS+E7RBv4Bw5mn5ot5uddZBA8 wxoGPnwpfqcW7u5UuM3BVsP+YOhRW5InAuj9uUtmOvI9V+CNWIdEQhMuiyBgnk7o B1w8EZV9O4OzmepS5s44QYJmUwgJ2ez8Woc5cRhD9GTA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=QS17CvH1RjgFcNPCt tGTHbgBBiL1zKkb/dMjyXe2K10=; b=MHPejBt+ekTzSWWNJ1Y3oVDmoGLTqBkTJ laV+3zAeY2O7tRkgZ0M3OrbkogMYkJvazORp66K1briIUjS3NRjJs9TUaN+fpeu4 /2uBPB3zWcoCreQ4PbuB3GSzz6ceEx7FMjU9R9vob0A17bYNRwvLbUCAQWyAYWBx ijKnYFHUv2FF2HzYsWn42paUj11JVk5yYqAVOQnHZHLI/KwmPMvFHvgcpI00c1RD 113QdEgLW9tbgwJVXgkRYtIcixqrW/VIXWjDQKhncUySwtAM3oP3irtyPxJ1zyls 7lleoxqmtBAhktEEOJhVbRVPI3YQMa2oGZcuwnuG+CstBI4PDJBvA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeijedgudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomheptehlhihsshgrucftohhsshcuoehhihesrghlhihsshgrrdhisheq necuggftrfgrthhtvghrnhephedvfffghfetieejgfetfedtgffhvdehueehvdejudfgge fgleejgfelfeevgfefnecukfhppeegiedrkedtrddufedvrdekfeenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehqhihlihhsshesvghvvgdrqh ihlhhishhsrdhnvght X-ME-Proxy: Received: from eve.qyliss.net (p2e508453.dip0.t-ipconnect.de [46.80.132.83]) by mail.messagingengine.com (Postfix) with ESMTPA id 7D6F81080059 for ; Thu, 3 Dec 2020 19:03:37 -0500 (EST) Received: by eve.qyliss.net (Postfix, from userid 1000) id 735FC769; Fri, 4 Dec 2020 00:03:35 +0000 (UTC) From: Alyssa Ross To: bug-gnu-emacs@gnu.org Subject: [PATCH] * lisp/simple.el (async-shell-command): use comint-term-environment Date: Fri, 4 Dec 2020 00:03:04 +0000 Message-Id: <20201204000304.8213-1-hi@alyssa.is> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: softfail client-ip=66.111.4.26; envelope-from=qyliss@eve.qyliss.net; helo=out2-smtp.messagingengine.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 03 Dec 2020 19:58:16 -0500 Cc: Alyssa Ross X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Even though async-shell-command will open a shell-mode buffer, and shell-mode inherits from comint-mode, because it doesn't use comint-exec, comint-term-environment isn't respected. It would make sense for it to, because since async-shell-command uses comint, any fancy stuff comint-term-environment enables should work in async-shell-command too. With this change, a simple (setq comint-terminfo-terminal "dumb-emacs-ansi") is all that's required to get colored output from many programs on a GNU/Linux system with a recent version of ncurses when run through async-shell-command. --- lisp/simple.el | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lisp/simple.el b/lisp/simple.el index b5ba05426f..dcd619b0ab 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -3783,10 +3783,11 @@ shell-command (shell-command-save-pos-or-erase) (setq default-directory directory) (let ((process-environment - (if (natnump async-shell-command-width) - (cons (format "COLUMNS=%d" async-shell-command-width) - process-environment) - process-environment))) + (append + (comint-term-environment) + (when (natnump async-shell-command-width) + (format "COLUMNS=%d" async-shell-command-width)) + process-environment))) (setq proc (start-process-shell-command "Shell" buffer command))) (setq mode-line-process '(":%s")) -- 2.27.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 04 05:07:46 2020 Received: (at 45034) by debbugs.gnu.org; 4 Dec 2020 10:07:46 +0000 Received: from localhost ([127.0.0.1]:42832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl809-0004bN-Of for submit@debbugs.gnu.org; Fri, 04 Dec 2020 05:07:45 -0500 Received: from quimby.gnus.org ([95.216.78.240]:56712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl807-0004b8-3p for 45034@debbugs.gnu.org; Fri, 04 Dec 2020 05:07:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PZDsWamq+5XHbIOkTo/FH9/JD/9Mi1E6fdnNz1AzGwM=; b=FOj6EsBCORZhpO/UwmbnFraE4K 8gpGVdZUHADA9mRh6tOmIhg9Se+SjHOSIUYewq4Wzouv11tdfQI9GeGXq0zQyVnsLFUdwl8LZPhYZ fqmUVUqhcDM0d4LdPOUqcOZ/oiWt3kNapI2N22O1UCTRxqKVXH294AEVSj6BCFi49Bs4=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kl7zy-00075e-24; Fri, 04 Dec 2020 11:07:36 +0100 From: Lars Ingebrigtsen To: Alyssa Ross Subject: Re: bug#45034: [PATCH] * lisp/simple.el (async-shell-command): use comint-term-environment References: <20201204000304.8213-1-hi@alyssa.is> X-Now-Playing: Edh's =?utf-8?Q?=5FV=C3=A4nskap?= 002_: "Slaughter" Date: Fri, 04 Dec 2020 11:07:32 +0100 In-Reply-To: <20201204000304.8213-1-hi@alyssa.is> (Alyssa Ross's message of "Fri, 4 Dec 2020 00:03:04 +0000") Message-ID: <87h7p1nau3.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alyssa Ross writes: > With this change, a simple (setq comint-terminfo-terminal "dumb-emacs-ansi") > is all that's required to get colored output from many programs on a > GNU/Linux system with a recent version of ncurse [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45034 Cc: 45034@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alyssa Ross writes: > With this change, a simple (setq comint-terminfo-terminal "dumb-emacs-ansi") > is all that's required to get colored output from many programs on a > GNU/Linux system with a recent version of ncurses when run through > async-shell-command. Thanks; makes sense to me, so I've applied it to Emacs 28 (with some small changes). This change was small enough to apply without assigning copyright to the FSF, but for future patches you want to submit, it might make sense to get the paperwork started now, so that subsequent patches can be applied speedily. Would you be willing to sign such paperwork? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 04 05:08:04 2020 Received: (at control) by debbugs.gnu.org; 4 Dec 2020 10:08:04 +0000 Received: from localhost ([127.0.0.1]:42836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl80S-0004cI-25 for submit@debbugs.gnu.org; Fri, 04 Dec 2020 05:08:04 -0500 Received: from quimby.gnus.org ([95.216.78.240]:56726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl80R-0004bf-7i for control@debbugs.gnu.org; Fri, 04 Dec 2020 05:08:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9usLt5aai5CL8GeYX9m1FZqkGfA+/S4wzQfRjAcmfNA=; b=h+10iRlJg/ObL7pW9vgOUvqDpF XS7vdAN5HFif2LiwOFcnkOATr7/7axSnSXEUxovxPlQiX7WNkBZtn3QexGdXbH3a2YSy63wfAykrk 9il6f40Sda9LtI87GxYvuBOhq00J0UIPM8/hbDGmnrNfjOSz6i34bR8prjdZxzz6uGSg=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kl80J-00075r-FE for control@debbugs.gnu.org; Fri, 04 Dec 2020 11:07:57 +0100 Date: Fri, 04 Dec 2020 11:07:54 +0100 Message-Id: <87ft4lnath.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #45034 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 45034 fixed close 45034 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 45034 fixed close 45034 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 05 06:26:59 2020 Received: (at 45034) by debbugs.gnu.org; 5 Dec 2020 11:26:59 +0000 Received: from localhost ([127.0.0.1]:46645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klViN-0002VX-JA for submit@debbugs.gnu.org; Sat, 05 Dec 2020 06:26:59 -0500 Received: from mail-wr1-f46.google.com ([209.85.221.46]:46923) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klViJ-0002VF-VS for 45034@debbugs.gnu.org; Sat, 05 Dec 2020 06:26:58 -0500 Received: by mail-wr1-f46.google.com with SMTP id g14so7806481wrm.13 for <45034@debbugs.gnu.org>; Sat, 05 Dec 2020 03:26:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=b/4tlaXIwR8r0WAq3akToRYy7lbG5wlsFOP1q6ZqR08=; b=JlDoD5yc50e8TFmQoc1OPXmFrPv99DT7IrTxAU+Mb7cXBZcOvRdZdlvUYi+sKOjsGu OCD52nFuIbCuFn8It4tWMNJ9OgRyxTq/jknejjJ+UOkWGhnfRxFjgwf0dqfbaUL0alKD jFv17YdMwSqP3AVBV2MFcQN2wGMpnh+isEzGte1CnqY4/WEktJ83Nl0dXs4bq3WTqtWe 9cZEBH0eqOqvs8Gd3FNojcfi41rcR2MIEewH8fV0dz8rvJumsNglnTFW2Y+QExvLBwNb ek+ga+2RaTrIIjYFGQWIiiFJc6AjAXtMKEZhzzSqgpG64xwIWK+Fcvc4+eTo6dytMldN 93DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=b/4tlaXIwR8r0WAq3akToRYy7lbG5wlsFOP1q6ZqR08=; b=Bwrww7HQ0NppKMm8eXZn7uQG29YVmyvhBFLMt2K4wHLdop07jkK9FNfSQxQv80TDXJ NoLt9HEpQF4708qCRz5ADTYQsEGexmt0YkTJ43GTF02LlhyeKsJM81ALJM/rCSwquqPW ywI1HPY7BP9mAwfwUGFpBQK3KkBcSlKPVrYySyLgzPMTdYwaGKuyWj3R6CLhR4+d3k9U yjsl8Oj9iXuMdksEf1jBhdI7nhZ0m68JR8teYQdiTl4BorNxukOFyv19BeGFDJL8iDz8 EX67G4hszc4BVpHA8TCv70W5Vqnh5JgfgFaLjKPWrf/2ihsDI0uYc9F1AQ9CeeF8/Jrp GeOA== X-Gm-Message-State: AOAM533Rh7/LLBJuuh1AXOMxZL7BcKBMfRuaB96qG3MG6rd5usKDeK+h +7/WR3a/+AabwNCtfdtBu+Mw5A== X-Google-Smtp-Source: ABdhPJzz3qlZfHKkAefcTfK+d62ubh5LXlBuQkzC6qVdbHrmbNwfTD9ciWG5cadAxAkWxIzBv+3w2Q== X-Received: by 2002:adf:fc01:: with SMTP id i1mr10132426wrr.250.1607167610304; Sat, 05 Dec 2020 03:26:50 -0800 (PST) Received: from localhost ([51.37.47.98]) by smtp.gmail.com with ESMTPSA id f23sm6320522wmb.43.2020.12.05.03.26.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Dec 2020 03:26:49 -0800 (PST) From: "Basil L. Contovounesios" To: Lars Ingebrigtsen Subject: Re: bug#45034: [PATCH] * lisp/simple.el (async-shell-command): use comint-term-environment References: <20201204000304.8213-1-hi@alyssa.is> <87h7p1nau3.fsf@gnus.org> Date: Sat, 05 Dec 2020 11:26:47 +0000 In-Reply-To: <87h7p1nau3.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 04 Dec 2020 11:07:32 +0100") Message-ID: <87im9gv6h4.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45034 Cc: Alyssa Ross , 45034@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Alyssa Ross writes: > >> With this change, a simple (setq comint-terminfo-terminal "dumb-emacs-ansi") >> is all that's required to get colored output from many programs on a >> GNU/Linux system with a recent version of ncurses when run through >> async-shell-command. > > Thanks; makes sense to me, so I've applied it to Emacs 28 (with some > small changes). This caused an error with: 0. emacs -Q 1. (async-shell-command "true") C-x C-e I pushed the following fixes to master; let me know if there's anything wrong with them. Fix last change to shell-command e5a18efd3d 2020-12-05 10:45:17 +0000 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e5a18efd3d96a942c6d6bdc04d0d431165f3138a Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 06 08:21:19 2020 Received: (at 45034) by debbugs.gnu.org; 6 Dec 2020 13:21:19 +0000 Received: from localhost ([127.0.0.1]:49174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kltyZ-0007Pw-7e for submit@debbugs.gnu.org; Sun, 06 Dec 2020 08:21:19 -0500 Received: from quimby.gnus.org ([95.216.78.240]:52586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kltyX-0007Pi-Py for 45034@debbugs.gnu.org; Sun, 06 Dec 2020 08:21:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8wn3KjqOYGzMjbYPKoAvhUs6M0IhBVRRIS1dJN1444E=; b=NlOeHUPjKnh6E403X/Ol/kuYGl 4WRvYa7tKd17v3FJzkP3qhWIgrzPWwPKz/H2DjV3GVtdb1UcRIoZeLF9wPLhLpHSAW0sqO+FtEbw0 HijtWBxRHdLSNGtChc16jhlmzEfpYaLigb0DBZ19OkGZqleHe+3l7wcvMgY45qB6lNao=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kltyP-0004V5-H6; Sun, 06 Dec 2020 14:21:12 +0100 From: Lars Ingebrigtsen To: "Basil L. Contovounesios" Subject: Re: bug#45034: [PATCH] * lisp/simple.el (async-shell-command): use comint-term-environment References: <20201204000304.8213-1-hi@alyssa.is> <87h7p1nau3.fsf@gnus.org> <87im9gv6h4.fsf@tcd.ie> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEUOCQktDAtcEA/h HBTXRzjai3brvK7///9zpNO7AAAAAWJLR0QHFmGI6wAAAAd0SU1FB+QMBg0JMF5ZWV8AAAGvSURB VDjLjZNhktMwDIXdlgN0CQcIDQfYRsp/qOQegLV8AUjufwSelGyYZFsGTaZ29VnSs2ynlNKhIyYi xceUBdP+8AJ/OjJpGLGI3hyksI6EJdfCQgUzfgcHClMTFVbSDn/ODk75zT2cC5tqsW+gbWQys5Jt sJxtvE/ZrMp3zzQEyIOPVif/lR+eiUMQJCGP1umtRw0HHStSlFivANIvejnnglx8LwYBdaQrAIdY ZMCumSBXAVrXu+zicnn5jKFoycWBytn3TSEbI3atQm3DAY5LLR/Fu3nGzMEaMncGnfXYc/ob0s0A JcQiIpa2K3AVPAMPQT+XVMHXAyG6fZGFoDVzQITwWFa3apsWa2iwCODi4JZWu3z66e5cp60fBjE8 wcpaIL3XwXKY6uvGH2Xgl47aLegi1YhK1y2Af5jqb9ytfuPHseD0pl84sn5Xm2qFWBuFdgAV7iPj MmyrnwCq2jDtQYNuGJf8IQJPRI0UAoRed2Ao3q2PIF4V7phsd7icK8gzsO/Jv8HXZ+DaPQCCJ903 DwFu0/EBwPN4CNArgMMjEBez+39wnEHzDJxW8AeobKeu9nzLPgAAACV0RVh0ZGF0ZTpjcmVhdGUA MjAyMC0xMi0wNlQxMzowOTo0NyswMDowMNPjpKcAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMTIt MDZUMTM6MDk6NDcrMDA6MDCivhwbAAAAAElFTkSuQmCC X-Now-Playing: Joan as Police Woman's _Cover Two_: "Under Control" Date: Sun, 06 Dec 2020 14:21:08 +0100 In-Reply-To: <87im9gv6h4.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sat, 05 Dec 2020 11:26:47 +0000") Message-ID: <87y2ibcbp7.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "Basil L. Contovounesios" writes: > This caused an error with: > > 0. emacs -Q > 1. (async-shell-command "true") C-x C-e > > I pushed the following fixes to master; let me know if there's anything > wrong with them. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 45034 Cc: Alyssa Ross , 45034@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Basil L. Contovounesios" writes: > This caused an error with: > > 0. emacs -Q > 1. (async-shell-command "true") C-x C-e > > I pushed the following fixes to master; let me know if there's anything > wrong with them. Thanks; looks good to me. I really thought I'd tested this, but I tested with `M-x async-shell-command'... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Fri Aug 15 16:19:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 04 Jan 2021 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator